From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A18ECA00C4; Thu, 29 Sep 2022 08:13:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3944640FAE; Thu, 29 Sep 2022 08:13:12 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id C293540E5A for ; Thu, 29 Sep 2022 08:13:10 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28T5Nlvc026826; Wed, 28 Sep 2022 23:13:05 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2173.outbound.protection.outlook.com [104.47.57.173]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3jvrvjk4qm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Sep 2022 23:13:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UXpJ0YReiwywQzMFfzSlsOyAvpobGsD0jF5mdFvigw7wUhhbofMPQJRUfsOaO8bULNdZgVxO8aaITFoSSpGzFI6OQ2pe7Iy1CZL7iXYGMCstVwi5xrWqwKb0Sv9iR+swjyDTPOFgp0ipzIC/kY+BVIFlBJGVa0ZncBPknffylFvaIE0w3SKdA6VwKTf5dEUZlNdXJe1VR2rSpKbSp7yr0OEO/MesiYBRi+0aWXsDa3PtTl4L8Nz5dTwc2xvBSecuEAG8r9MJy3vwKepAPG/XjT7tWuNKqqRkfCStnQDqPidBT8kL7/3TsUfy/iakufu/d9RtxvennccJYvBJMLEacQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EAX9HSkkbc4w415TAExaG/5BHmpPiK5pTvxj+RY03/Y=; b=Mh8GbCBPQ6cp6lwj8IgxxaDoESkb2Fh/zOcCAAE5oBgedLqdxW7iuXgNjIiefra8X721+KjqtW0I313NDZMDFIO00TDMxG/0+sa5PB0/dyx5ypCEcBQT5KKt7Ks2UyGNXD3r/P6z4t1rrI+KLEkTefu9DaVOdKCMpz+pqtbcKqLpDfBFMrmgC/2m0dky/onuRWedwd6QuGEk0pEV3+ybpO5Yr2DrCNlab4g17NrDjLU3aaamj9T/IPiuwKOTd4c3Bapd+jfgV64XiRq4Xx85VeAsrTVCyfWNIEoJmAFeN+0OCo5mh2JnwdXebbxG+YogiEXb/l5PiTa3jnqZXocbng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EAX9HSkkbc4w415TAExaG/5BHmpPiK5pTvxj+RY03/Y=; b=GKwRgCbPg9+/5Gfv+63oM5QL84g9x6ZrDSTPNSE6VfaCIDCZ66HrtLgolg1QnDARcOfo/rPwt/9mep4L/eSCiF4a+KIbGSWbYGc/RSBh6e1GHhZmWGlv22R5lR4Q6Q0T1xwVKlVgUc4qBJy3kbuV5MzW7BO0m2lOLXt40FdQPEQ= Received: from PH0PR18MB4425.namprd18.prod.outlook.com (2603:10b6:510:ef::13) by SJ0PR18MB4865.namprd18.prod.outlook.com (2603:10b6:a03:404::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.15; Thu, 29 Sep 2022 06:13:03 +0000 Received: from PH0PR18MB4425.namprd18.prod.outlook.com ([fe80::16f8:9275:a441:cfec]) by PH0PR18MB4425.namprd18.prod.outlook.com ([fe80::16f8:9275:a441:cfec%5]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 06:13:03 +0000 From: Shijith Thotton To: Stephen Hemminger , Olivier Matz CC: Thomas Monjalon , "dev@dpdk.org" , Pavan Nikhilesh Bhagavatula , "Honnappa.Nagarahalli@arm.com" , "bruce.richardson@intel.com" , Jerin Jacob Kollanukkaran , "mb@smartsharesystems.com" , "david.marchand@redhat.com" Subject: RE: [EXT] Re: [PATCH v3 2/5] mbuf: add second dynamic field member for VA only build Thread-Topic: [EXT] Re: [PATCH v3 2/5] mbuf: add second dynamic field member for VA only build Thread-Index: AQHYzcICjNlSEBvC0EyISs0W8mrpIK30e0eAgABbn4CAAHQjgIAArd4g Date: Thu, 29 Sep 2022 06:13:02 +0000 Message-ID: References: <20220907134340.3629224-1-sthotton@marvell.com> <5861713.UjTJXf6HLC@thomas> <20220928124827.790ba22f@hermes.local> In-Reply-To: <20220928124827.790ba22f@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR18MB4425:EE_|SJ0PR18MB4865:EE_ x-ms-office365-filtering-correlation-id: e019a3cf-c7ad-42ba-4d01-08daa1e1aac0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RvXfUPoiYQo8jjcS9l6Lynn+UWkA45KDa2KjUmfPTO6BX5SpqX8ouHvLdr4t9XkJL9egLimJGfayFedsyR1wOw1lWnWw/0Ci/ZOQ9o8TTZi8KJZdwPaNnBmf+pvF5Q3cuAJhsBECqjMCUy2EE2OBGKDBNwFVO6Y6eUcdHlOy7hTNwnYhSznVEubF+KMVxV8GbYOU8G4fMdqr/uFHSJxFalGHlelrDdxF5uN8mgAfy0jz/VraFSxp2PE6u6Lv/nhRK2U5mQZzWuB0/LiN0MOgS+/VCSNhrr372hUK0Pv8Qskt4qGW84YjARBCa+lOSFuxplqML02yVdbem+2a6dfEKXTKv5IAjs6WmLsYuELy3lRHPPN4YiE1KM0w7XbqojumScgnA8qfQF3KhSUjUFyYAKou4vWwGAYabFmY5X8wc2rxKwers+LOy0Cm+b3mlaVBbKjsM2+HC/XshlF7TzMl8T8ge4PsxTR/j7a2DZZV2zF6N2D0jwsgV57uUNiPd8iMmoKJi6V1UIRO/u2QH6NzVvdwUkRS803obyExGJfew1FBM+QnzJLMH30T35TiLe4Wp3jbWK9qiC/WRVBTGgPNSvUgN/KGurrig4EEufBolVTOQMgO396Iflk6TZ4st/95b0RXzjcpLt9+GjOBuWcXEwvDrhi6oSW4p3XTRPtQoWFOv8zFNQVpXuma5odJGpuTanKcw13P7J4wCobR2z9B4X2ZGnZktdmP6p9k+l3itDQRWaCBDO+iMl1dVx8rSBsd8K9Egge5G3zxzfOPiqPecw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4425.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(346002)(39860400002)(396003)(366004)(136003)(376002)(451199015)(33656002)(5660300002)(26005)(66556008)(6506007)(41300700001)(66476007)(66446008)(64756008)(8676002)(4326008)(7696005)(122000001)(38070700005)(55016003)(86362001)(38100700002)(2906002)(186003)(478600001)(71200400001)(54906003)(110136005)(9686003)(66946007)(8936002)(52536014)(316002)(76116006); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NJLPWr6oFu90Ke2/mxhVpUskp5Lziz//qtICgLauJxs+Oy+PZoBRBZEwFUX7?= =?us-ascii?Q?JEgHT2KrK3khzJBXm3K8wlsMH/nteNQpQvDai3g8kHthBHHvnAlrXSD7+b11?= =?us-ascii?Q?Y9CxSGe2fTk/nl6IsgAZWOaZ3EcH16iOY23httbKNH3PhITkLmmHwl51EscT?= =?us-ascii?Q?D0JnHzdrSyV2fq/GgEzBZOW17Li7dft7mEWnO0BDHr2Gkn6aiH4Cq9mrvBoA?= =?us-ascii?Q?0WyuISgiK/Ln9LoPpbyiWSKDoXN5M4/7TneUc8x2uzkNijgOgxh2qTows4uE?= =?us-ascii?Q?L5wDH+8gJNC1dKa0gP+b2kPzWmaKrGDY4ml+8S/4VBz9NKP1oq3TlAlWQVml?= =?us-ascii?Q?Een4IYkU9P9LhKYgbOhicxwLzW0ONRXUtro5DmRyI843XH8WZpniCHT4xRmb?= =?us-ascii?Q?U/Itsjkc5GwVM+h2LJQKD2Kg2G4Fv2Hq3zLiipSqjdPXscxxGFAuychnNSrJ?= =?us-ascii?Q?G1iM8bugSaG/eKKs2+DIlFXxCDgMPUInVqN9mJyeKuEzFZsf+Iuyei83Hyw5?= =?us-ascii?Q?LIPUh2sbwi5xWTjqyWdG0/84F2weN+/6MWceJywl6VxFbxfapMWsC9hAcwtc?= =?us-ascii?Q?58LHSFqpUPKBdB5il5o6rCirj1tdGut3ws440bC8P6Y4qGGKAN3jCosm+HNT?= =?us-ascii?Q?/aR/kGO42ttjfTGv+KseZSgYD0Yta5NeEJl1opLGPx5G/4jWh5gQIu+MjoaF?= =?us-ascii?Q?+A5HigwuMOKoDLEJy/O+e0RgWh+8hP7849X071qSPf1u8LL9+60Oy/U8Pl1v?= =?us-ascii?Q?s1ukemecdkK4AtC92tkOeoJiZRnaC9xSVT3hQUQ8aayUwLDHeJIKrSpzItHF?= =?us-ascii?Q?xMEmWW4HPPY4hPZU/4qgw9I3yzUQjDxEay2ZZW9+1sb8I8sPv1co0Y0bnEmB?= =?us-ascii?Q?07xhdrLw+K+UISfqCaT1av8oXuO7Lc64ujo+ksGc9rdV9KBjzzG4e1SW2sM+?= =?us-ascii?Q?rFzzxgqhxkNLdEF1539e7u2WTInGw3qhH0X/8SEP8JRbdpVss2WzscjaBI59?= =?us-ascii?Q?sOgGGcv4Qz7puLDjTD/YUKrL5E11FGAWZqEXH4+dG7H9ULiDhB8bjkxr0R/e?= =?us-ascii?Q?jrsixLmE0kVuLVsRKp3DQ2wqsaT3NWWnGs33axlSmdI2pjlvERHOUPfoSBUn?= =?us-ascii?Q?2ME/wU46czjSQFHiPJLsY6MIxii7bsO49zGvZgAYYgAuZt/BwRL4ttcjR22j?= =?us-ascii?Q?6z9k+CzM0wyRf/C7GBsl650pL1WY6kp2j1aN4KK+9MEZGtasX6DyWx9N9nha?= =?us-ascii?Q?lhHMqyO3hpUZSvB7doGPSDdrzz9tI+Ohvw8WwDXTEAsWe49KpXUPqhwk2esw?= =?us-ascii?Q?eGmBOFXGqq+InXFZuosQDb87UpjLTK/imJKVaIcFOwbcP//OD2lbiG20vZg6?= =?us-ascii?Q?rTuHxsjyRG9rZgJv+uyQxSjWLpyc10A8IoUfJqD6PBzK06n9/INBx4rJFq2K?= =?us-ascii?Q?dsAdoL98tHxXTJB7TE7gjuzP9zQLX9ZHSv1kYZ4lzwwP5O88K0QFMD+n56R0?= =?us-ascii?Q?xMeqyOYW4uqZcXYgLZgajwaKWL+LSxc0t1tOBDGcHXx54pR8oV3+edXRh61k?= =?us-ascii?Q?NyG3vHGtMzoSbEn1CSvBedZ/QI/ZM+Xhc+S+7zIe?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4425.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e019a3cf-c7ad-42ba-4d01-08daa1e1aac0 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2022 06:13:03.0164 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hjUjVCRNK6ANfr3JAgb50qpsPU7H0Q3det4hhw8WPOzXJr/ExEI96F/kDBJfumCqdIBbK1oxci2cIqxqCV676A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR18MB4865 X-Proofpoint-GUID: qcxsKEkofz4nVJgMPOac3koyfDwoX090 X-Proofpoint-ORIG-GUID: qcxsKEkofz4nVJgMPOac3koyfDwoX090 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-29_04,2022-09-29_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org >> > > mbuf physical address field is not used in builds which only uses VA= . It >> > > is used to expand the dynamic field area. >> > > >> > > Signed-off-by: Shijith Thotton >> > >> > We cannot condition the use of the dynamic field. >> > I think it is enough justification to reject this patch. >> >> I don't think it is an issue. >> >> > And about adding a compilation option for IOVA in the first patch of t= his series, >> > I think it is not the direction the majority wants DPDK to go. >> > We tend to avoid compilation options. >> >> In general, I agree that we don't want to have many custom compile-time >options, >> especially if they impact ABI. It has several issues that have already b= een >> widely discussed. >> >> However, in this specific case, we can suppose that removing buf_iova is= a >> long-term goal (in years). Having this compile-time option is a way to t= est this >> approach, and progressively prepare the drivers to support it. Then, in = few >> years (if we are still convinced), we may announce an abi breakage and s= witch to >> this new mode by default. > >Since field is invalid if compile option is set, >shouldn't the field be inside an #ifdef so that if a driver or application >was to make the mistake of using that directly, it would fail at compile >time instead of runtime. > >Leaving booby traps for applications and drivers is bad design. =20 Will move to using #ifdef in v4.