From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38489A00BE; Tue, 25 Jan 2022 18:38:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 21EE241178; Tue, 25 Jan 2022 18:38:46 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 35DA041161 for ; Tue, 25 Jan 2022 18:38:45 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 20PAe1u3008698; Tue, 25 Jan 2022 09:38:44 -0800 Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2100.outbound.protection.outlook.com [104.47.58.100]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3dt8mujtj4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Jan 2022 09:38:44 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cpnzHBPZ6ueb/WnccyDxKi5Y3mAbmXNtYhl0a64MeeNCTQUa0E7GMv5gfBL+CmIo83RQiU7Dfco1JDLfIPLr3rhg38I0McEtnldkkIUQNYyS933qEMhkTdvf67iYRE6sDgK2IgrdmPNcAonM1uhPE3r3Aw4imL9QnW6BWYe3PnoJ6p4iIYi8Ft/H69uPjXaUqw1orKKYo6jbLLi3kT/++ukhQbYhpK3I4WBUMpVjDNhL4rsl+mhMvFHbKWtcg8eMJ94oinbs79lm5HITccripYYnQwnkwBUclU5vs0hnSpEh+z81cpMT1Ym2bCDi6UeAu8wGudPvkMqt1X7aBo1MHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p6ocjDpBRDjmIUKAIpC4udIvCu8iYjqlzqi3t3+32P8=; b=SnpkEFGBV641oRgG5B/BfUYBTFU+X4ZQ4iAKHisRbF1Jr9bemtzHG9qqWS9CvK66z8sVFqpiTtpmLI0oLKNPMgMkmsBJzuG7U+9lA1Y2UNWoxNbOXnT5NqYViylFJMMVS6BfVrbanbCHb9NZuIC/XCwMXrCpcKHPQjipPNOjdPLy1fwOFUNmVrxF4X8LSDecMB/OY6kkqWi3LgSQRWp1V6YWqGGqSAQAM6+GiGQf2YN2qLpdmJuy01LwZhA+2azfYynH6cyL3kVkrAjDuZfDCTqmjWpGQkhNzZ3wBRZNbreuzRTxE+/ikJKmrhiZ8Ohyfk2NdL2waXjE4k0C5bQhZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p6ocjDpBRDjmIUKAIpC4udIvCu8iYjqlzqi3t3+32P8=; b=ApvNF1+gTtDbPJVSgcarWYAGsQPjlziigz8+BGek/4134jzRC3t3SMeLCprFAfSGBhkzUOkJ/0nfVkUuOTanFaTcuqlTDABGyK72y5vUXCosDbyru32mIK3thiWh5GhrN0rwHdJ6oh8f3khSka2spwIIgULR3OPNdznQrzxqxZ8= Received: from PH0PR18MB4473.namprd18.prod.outlook.com (2603:10b6:510:d4::18) by PH0PR18MB4544.namprd18.prod.outlook.com (2603:10b6:510:af::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.17; Tue, 25 Jan 2022 17:38:42 +0000 Received: from PH0PR18MB4473.namprd18.prod.outlook.com ([fe80::98d5:32e8:240b:ca02]) by PH0PR18MB4473.namprd18.prod.outlook.com ([fe80::98d5:32e8:240b:ca02%3]) with mapi id 15.20.4930.015; Tue, 25 Jan 2022 17:38:42 +0000 From: Liron Himi To: Stephen Hemminger CC: "dev@dpdk.org" , Liron Himi Subject: RE: [EXT] Re: l2/l3_len fields Thread-Topic: [EXT] Re: l2/l3_len fields Thread-Index: AdgQ/fTHBIFdckyoSEG3ajKSooWLCQASM8kAADLM1OA= Date: Tue, 25 Jan 2022 17:38:42 +0000 Message-ID: References: <20220124092104.07db8409@hermes.local> In-Reply-To: <20220124092104.07db8409@hermes.local> Accept-Language: he-IL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d97a0966-a636-47e0-7a24-08d9e029878a x-ms-traffictypediagnostic: PH0PR18MB4544:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4iIeWw0oW1RBmj4kw4QQ01bCOeDGKDFmN9S0QvJX675fI1sAvIihNPYCV6oF7E+25mTOK4FStiCLbezGsQsvd8MGLBTeZNwlq8RgwqL89pkJ+K1nlu2bhAdpuOWNovx4hiLFkBN0i8bIEB96bZXxYCHr3V8Q7zI3lFmQhIo0j6balPJpp/Ht5/LIHgHGF0AeLdU70lccfAirSFgs3Us78kvW7kBku0T8WSg9fE00gYTvhk+pceIIadq+RrPAGa/ZCzcTti+HNCfN0yRsz58FhLKmRF2+Dz4r77xboPz40bCZtqlxELCbN1X/6mJ8ybjjwv8/JLiemYZNSlsGV2zYjnuCzvTc7eYw4rzafGIjFsFFqA17JJle9iulBygdaxxy2PArbKSibxD8s6urKIBLT6N7JC/qbQLJDgpSgTL0EnLrIIafqc2FL8dtLViydQZmdL0gYp8zoMa6MD8nk+FXLQM6htuQilpLMQyiyYl6cicIwU9AukjcgMTQATSDs/HanyrKid4ApCNun+FwbdCCTtZObIAcGdQPFD38PBDTRwr9NdVzLs80Yw2DuhND4gjrkAWN/FujmEALSwh+Hyb1MLgN8tD2JhaKli93RJGor7fJDh36cTIUBvBNw5Taj1zLIs4b73c2mQA9WlD2e+pUQ/PZKHpo85Mv5jFM+Z6CM5idwHT2z5GIfKxnB9pm8ISnlxGvtYFvESYq2pNzXHoVy7OMC2j3RoJ9F3Y3qTH8M0nIUFhuwFWvIAyjTflKU5zTYF1lBaISdZxwMspPeZC7/SQjzxsX9WyHl3uZr8KmINw= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4473.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(76116006)(66446008)(55016003)(52536014)(71200400001)(33656002)(64756008)(38100700002)(4326008)(122000001)(8936002)(66476007)(66556008)(83380400001)(54906003)(5660300002)(186003)(6916009)(107886003)(508600001)(7696005)(86362001)(53546011)(6506007)(38070700005)(66946007)(26005)(316002)(2906002)(9686003)(8676002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MVP+xlM+qBgw0umj8q8ZhxbqkvsfDwVWISnudue7FvB8N2HuMjzZzk1Be/4g?= =?us-ascii?Q?iCTKp/EpNW35AJH+qBZ0VlSn3WgbGYeZQ9uflaR931IfTQG65R+p0uYlGYOV?= =?us-ascii?Q?/ps6OXxKuYNupVyGQRdEJ09jIfH0+8LxPFDYT0VEi4Sxe5AMmYls0asN9h/l?= =?us-ascii?Q?Cuto29STxb+zvbA1watF6aZoUS0Skeay44fPI+YBtIYKH75rDQalFj5xEqe9?= =?us-ascii?Q?0QWUH3mzi8vJ8/ISWLXsi6H5+JwjAqnpi7f6U9QLdcia6j2pnnTAWu6ZYJCW?= =?us-ascii?Q?QZlro+Qcr2w4yO4CFg4vczUVhWHQ0oUaSRhqjtQDaz4wb1KkwUjJBTovC45P?= =?us-ascii?Q?lW9cgEQHLEqbF0gQE7rROROkRgqUDQllsX//9ivOwWyMGAjasRa2tx09H6Vh?= =?us-ascii?Q?En1M/Xn3AxqjYAo2/NxljpmxQEuhy2xLDj4PohJ9ffsnZyaFZdtq6rym6Ug2?= =?us-ascii?Q?2ztZccEpyWcdJoQ8FUEf89bp/nfzhoY4O+jFuX3QnV0kNC+6Qy0dPZwKq/ox?= =?us-ascii?Q?ITIt6+gHZrPDZT2JOZFR1fTIwtOCTzIx/op4G94D5/SPDq1rjgVf8V8lzfcY?= =?us-ascii?Q?tOU6swLvpVOTV5DD5+8dG7J00KY71mf8roRR3c9wpm2gLSYElbmy7RpPg5or?= =?us-ascii?Q?04P3uvz2++DEAmJhfb+xNPK+InyQlSWrGJ73m7SfhpyI5+BjxuTJB/fv3Pyh?= =?us-ascii?Q?P30Qyx+/F6nf5xug+6NSxYnx168cSZOcEcCpEUD7bULEcag0ZlyCdXUtY0Ci?= =?us-ascii?Q?u9FKq5o3Beg9zF/yk58LUzKxjzdS0p4XS6TCxIqbxYWF/QFEdC8/W6Y73VBn?= =?us-ascii?Q?hyXDc4OyHMb1s9FQLQCSR9ONqoBDTgqLX+zLv9SGDF5+GJmSZz1LkIk7yMeD?= =?us-ascii?Q?tULDOVL+DYjbHL0EFpfr7Ne9LYxrVbKmo5trouXY1QfRczoKMo438tgXcX9d?= =?us-ascii?Q?gXcLfeqIUcNoMZr403r9rHALKngvdEmbQcVt8iowFw3wMMVPsBW2HGTawqOE?= =?us-ascii?Q?RPfS7avOV5wSKACvHnci1H9tZ5yw/S6+O3MJV3MlBcS7m9yrbbNdhC9GanET?= =?us-ascii?Q?kd6RITZ7uTUEVnXXblRwZgPubw74aATpU+yl3pm7S/THUQGzddnw1uB024pZ?= =?us-ascii?Q?mc+qfHCYSmGCqZ+ftxnJqRpYu8WuPnwJf3KyETF1WBcYFOtHMjt6IKiPkojM?= =?us-ascii?Q?VMyF8/z9LzW+ySKh0oAouyi+yvUUBkzbu4LRzoYApY7Ujpsiwjdka8tGHISJ?= =?us-ascii?Q?SOvygjnuPwpw7MESlXtrqCAQVoofzjApXKnDcULmS2SRMCg1kx3qza7By+p4?= =?us-ascii?Q?dJalX2xl6enZw7v7FLcOSaVceslcGgo7PjP+pxJv5R7NcdyO4yKVheFYxshB?= =?us-ascii?Q?WxiV4JU8S+1af+iRguEkLgDz2fGeOeAOKV1aV1bwcTorlDH1qHwg/ZTrugGU?= =?us-ascii?Q?Ao50zfnZboL4tipKFzH/8/tye4FLLvPD6LqgLmEuTPJAXRpx2ecL560F1HeO?= =?us-ascii?Q?mx0gsMAqRWaJ9SxvjYi7oL90pYpAKtIT8stHByaCxzBcQHdSy2E+gBwVhNE2?= =?us-ascii?Q?fGRGbyV0kH1FFYeGjPJ74UDCR5RHwH0g3J/p6UzoHDoorIj6BlPMFd6/hwJ1?= =?us-ascii?Q?3A=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4473.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d97a0966-a636-47e0-7a24-08d9e029878a X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2022 17:38:42.1135 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xs6bqRYYJbHIfh8Lg1c7PYYsa2wpQHxqXImd/z5hScvAOR+W10wDumLVFkRTtUfqqAq73JBzwuVNYSOco9+Rmw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB4544 X-Proofpoint-ORIG-GUID: SOH_IwVW2jwCqYYBcVMZQbI7WBFRwd_h X-Proofpoint-GUID: SOH_IwVW2jwCqYYBcVMZQbI7WBFRwd_h X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-25_03,2022-01-25_02,2021-12-02_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org -----Original Message----- From: Stephen Hemminger =20 Sent: Monday, 24 January 2022 19:21 To: Liron Himi Cc: dev@dpdk.org Subject: [EXT] Re: l2/l3_len fields External Email ---------------------------------------------------------------------- On Mon, 24 Jan 2022 08:39:59 +0000 Liron Himi wrote: > Hi, >=20 >=20 >=20 > Can you please share the motivation of not filling l2/l3-len fields on PM= D's RX function? >=20 > PMD already filling the mbuf with parsing info, and the l2/l3-len are als= o probably part of the HW descriptor, so why no propagate them as well? >=20 > The current way for application to find the l2_len (for example) is to ex= amine the ptype using multiple if statement. >=20 > However, this may not always work if there are unknown/user headers (e.g.= DSA header). > in addition, some of the examples are not checking the ptype and assumes = a specific packet structure. > e.g. l3-fwd, assumes only ethernet header exist and hardcoded jump by 14B= to access the IP header. > but if VLAN exist it will fail. >=20 > checking the l2_len will work in any case. >=20 >=20 > Regards, > Liron Himi >=20 > [A picture containing clipart Description automatically generated] >=20 > Park Azorim, Kyriat Arie, Petah Tikva, 49527, Israel > Mobile: +972.52.3329169 L2 len would be relatively easy since almost all devices are Ethernet only. L3 len is the problem, many devices don't interpret L3 and below headers. Only those that have flow type functionality are likely to do that. [L.H.] Not sure I understand what you mean. what will be easy? Easy for the application to calculate the l2_len?