From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A2BDA04FF; Tue, 24 May 2022 14:30:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 30F2940140; Tue, 24 May 2022 14:30:06 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id A555D400D6 for ; Tue, 24 May 2022 14:30:04 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24O99phh005704; Tue, 24 May 2022 05:30:02 -0700 Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2045.outbound.protection.outlook.com [104.47.66.45]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3g8vg48n79-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 May 2022 05:30:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eA3eGdcUWJu1VOPUuK8JdfI0YFo6g0+GtblnzpwNdQnGfP1CwW4O9pD86DiJzotoFUhVMFU4w92TWjhUQ4UKHhVbsRrRd25/XFP0i/L9mY/x1asl/Bml+CJ3t2/2LtaNc6cpcuVEFFAw4KBQKD5figzfWYTitJ/zw5HRN6Ohe+W9vkOe09uIKGVJz94A1/eaEPNKy/JpKmgGPsYwKzxrPx7+02Lk1QLSt4qMm3dQnp7keOcNv8m9KbwV1hkabUOsneUILokyhMuWCwDycnjHHK8H4mKuohAkAqzxV5rH51hbPTFXDYLZ2m++muBhMh7wfDwaTIYed9HaxxRip0/9vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kn6tyfySJ/1A0PPUkwyofYDySI8AOxiVJX7ZltGbgBc=; b=cC0+101RhPO3d/TEjwc9k6z5syHApNDtXShQ+Oudr9+EKnNyCd2X96nEWVo4ZMqTx31G09EOMWhF8YSCY9NRmPo2dC4UDxIlBYFBkleYAr3c1MeOA6V2uQkcmJEOfXYyAQg/lcoLexs9gEf2XCJ6GjmAJ0LMiFH/pmWF5aG826ONMXQ6eCiS3YZqkV6En2u4shAvVg8QcWUvhVnhE/t6V1yoZKGMkWsPT42FonSyUO+P0CP9wEvUqJRkRu1nGbR2WPyu3AV7v2b9+p4+KX5QyHp4LDBxSBWqN+vakpuTdSld2F76vuFz3UEAv42K1BnANAyOKDU1g26eeI3ROzQong== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kn6tyfySJ/1A0PPUkwyofYDySI8AOxiVJX7ZltGbgBc=; b=pw/3AE15/TLuBJcsEIx1VHfiL7sfSqHl9nnofwWP5ZisumgukbUs/lqNmoFWWulOYq74Dem4e9+PeMGPL3CQw+Gw/p6IXZ5yEJUeZTWSDzbRI1t1Xw69O79+YrdaurdtiRRuIw/5iUJBgZGQXLcK7QrzOKYNH06m+9emt2KuDPk= Received: from PH0PR18MB4491.namprd18.prod.outlook.com (2603:10b6:510:e6::13) by MN2PR18MB2671.namprd18.prod.outlook.com (2603:10b6:208:108::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.23; Tue, 24 May 2022 12:30:00 +0000 Received: from PH0PR18MB4491.namprd18.prod.outlook.com ([fe80::b065:32c0:f517:f85a]) by PH0PR18MB4491.namprd18.prod.outlook.com ([fe80::b065:32c0:f517:f85a%4]) with mapi id 15.20.5293.013; Tue, 24 May 2022 12:30:00 +0000 From: Akhil Goyal To: Arek Kusztal , "dev@dpdk.org" CC: Anoob Joseph , "roy.fan.zhang@intel.com" Subject: RE: [EXT] [PATCH 29/40] cryptodev: add salt length and optional label Thread-Topic: [EXT] [PATCH 29/40] cryptodev: add salt length and optional label Thread-Index: AQHYbBe/PofxhL6bJ0+y/qcI4grbKK0t9+kA Date: Tue, 24 May 2022 12:30:00 +0000 Message-ID: References: <20220520055445.40063-1-arkadiuszx.kusztal@intel.com> <20220520055445.40063-30-arkadiuszx.kusztal@intel.com> In-Reply-To: <20220520055445.40063-30-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 76907d2c-4b35-4371-eed6-08da3d811ecf x-ms-traffictypediagnostic: MN2PR18MB2671:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nMO1vXgmo6zV69MaZh+tz7Ephwhnj54ljIimMcrt3RknN6Q2JBQk3dQ4y78fmyV+TYKOmqk58ukp/QnNaP7Go+Z5NPhwdvHVpS6eR6oZfL3F3IchG5r6ny+Yeg0qIr4NJwOXK74BnxdLoLSZAtI5DUZdHGQQ3dB5TS0I5kCwaw5sACGY6Y8JDJzVTDRVnMCqYrc2r1HwxSsR9kngtw/pQuZuGo2EzqZBVE723Y7OxNW9o8ZmPeCJc4RG18uzXPvlAp6jkFLBMVpIkBMTApy4JrTFjvgMPjJWioeWry3CPo8+JRCM2PYP9puIrheONhyCZHwflbIpSF9PneYKzIs/vA4Oj6whFWhahSZnnICVR72wGKoclQXd8Seq8CQbxtfpEA5RsNZJVtAesjmuYlgf3uUHsaFPuKeQi+BUFIjKusGkCuyjzzW6tpcxpEphy0G6r31PzQS+FaQvrJQw4cPM3Yp1iCRjlMbHpUO2KRvWXBr3khhvkyjSqoaOhjlnYDZsLmOIMOqvWPKh3E5xbetYwnN2gR1N2doQJbef41SZvcWK4vEgwAIONWJFF0t3lKRnjzg+Pm8pBveN/WS+UbfyFimc11JymUfuFZffuWOZNy3beKWWDWcN3g13EuzTVf97MVSBlV9kcLyPopuGX76t51bwisGWEd04lczT926bvQ7solTERulZ6QTJYIQSP6qz2yJqhi0KLychyorUUjTDmT6sq5UGEsKv9wp8z75k3lk= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4491.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(26005)(508600001)(5660300002)(122000001)(38070700005)(52536014)(71200400001)(8936002)(6506007)(7696005)(9686003)(33656002)(2906002)(316002)(4326008)(54906003)(55016003)(110136005)(55236004)(186003)(66946007)(64756008)(66556008)(66446008)(66476007)(38100700002)(8676002)(86362001)(76116006)(83380400001)(473944003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?w7efIMKGKdyqsOrC9Kg5VjnL2Za5NDwks8kw3m5GAhmwFCkroKqYAXcn0nJN?= =?us-ascii?Q?wHT8XvojyQvuiQD2WJo2h6P32uszDfxSYOcP6cRvHUUFH737XuyG1UdIIPTF?= =?us-ascii?Q?MbUp8rKh74Fq3isYXHdkASrhpc3/DKDAZS7DuUBQ/1+jIcEhUZc4ICpMH1Yi?= =?us-ascii?Q?O/zJqiVf2rXCL5ISiDP2wsOXqTc0fHPGDocC5H+6Mv7XjGx0zNQU6oFvOXnl?= =?us-ascii?Q?hmEcus/MDrFsj0CDZABcDdsADY3qOniCIy99Y8fahkDA2en6JGg6hdkxD63Y?= =?us-ascii?Q?vdqAgsvB2cVD8NdRhLWtwdis0adiCvWlvzuaUv6DeTqH/NsBehlpvcCmSPrU?= =?us-ascii?Q?poVYBvKZSJr+banEUIhlTRpCT0zA8LMFGIW+Y2V72ibnm1x0NTfX5Es7//qt?= =?us-ascii?Q?z9x3+NY9IKfXNGolowNI+KVLeomwTcBuDzQj+Exbh7FZ76Ojn/nyHYgafLC2?= =?us-ascii?Q?E2zGnh5iCEAyzmGwgQOPctTIbIo1EcFlP6Qy60kS242qwBY45Mg+EGzDvEMA?= =?us-ascii?Q?P25m6nIZSPANKZ4oV8jCKHWZifE/Fn75xypNgpFNLySYcmdEKloB0sGm2rt+?= =?us-ascii?Q?pYJUUdew+XfkiptEvK5yQGgsJULoFoEz1WhXfcJV8w8sXqdIAYKGiVntbLsu?= =?us-ascii?Q?TG9s6hmJxWbT9omrmTaiR1RgAQbxw2IvllUCprOKwGiEHARvrZrYcqYvF4Oe?= =?us-ascii?Q?lhp3Ova4Il5n7Y/m6wp1oG6hSjNIsSSpKiZ9y6MbkDw8jSp8oJo8/WQvO5/+?= =?us-ascii?Q?e0l/gX7KaHL/eXXbqZVKUs5pWArCIMh/wS/8l9BdGHqoSa7yRfNmxudF7RYm?= =?us-ascii?Q?sOg3PiEtemiaNi7TdQ9y92AdQ3kBrCfkyZZA6VilyNqzXVCUGCX9X6AZlGOb?= =?us-ascii?Q?+cPu9JKyicbuw2jAvsvs8Ep0aTsfFNzpjkNeqF6hXxgLRsR12yifiO7W9seX?= =?us-ascii?Q?u2nHWuKzDOZrMoOzi9k0Rj8E8X7SVHsLwQKYofxm0kfCZPcB80lgza1YkDi1?= =?us-ascii?Q?EhE+QiJxK9y+Jq8xoohZ6NJ0ihWZpL0EJzRpb0yrwzqZO0aygqWLGihIGmuM?= =?us-ascii?Q?R0e/ne3WObEOu2k1rJ7ESufOMdADRCTUcllJ4+0kjIvXPWBnPlWyH0uLLNZ6?= =?us-ascii?Q?S8rvOz6Dv+b+2baY9Cmcrg+2qDh3gxGBn/EUHTYhTvjsNqxY90jGLJpmoMZ2?= =?us-ascii?Q?B0DG23Vs3U6S9e4TDPYDeOqjFf1OR/a69CghsVjRh5gmTzo/7UU0YOCc9x6t?= =?us-ascii?Q?spLpS+KJu+fcQsvDfhfit4XPFfpPmsEjXFF9hZJovEIKP1T8vIxHMAN0o8je?= =?us-ascii?Q?gXcayuNb09j8jAUNTgl+vPA/qcE6nT+v+xgWisZ8rJLi1Z4NuI5n2R8JYog+?= =?us-ascii?Q?BXLxb/7GD99zpI+XqiTA0MgNLahbutighoPPMvkxPAdkq0M83BJhJ12ZQgs/?= =?us-ascii?Q?wXzZYyRnP1jXH44Cx7B+HpNsKv+mS94UhqrKpexB0dHfqUZSMyJXE1jWCPjC?= =?us-ascii?Q?wo+I4/1DfM7Rita3HmAMFep2Sq51j715HU+cGKQHpkfjryfNrGKHMZdwk7WI?= =?us-ascii?Q?cbY8ODPINA210SVy53GD3BlbBmMaD6bdw5uGoS231cVNXWRK8v16IPQK13Lm?= =?us-ascii?Q?Ps1CvQgQrCQOaXGNsA8oysbd8RoR7oh0IHwgsLMN+aVXyLGItWlFdsbXqu9F?= =?us-ascii?Q?ckIvqUAv3ZcUiYyi7+IXWMpqmo+gPPysqceFJmX+GJRHssKEbzIp8ePRaJIQ?= =?us-ascii?Q?IjPo9g3I7A=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4491.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 76907d2c-4b35-4371-eed6-08da3d811ecf X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2022 12:30:00.2740 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OkVXK1QnFnS1n6Q6ZM77XuuopZxmWMgACDV2VsC9dA9O4a6N1S18EsxVRrsCcgzmZerOK1IvV14falAAm4JoUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2671 X-Proofpoint-ORIG-GUID: 7vzvIUaHbtz44ajcjpWZGLRZAolsAMY_ X-Proofpoint-GUID: 7vzvIUaHbtz44ajcjpWZGLRZAolsAMY_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-24_06,2022-05-23_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > - added salt length and optional label. > Common parameters to PSS and OAEP padding for RSA. Please add description about how it is expected to be used. > - Fixed hash API in RSA padding. > Now it is specified how hash should be used with > particular RSA padding modes. I believe this should be a separate patch. Right? Patch title does not justify this >=20 > Signed-off-by: Arek Kusztal > --- > lib/cryptodev/rte_crypto_asym.h | 44 > +++++++++++++++++++++++++++++++++++------ > 1 file changed, 38 insertions(+), 6 deletions(-) >=20 > diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_a= sym.h > index 97c3fbee38..c864b8a115 100644 > --- a/lib/cryptodev/rte_crypto_asym.h > +++ b/lib/cryptodev/rte_crypto_asym.h > @@ -205,12 +205,29 @@ struct rte_crypto_rsa_priv_key_qt { > */ > struct rte_crypto_rsa_padding { > enum rte_crypto_rsa_padding_type type; > - /**< RSA padding scheme to be used for transform */ > - enum rte_crypto_auth_algorithm md; Any specific reason to change the field name? I think this matches with the next field mgf1md > - /**< Hash algorithm to be used for data hash if padding > - * scheme is either OAEP or PSS. Valid hash algorithms > - * are: > - * MD5, SHA1, SHA224, SHA256, SHA384, SHA512 > + /**< Type of RSA padding */ > + enum rte_crypto_auth_algorithm hash; > + /**< > + * RSA padding hash function > + * > + * When a specific padding type is selected, the following rule apply: > + * - RTE_CRYPTO_RSA_PADDING_NONE: > + * This field is ignored by the PMD > + * > + * - RTE_CRYPTO_RSA_PADDING_PKCS1_5: > + * When signing operation this field is used to determine value > + * of the DigestInfo structure, therefore specifying which algorithm > + * was used to create the message digest. > + * When doing encryption/decryption this field is ignored for this > + * padding type. > + * > + * - RTE_CRYPTO_RSA_PADDING_OAEP > + * This field shall be set with the hash algorithm used > + * in the padding scheme > + * > + * - RTE_CRYPTO_RSA_PADDING_PSS > + * This field shall be set with the hash algorithm used > + * in the padding scheme (and to create the input message digest) > */ > enum rte_crypto_auth_algorithm mgf1md; > /**< > @@ -220,6 +237,21 @@ struct rte_crypto_rsa_padding { > * for mask generation. Valid hash algorithms are: > * MD5, SHA1, SHA224, SHA256, SHA384, SHA512 > */ > + uint16_t saltlen; > + /**< > + * RSA PSS padding salt length > + * > + * Used only when RTE_CRYPTO_RSA_PADDING_PSS padding is > selected, Used only when RTE_CRYPTO_RSA_PADDING_PSS is selected, > + * otherwise ignored. > + */ > + rte_crypto_param label; > + /**< > + * RSA OAEP padding optional label > + * > + * Used only when RTE_CRYPTO_RSA_PADDING_OAEP padding is > selected, Drop the word padding. BTW, can this be a union for label and saltlen? Also can we name them as pss_saltlen and oaep_label? > + * otherwise ignored. If label.data =3D=3D NULL, a default > + * label (empty string) is used. > + */ > }; >=20 > /** > -- > 2.13.6