From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A24F9A04FF; Tue, 24 May 2022 13:52:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8E75A40140; Tue, 24 May 2022 13:52:18 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id A12BB400D6 for ; Tue, 24 May 2022 13:52:17 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24O99peq005704; Tue, 24 May 2022 04:52:16 -0700 Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2106.outbound.protection.outlook.com [104.47.55.106]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3g8vg48gvr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 May 2022 04:52:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m5zsiA1vUpUYz/P6E0bCkXOVC3TL3DSsElM1L2Drj/dUWBrbOdUMUzRUKHrA0xOdzr2JBsXovIkTj+Mzz+JaiKfPlsUbyX+qNtV5wpIfILXIa3HpZBC6MnL7Xd5l9AZelTzcpNy7OkBSNCtlpoTkY+AZ9W0ZJcluAF4p06BSSC/VMYWiq9bHt0ZgKGRXHC8434JZx7p+h3TWnyhQNRuiqzU8oXye19uqzFrzcwdPS5tbvRIwsniWpRgyluuHhrHeJ9FzMG/jHMCVMmmiBRFJqN9rS5rZy7DYZrcHVMPOzN3d8aBwEJU+0kvMKgQQIi72yb4TdS0eluTNwxnsG0AQlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DSmyoi4JwIsHLgJr0+zL6b0h3Cqc8fjoabEKa4W8tZM=; b=MIdBw1d7VmFOubhQoFuplD5crAG350ym0Ef/Iku1JWdY1aRNBHxX4jk8AflgdDWAwROhgnCrnDcdM1QXsTvKqb+Qtw7sirhKs3l9LMUEtalwOcQrJKVoCZrNVM0EcLcs9jsIacTztnlH+ebYBdXNAg64hTp0vVZ0xRZKH9ODxIsS9RLlI+JsRpmR6Eabk1s6E5537KfgTRbu8qJYAtCjVdpXFxlan7ICUjbX2dGN5K5ZWKD4j/aGP5BLKtucTr3pu50kmgvfbaCFspipJjgltq6lvb4DZSH169toSxWiVVS7Ec/rheqtXrXxYWBd2SkVKt9fUy/oPGePpCzfoszohA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DSmyoi4JwIsHLgJr0+zL6b0h3Cqc8fjoabEKa4W8tZM=; b=mK3loGBYeLHiq+/7YW0535EzsaHpPUzb2FsAPez8OJ3kwfzaeCLh3j2MzEags179NPXR8/HmG9m01pKjMLeCyMs6st9vgwMbdKrPJdpmkALIl7v/lL+hDsqBh8E5ItBPVz4LEKZszx9dAxPeull4yduVSmj/SRrgC2+9lNpokGA= Received: from PH0PR18MB4491.namprd18.prod.outlook.com (2603:10b6:510:e6::13) by BYAPR18MB3702.namprd18.prod.outlook.com (2603:10b6:a02:cd::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22; Tue, 24 May 2022 11:52:14 +0000 Received: from PH0PR18MB4491.namprd18.prod.outlook.com ([fe80::b065:32c0:f517:f85a]) by PH0PR18MB4491.namprd18.prod.outlook.com ([fe80::b065:32c0:f517:f85a%4]) with mapi id 15.20.5293.013; Tue, 24 May 2022 11:52:14 +0000 From: Akhil Goyal To: Arek Kusztal , "dev@dpdk.org" CC: Anoob Joseph , "roy.fan.zhang@intel.com" Subject: RE: [EXT] [PATCH 16/40] cryptodev: move dh type from xform to dh op Thread-Topic: [EXT] [PATCH 16/40] cryptodev: move dh type from xform to dh op Thread-Index: AQHYbBesNEMs9JEJr0C50yDPaMjGFK0t8PuA Date: Tue, 24 May 2022 11:52:14 +0000 Message-ID: References: <20220520055445.40063-1-arkadiuszx.kusztal@intel.com> <20220520055445.40063-17-arkadiuszx.kusztal@intel.com> In-Reply-To: <20220520055445.40063-17-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e2e05872-1e09-4d44-3267-08da3d7bd823 x-ms-traffictypediagnostic: BYAPR18MB3702:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +3fAmUrpjCYfkQGZi7w24/cNdp8xpqxHjzmw9z2Oq7ETb4K9eGnPCN9ppRjGa5+2QsqDK5VaUlMfptAx2aWw8wHb/66NqNB/IO7Wums//z9ggQQRTBhs6fLZRMBDQnaHY9RXcPEkToeIcmcDofGLyjifWHFNxZzVL0iYQjaqZteeDRNOOAg97qNS5P9q91Oh8TJFOyhlYWTsX+V7aqexKZQ6PTAMJljMeWxLTtSJN5tlzlkRj1XFpr4DL/Kt4VPoCtZ3SzN4ftxZEYHuvnFx4LtDhdbfMCHUcB4LsrKBuHgKICZ7/Zf4fl+scMneUPZzS4FaiL/V9wznB+5c63mzEAV9re4N1zjiF01tOuPgsbY6wZ1aJu9foBxlmx7Wu9SDTd4RoI16FdGBli5ly2T+fQas+NgsL8R6CfGyWwtU6Peii2Q9uRnDx/ReVpVCkdUFUNPHXcDDn6UYQkaVE1kW7X/3T7ad2rEcpI5pX1OnSB12+t3im2dXxAa5uh8x8+0gW1koYyoVTjvY5NZAMPqRbdchsON6r8ugC+C0glzF8xKn0goSzekviraZfQQrp6/dBh5HvixxA99Kn85nGsfd0CrEp7Wt6pYD8FH2zi2IlKMV4xVqF5bX8hBW9Tt2cf8g+QHCHMOqCPFfncFXldGrunnWAKlSgahJdI/uDh4PcMkqJXhcGn5Vd/BUQCDBV6Ppf5sVFXCe91Vi7sAv4Q84pg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4491.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(8676002)(76116006)(5660300002)(52536014)(66556008)(4326008)(66446008)(64756008)(66476007)(9686003)(33656002)(55016003)(8936002)(71200400001)(2906002)(316002)(66946007)(110136005)(54906003)(508600001)(26005)(55236004)(122000001)(7696005)(6506007)(38100700002)(83380400001)(38070700005)(86362001)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yvQEr3WhCey8IMBfHZ5DNxjzKnXAeoOPil6ZhM2OO6ZmyG1MVLaYHXHxFrb9?= =?us-ascii?Q?E3IdaxPt78Iw5FWRTiDguerlTq0hDhkrgKf9DjGdiVH2Mm+r4crsFR2dF5ih?= =?us-ascii?Q?DXXowu2w7kipVxZgCgw10/vwLOmAszJwkgj3yrP9JG9nHAtVRlv31B3NSHRh?= =?us-ascii?Q?zIbHrgYPOv4VF8scTT+1bT85fWbZyrh77A7BJJ6x8KCAEWQ+ttkg3vqJlpIQ?= =?us-ascii?Q?ETbHQxhD8Yd8sNd2h2b5TgkG/9AoCSuOQ1O2jnIngUsexSrwtQWX+T8yUI7S?= =?us-ascii?Q?rfjNIzLaV6vSnOWA+BaHlmTlzOO+7fsmNw9j687hyT490jH4zHRpDmXEIQUN?= =?us-ascii?Q?bmB6bNE0UJDx5kqxcPn5us7oQWXRRq5p/6jKE2s++zPwxkyAH5A+QQ69JmMb?= =?us-ascii?Q?PmEERq0b4tRREFduZfLrYr0hfOuM45yc5FbYOQZcOXMoi99xJMrLraTcZ2Ir?= =?us-ascii?Q?P8kJIsApuoaxTL8YNKGYHsPeEAdiF+lhatSZlCSf81Xy/almihFqtgGFE5li?= =?us-ascii?Q?SatjR8YKahzMpXTvJgzzPa4bPtqDczNqkMXDbQ82bqExyor0N+l1Vi0zR+Fo?= =?us-ascii?Q?+WmQVZc51NnxAjeLDBoT9lNYo6SsN/fuVxSU9ogBpV+L+EkDjip7yVdj1ZFz?= =?us-ascii?Q?FlHmFqr8YyzjQgjLeRjS/cXmtbIfe+RHQMaCMquDLRkx8NwNHafiY9dBDFC1?= =?us-ascii?Q?pS1e1V4adFamgCZ0iQLNN+K+ZMHucr/ihQ35KRa4MmON5vbSL6KAqQWD0waT?= =?us-ascii?Q?FZgSgLNSJZ9RFTWuQLqJsgeRSTwecnvNfDW0kUN3k6sINZu0HkPDbqwiogBG?= =?us-ascii?Q?F5a0bc+1Xpnu+p9YGUKvCuy1KLwnCF/bIZcN4vwWsX0bpQcM+rGKy90RGw0g?= =?us-ascii?Q?U4TZCsHr/qKe/fVXry6XnbBG2KmBRNwcJO8hwY0iWyehmmn/JN6InNsKvvsn?= =?us-ascii?Q?CSeUHy4O4o7aRoTd/94QEDz72rKNE8WZYpKuLU8+kHUVvERBJW6cpD07Cv7j?= =?us-ascii?Q?dbJt+PLpKbrhv991R1ptp9RemKo8NtVGL+z2crsPgwmnFYVzj7jMT5mPnD7i?= =?us-ascii?Q?f22kAHEfjeQMSFZWxyuvoAyuUx+MexUlLzCVv11gtCg0NnoyZyN0sXmUcwe+?= =?us-ascii?Q?FCGJTPRdkrs8XuIWYm1OQLZTbaYOaWn1vPqARUFejIopTWguq1VxqebE5CoK?= =?us-ascii?Q?Q1gU2/PGLFTPeAK/ldtOFQC73BoYJln5BAmxW9nqs3xQt1hAmRIrjowF5+gB?= =?us-ascii?Q?PPG7DUSZzaBX8C0Ha6tnzLjIqzb4OC7oBqLXjVI3i/U72qkND0DU8pZWe7TL?= =?us-ascii?Q?8XRxVuoAygGimU3xaqoOwZIhGzoRyuDoWQCIb4G7zedau75VBh2WJM39GLZd?= =?us-ascii?Q?wUk40Ejv4M4vUMtA8o/abzMY8NpcXNRlU+dCfxqkyr5WRdF+x83q/uVTT0xk?= =?us-ascii?Q?+DADKxiG4ODfRsFHNVP8vGhydZsePnRxHqd4/uEqsXtWTotXaiO1bmaJFWOc?= =?us-ascii?Q?nIJptbrbQcfopdKCyqLIKZoWl+yLK17Iww/7jVwuJcBfLkf3J1ZcWq7QM0EP?= =?us-ascii?Q?AJY+EWf+Di6rK9+llQ8vJBPeg/5PXe5gd3tP65wO/+aINqKRoPml5uBvPBKI?= =?us-ascii?Q?tQfr6fjA63n9LfKNp5dlbiM46fQ5CLfB5HLVwc2INzQhfDD5TnmefKvxhWhU?= =?us-ascii?Q?lWdWrsMH8ZrS/K8Y64wRG5M59szwn+yYTJyIZAz5zZPiR1ZD01r9dEFS9SNz?= =?us-ascii?Q?MuZTtvaa5g=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4491.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e2e05872-1e09-4d44-3267-08da3d7bd823 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2022 11:52:14.2334 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7kPEgK9N80ob/n3+UycfzCHdGqI38AlYxb128+pBF5O3e77PzxIDLB2lbKYHwGMlWXRkOHU3f24vjJy3GtYedw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB3702 X-Proofpoint-ORIG-GUID: -rthnDoipTXOUnAv_3NMkqop8mTYJOpl X-Proofpoint-GUID: -rthnDoipTXOUnAv_3NMkqop8mTYJOpl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-24_06,2022-05-23_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > - Moved dh operation type to dh operation struct. > Operation type (PUBLIC_KEY_GENERATION, SHARED_SECRET) should > be free to choose for any operation. One xform/session should > be enough to perform both DH operations, if op_type would be xform > member, session would have to be to be created twice for the same > group. Similar problem would be observed in sessionless case. > Additionally, it will help extend DH to support Elliptic Curves. >=20 > Signed-off-by: Arek Kusztal > --- > lib/cryptodev/rte_crypto_asym.h | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) >=20 > diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_a= sym.h > index b355cbe5fa..728a98f02e 100644 > --- a/lib/cryptodev/rte_crypto_asym.h > +++ b/lib/cryptodev/rte_crypto_asym.h > @@ -250,8 +250,6 @@ struct rte_crypto_modinv_xform { > * > */ > struct rte_crypto_dh_xform { > - enum rte_crypto_asym_ke_type type; > - /**< Setup xform for key generate or shared secret compute */ > rte_crypto_uint p; > /**< Prime modulus data */ > rte_crypto_uint g; > @@ -379,27 +377,29 @@ struct rte_crypto_rsa_op_param { > * @note: > */ > struct rte_crypto_dh_op_param { > + enum rte_crypto_asym_ke_type op_type; > + /**< Key exchange operation type */ > rte_crypto_uint pub_key; > /**< > - * Output generated public key when xform type is > + * Output generated public key when op_type is > * DH PUB_KEY_GENERATION. > - * Input peer public key when xform type is DH > + * Input peer public key when op_type is DH > * SHARED_SECRET_COMPUTATION Add reference with the actual enum field. > * > */ >=20 > rte_crypto_uint priv_key; > /**< > - * Output generated private key if xform type is > + * Output generated private key when op_type is > * DH PRIVATE_KEY_GENERATION > - * Input when xform type is DH SHARED_SECRET_COMPUTATION. > + * Input when op_type is DH SHARED_SECRET_COMPUTATION. > * > */ >=20 > rte_crypto_uint shared_secret; > /**< > * Output with calculated shared secret > - * when dh xform set up with op type =3D > SHARED_SECRET_COMPUTATION. > + * when op type is SHARED_SECRET_COMPUTATION. > * > */ > }; > -- > 2.13.6