From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1D20A04FF; Tue, 24 May 2022 14:08:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8208240140; Tue, 24 May 2022 14:08:32 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id DF442400D6 for ; Tue, 24 May 2022 14:08:30 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24OA7ruq031844; Tue, 24 May 2022 05:08:30 -0700 Received: from nam02-bn1-obe.outbound.protection.outlook.com (mail-bn1nam07lp2046.outbound.protection.outlook.com [104.47.51.46]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3g6ykm2dqq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 May 2022 05:08:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lzgh+1dqG0d4mF/7KHaxDkbBMxAuTd/zZeI54fCrL0Fs1mqlpy/hTxggwosluxmqlG+MpBx8A4j6zq8nmiDzDZitjuUiyzo0tXFyAD49eq2uX9ncu3y4143xcP8/bB36bDQExUwEa0OKMo1IiqM+8t0NxnUwIgTdTFA43ay4pYYchFJQqC2e0YnF7Ok64Kih823+y3fkJeJzwcALDIycSeszbzm2QsqEATsBMgZ5FPh/Zr3J8TM0qmgvSIpwSYxe0QKHt/rmMTBFA7ERLejTcyPrtvbr28/w90aF+el2UOOonMH89WGrIAa5JCHjWzSNM5MQsuEOX9Ut4AgH39YGPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fvIrpZEnXpeZiO3UReJVa6niOvzgwVJjlBhmHcPSPts=; b=Wce8awjqXm0ArxCQ+hrzFpm4DU6vhOqU3otC7fFY7+Vy1Y6iaVtpLH5pd/tfwFAp1jo6T8JMnNvET1JjN/IZy5pnTrY4yk0F1RX3od186HK5bb4w7IqUVdM8si0LMlX0LzW6RjEV8f4jhRovpLGEiiVR1P4o8TAgZFyLxiLI+f+PkUzDZ92bGYWalGzFqFfAVAiXBA8wMRuSulIGoGo3xMeUpWYQ9J52gmgN1Y+sIZHSzCfkwvINFBSTEOp1wPK5xJ2KAkOWKKUUd4BrkaUfMTkPp4ccEuvcHnbHj174/CG6uVk+s52QL0NUcXl7YMOp+jpNkYInnVHpcEk+gZRbsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fvIrpZEnXpeZiO3UReJVa6niOvzgwVJjlBhmHcPSPts=; b=qEHqMfetC8YfQvzMUvVLSkPtCN58idoghM3oCBfYAGE+Opcue9nRGfyA8XYO+FaZu6aW7d62GfcNTIIsTbz+KiPfnqiofnCsxM7W2NmbveV4aOBiu2EIMa4kjW1ZuXcFHt2lMHt1Y7zRnx8Xow/3UZC4hheVcbpjXb1CzzwQ0gc= Received: from PH0PR18MB4491.namprd18.prod.outlook.com (2603:10b6:510:e6::13) by MW2PR18MB2155.namprd18.prod.outlook.com (2603:10b6:907:12::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.23; Tue, 24 May 2022 12:08:27 +0000 Received: from PH0PR18MB4491.namprd18.prod.outlook.com ([fe80::b065:32c0:f517:f85a]) by PH0PR18MB4491.namprd18.prod.outlook.com ([fe80::b065:32c0:f517:f85a%4]) with mapi id 15.20.5293.013; Tue, 24 May 2022 12:08:27 +0000 From: Akhil Goyal To: Arek Kusztal , "dev@dpdk.org" CC: Anoob Joseph , "roy.fan.zhang@intel.com" Subject: RE: [EXT] [PATCH 20/40] cryptodev: add elliptic curve diffie hellman Thread-Topic: [EXT] [PATCH 20/40] cryptodev: add elliptic curve diffie hellman Thread-Index: AQHYbBey3IhHvQ40CEuYISM+aZVaF60t8kcQ Date: Tue, 24 May 2022 12:08:27 +0000 Message-ID: References: <20220520055445.40063-1-arkadiuszx.kusztal@intel.com> <20220520055445.40063-21-arkadiuszx.kusztal@intel.com> In-Reply-To: <20220520055445.40063-21-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4a00e68f-64fd-4482-9bc6-08da3d7e1c5c x-ms-traffictypediagnostic: MW2PR18MB2155:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9cG1g9fGrLAYPXibUUYt2r4TDkh6bschRZQaqQxpxjf1blthHCluX4suhMT3ZMyPTXaLj77V/fNP/R5NYLld3MJ2V8n9i2DDLmVqe1zvzVSJOebEwpJ6J538Nh7dumfauSj4j+fQtpHCvkZXg69y4RDqvqlpFoBt/o90TmEnYlmPnLKeBAOlrYKCLn5EZNhtoz/XCPkf0de1lgiiNTHIaKFLLESaVNAHCrsjNWUB9FkCzyYF0mbclHwTB+K/EiWcc3Z/i2nKIBG0vmQe7L+zsJEI8n5tLry3zuj8aw04K8IMoV6EHqcl0v7JGIX7Os9y7gQgKNxcZqH46Vibm1DhBJbyMOpeGLSM96PT13aT0azlVWHIypjt65TXfGTNtv4jgiHMjm2tfLCloQoqFs4MxmPT5yHUXLNIRGV4J3Q9ynsbTFvCrzSlEqmxnzQi8YIJ69YpgaOlGi+aGy6MBkkydjzYgOjB2owo6GzgwLD4WpYdM1CPvCdqksrnMiIP0ZA1J+GRTHNOV1BY1x5W2C586qLnjRfOLJN+Ey6+YmrrmHSypK6nt1Ns1bZhIUhvlf0+KDG2fV1PeGXmJZeEt+d5z52nU5qgs/OifAjXv0QUJRTgslcSDTdty82NvYhJpUbhoK1HLQZFcI9CrrMvmkm/ngkQtOv8RGBf4Jq8k678eilr8AW4K1JpoPfQM1DEOBzjWcou9wv+j2w1d+oZg0LnvQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4491.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(316002)(4326008)(8676002)(66446008)(66946007)(66556008)(66476007)(64756008)(122000001)(26005)(71200400001)(52536014)(76116006)(83380400001)(33656002)(186003)(86362001)(9686003)(508600001)(55016003)(2906002)(5660300002)(7696005)(38100700002)(38070700005)(8936002)(110136005)(55236004)(6506007)(54906003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Oklgo8Gf0DpxQt+cTlSGO53Prwb2lJlrBFdEf60Mpw1/fZYPjD7dNl81Il9j?= =?us-ascii?Q?FI+s3AkE+vRQg6Gm8TWx2cjodoScXgNOWDspAcRXz6jMI/r/ZLnHFJx2NYVA?= =?us-ascii?Q?E58kZ2oOdI8X1r9cgCmQlmExy7/LHEsU502CBCgIhNXX8Bz8yxhXoBjP4i9D?= =?us-ascii?Q?dpOqQo3lgJx0152wlNayhIVeZ1xt8gRQBKyFpgw9lZFxC4dx70Hjrnq/2UMN?= =?us-ascii?Q?brlp6uMAKP8QEmH0Z9/m9a6Nmytg+dM9O9A3y8dIXL1P78i4B0AtfRq069AI?= =?us-ascii?Q?wz6d4aF1MIBXAxnSB0nCbJo4ids8XAq5DLbMHRfUpSV45PNrYMERlZn4aaGU?= =?us-ascii?Q?2zgu0dQMQFi5V/25gHZdKOkjBugM5zAeG16D5QBLccLi+FOhlYfMkSUxxXTQ?= =?us-ascii?Q?uQ4Ca0UOuyvV54UVAJN7aA4tFzNrISkesPUhNazFGvVt5TCjuzLsI2L+J38m?= =?us-ascii?Q?KPWNb42Z9pQJx0nRNn4RG0oCvm/oJGPz3I0Mjw8gh6vzCpQqJnM+t+KZG0Ru?= =?us-ascii?Q?3qA2rvJED3+0XKghpVjfWAC/00u8exRWy7mKz4uFxibBCPrFqnODwvetOyo1?= =?us-ascii?Q?SRmdmJkpruVu4m63X0Ob2IMzNiS0ziuej2iMoiao7f/kGmmaumRHK8R1jyIf?= =?us-ascii?Q?lGK6yEeYzm8GEVaZ9StRvKoSWBDjFliAb7OeGHYwsBK/h+MtlnyzfHqArbXX?= =?us-ascii?Q?G/xG7+d+I7bwz09e/o9//PVkFpIXzv1Hykon98uR5v++kqrqepvKPP5lXzQX?= =?us-ascii?Q?7FSO6Q1V/eUL5E5v33JC6GfTVvt43IMM9Rzvk3BLSYeCdIgTqdZHwIuGfu9o?= =?us-ascii?Q?dU+fTs/tIXwTzr+Ln5JTZCiNtnO6910JYJ29v2gczBogW8YdG+7MMnNGbzJp?= =?us-ascii?Q?jOOOW81jUN9McSrswqLCPQLBd6M2J/ETHHX8LFTiv4oHLepLPH4DJF6VC3bj?= =?us-ascii?Q?j/3gxHi3ELIBbCrAJueCZPcADnuVnGFVlPN7s7nLs5K9Jmn0kWMf6gfYQiqa?= =?us-ascii?Q?j67xPndJO3R1umjHHzGkYY3bffIUZ6kLof8nvxIVN6G3hrnw/yenFsxi9+w7?= =?us-ascii?Q?deld8b53IJMl+jvY5hMWGLJpF6Gm7Zplgjf5G08tPOEU7bHzW071NkTNMVFD?= =?us-ascii?Q?+ceOTz2Ji6dDOEzG+9pKGCn+ty05Hin7pm79iTZahMfc6fA9snZ7qFEWHzJX?= =?us-ascii?Q?ZlpDEwbsGnVZWlEhP705I58FqH2lz3a59960SSJNDIFFVdyC1l+sfv98B/rp?= =?us-ascii?Q?Aeejfg+ExOBZ+Sx/xxN/oFju4Onwh4vYW4PSkn39/PEjjLs2KZdCAaPyy0fl?= =?us-ascii?Q?Eb91caJZJdJCJyIzWOPka04PBjA+G+PclCZwogQq45yOGlbVw4SjL+kr3kwY?= =?us-ascii?Q?yeHaLYcvqfI9kmfFaskQ0/R2jz1N0g/uTBPpVPvFwVHHOsbOnSDGB4BHQV8i?= =?us-ascii?Q?vlw/kTtTxmLjc1eCqClRkuh234xVc1HHAKA2s2Uti60jBhtUSpYhH4Uz7dPM?= =?us-ascii?Q?n0YqFO10Cz6WJ1kRkWCbFh+E53gMqpKodz68RbyxTWy5eSPnSTGCCYylpUls?= =?us-ascii?Q?UeEskeVAq0X75niVZ1L/1TjmAQAH03mRsUCvfN//sr3kGOpOzawdkIwFL4nC?= =?us-ascii?Q?kmsLaOWJWZPDQ3e/9mJI5uWiWJ5N/bDJ7Yqmwu2U++Nx/9RrfUrKw1i/rgfR?= =?us-ascii?Q?HLGSz0+XQgiuw/ecWAyW4YZyf5BLW46kAzc1Pa3gG504gVrxsDp17SCQgagu?= =?us-ascii?Q?TRbLit3Wrg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4491.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a00e68f-64fd-4482-9bc6-08da3d7e1c5c X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2022 12:08:27.7195 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sBdy9xrcJD4QNwmCru/8chgZn8pQ3R3aegKMfn4jBnydatr/WNjZSLZ8Xzf++YAm57M/TWhJaJWJvutrOyYvog== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR18MB2155 X-Proofpoint-GUID: utwNdGtDe8Pq1w8TiCGnl0-y58ES050k X-Proofpoint-ORIG-GUID: utwNdGtDe8Pq1w8TiCGnl0-y58ES050k X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-24_06,2022-05-23_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > - added elliptic curve Diffie-Hellman parameters. > Point multiplication allows the user to process every phase of > ECDH, but for phase 1, user should not really care about the generator. > The user does not even need to know what the generator looks like, > therefore setting ec xform would make this work. >=20 > Signed-off-by: Arek Kusztal > --- > lib/cryptodev/rte_crypto_asym.h | 34 +++++++++++++++++++++------------- > 1 file changed, 21 insertions(+), 13 deletions(-) >=20 > diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_a= sym.h > index 52cb1c5c80..09edf2ac3d 100644 > --- a/lib/cryptodev/rte_crypto_asym.h > +++ b/lib/cryptodev/rte_crypto_asym.h > @@ -82,8 +82,10 @@ enum rte_crypto_asym_xform_type { > /**< Modular Exponentiation */ > RTE_CRYPTO_ASYM_XFORM_ECDSA, > /**< Elliptic Curve Digital Signature Algorithm */ > - RTE_CRYPTO_ASYM_XFORM_ECPM > + RTE_CRYPTO_ASYM_XFORM_ECPM, > /**< Elliptic Curve Point Multiplication */ > + RTE_CRYPTO_ASYM_XFORM_ECDH > + /**< Elliptic Curve Diffie Hellman */ > }; Please add relevant information in "doc/guides/prog_guide/cryptodev_lib.rst= " >=20 > /** > @@ -383,22 +385,28 @@ struct rte_crypto_dh_op_param { > /**< > * Output generated private key when op_type is > * DH PRIVATE_KEY_GENERATION Update with actual enum name for this as well > - * Input when op_type is DH SHARED_SECRET_COMPUTATION. > - * > + * Input for RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE > */ > - rte_crypto_uint pub_key; > + union { > + rte_crypto_uint pub_key; > + struct rte_crypto_ec_point pub_point; > + }; > /**< > - * Output generated public key when op_type is > - * DH PUB_KEY_GENERATION. > - * Input peer public key when op_type is DH > - * SHARED_SECRET_COMPUTATION > - * > + * Diffie-Hellman public part > + * For DH it is big-endian unsigned integer. > + * For ECDH it is a point on the curve. > + * Output for RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE > + * Input for RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE > */ > - rte_crypto_uint shared_secret; > + union { > + rte_crypto_uint shared_secret; > + struct rte_crypto_ec_point shared_point; > + }; > /**< > - * Output with calculated shared secret > - * when op type is SHARED_SECRET_COMPUTATION. > - * > + * Diffie-Hellman shared secret > + * For DH it is big-endian unsigned integer. > + * For ECDH it is a point on the curve. > + * Output for RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE > */ Is it output for others as well? Please be consistent in the comments for all params. > }; >=20 > -- > 2.13.6