From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C5E143B81; Mon, 4 Mar 2024 08:33:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0767A40144; Mon, 4 Mar 2024 08:33:32 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id B41AA40041 for ; Mon, 4 Mar 2024 08:33:30 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 4245ROgQ027004; Sun, 3 Mar 2024 23:33:26 -0800 Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2100.outbound.protection.outlook.com [104.47.55.100]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3wn85xg9k8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 03 Mar 2024 23:33:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AxrtejDlNcbGgB/9du+wdJa3nFxcZ18xhrqCEF4oGWU6dqd8bJyFB7Z3Yzu+8OJE8BVBya6/OxbXWDeDwC5FX89L3yn4OMxZQPv4+Nu6NbIfCcNmpJ/VN28QX3HZtwXox79dgcZkJpNSxa16l8LaGPE7TBpW/QQgODVkR+5M7aslVV0zkorH8NUN+FWWsjgLyI9il3B7HwVqm8S776jI6Sbvbt0FCoYTebawVbk4LFVvr05RJ1Q9dhQmWlI5SM7G0GIfLfboYo8wGlQojo+oA5C/4kubVDFdAF2khpjOMQZiJfUXz3VM01GDe/il1ge6r1yHildw0FonFfqykUCf5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3np30VrpcSKbGYTM1WOh4GHFI0naK4rasfW2S6ftwac=; b=l8vHMpqsznUN1r65fY2mpluqFLisf8H562NgsNrRBUTMdjqGlKmGY5asWXaB6s7+ac81Z4l4ov/t56ChpkZDTEKdDvo802emAZOE2Czs1joALi51V4Jk36DJBnjsGG63B5OQkbwha/NBxphk4E1eh+HPSuZWYmiqP2On83U+UkQNtjqFYBX50c74Rkn6HoG68/Aj7jShTzsO47w4QB6spnurXA7BEez2hW3GelyZMy+9fgTHa2aLWkujBWdlIXfQnSOLsS9JgdgoJgaHbSIEWouenU0y7VK1bAdUpTUusiuj4Jg7vwv1G7QDnFYxhwFl66WtzHVKhnlQI8HEmyCSjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3np30VrpcSKbGYTM1WOh4GHFI0naK4rasfW2S6ftwac=; b=EFgF17QGYedknr5zvOggHLFSNQpVLCwQyP3ihppiGd4dhA0EwE8wRlocoVteisBZTIy8J7c9YgNPgCbQKnauG+ro2xns76QYR1dgFVv0O+9v8Jo80PdkWeMU/VWIhCUmR3cznUeW1aPSYy8vz472cVCG3FEfdyuBLZrt7Tyr2p8= Received: from PH0PR18MB4491.namprd18.prod.outlook.com (2603:10b6:510:e6::13) by IA2PR18MB6101.namprd18.prod.outlook.com (2603:10b6:208:4b1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.38; Mon, 4 Mar 2024 07:33:23 +0000 Received: from PH0PR18MB4491.namprd18.prod.outlook.com ([fe80::8747:980c:94d9:c0e9]) by PH0PR18MB4491.namprd18.prod.outlook.com ([fe80::8747:980c:94d9:c0e9%4]) with mapi id 15.20.7339.035; Mon, 4 Mar 2024 07:33:23 +0000 From: Akhil Goyal To: "Dooley, Brian" , "Ji, Kai" , "De Lara Guarch, Pablo" , "Power, Ciara" CC: "dev@dpdk.org" , "wathsala.vithanage@arm.com" , "ruifeng.wang@arm.com" , "honnappa.nagarahalli@arm.com" , "Jack.Bond-Preston@arm.com" Subject: RE: [PATCH v4] crypto/ipsec_mb: unified IPsec MB interface Thread-Topic: [PATCH v4] crypto/ipsec_mb: unified IPsec MB interface Thread-Index: AQHaayuxbsUnQwZXw0G1EZ4JKBQDv7EhgcHggAWz03A= Date: Mon, 4 Mar 2024 07:33:23 +0000 Message-ID: References: <20231212153640.1561504-1-brian.dooley@intel.com> <20240228113301.934291-1-brian.dooley@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR18MB4491:EE_|IA2PR18MB6101:EE_ x-ms-office365-filtering-correlation-id: 82539280-4788-4550-3d45-08dc3c1d5f8d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /cfSaLCsYFhbQlynmAVf7KQ01kem5gJ+4p8JF1Gcobz+9YeTrXLlB11UR37on5MC4oF3u/7CzWxPC8YAHNHPa0UUENbStyDbUeLOifWSgxWV2o0KmW9dkx59BdIm3tJ7G5QrEXajaV7O3Jlm+9J4vzd21m58oIB46f9KBvA88XYW2uzgwtwTk/le78lynBTnor//hpYFZDZwQ7o90NKA9d+gqilyag5OITFKkpMaRjhWWq4ttjs4L4BEbaNcTbzWN4f8RlyaN2owCjRYbAyGEZELABRKEqXWnsQEkxzcNpkZOAInBu9wVbnxqPelnECIRRlYlRxLNLzwCSbnbSeutnLMdCzemzGn8HTS7lf//oWJCN/msZP4drFz5V3VDiExyAMI8IGGSSgnXIV3jyQF7wtZunorGNFvdf0gZi7oDBhtmTgWRcFrL6qzFAoj+GbIl0jGlC0v5qpKBsxjaw3wu2ZJwcnsUrcftmlrLDlW8oKgwbCXrnH02Ex9wA3GOpM2Dzn6IMCO6kuNgrmm1q6u0Ae1M1Bd0yeI43pu7Mcqr9BxjMJh0K+nWgfHUtmTv+zzjCnQe3/21UxCZVTkQqvZoHH6LrawJdxzbupMWGyknDgAr2iFna4bFeXOaCPhBNTDtM+hjyKJOWbwi1XjK9ygGXzosITRkIhLPAl9QG+ec44= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4491.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(38070700009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HqSVGjhQqzbL/8lYedyr+fj+9vnqYuhNMn/0jxfUrc9lPhmpGaGpbNBejO9X?= =?us-ascii?Q?a7eyj7MLBK01pcZ0Q7h5yZyshYpVg5qD2a1Ormlm7x4OafxKWcnUcp8Q4qDD?= =?us-ascii?Q?HO9q0nx2XttC84aTQt9K8qNOR+X2bU0LVT3EDzRAZvIrIoNrItiPBbEucftd?= =?us-ascii?Q?51tFq+JZyB7rcyfK+AzA3PKICOcMwGT+2GDIL/40wcmf2aHcQmEfej5e7g93?= =?us-ascii?Q?5QMxJ0x8ClkZbipm1UdSKYqlOW1rEYaE/OD9rW+wKS4sBQdTvwy6YTy+h8Q6?= =?us-ascii?Q?yWie3nJpiY4E3GYJIoUSMnz1Ll9Uu9JHp7oYDL0rgu5pXhBtkwRxJGgCMUOM?= =?us-ascii?Q?0F+ahtg0ZA++3vjwtGaPGf57bKs7Zykd7tBJZfI+lgU4NCwdX9JuH3HcWqX9?= =?us-ascii?Q?p77X/OIQ8L8v/NU7b/ZkRS5JvYCJdKE42wau8hpvcbv7RNQcsOR+/SMvpo5P?= =?us-ascii?Q?lD154fza+S0ePyDRkQayOrYMHs+5OMrLPGs57D92Pfvq72INU4OY1s/t6IbP?= =?us-ascii?Q?fGX3qb9VBEIwru4lEp+OfMkyhVCvZdjFjtc8SPe/PoRP3GTmhRI2at1kHawC?= =?us-ascii?Q?sNxN3tLDzMDytU62OK8RDuPpGCqlwsw/l8t3e1TZ5m34be7sg97sf9MyA2Yd?= =?us-ascii?Q?//LcHVxrfeoZuCyfH2S7GeREGUqhj5SOLt0P9PiRTqg+Zt4bHsPkx+gSq7pg?= =?us-ascii?Q?rMnZKwjuzNhOPVor5VDt53NQSI1KErAtQmARHahoIpBnXqe4Ng7v5SP9ZQ1t?= =?us-ascii?Q?8qFK2gcIrQuirvJDiXXbXDQRiXSAuJehtt9SUrYa2gu6S7DANicLhoe6owMh?= =?us-ascii?Q?ARLpf3g/pYg0SvrsXNN9p9KkcJz9vl69CrPXHcHd6FsHXXA5VkaBD7ElQ+js?= =?us-ascii?Q?YKL2oayxvgb7vwC28/9AmiqN8LoDrgvEOrDzXN69fTR+oY1+KQ4I2JnQCfH9?= =?us-ascii?Q?ughYRR7MfDnpUxKCUYmMOHZqw4vn302e0qpwVS1el5+lCxXe0fRiXGq3hkq7?= =?us-ascii?Q?rf7khNao/bh2u9/tyn90ptKnh7z1nQ3jEwUkPGoyWa+58xjJPkANwCdzNAc1?= =?us-ascii?Q?nJiE0WjqkUjlEbmKvrwmM/xDmEv2BL+fzNu48t9HHTW5D6U3JrQOi887gh+h?= =?us-ascii?Q?uBJWBHMgKF9sUveSffkoPU6GWHawNW0cyx4/34QmcArAA3aN7nq34YAcIAfn?= =?us-ascii?Q?brbCMYV9GooC7+PH2ZoYxhq09b0hHiJrBbcySa/tfazuyzV/Ewie2Y0wXpYh?= =?us-ascii?Q?3ziXLuN0GlJZy7BPOIr1hKxe1NNjm6FkeFZKViaOCDeXTVwdPDSHFl63qmco?= =?us-ascii?Q?ZYCsIw72R37iPKznkYArflLJqans9ou2rdqbRTDmJCrPMk572+//OqgxLeAR?= =?us-ascii?Q?Csk2xnGvdLJhY1Khqr/7tDJyj/xFg6wfWn5v8snYb+aX4+a6GHRhfmakLX0S?= =?us-ascii?Q?own/te95HwDqxNB8v8hI7T4KVB4Tu94aDNX+IHEE5c6+upS1DCGaArH3qY9m?= =?us-ascii?Q?WLmGuNbQT83ZOQtRKqG1HSg5Gen5LoGoH2X6nIy3Zz1OC6eApc8EGEQx9PKf?= =?us-ascii?Q?NNHmGP6BP+uCxrrA5My6itwyqumd1d4pJRKq5rnZ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4491.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82539280-4788-4550-3d45-08dc3c1d5f8d X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Mar 2024 07:33:23.4367 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ms7KEiklGT1dE/+7sSKG443wEbc7GD0VeUrjnFFG/x2n2yYQyCrnrZ64ABhLYD5hcP6VLbD+c8ZzwcL36JQa1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA2PR18MB6101 X-Proofpoint-ORIG-GUID: 4i28RXebnHrkESt5gRLxz3xNWTkjNnQw X-Proofpoint-GUID: 4i28RXebnHrkESt5gRLxz3xNWTkjNnQw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-04_03,2024-03-01_03,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > Hi folks, > > > > The introduction of a more unified IPsec MB library for DPDK is causing= the > > snow3g tests to fail on ARM. Artifact here: > > https://lab.dpdk.org/results/dashboard/patchsets/29315/ > > PMDs using the direct API (KASUMI, CHACHA, ZUC, SNOW3G) will use the jo= b > API, > > from the AESNI MB PMD code. > > We have come across a similar issue in the past that related to an offs= et issue as > > SNOW3G uses bits instead of bytes. >=20 > The above link does not seem to be working. > I believe from now on, since we continue to maintain two separate repos, > it would be better to get ack from ARM folks as well > before merging anything onto crypto/ipsec_mb PMD. >=20 > Arm folks, Could you please get the below change tested/incorporated in t= he > repo. Hi Arm folks, Any update on the below fix? >=20 >=20 > > > > commit a501609ea6466ed8526c0dfadedee332a4d4a451 > > Author: Pablo de Lara pablo.de.lara.guarch@intel.com > > Date: Wed Feb 23 16:01:16 2022 +0000 > > > > crypto/ipsec_mb: fix length and offset settings > > > > KASUMI, SNOW3G and ZUC require lengths and offsets to > > be set in bits or bytes depending on the algorithm. > > There were some algorithms that were mixing these two, > > so this commit is fixing this issue. > > > > This bug only appeared recently when the ARM ipsec version was bumped t= o > 1.4. > > It appears there could be a similar scenario happening now and this is = a > potential > > fix that needs to be made in the ARM IPsec-mb repo: > > > > diff --git a/lib/aarch64/mb_mgr_snow3g_submit_flush_common_aarch64.h > > b/lib/aarch64/mb_mgr_snow3g_submit_flush_common_aarch64.h > > index 13bca11b..de284ade 100644 > > --- a/lib/aarch64/mb_mgr_snow3g_submit_flush_common_aarch64.h > > +++ b/lib/aarch64/mb_mgr_snow3g_submit_flush_common_aarch64.h > > @@ -94,8 +94,8 @@ static void > > snow3g_mb_mgr_insert_uea2_job(MB_MGR_SNOW3G_OOO *state, IMB_JOB > > *job > > state->num_lanes_inuse++; > > state->args.iv[used_lane_idx] =3D job->iv; > > state->args.keys[used_lane_idx] =3D job->enc_keys; > > - state->args.in[used_lane_idx] =3D job->src + job- > > >cipher_start_src_offset_in_bytes; > > - state->args.out[used_lane_idx] =3D job->dst; > > + state->args.in[used_lane_idx] =3D job->src + (job- > > >cipher_start_src_offset_in_bits / 8); > > + state->args.out[used_lane_idx] =3D job->dst + (job- > > >cipher_start_src_offset_in_bits / 8); > > state->args.byte_length[used_lane_idx] =3D job->msg_len_to_cipher_= in_bits / > 8; > > state->args.INITIALIZED[used_lane_idx] =3D 0; > > state->lens[used_lane_idx] =3D job->msg_len_to_cipher_in_bits / 8; > > > > Thanks, > > Brian > > > > > -----Original Message----- > > > From: Dooley, Brian > > > Sent: Wednesday, February 28, 2024 11:33 AM > > > To: Ji, Kai ; De Lara Guarch, Pablo > > > > > > Cc: dev@dpdk.org; gakhil@marvell.com; Dooley, Brian > > > > > > Subject: [PATCH v4] crypto/ipsec_mb: unified IPsec MB interface > > > > > > Currently IPsec MB provides both the JOB API and direct API. > > > AESNI_MB PMD is using the JOB API codepath while ZUC, KASUMI, SNOW3G > > > and CHACHA20_POLY1305 are using the direct API. > > > Instead of using the direct API for these PMDs, they should now make > > > use of the JOB API codepath. This would remove all use of the IPsec M= B > > > direct API for these PMDs. > > > > > > Signed-off-by: Brian Dooley > > > --- > > > v2: > > > - Fix compilation failure > > > v3: > > > - Remove session configure pointer for each PMD > > > v4: > > > - Keep AES GCM PMD and fix extern issue > > > --- > > > doc/guides/rel_notes/release_24_03.rst | 6 + > > > drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 10 +- > > > drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 15 +- > > > drivers/crypto/ipsec_mb/pmd_chacha_poly.c | 338 +---------- > > > .../crypto/ipsec_mb/pmd_chacha_poly_priv.h | 28 - > > > drivers/crypto/ipsec_mb/pmd_kasumi.c | 410 +------------ > > > drivers/crypto/ipsec_mb/pmd_kasumi_priv.h | 20 - > > > drivers/crypto/ipsec_mb/pmd_snow3g.c | 543 +---------------= -- > > > drivers/crypto/ipsec_mb/pmd_snow3g_priv.h | 21 - > > > drivers/crypto/ipsec_mb/pmd_zuc.c | 347 +---------- > > > drivers/crypto/ipsec_mb/pmd_zuc_priv.h | 20 - > > > 11 files changed, 48 insertions(+), 1710 deletions(-) > > > > >