From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 753EEA04FF; Tue, 24 May 2022 13:45:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 23BDE40140; Tue, 24 May 2022 13:45:56 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 1E2CC400D6 for ; Tue, 24 May 2022 13:45:54 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24O99rE9005720; Tue, 24 May 2022 04:45:54 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2168.outbound.protection.outlook.com [104.47.57.168]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3g8vg48gb6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 May 2022 04:45:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M5UgouOD1XdbnJV0zPfO28ETrmViFfgh1NTWCvUffqmKjhr+ahsOQwZu1MnxvXSchet1xDNrHsqfMtgxUP/SSx94E/cEyLS2qhG9V0/SZP6BJtCN8JKsTs7sWC48q91SnA6K8hG3N275x46IYTsj8+pa8+eea8QoJ+FkG1NhOUJZuhCBf07g8B4Ndr+S4uhjyclFWoHXXXxtjp3/mFOHP7LpNyHPO3ESTDLaMF1IWFflteVjom3QukOPFLEqRW0Rwy0HP74eApXI9MIihAyLHodOBwDjzONS1qyeASOm47P/hIAz1qSadCeFMj6Xfa2P1WQdwfRdEUDNtEdGnfn7/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TAN6Cg8Lp4eThz8ff9ScoLFblC3kkE50XCjh/EBDbPU=; b=nUCXWQqUpnqk4wBBQ4D7n/LMznNLI7E+qSaRXSN10higHDzOrZJ+RRNNuvzABtub2Zs1Jymb2zMFZZ4OQHUXTvvNVoGJLVWgqBsSQPBlMA1183KS70v0QnW+AsDBof0MEHuDjG5klVVl20b9a627tPNLUU7M8qgauOEOrhySngxPXIDWRBV1/Xe7inbppF26Plldse3mV8JUhN7wbwgSmPETto83eMDZDWqYYHUCaP1iuhoEcl9VrRMawIhZ3FNYtqU8ofdvIsgi7SrYkpfLavbkcU9ga/b1kjwcWXtVJTC8Q1qawzprduQwGnPVjHKo+oNptl2afTCfRtZSIGJNSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TAN6Cg8Lp4eThz8ff9ScoLFblC3kkE50XCjh/EBDbPU=; b=eB1PaXyT9mpFoHt6vCAE5PjUD6V2LfjrYnfFjzIgruGGfJPmBpWE+4zdOsUBL09KxTm4Q7Y/bZeOhZcnsxZJWCAH6jiovx6kTAyCm3Ny0rCVBuAjZARL/ALJf4iQFH2GtSfIsNkYajenud0leF2SkxMaaD80eQfL+G1kpoOSQE0= Received: from PH0PR18MB4491.namprd18.prod.outlook.com (2603:10b6:510:e6::13) by MWHPR18MB1581.namprd18.prod.outlook.com (2603:10b6:300:c7::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Tue, 24 May 2022 11:45:50 +0000 Received: from PH0PR18MB4491.namprd18.prod.outlook.com ([fe80::b065:32c0:f517:f85a]) by PH0PR18MB4491.namprd18.prod.outlook.com ([fe80::b065:32c0:f517:f85a%4]) with mapi id 15.20.5293.013; Tue, 24 May 2022 11:45:50 +0000 From: Akhil Goyal To: Arek Kusztal , "dev@dpdk.org" CC: Anoob Joseph , "roy.fan.zhang@intel.com" Subject: RE: [EXT] [PATCH 06/40] cryptodev: separate key exchange operation enum Thread-Topic: [EXT] [PATCH 06/40] cryptodev: separate key exchange operation enum Thread-Index: AQHYbBefaLJzJFir2EOiCnmAJv1Tr60t70yQ Date: Tue, 24 May 2022 11:45:49 +0000 Message-ID: References: <20220520055445.40063-1-arkadiuszx.kusztal@intel.com> <20220520055445.40063-7-arkadiuszx.kusztal@intel.com> In-Reply-To: <20220520055445.40063-7-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ce65ef98-2205-4706-7573-08da3d7af314 x-ms-traffictypediagnostic: MWHPR18MB1581:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eqmk9ejuVufamMTzyrCATlw/VvS7OP2ByWobyDcSAj0l5LVU+nFLLHGibULtQud5lFV28UZ9n8jh6FrNA/Qx7/zRaksLq60xSjQNbgbjzA10HTBmvqlkC+nfuBiMawSoD9fPFocIfouVoUsjd/2aSJXwtAfTpn1Ycy04SUTCwUEmdU7cJguCC3oVxyq2sUKd5t+EqTitN4zf1BuIGVSHmPutVWAT6hEvUbJHhMXsFw1lwDY+l3hoCRHXqNSyD6yz1H5QgwJrDRfuLmvWzU1XVcz9M5Xvaf/b+hbMoU8jW4dn3y948OKlR6Cy4MysEqlRl3x7TqQnY0yEu78Uo9g3N28KRwYZr8ihek43BU5Rn2jSC8ete0vJ/Sl6cBgekn8n1FaTzPglpyhlAWJ6tQOIkSUapkkk8eLQS7t0f1YrLonrfm6dFlmKQEjJc5lCN967PnatKnn59WrP+kxN3o/nlDIEtDcuHktQQcvBAdKE0cLVRCQNvtQerY97LKUsinIzEP8Yp+9953ZUIeHZDZ1DNYxulfv9thB+rK+jDINCS0gcm02Pt6K6kwEV/tf4EJVZhfDvWGDIfAQRIxcca5BGFy588reZLstRiQRutOdzfKTHzWyDRB/I0eknjyBofQTPVhZ6KaLDJ2jtEZSaLtNudhHY1NoDsWOXakMXvZ6QcltahvsK2kj7Oq2U69Iv2mAvG/nrhBMBsR1dLBVdkd7PUw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4491.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(7696005)(55016003)(8676002)(26005)(66476007)(186003)(5660300002)(71200400001)(83380400001)(33656002)(52536014)(8936002)(508600001)(55236004)(6506007)(2906002)(316002)(38100700002)(38070700005)(54906003)(110136005)(122000001)(76116006)(86362001)(9686003)(66446008)(64756008)(4326008)(66556008)(66946007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qMMYcEk9oumc0p22RljY9eWVmspPln+gnTbcgbxNzWGRI8nuLLPOvifXgdoE?= =?us-ascii?Q?kzFIGH8jhbRZtaeIM92X3ok0+DkAQ46nIJHL0nNeEQ5UWNSfbvY36a+ca89a?= =?us-ascii?Q?9gXpetZjynlPImgRbviSPo9M+rgDCAjfhdaO1gRpkYjL+JXics/vksuJDOwK?= =?us-ascii?Q?6NopShZL5ZaBscU0rVdbqTndjHV8jdvJ7tCiQoSFDKFrXRsHOGW5rgnBv7H4?= =?us-ascii?Q?am1l88DUGJDzosm/RSjkHkIvWGVBnKhXkMZPBDAqO57ZSWqdRQLhwsf3avcV?= =?us-ascii?Q?pBiVGNqZQNv6eMQvDJRHb0NMeJtAG1jx2WpW5jci0FDmuIwmA/OtU5pliLLn?= =?us-ascii?Q?v8SEpcyS3ct5TkRl2L6HEx361f2t0u0mG+RGXS0F0EqxAIUhs6Bb6ZUYOpdg?= =?us-ascii?Q?HTR0ynJSAHY9Yn6toR2+pZ+2pA/ysYSIsHWbXIsyFnQNJ3tuAixuKiv20ZtX?= =?us-ascii?Q?9r/pDJ+mCIPicWbU+03fh9kF9SAhRJdOKhXiu3M7Jmd7kJZOha+NWy5KqkLh?= =?us-ascii?Q?Q1HsC/g0+VwEt5+0H0XEtx6WYFzPT/tUU0mBfmFbOCUEhqsmrREcoxN+kIpj?= =?us-ascii?Q?Gc5KtphCSNIDc5g+BFUar+jVSrIIdvRKlZsSPm1yhjyaWYo/XxIJYW0D6gEj?= =?us-ascii?Q?Ws9pl4qnJ4NitGVtB8UrLFydG3X/j/Of0M6ArbJ0b7b4H+/XXfZlpsqB6/xd?= =?us-ascii?Q?4y/wYA/2vLES8C09tvSlZZfaylSwPogBVvoRHvOadldZl71gdp/XEMOZkYqT?= =?us-ascii?Q?V5GwyWuVvIyHQfdeRT2lvfDY78HXRQ2L5pL+gVoFzF4cLNvHAsvc7zGorpH2?= =?us-ascii?Q?NVRFqd35CXH+tnPa7b+w722EwOV4G0nieMkpsSXSoSVthQsNFY39pBLGkrVC?= =?us-ascii?Q?9nglJMEM6ZKJ4vUEP3CTSn5oiM8w+FTS+cDilsBXbdduumuvIyAk1/rZtDgl?= =?us-ascii?Q?bl47GTR2vJQERLGWeh4Lq1nyB0wD+MF8l9uaFXFnE1aoRC3IUKfyIuGShT0H?= =?us-ascii?Q?ByeaN+AyXMqz6vQCRsAVeljKxpTPxDKQwlbRhstgbp58UwcTZ8uZdjkLhsb9?= =?us-ascii?Q?F8xkhb6Y94RwKV5Tpqa+GCViSy5B6V6ttvkFNOsx81W2f+giGGNfr6yXaShr?= =?us-ascii?Q?abXArSz1/O2hxiZuLtRs3gAoA/f1JaayDT1E0ahlWi4O6m0a2S9O85Q+9Abx?= =?us-ascii?Q?Dxt4gcj5NQ8C2wAu+eAF2U7R/ufJFlbp09qU2DefD0k1gkuXKugMNhKPYPRc?= =?us-ascii?Q?OMKG5pU5uOGBk6w4xQF7+Ml8ssLEvGVZi+TGi+Aexi+ga1w2jHfjSjSlfDAv?= =?us-ascii?Q?aOj+x2VSX2vrvEjvpJry49BVxWE0G5Xke+6ATeYXTArRPg/+TEJIwPui65Ns?= =?us-ascii?Q?ZEeCQBlaFnX6LAg1aFZm3A663ICMa6q7yUwemjzAmq5QEBSbbVhIYvAu8J7D?= =?us-ascii?Q?pQKhZdUiQ8o/d5RricRZGQlK1cGp9wOVL4vlzIuOmeOSIsrUJuBxSmKeVtQg?= =?us-ascii?Q?Pr0xfZsVEUbCAVWEmD6Wc+19Z0qIfQCrgqZ6M6v1utD78PVwTAZJq8PsGzfi?= =?us-ascii?Q?AKJceVLrgS4qJ/bTykW6pgAOKluLzPwc5eUx7U3tu9W/St1wE983Odp2sTC+?= =?us-ascii?Q?ArWkilX0nnhkSgQc4DeLF7VEfmtRAjOA5YHTWPsVn2RuEpOqRtLQksNdxWMs?= =?us-ascii?Q?G4qWBJ2MTolT9S6INSXUp7PIFbmyVe3u5ONlSgP/WWbPuEGHvLFAxSxrVdrp?= =?us-ascii?Q?xTRW0fImXA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4491.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ce65ef98-2205-4706-7573-08da3d7af314 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2022 11:45:49.9542 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: m1Cg1yN5Fq6S74A225V6E/xv7Rwihg/kmSmtoodgpmLNTUBW7sj+Jr7XknTUX0BudqeNPtLa90RCRNQlZy6KWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR18MB1581 X-Proofpoint-ORIG-GUID: 1yEuEEFHaeZJwUkhtRLj7n8xWMVoYqZ6 X-Proofpoint-GUID: 1yEuEEFHaeZJwUkhtRLj7n8xWMVoYqZ6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-24_06,2022-05-23_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > - separated key exchange enum. > Key exchange and asymmetric crypto operations like signatures, > encryption/decryption should not share same operation enum as > its use cases are unrelated and mutually exclusive. > Therefore op_type was separate into: > 1) operation type > 2) key exchange operation type >=20 > Signed-off-by: Arek Kusztal Please check if it need update in Documentation. > --- > lib/cryptodev/rte_crypto_asym.h | 24 +++++++++++++++++------- > lib/cryptodev/rte_cryptodev.c | 14 ++++++++++---- > 2 files changed, 27 insertions(+), 11 deletions(-) >=20 > diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_a= sym.h > index 0251e8caae..0fc9f49b87 100644 > --- a/lib/cryptodev/rte_crypto_asym.h > +++ b/lib/cryptodev/rte_crypto_asym.h > @@ -33,6 +33,10 @@ struct rte_cryptodev_asym_session; > extern const char * > rte_crypto_asym_xform_strings[]; >=20 > +/** asym key exchange operation type name strings */ > +extern const char * > +rte_crypto_asym_ke_strings[]; > + > /** asym operations type name strings */ > extern const char * > rte_crypto_asym_op_strings[]; > @@ -94,12 +98,18 @@ enum rte_crypto_asym_op_type { > /**< Signature Generation operation */ > RTE_CRYPTO_ASYM_OP_VERIFY, > /**< Signature Verification operation */ > - RTE_CRYPTO_ASYM_OP_PRIVATE_KEY_GENERATE, > - /**< DH Private Key generation operation */ > - RTE_CRYPTO_ASYM_OP_PUBLIC_KEY_GENERATE, > - /**< DH Public Key generation operation */ > - RTE_CRYPTO_ASYM_OP_SHARED_SECRET_COMPUTE > - /**< DH Shared Secret compute operation */ > +}; > + > +/** > + * Asymmetric crypto key exchange operation type > + */ > +enum rte_crypto_asym_ke_type { > + RTE_CRYPTO_ASYM_KE_PRIVATE_KEY_GENERATE, > + /**< Private Key generation operation */ > + RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE, > + /**< Public Key generation operation */ > + RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE > + /**< Shared Secret compute operation */ > }; >=20 > /** > @@ -239,7 +249,7 @@ struct rte_crypto_modinv_xform { > * > */ > struct rte_crypto_dh_xform { > - enum rte_crypto_asym_op_type type; > + enum rte_crypto_asym_ke_type type; > /**< Setup xform for key generate or shared secret compute */ > rte_crypto_uint p; > /**< Prime modulus data */ > diff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.= c > index 691625bd04..af58f49d07 100644 > --- a/lib/cryptodev/rte_cryptodev.c > +++ b/lib/cryptodev/rte_cryptodev.c > @@ -176,10 +176,16 @@ const char *rte_crypto_asym_op_strings[] =3D { > [RTE_CRYPTO_ASYM_OP_ENCRYPT] =3D "encrypt", > [RTE_CRYPTO_ASYM_OP_DECRYPT] =3D "decrypt", > [RTE_CRYPTO_ASYM_OP_SIGN] =3D "sign", > - [RTE_CRYPTO_ASYM_OP_VERIFY] =3D "verify", > - [RTE_CRYPTO_ASYM_OP_PRIVATE_KEY_GENERATE] =3D > "priv_key_generate", > - [RTE_CRYPTO_ASYM_OP_PUBLIC_KEY_GENERATE] =3D > "pub_key_generate", > - [RTE_CRYPTO_ASYM_OP_SHARED_SECRET_COMPUTE] =3D > "sharedsecret_compute", > + [RTE_CRYPTO_ASYM_OP_VERIFY] =3D "verify" > +}; > + > +/** > + * Asymmetric crypto key exchange operation strings identifiers. > + */ > +const char *rte_crypto_asym_ke_strings[] =3D { > + [RTE_CRYPTO_ASYM_KE_PRIVATE_KEY_GENERATE] =3D > "priv_key_generate", > + [RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE] =3D > "pub_key_generate", > + [RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE] =3D > "sharedsecret_compute" > }; >=20 > /** > -- > 2.13.6