From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1809A04FF; Tue, 24 May 2022 12:59:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6AE9540140; Tue, 24 May 2022 12:59:21 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id BA0D0400D6 for ; Tue, 24 May 2022 12:59:20 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24O9AGIm006391; Tue, 24 May 2022 03:59:19 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2170.outbound.protection.outlook.com [104.47.57.170]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3g8vg48bh6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 May 2022 03:59:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Unjh4JFcuD7LsbNWuThI1821RPSs34cR53PTObXDZ6UfYpROGsd6BmX/einUhw04jr+6lLgynxIZp7x2uA2zk9FyvBA3rXZ+VYlrYjmUdEWdJIkxLi3s9Kz3aEcS2W8do8+HNwjNEuR1tiQO5xCcvLX2VlNENGrDmmdcXNaS6z1zYzhL2Xz8oBMOLRl+BJtgO7+APQRIIpr0Ji4JNgdnXPRepK1tz16hVGno6xRfmFTwhHq6kjKenqZ6TLF+pGk93hBk8cjrXMT2bd+5jXrBkvGJU3/efRmYKt9HHqy8j05YTkkbu/L/eJpXXFDVdobAO+Fo9PLEA51G5c2dHWk0EQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DpiEDjxTvRvRe3HC/RXnhHkZ0ft0lY9IbQpvqvOnaOw=; b=MNyrkdJIip2CV5ZDYdHNloEo8Pk2Tp24CalzwY38LIPUKFidVn6H/PNqflM2mawMT9iulAJDnBnYAvSw2yX0Uf+PVLvnOWllPvusOAodipLLq99jeaCuAIhduodZntZn7RNVi2KsWkPn/Y5PqzzU5+63lPSk+pa6mcNzCA+s9ws5jd+8exb2fd1ppU30VW6vgCLQgPgM7FaCUlQL2agUSR93NO6xhOV1mA3fP8HyH3Sk6BmB7cbFdYbewdF8EiRjYkBTCrdU+O2uxO/xS9/tft4zOwsAbtOWbVAJYrlqZ3hd5zwhKYbfhukQyV+fGIBJQnbXurcVPZCmhLCLsVkc5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DpiEDjxTvRvRe3HC/RXnhHkZ0ft0lY9IbQpvqvOnaOw=; b=S1a5I8yQVwPKYnNyWAlQ//RDbf5lc7N0AdJyy7W76kSKdqJTfJMX+1xJlTIH1zkSsz6joCH4C9XpsHdWghhiDhMEFrS99gDXjslj4Gumc3LDoSBsmz7j17EleN3I2wOuq7c4ELwlysNknWPQh6A4DU0NnjL6R1d+pks1fya5RAQ= Received: from PH0PR18MB4491.namprd18.prod.outlook.com (2603:10b6:510:e6::13) by BN6PR18MB1300.namprd18.prod.outlook.com (2603:10b6:404:ec::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Tue, 24 May 2022 10:59:16 +0000 Received: from PH0PR18MB4491.namprd18.prod.outlook.com ([fe80::b065:32c0:f517:f85a]) by PH0PR18MB4491.namprd18.prod.outlook.com ([fe80::b065:32c0:f517:f85a%4]) with mapi id 15.20.5293.013; Tue, 24 May 2022 10:59:16 +0000 From: Akhil Goyal To: Arek Kusztal , "dev@dpdk.org" CC: Anoob Joseph , "roy.fan.zhang@intel.com" Subject: RE: [EXT] [PATCH 04/40] cryptodev: reduce number of comments in asym xform Thread-Topic: [EXT] [PATCH 04/40] cryptodev: reduce number of comments in asym xform Thread-Index: AQHYbBedXEj7gm1AOEag2xuKTQZQZq0t3BZQ Date: Tue, 24 May 2022 10:59:16 +0000 Message-ID: References: <20220520055445.40063-1-arkadiuszx.kusztal@intel.com> <20220520055445.40063-5-arkadiuszx.kusztal@intel.com> In-Reply-To: <20220520055445.40063-5-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b9bb8720-d34b-48c2-6f5c-08da3d7471d9 x-ms-traffictypediagnostic: BN6PR18MB1300:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hbucovD0FJZxZPsXULaX7A4j5Qkh6xhaPrYgOHBRXAC1mfwT/E4D1wnioVK4UeHBVkAe34GyCdoqn4aHTiRsaq4pO0o6i1TJnb9/78KKw9TgM9LETnz7OGUbExtZ4pUeNQj+XcxF0gIDOPtlHGbG5uNzIUiiJ2jkgnqQcnMp/1FCbhQH+hlF/Y7BUTD3xhtjNpAfz7MUXaeqRnmhmCWREAeDXVWXe1QEsFObUdOVpTpHCql9oZT3m1o01hXFINrq7aziSbZR+fpfz4W8VfAs2qm1isLRVixBLIg9eyImoF/SmL/0AYG3sip4PNV4j1AsDM1bXfHEQTUOx1WkcWWa/Y3az7/pR5wvlf/yPyhy4F0KwequkUxJ6sUpE/GcugyFg+OmhCCv44IY0PBOfel4r8MKUX+BYmL9Gtxd5jybJBKlV47sICGezm4RdVfX1in8TU9UfLHuaU3DVR6FOPDspt70POeN5cMCPKbcvMhKnjcCGJPhMumjk8TLwiNgou0RiZo9U7grPbo/hvYXYRqTDhF9lPq2SU6lPV4rzTF66mStermVjQdM5dZ6QOUL8CEVc5Dg7c0PtO+upfMe6F4jh5fokYAW770/3A9Np14H0aqLiaGmidGkA/MdoCAY5CHvOWuOZtpkk1o5J/zmskvtccJTSXhxWYwaEFyM9+i6xgToG7Sn4dcLZmJG4oWFOLWnMXbtWsgm2AtH6jCKE7jPvg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4491.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(54906003)(76116006)(110136005)(316002)(83380400001)(2906002)(5660300002)(4326008)(8676002)(66946007)(52536014)(33656002)(8936002)(66476007)(66556008)(66446008)(64756008)(6506007)(122000001)(55236004)(7696005)(9686003)(38100700002)(186003)(86362001)(55016003)(26005)(38070700005)(508600001)(71200400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?smptiTTcWKLrNhb3XEzFvCzPvkkExbS9L+NX1nsBh04fUirwmn9eTVAy8Zqb?= =?us-ascii?Q?8pqdRGZdsbqmfvbNPV7YZnd/kSIgITXX8+waQEb/sLfui/Z7FNsH9z8X3hxf?= =?us-ascii?Q?QwDjPpJEGDhMOpNBqnV9pQqsfUNWWzNcFPmce6ye/z3v7tdDVRX6jf9eOG/h?= =?us-ascii?Q?WbmfFcvbhuDcPRpxyLf+GWWLFDETKWgKnmCyw/yn6uPEDY8Um+2niTcPtSqT?= =?us-ascii?Q?OTNLtin5qb7dbyJjkxPc9BCBKJutxwWmpoPL9fYXkTrM5fAt+k2dPjdqKCq9?= =?us-ascii?Q?CY7Jd0jFJ/11TTaxoirxtxyNlimr8HFDLkm447A4eDS6ZuGw4QYeIX4cdPC1?= =?us-ascii?Q?pELZ1aVLHxLEhAz+JyVAOfW16oxepUw4giKXhaft8sbK7vW8vG38JnPvS4Xn?= =?us-ascii?Q?n8kihfB69XCgSJrVJguqcrLjYsj4Zrs7YbvcOHtXEmoW/XY0glxW/w0HO5ZD?= =?us-ascii?Q?Mn6jaOXdlfJmDlxA9Xa5j/JqwxOKNR4uQu95iKzhFHil1JCclGwfkmPiXheR?= =?us-ascii?Q?ZTqb6+SdAyomM4TU2rkrvxn7cTaewMzMzWxwQI/Q8tiv6bSpgJ36EAbHsIgM?= =?us-ascii?Q?ZLDbVwQ/Sk2nW4uvcEQJnpv5G78JgjfUhK8f+TZwo63PWvJDxn+zSL4HToAK?= =?us-ascii?Q?3MhEeAgXZBN6Tul7/5NfRjaKFGSy15CpzGZV1VQ23K0VnsQWYlVboWtBgCmU?= =?us-ascii?Q?Q0/xUC1uCdY68kbIGEKSEpHsua+99VulZCrFf2mNyDV536gAsMw6xrDMKVI0?= =?us-ascii?Q?G/W5xDd7B4DnjkrXV8IC/J65KVef0DO/E9F1igOLt70UJRJAqYB0Ef0b+b2W?= =?us-ascii?Q?aLWqS7S6mfIoCoVzBiWUJPAzHuJYkapxFU3+LWfJLMv1MgsBN6I0mIl0oYPR?= =?us-ascii?Q?h4zgLG26lmXYznHh10fQXaGesdv4zrPlw9JWwXFhp2dU6c9tHOPWRx3eFwak?= =?us-ascii?Q?JKJj7qjaFQJc6MYO69GD9yS4C6onnZM6XlQVg3NQiK3JV56jE9MXyVJBtzo8?= =?us-ascii?Q?9kyVOzN36Q25y906idX+t811Jo/9Ol7LGP062nWN7LG8CABxRQ+6f25UeBYE?= =?us-ascii?Q?cRF+t0uXJ102Y5Xm/Es2+4BKEc9bs+xe2jD3T26WzCvtDhy6wzb0yqqDN4CO?= =?us-ascii?Q?7LLZ3iL9zvOezZXhxNZUy/538XYJ3gT2VFHtFgVdcVbLKnLN3D6i+DtJBeiX?= =?us-ascii?Q?a9bNr6uz3FqrgddEZRCLFqsFchmmkguWcftTNXPoENRyUDvi9UywHB0uQKg0?= =?us-ascii?Q?AFWiXD3qRzEkPeVRANN71zvqiu5XfNuv5oazv++G2ZTj2cnuO6n5NNgPjecD?= =?us-ascii?Q?dwwZ1pMHZ34Ghkg5ct2mM7Zf1Fc0fm2n9NSlsKkdOQj8hlf1jemuu243PqiO?= =?us-ascii?Q?e8FD7ItxlBA4TwPdyMmyGhG7irww4PLTyoraRnne0sSfC42vNW6VIxeUt+6/?= =?us-ascii?Q?RAM1RgzOy67kEtvvDvodnX31lAd4G5Rnj6wbJJhzNPXlDNaQZAPKRpYLTSBy?= =?us-ascii?Q?rZEZNyUJCvIZeFeQ9tCwjiYNE03S1GNfxUXqF1okqax4EERaEHlS08fzJzhn?= =?us-ascii?Q?lJaYVEjHHnlY2ExB6RvKeDQTVfaavnkBEqntsRLAtg0OA/WmXjSv9zi4rZgk?= =?us-ascii?Q?ZAm7NSVJUlskODU+egZMMuWahAG7Sp/Ll1EHBtotzwGcBV1xbaHOTtHz0LvV?= =?us-ascii?Q?o+1LGcFPg4k4L4Mx1YUX5R+v9eL2c0ZNTidukCzJGl7OHhnSfky26qfDI6Gm?= =?us-ascii?Q?GmgSimAyFA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4491.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b9bb8720-d34b-48c2-6f5c-08da3d7471d9 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2022 10:59:16.1453 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5Uli6OfwKhdL1sXyqjWbF/Yskmb0XE6ss0q1gyTvEwVLnqUt+aKdNK6Zdd1QiFX7zt6u+PKOsQlfCfBlH0yRMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR18MB1300 X-Proofpoint-ORIG-GUID: xrRoJfhkk7Ps_q5nLriIaQVJxXAoxvfn X-Proofpoint-GUID: xrRoJfhkk7Ps_q5nLriIaQVJxXAoxvfn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-24_06,2022-05-23_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > - Reduced number of comments in asymmetric xform. > Information describing basic functionality of well known > algorithms are unnecessary. > - Added information about data memory lifetime. > It was specified how user should work with private data, > and it is user's responsability to clear it. > - Removed NONE asymetric xform. >=20 > Signed-off-by: Arek Kusztal > --- > lib/cryptodev/rte_crypto_asym.h | 45 +++++++++++++----------------------= ------ > lib/cryptodev/rte_cryptodev.c | 1 - > 2 files changed, 14 insertions(+), 32 deletions(-) >=20 > diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_a= sym.h > index a474b6acd1..0251e8caae 100644 > --- a/lib/cryptodev/rte_crypto_asym.h > +++ b/lib/cryptodev/rte_crypto_asym.h > @@ -55,46 +55,29 @@ enum rte_crypto_curve_id { > }; >=20 > /** > - * Asymmetric crypto transformation types. > - * Each xform type maps to one asymmetric algorithm > - * performing specific operation > - * > + * Asymmetric crypto algorithm static data. > + * Data that may be used more than once (e.g. RSA private key). > + * It is the USER responsibility to keep track of private data memory > + * lifetime and security of the this data in xform. The same way > + * it is the USER responsibility to call cryptodev session_clear() > + * function if a session was created. If session-less not used > + * xform data should be cleared after successful session creation. > */ > enum rte_crypto_asym_xform_type { > - RTE_CRYPTO_ASYM_XFORM_UNSPECIFIED =3D 0, > + RTE_CRYPTO_ASYM_XFORM_UNSPECIFIED, > /**< Invalid xform. */ > - RTE_CRYPTO_ASYM_XFORM_NONE, > - /**< Xform type None. > - * May be supported by PMD to support > - * passthrough op for debugging purpose. > - * if xform_type none , op_type is disregarded. > - */ I believe removing this is not a good idea. As stated, it will help in Debugging. > RTE_CRYPTO_ASYM_XFORM_RSA, > - /**< RSA. Performs Encrypt, Decrypt, Sign and Verify. > - * Refer to rte_crypto_asym_op_type > - */ > + /**< RSA */ > RTE_CRYPTO_ASYM_XFORM_DH, > - /**< Diffie-Hellman. > - * Performs Key Generate and Shared Secret Compute. > - * Refer to rte_crypto_asym_op_type > - */ > + /**< Diffie-Hellman */ > RTE_CRYPTO_ASYM_XFORM_DSA, > - /**< Digital Signature Algorithm > - * Performs Signature Generation and Verification. > - * Refer to rte_crypto_asym_op_type > - */ > + /**< Digital Signature Algorithm */ > RTE_CRYPTO_ASYM_XFORM_MODINV, > - /**< Modular Multiplicative Inverse > - * Perform Modular Multiplicative Inverse b^(-1) mod n > - */ > + /**< Modular Multiplicative Inverse */ > RTE_CRYPTO_ASYM_XFORM_MODEX, > - /**< Modular Exponentiation > - * Perform Modular Exponentiation b^e mod n > - */ > + /**< Modular Exponentiation */ > RTE_CRYPTO_ASYM_XFORM_ECDSA, > - /**< Elliptic Curve Digital Signature Algorithm > - * Perform Signature Generation and Verification. > - */ > + /**< Elliptic Curve Digital Signature Algorithm */ > RTE_CRYPTO_ASYM_XFORM_ECPM > /**< Elliptic Curve Point Multiplication */ > }; > diff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.= c > index e16e6802aa..691625bd04 100644 > --- a/lib/cryptodev/rte_cryptodev.c > +++ b/lib/cryptodev/rte_cryptodev.c > @@ -160,7 +160,6 @@ rte_crypto_aead_operation_strings[] =3D { > * Asymmetric crypto transform operation strings identifiers. > */ > const char *rte_crypto_asym_xform_strings[] =3D { > - [RTE_CRYPTO_ASYM_XFORM_NONE] =3D "none", > [RTE_CRYPTO_ASYM_XFORM_RSA] =3D "rsa", > [RTE_CRYPTO_ASYM_XFORM_MODEX] =3D "modexp", > [RTE_CRYPTO_ASYM_XFORM_MODINV] =3D "modinv", > -- > 2.13.6