RE: [PATCH v2 07/24] crypto/cnxk: enable Rx inject in security lookaside

[Akhil Goyal <gakhil@marvell.com>]

> Subject: [PATCH v2 07/24] crypto/cnxk: enable Rx inject in security lookaside
> 
> From: Vidya Sagar Velumuri <vvelumuri@marvell.com>
> 
> Add Rx inject fastpath API.
> Add devargs to specify an LF to be used for Rx inject.
It is better to specify the name of the devarg in description.

> When the RX inject feature flag is enabled:
> 1. Reserve a CPT LF to use for RX Inject mode.
> 2. Enable RXC and disable full packet mode for that LF.
> 
> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> Signed-off-by: Vidya Sagar Velumuri <vvelumuri@marvell.com>
> ---
>  doc/guides/cryptodevs/cnxk.rst               |  12 ++

Should we also update the cn10k.ini file for supporting the new feature flag?

>  doc/guides/rel_notes/release_24_03.rst       |   3 +
>  drivers/common/cnxk/hw/cpt.h                 |   9 ++
>  drivers/common/cnxk/roc_cpt.c                |  11 +-
>  drivers/common/cnxk/roc_cpt.h                |   3 +-
>  drivers/common/cnxk/roc_cpt_priv.h           |   2 +-
>  drivers/common/cnxk/roc_ie_ot.c              |  14 +--
>  drivers/common/cnxk/roc_mbox.h               |   2 +
>  drivers/common/cnxk/roc_nix_inl.c            |   2 +-
>  drivers/common/cnxk/roc_nix_inl_dev.c        |   2 +-
>  drivers/crypto/cnxk/cn10k_cryptodev_ops.c    | 124 +++++++++++++++++++
>  drivers/crypto/cnxk/cn10k_cryptodev_ops.h    |   8 ++
>  drivers/crypto/cnxk/cn10k_ipsec.c            |   4 +
>  drivers/crypto/cnxk/cn10k_ipsec.h            |   2 +
>  drivers/crypto/cnxk/cnxk_cryptodev.c         |   3 +
>  drivers/crypto/cnxk/cnxk_cryptodev.h         |   3 +
>  drivers/crypto/cnxk/cnxk_cryptodev_devargs.c |  31 +++++
>  drivers/crypto/cnxk/cnxk_cryptodev_ops.c     |  27 +++-
>  drivers/crypto/cnxk/version.map              |   3 +
>  19 files changed, 250 insertions(+), 15 deletions(-)
> 
> diff --git a/doc/guides/cryptodevs/cnxk.rst b/doc/guides/cryptodevs/cnxk.rst
> index fbe67475be..8dc745dccd 100644
> --- a/doc/guides/cryptodevs/cnxk.rst
> +++ b/doc/guides/cryptodevs/cnxk.rst
> @@ -187,6 +187,18 @@ Runtime Config Options
>     With the above configuration, the number of maximum queue pairs supported
>     by the device is limited to 4.
> 
> +- ``LF ID for RX injection in case of fallback mechanism`` (default ``60``)
> +
> +   LF ID for RX Injection in fallback mechanism of security.
> +   Can be configured during runtime by using ``rx_inj_lf`` ``devargs`` parameter.

Can we rename it to rx_inject_lf to improve readability for user?
Or can this be rx_inject_qp as for dpdk user LF term is not exposed?
And we map it to a qp internally. Right?

> +
> +   For example::
> +
> +      -a 0002:20:00.1,rx_inj_lf=20
> +
> +   With the above configuration, LF 20 will be used by the device for RX
> Injection
> +   in security in fallback mechanism secnario.
Spell check scenario

> +
>  Debugging Options
>  -----------------
> 
> diff --git a/doc/guides/rel_notes/release_24_03.rst
> b/doc/guides/rel_notes/release_24_03.rst
> index e9c9717706..fa30b46ead 100644
> --- a/doc/guides/rel_notes/release_24_03.rst
> +++ b/doc/guides/rel_notes/release_24_03.rst
> @@ -55,6 +55,9 @@ New Features
>       Also, make sure to start the actual text at the margin.
>       =======================================================
> 
> +* **Updated Marvell cnxk crypto driver.**
> +
> +  * Added support for Rx inject in crypto_cn10k.
>
Add an extra line here.