From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2E45A0093; Mon, 2 May 2022 09:42:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 925DB40F35; Mon, 2 May 2022 09:42:38 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id AED6B40E28 for ; Mon, 2 May 2022 09:42:36 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 241MrMIl029478 for ; Mon, 2 May 2022 00:42:35 -0700 Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2104.outbound.protection.outlook.com [104.47.58.104]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3fs4mkmqhv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 02 May 2022 00:42:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WBcVN1BcLWRMe/8YBm5ryAKYzv/Zhmtbsxkf5lNWKkeajGIuC7exDlxIDTSYqp1Jn9Cva4ds/C2fpEsYgkclZQKLEp0e34dKyMPy9T9dveaUvEDmjT9qyk4ZbxmVcnFzJWBLmGHosELmAOOq0Q/1jChLoMA1LYocdsgPvzjj7MbFZYItekqFN3ZXDXT+HL+lebKe1G1s7xKSNFuGdjn4ked7ZBwhFF88ccJspQ4TPJIlAnSZZee9kfF+yHUIu9XB2eqhGtLl1LOSL4iORaejXuD7L/ZDdF1B/pjelvAjafa1rbH/yXrjqWSReXcCb6x4CKzzyqS/4nQu/qqrs/Wzug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yjImmio9c7KqtYWLKg8i7dQn7v7HpX2plRxOTjysuB4=; b=MNew+YLNk543N+nhb68kQWBVtTDKrnVGPxxa4alshj2SwFbAI4QJmdasGXUdClkvQWnM1vAxTxcjt37bQW83UxrTf9Q35hZvMtvq/2TEmdI9SuZ0HFOK4kHy3xQ22dO4/K0TX35yz3LwRrj8Mg5aGPc4zKQToVGMwsBiDLfdGstP8wvrsM8fdMeIdkmqPCJlb5mAek6LtCJva1rjoTUIj7PCQ6cUEn4DhgfdwoRcxLNneiBPJHNy8aLD3NayJiv+YC1fDlVilei2WZSfMS/g83Hf/sSBUEaEgA1Bm5b0yvZvNbomGWnOTgsG+pQGKsEUvJgtxQUBm8QCicYvBqp8sw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yjImmio9c7KqtYWLKg8i7dQn7v7HpX2plRxOTjysuB4=; b=NRjw3xPu3oSlO/zpkIT0vgOn1vrmy4qRCEYu1LxTXIKNzlYiSHAYmFuNyTTh7Xi+HR54XrZT8doN9fytyzdCQ3VCBjYTBWnez5yQ9jraVCGvXcZJ1+p9rlfBcgNufSB/kNn9Lj6jA0fBhCOj4Re4f8dEFI0M8NRdCK01gxulC1c= Received: from PH0PR18MB4672.namprd18.prod.outlook.com (2603:10b6:510:c9::16) by PH0PR18MB4670.namprd18.prod.outlook.com (2603:10b6:510:c7::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Mon, 2 May 2022 07:42:33 +0000 Received: from PH0PR18MB4672.namprd18.prod.outlook.com ([fe80::141b:43fb:348e:f3a]) by PH0PR18MB4672.namprd18.prod.outlook.com ([fe80::141b:43fb:348e:f3a%5]) with mapi id 15.20.5206.024; Mon, 2 May 2022 07:42:33 +0000 From: Anoob Joseph To: Vamsi Krishna Attunuru , "dev@dpdk.org" CC: Akhil Goyal , Vamsi Krishna Attunuru Subject: RE: [PATCH 1/1] crypto/cnxk: enable 3des-cbc secure capability Thread-Topic: [PATCH 1/1] crypto/cnxk: enable 3des-cbc secure capability Thread-Index: AQHYXFRXHuirhB++oEydp3weS5npaK0LNv/Q Date: Mon, 2 May 2022 07:42:33 +0000 Message-ID: References: <20220430053637.2065578-1-vattunuru@marvell.com> In-Reply-To: <20220430053637.2065578-1-vattunuru@marvell.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4feb9971-a93f-44bb-2a4d-08da2c0f51df x-ms-traffictypediagnostic: PH0PR18MB4670:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: l27YXcWRNAUbaXALs67+daesTrA49gaQErONVYDnQOoDqEq0r4IFT2TkIcNtnq3omABHKKzoi7JokScy3sLt6zQj6duPjlykfTbxSRYi/OPWjUAX2baroVcrpcgCBjHZoFjf3i1FMlY0ybDsSwMZrKa+TmUzPPLkqUIzxjor4AGMngMoElaWyx2ibqpZlZoKrSfkgFFtdRm1itmXSHN0o0YcN7tMmyPGgb15LDQC4S2zEP4VyKNOagLrHshvas5jx0+TFMLEYZyB6/xVmzSBuY9LJ8/EkbiW/1stpQDbMG8M7QN8pYZiV0/ux39kkVchgcXsyf6PZ9lAX+G8r6MAh3OSxwXvl8JizVdjYUigStM35yw+QcmZ5mNsZVUmND3z1+hWZVv/PvmRqUkjj6HVHCAfruXKPphPOv0H18WjnPe9mlRl2oo/9KGtuRl3tArJn52ojCPo1jYNtJipwBZ6L8R6wYovoqZoDnNl/zNfT+ZjFeLvXzerCJhm5xVH7aQEYdEMbAfw+A0RsXr7yUOIcv68iv5X/2/x9ugDTIVXFQg8/gEGnzWuu95kbP7hHi9gOCtKgc0kigK90LLurCTo5wqups7rmngChDlyF4BM4s4aRDgIwym88eNkDrEfHxNbxxPQJwuskd4a7lBRkErvqYbLb90mz6o8hG5HUSg7cYddYu1lixYxCOuXgUIjq/GKiDqyNGD/3/IQpL8ajpZuQw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4672.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(52536014)(66446008)(64756008)(2906002)(107886003)(8676002)(4326008)(76116006)(66556008)(508600001)(66476007)(8936002)(33656002)(66946007)(55016003)(5660300002)(38070700005)(7696005)(71200400001)(122000001)(186003)(26005)(86362001)(110136005)(83380400001)(316002)(9686003)(54906003)(6506007)(53546011)(38100700002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Vo5W9HSfITGatnYcs0wsJuYixp0PL2rz66AXjtr/WXGyMwuRKjntrLROayjj?= =?us-ascii?Q?NhjNbLZKzlZePRfe5nyUgh9oSetKkuCV49Kbyl2dRp7410bpIDG35e7Smr5A?= =?us-ascii?Q?0HG73J54s+8qMpgmyZLu1p5IRyt3we2IZbd26YBBqxl2GVlt3RhsyEIQILCw?= =?us-ascii?Q?FaM1A2vgXFmf/emKSULeewDM/DfVAfv0ymUdHz9dh5wP/Gez7shzXhFKCGq1?= =?us-ascii?Q?Bt2idu18bNGSk6pk32CsDJYplg66ONuhHfo4Nk+WMEGeoxWPjE2uCs3+AMF3?= =?us-ascii?Q?S34SmFwotTJc2snCohTo8PtN9KlzFA3gF7FBUW1U42TB8bD70HgX7BK4pJ4j?= =?us-ascii?Q?cWYX4vF7yVL6kxyO+Dd6hN7ViOE9MYTidpp+V0Vx+LFezDo+IpgqwAiV9yA2?= =?us-ascii?Q?+dfDXILGX/z1MGJ4lzR3ssW2Z/bjHwL6uOy+nf+hANW9egRmz17xO4gD+kfB?= =?us-ascii?Q?lRNGiyxXAj2eUBD+ltqdywdGyA+rIei/k0eQSmcSoQCpBmfy32+6i+uxckVv?= =?us-ascii?Q?dZFByicHktZgTOxx382Qe5rHMfJQaH7HE16F5YnFBuI/+Kh4tacByFWrNVoy?= =?us-ascii?Q?G1DbnCy+9oW6ovThpHs28z5IPDoEDwDQsWOUeTjdCPL5y7jdeXBdU+HP1ga5?= =?us-ascii?Q?lJpX8UY0qkyuZ811Y6TzvbPjZsqKsvV5f0741MyKqaTuDThET88in4xEdtK3?= =?us-ascii?Q?+wSU9H4LVXU2CYo+3pjUm75t7jvKyzC/++mZ+yr6xz/hjIF81psIYBrr8KUK?= =?us-ascii?Q?Lt8dqpAOLg1Wy4XhDqJqJLwZd3QtVwoMamemTMR8OrbabLMEShbK6YycIRIg?= =?us-ascii?Q?tcy+EBlaeLUPX8mkiVX2ScQ/TqNmcnMVqSPxkoassZDr0hzh7QViiTbcBlfs?= =?us-ascii?Q?6GuStd2Xsn6g1+4ERFvNbna+GBtRJSQxDtwPutmlOmOZM1Rtq6XvDLssgUDu?= =?us-ascii?Q?EDYWYZxCROWgwljdTZi1wSi3/n07lnCGtfzffrwKU0mNqVy4g28YcZOLhLpp?= =?us-ascii?Q?+DbBVSuvDSRH5HLuNIWxPGOOEud05zYVupMQg7Foabls9OySmarxS0o00ZHu?= =?us-ascii?Q?ruCcGWWjO4Iqva5dSkliCc+Eb1RwzNJYPbz7wzOsbedZracSfEUCVuW7oe49?= =?us-ascii?Q?WkuezxWZm1fT2e82/Pbv15mEd9xe5A8pOmiWgt/BmuJ1HqTKehKxoWQGdy4N?= =?us-ascii?Q?P+R2oWRU56s3XsH2iHUXL75AMI0eDbVXEy9eSddF6ojpG7Afw2UkTESRS7I2?= =?us-ascii?Q?ciZhA0H6c42vdfuxpdqy2cNTON4piMQ/oxzDeF/Zz/cj0iEQTkJcewiUhVRQ?= =?us-ascii?Q?3fFxn8WhweRycU9767R5EJDmxivYtszI/PcAF6wDsHSYA5BwvqQyb16hbigC?= =?us-ascii?Q?+ioAZctybk/usLVcmYzm9bgnvT3ZKN5qX0R2tkL0aGUQGHlzEyE7djNli+uM?= =?us-ascii?Q?r6IAs5rwCsaARQ6qvZzjNRhlhcbsjkpg4FQGsxZDkbEYrXGa9CNsp+ItUsrf?= =?us-ascii?Q?iQ3+XeDCdPrcyclESLgat640z44QUaRdoYjWXq+mEsRfj9zF6t6E3rTLmZ3m?= =?us-ascii?Q?7jzxho7HP2LLC3bzAj95fZbJFNmp40g/gJKBhEn8mSJax166RScIwRjZOnKN?= =?us-ascii?Q?Dwl4Up5WCLaXWp99DL4K4uAnC7Kz63tyH9Tfz/rSWjeMd5xO/n106hdynN5Y?= =?us-ascii?Q?iu8lvI9NhTVkQ4kbkLRbZ5pdUbmQq0wUh+DimKnRY+NK3KzD+2cFgQAP1dOK?= =?us-ascii?Q?8KwK1ETrlQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4672.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4feb9971-a93f-44bb-2a4d-08da2c0f51df X-MS-Exchange-CrossTenant-originalarrivaltime: 02 May 2022 07:42:33.5745 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ptEPax2u1c0H+H0oAktzMs8kePHrWcjIgau1W7yqZ+EcIZQDwfHdOInRHYZ3UTxjbpKktRYNSYId418FZE/jug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB4670 X-Proofpoint-GUID: A7wgLn4VP7Cn2S1bXTsQE6NWEVo6bZ_H X-Proofpoint-ORIG-GUID: A7wgLn4VP7Cn2S1bXTsQE6NWEVo6bZ_H X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-02_02,2022-04-28_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Vamsi, Please see inline. Thanks, Anoob > -----Original Message----- > From: Vamsi Attunuru > Sent: Saturday, April 30, 2022 11:07 AM > To: dev@dpdk.org > Cc: Anoob Joseph ; Akhil Goyal > ; Vamsi Krishna Attunuru > Subject: [PATCH 1/1] crypto/cnxk: enable 3des-cbc secure capability >=20 > Patch enables 3DES-CBC secure capability of crypto device. >=20 > Signed-off-by: Vamsi Attunuru > --- > drivers/crypto/cnxk/cnxk_cryptodev.h | 2 +- > .../crypto/cnxk/cnxk_cryptodev_capabilities.c | 24 +++++++++++++++++++ > drivers/crypto/cnxk/cnxk_ipsec.h | 3 ++- > 3 files changed, 27 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/crypto/cnxk/cnxk_cryptodev.h > b/drivers/crypto/cnxk/cnxk_cryptodev.h > index b75d681185..8870021725 100644 > --- a/drivers/crypto/cnxk/cnxk_cryptodev.h > +++ b/drivers/crypto/cnxk/cnxk_cryptodev.h > @@ -11,7 +11,7 @@ > #include "roc_cpt.h" >=20 > #define CNXK_CPT_MAX_CAPS 35 > -#define CNXK_SEC_CRYPTO_MAX_CAPS 12 > +#define CNXK_SEC_CRYPTO_MAX_CAPS 13 > #define CNXK_SEC_MAX_CAPS 9 > #define CNXK_AE_EC_ID_MAX 8 > /** > diff --git a/drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c > b/drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c > index 98b002d93a..ba9eaf2325 100644 > --- a/drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c > +++ b/drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c > @@ -862,6 +862,29 @@ static const struct rte_cryptodev_capabilities > sec_caps_aes[] =3D { > }, > }; >=20 > +static const struct rte_cryptodev_capabilities sec_caps_des[] =3D { > + { /* 3DES CBC */ > + .op =3D RTE_CRYPTO_OP_TYPE_SYMMETRIC, > + {.sym =3D { > + .xform_type =3D RTE_CRYPTO_SYM_XFORM_CIPHER, > + {.cipher =3D { > + .algo =3D RTE_CRYPTO_CIPHER_3DES_CBC, > + .block_size =3D 8, > + .key_size =3D { > + .min =3D 24, > + .max =3D 24, > + .increment =3D 0 > + }, > + .iv_size =3D { > + .min =3D 8, > + .max =3D 16, > + .increment =3D 8 > + } > + }, } > + }, } > + } > +}; > + > static const struct rte_cryptodev_capabilities sec_caps_sha1_sha2[] =3D = { > { /* SHA1 HMAC */ > .op =3D RTE_CRYPTO_OP_TYPE_SYMMETRIC, > @@ -1195,6 +1218,7 @@ sec_crypto_caps_populate(struct > rte_cryptodev_capabilities cnxk_caps[], > int cur_pos =3D 0; >=20 > SEC_CAPS_ADD(cnxk_caps, &cur_pos, hw_caps, aes); > + SEC_CAPS_ADD(cnxk_caps, &cur_pos, hw_caps, des); > SEC_CAPS_ADD(cnxk_caps, &cur_pos, hw_caps, sha1_sha2); >=20 > if (roc_model_is_cn10k()) > diff --git a/drivers/crypto/cnxk/cnxk_ipsec.h > b/drivers/crypto/cnxk/cnxk_ipsec.h > index 171ea2774e..7c7833ac1b 100644 > --- a/drivers/crypto/cnxk/cnxk_ipsec.h > +++ b/drivers/crypto/cnxk/cnxk_ipsec.h > @@ -24,7 +24,8 @@ ipsec_xform_cipher_verify(struct > rte_crypto_sym_xform *crypto_xform) > return 0; >=20 > if (crypto_xform->cipher.algo =3D=3D RTE_CRYPTO_CIPHER_AES_CBC || > - crypto_xform->cipher.algo =3D=3D RTE_CRYPTO_CIPHER_AES_CTR) { > + crypto_xform->cipher.algo =3D=3D RTE_CRYPTO_CIPHER_AES_CTR || > + crypto_xform->cipher.algo =3D=3D RTE_CRYPTO_CIPHER_3DES_CBC) { [Anoob] We can support only key.length as 24 with 3DES. Rest of the checks = are for AES. Please introduce a separate check for 3DES. Rest of the patch looks good. =20 > switch (crypto_xform->cipher.key.length) { > case 16: > case 24: > -- > 2.25.1