From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A082542A83; Fri, 19 May 2023 12:31:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 71A0C4161A; Fri, 19 May 2023 12:31:35 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id D901041148 for ; Fri, 19 May 2023 12:31:33 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34J6Bfj1019732; Fri, 19 May 2023 03:31:32 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2170.outbound.protection.outlook.com [104.47.57.170]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3qp3mkrsex-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 19 May 2023 03:31:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YNB4W9y0QkN3zPwMm4PfrwK+LOmW97XPA7dZGExc+p+c+7MXTbE9TXumuy8liAgZ9fc2f8F8IvyaOoJuCjMYBfrR4pXBpPM7o9EoQoPo/sI44+4NvsPRaf/y5yiFlbo3bR+vMcl6PKlWUzoWK1Sd+KJh+h7HqIlZ3dYCNCQ2OPlsMWpGEm/+KWKh/im93t+HMRZ/NC712dfMKz+xG6hOK0NVP6HedNixE+E3it8kAVsfwAtDopAPOe4p0tYB63efKEuAqULm2ug4os8cHnp4rC8qifcsMcCjoI0oPYODO9HOlhDpbodoPVWR26MGDAFOgIV4cPxM8+hMDtpKsMDKHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pvK6DcCWP2b4Od7cfws6Y/8UZWMVzRBMQDex1dDgxds=; b=eEWGc4IJHUcBqBT7J30OShLA8C4tB7nDCK6MOW6sIWPs1UJg8IaZUil+qyK6O6/CdgzABrUfnOKuF2RsTAjwpTX4Q2pQTiEvAtcsNjrvIs7IYf48+NGGInl+4qlSLpAFXfJkUr4+xcQOaO3q7usBZbKbEDqu7eWuJt9ZIy4yRxpZMrG2g8DD0WhlczaKNFaKkCZ2KCsDWcAO6+knUDjF2hY7WQ5ber+8l+jW+3NerR3TUWrtK1aaj2KoIOmtj9ODm9+lwviBG4y8QG1y1gs2KKXloh15ANmrCWie3XYYFEGFmL6lDoqB6ubstiIylFojeiYFcnHkjOZQ1yczhymgrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pvK6DcCWP2b4Od7cfws6Y/8UZWMVzRBMQDex1dDgxds=; b=ELyURv6MaLTj8EF4+rvpTwNE7FGYpkwZT1UiGgxarryvFHemkEFUSC6FfFgeQw+s5miPyytf5Wp8xCZPBQCoJ5qq8Jv29v23WeB/y4a0EBBQw79qlvaAkqxpG75jYGDJCP6ohrcp96flrowLfC9QnrqBiEk1rV6csVzy1adLXpU= Received: from PH0PR18MB4672.namprd18.prod.outlook.com (2603:10b6:510:c9::16) by DM5PR1801MB1963.namprd18.prod.outlook.com (2603:10b6:4:62::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.18; Fri, 19 May 2023 10:31:29 +0000 Received: from PH0PR18MB4672.namprd18.prod.outlook.com ([fe80::9225:bda3:4faa:a84b]) by PH0PR18MB4672.namprd18.prod.outlook.com ([fe80::9225:bda3:4faa:a84b%4]) with mapi id 15.20.6411.021; Fri, 19 May 2023 10:31:28 +0000 From: Anoob Joseph To: Akhil Goyal , Thomas Monjalon , Jerin Jacob Kollanukkaran , Konstantin Ananyev , Bernard Iremonger CC: Hemant Agrawal , =?iso-8859-1?Q?Mattias_R=F6nnblom?= , Kiran Kumar Kokkilagadda , Volodymyr Fialko , "dev@dpdk.org" , Olivier Matz Subject: RE: [PATCH v2 09/22] app/test: add lib pdcp tests Thread-Topic: [PATCH v2 09/22] app/test: add lib pdcp tests Thread-Index: AQHZiV9CJJXkut22L0qulNM/fp/Yz69f4QbAgAAOfoCAAAC1gA== Date: Fri, 19 May 2023 10:31:28 +0000 Message-ID: References: <20221222092522.1628-1-anoobj@marvell.com> <20230414174512.642-1-anoobj@marvell.com> <20230414174512.642-10-anoobj@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-rorf: true x-dg-ref: =?iso-8859-1?Q?PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcYW5vb2JqXG?= =?iso-8859-1?Q?FwcGRhdGFccm9hbWluZ1wwOWQ4NDliNi0zMmQzLTRhNDAtODVlZS02Yjg0?= =?iso-8859-1?Q?YmEyOWUzNWJcbXNnc1xtc2ctNGQzODE5ZjAtZjYzMC0xMWVkLTljNTItNG?= =?iso-8859-1?Q?MwMzRmNWY5YjRmXGFtZS10ZXN0XDRkMzgxOWYxLWY2MzAtMTFlZC05YzUy?= =?iso-8859-1?Q?LTRjMDM0ZjVmOWI0ZmJvZHkudHh0IiBzej0iNzc3OSIgdD0iMTMzMjg5Nj?= =?iso-8859-1?Q?U4ODQ4MzE5NDMwIiBoPSJSSkxhakxEdkdBMFhFbzl6N1ByTWdvK2o4VGc9?= =?iso-8859-1?Q?IiBpZD0iIiBibD0iMCIgYm89IjEiIGNpPSJjQUFBQUVSSFUxUlNSVUZOQ2?= =?iso-8859-1?Q?dVQUFNZ01BQURHRitNUFBZclpBWDVWV0NLN3U4WS9mbFZZSXJ1N3hqOFVB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBSEFBQUFCWURBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBRUFBUUVCQUFBQTQrVXREQUNBQVFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUo0QUFBQmhBR1FBWkFCeUFHVUFjd0J6QUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQU?= =?iso-8859-1?Q?dNQWRRQnpBSFFBYndCdEFGOEFjQUJsQUhJQWN3QnZBRzRBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBUUFBQUFBQUFBQUNBQUFBQUFDZUFBQUFZd0IxQUhN?= =?iso-8859-1?Q?QWRBQnZBRzBBWHdCd0FHZ0Fid0J1QUdVQWJnQjFBRzBBWWdCbEFISUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFCakFIVUFjd0IwQUc4QW?= =?iso-8859-1?Q?JRQmZBSE1BY3dCdUFGOEFaQUJoQUhNQWFBQmZBSFlBTUFBeUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-refone: =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVBQUFBQUFBQUFBZ0FBQUFBQW5nQU?= =?iso-8859-1?Q?FBR01BZFFCekFIUUFid0J0QUY4QWN3QnpBRzRBWHdCckFHVUFlUUIzQUc4?= =?iso-8859-1?Q?QWNnQmtBSE1BQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFBQUNlQUFBQVl3QjFB?= =?iso-8859-1?Q?SE1BZEFCdkFHMEFYd0J6QUhNQWJnQmZBRzRBYndCa0FHVUFiQUJwQUcwQW?= =?iso-8859-1?Q?FRQjBBR1VBY2dCZkFIWUFNQUF5QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFKNEFBQUJqQUhVQWN3QjBBRz?= =?iso-8859-1?Q?hBYlFCZkFITUFjd0J1QUY4QWN3QndBR0VBWXdCbEFGOEFkZ0F3QURJQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBRUFBQUFBQUFBQUFnQUFBQUFBbmdBQUFHUUFiQUJ3QUY4QWN3QnJBSGtB?= =?iso-8859-1?Q?Y0FCbEFGOEFZd0JvQUdFQWRBQmZBRzBBWlFCekFITUFZUUJuQUdVQVh3Qj?= =?iso-8859-1?Q?JBREFBTWdBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQVFBQUFB?= =?iso-8859-1?Q?QUFBQUFDQUFBQUFBQ2VBQUFBWkFCc0FIQUFYd0J6QUd3QVlRQmpBR3NBWH?= =?iso-8859-1?Q?dCakFHZ0FZUUIwQUY4QWJRQmxBSE1BY3dCaEFHY0FaUUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reftwo: =?iso-8859-1?Q?QUFBQUFBQUFBQUJBQUFBQUFBQUFBSUFBQUFBQUo0QUFBQmtBR3dBY0FCZk?= =?iso-8859-1?Q?FIUUFaUUJoQUcwQWN3QmZBRzhBYmdCbEFHUUFjZ0JwQUhZQVpRQmZBR1lB?= =?iso-8859-1?Q?YVFCc0FHVUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUdVQWJRQmhBR2tBYkFCZkFH?= =?iso-8859-1?Q?RUFaQUJrQUhJQVpRQnpBSE1BQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQURBQUFBQUFBQUFBQUFBQUFBUUFB?= =?iso-8859-1?Q?QUFBQUFBQUNBQUFBQUFDZUFBQUFiUUJoQUhJQWRnQmxBR3dBWHdCd0FISU?= =?iso-8859-1?Q?Fid0JxQUdVQVl3QjBBRjhBYmdCaEFHMEFaUUJ6QUY4QWNnQmxBSE1BZEFC?= =?iso-8859-1?Q?eUFHa0FZd0IwQUdVQVpBQmZBR0VBYkFCdkFHNEFaUUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQU?= =?iso-8859-1?Q?FJQUFBQUFBSjRBQUFCdEFHRUFjZ0IyQUdVQWJBQmZBSEFBY2dCdkFHb0Fa?= =?iso-8859-1?Q?UUJqQUhRQVh3QnVBR0VBYlFCbEFITUFYd0J5QUdVQWN3QjBBSElBYVFCak?= =?iso-8859-1?Q?FIUUFaUUJrQUY4QWFBQmxBSGdBWXdCdkFHUUFaUUJ6QUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVBQUFBQUFBQUFBZ0FBQUFB?= =?iso-8859-1?Q?QW5nQUFBRzBBWVFCeUFIWUFaUUJzQUd3QVh3QmhBSElBYlFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFBQUNlQUFBQW?= =?iso-8859-1?Q?JRQmhBSElBZGdCbEFHd0FiQUJmQUhBQWNnQnZBR29BWlFCakFIUUFYd0Jq?= =?iso-8859-1?Q?QUc4QVpBQmxBSE1BQUFBQUFBQUFB?= x-dg-refthree: =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFCQUFBQUFBQU?= =?iso-8859-1?Q?FBQUlBQUFBQUFKNEFBQUJ0QUdFQWNnQjJBR1VBYkFCc0FGOEFjQUJ5QUc4?= =?iso-8859-1?Q?QWFnQmxBR01BZEFCZkFHTUFid0JrQUdVQWN3QmZBR1FBYVFCakFIUUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQUFnQUFB?= =?iso-8859-1?Q?QUFBbmdBQUFHMEFZUUJ5QUhZQVpRQnNBR3dBWHdCd0FISUFid0JxQUdVQV?= =?iso-8859-1?Q?l3QjBBRjhBYmdCaEFHMEFaUUJ6QUY4QWNnQmxBSE1BZEFCeUFHa0FZd0Iw?= =?iso-8859-1?Q?QUdVQVpBQmZBRzBBWVFCeUFIWUFaUUJzQUd3QUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQVFBQUFBQUFBQUFDQUFBQUFBQ2VBQU?= =?iso-8859-1?Q?FBYlFCaEFISUFkZ0JsQUd3QWJBQmZBSEFBY2dCdkFHb0FaUUJqQUhRQVh3?= =?iso-8859-1?Q?QnVBR0VBYlFCbEFITUFYd0J5QUdVQWN3QjBBSElBYVFCakFIUUFaUUJrQU?= =?iso-8859-1?Q?Y4QWJRQmhBSElBZGdCbEFHd0FiQUJmQUc4QWNnQmZBR0VBY2dCdEFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUJBQUFBQUFBQUFBSUFBQUFBQUo0QUFBQnRBR0VB?= =?iso-8859-1?Q?Y2dCMkFHVUFiQUJzQUY4QWRBQmxBSElBYlFCcEFHNEFkUUJ6QUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUcwQVlRQnlBSFlBWl?= =?iso-8859-1?Q?FCc0FHd0FYd0IzQUc4QWNnQmtBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reffour: QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBUUFBQUFBQUFBQUNBQUFBQUFBPSIvPjwvbWV0YT4= x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR18MB4672:EE_|DM5PR1801MB1963:EE_ x-ms-office365-filtering-correlation-id: 9295c11e-e227-47d0-5f7a-08db58543480 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Gdnat0kg0pz0wIHeYkFPNLE5LD/JHn9Mk+TCIrm+5OVtAN2F0d9v/sdTiH7S+py2FPIufrNvDid9DCu/XXAKvi9ynkWHNyIWBkGAKbL3VCaPoo/FnlLGWxVDCqyomcPply552KHQFJDW6kpKmBXarpLAqiW6ZvBYAFGDmSh0OczL7W2aG5ctHb9Dr+3g4Ry2RKs+D97U+v4HHlVBN5wRMnfUtr8++EH4u6qiTtfarJWh5rLleObl+qTC6/IfhHmhBgtoCtw6z1eCrFHfiSu5zx/vmJkYXMOHxdWOmixujl7cXKB3pXl8E7/3CUDsyMr5ZZACXoYHfex7kuTgW3Wgde0/+UJkq4J0fXiBFN5ucXgTaJgTK8LTvN1s2UTiVr/sQaFz0sfAYebX0BeYZ8MO4hqbxrVRFOsdJrcBKi+HBdd7/IsLNM07wzkc4JMT5DeXrBr1Fd3mq9ndY8+8daKKo+u8LPVbx2PiRtedaWVTtAYSuKuFSnNmIMXkbu1P2xPm3PArD1J4esrYHk8rFOp/oHTiuhpoaELi5KOctZ5C2CHrhiGPg5vcx0rqdCI9anptyj28Nw3bu52ZfjSKYB2y3Z/9TkAbKnEi49xp3yRrYfzGdwjoWUBllk/Gh1JqBInE x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4672.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(366004)(396003)(39860400002)(346002)(376002)(136003)(451199021)(478600001)(54906003)(316002)(110136005)(83380400001)(122000001)(76116006)(66574015)(86362001)(66446008)(66556008)(66476007)(64756008)(66946007)(4326008)(7696005)(8676002)(8936002)(71200400001)(41300700001)(2906002)(5660300002)(38100700002)(53546011)(52536014)(33656002)(38070700005)(9686003)(6506007)(55016003)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?oiKgWSGXCw7YBm/I6rjiXRpV9e8ow9r3qbpMlnPz751EpCdQBSLcUX4TGS?= =?iso-8859-1?Q?wGMuqQRirPuWQN7LWZFycdfq6LQx3ALbxewR3ZyQY6i4ZCH+PPK5vShL1e?= =?iso-8859-1?Q?wejhWH/pv/AehQQB9FxNQryhhGLU3I03MpkKTWt6RXcYsOwoRU1gg9BJCl?= =?iso-8859-1?Q?j3PgLx5oi7izSHOrjrgfbCIIRy91Os9gR50FTGYlN/bfUlGyPcsO9AObKV?= =?iso-8859-1?Q?LwdhS2/i9ry34S6BzKz6fehnY01W8HWNs3hJ8OmZJJ3h4f2XWp2NFSSVSL?= =?iso-8859-1?Q?uJvfRe+eGwexVtuR33NLpUgSChy0pk/zp729otROY9QRD7vq0yMdJqlk3h?= =?iso-8859-1?Q?mM732eEMUPPsnz8C4Z08CfteXMWZ5WCL+GqSJYswm0+IiljJ1NTFCBoKe1?= =?iso-8859-1?Q?hAjDJG4esZ4Je6cW5aGtwuxbaMlh/uPjfnPxEMV+n7QjwpGfQEvpYj0lo7?= =?iso-8859-1?Q?sAkIS+Yv9ryCYN9Sz+h7or5se4VCgYFI6PKxIXns7MIzwKZFsNZlH2jhJh?= =?iso-8859-1?Q?xxKdLzYCKNh3ggAWj/4lvvmGAlHP7EHbi0GGaS8QARl49FbzqahQKGyFS3?= =?iso-8859-1?Q?ZHFH602fnlcL12Okx+v9IssrjpTWGUMwtKYsyrfyhO/ClIwssOaOuRDMZF?= =?iso-8859-1?Q?fLdODTbmoenm+iBm9QcOZItL7Jd1SjLDrwVQ0NClfkkduUIzzB7ajXzbJM?= =?iso-8859-1?Q?dF7cTj1Qz7k/jH2wTO61vv5NPryg8V3TRkyIw5WM3Xe2ffoM3Qoy6bAoQG?= =?iso-8859-1?Q?sPoilfzHr99e3i2jzuDNYvm5mz8rTUKY8VYmrRCnCnMezMmmW8/diJ3eaN?= =?iso-8859-1?Q?BdayCL6jXTjM7GNz7Q0Zk7zl50LP3aqNW0E7mWkMyq5ulLnNisLMFOcexg?= =?iso-8859-1?Q?y74DbN4RjdKaRbx8N49iHn6QQhR+7SPWe8yn0oWxmybzwv1Pez5zvMoAaS?= =?iso-8859-1?Q?RzFNhb2Um2ZKnGh0fzrhleewJ13fzwyCwnoK8QsUyhH1fDAiLpz/0b71A2?= =?iso-8859-1?Q?Fl8iyNLYAEGSOT8WnY/FO7gQCu3fUtZ7nm+kYdIZjkTnZMlxbM4se3KMKF?= =?iso-8859-1?Q?XdtrZF9Zw8FHboBzDaLLoyHwoj3uJogVpCCqKrKey7C3SmnkcCSFcW+qY7?= =?iso-8859-1?Q?x0IQLaZM+u4oheabCQV/o9u50XnFjgeTSUXEvhIjCRJg95pCx4N78FsCJa?= =?iso-8859-1?Q?BxocP7q9c1dQjwnlGn2xoNegTUVIrmzXeVjTtmoTiWFLNSSSY/5C1MFBvk?= =?iso-8859-1?Q?7IBggTW8nmDzY95nriYr9bv7UJAEuvQGxT+cyl0fYJAzYKwCVYdkkXyGkx?= =?iso-8859-1?Q?ZY6kudWLPpTUA5yq/2Lnmvx6D/mO5T53rz0yfELPq+jo35BGL+DBNmHEoH?= =?iso-8859-1?Q?MJ0uI/UV2HrHgK8Ob8sJp83spPdBOPWtMvdMqcwgZ21+LirTeUnCJZNbPN?= =?iso-8859-1?Q?wVWrdDIoV3Gu4TEkDExH7kmEIJtovmt3LkDUvIzJR7WVlC42T0B+3gkhMx?= =?iso-8859-1?Q?z8MShlWbgpdnX50xjVVqkMzXTUzScqwj4bTUtA81iAiEtclgLhbdQ7vwv1?= =?iso-8859-1?Q?K8l9B0plAT0eS/pT5WvQNyN7xsi/ZSUPKm9dKFPo0dYcj+EItg=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4672.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9295c11e-e227-47d0-5f7a-08db58543480 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2023 10:31:28.3937 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9L6BQvI8HkrAs0CBxHJ9EUyvzq34V0kbbGEXBjOhYjMkpv36vkd0MYKICjMAuYQdRgm1iSdO/4PrI2/xi2XStA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1801MB1963 X-Proofpoint-GUID: 2fV-TsuCJMISaQT41-wBdnvSjOm2MwMl X-Proofpoint-ORIG-GUID: 2fV-TsuCJMISaQT41-wBdnvSjOm2MwMl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-19_06,2023-05-17_02,2023-02-09_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Akhil, Please see inline. Thanks, Anoob > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, May 18, 2023 5:36 PM > To: Anoob Joseph ; Thomas Monjalon > ; Jerin Jacob Kollanukkaran ; > Konstantin Ananyev ; Bernard > Iremonger > Cc: Hemant Agrawal ; Mattias R=F6nnblom > ; Kiran Kumar Kokkilagadda > ; Volodymyr Fialko ; > dev@dpdk.org; Olivier Matz > Subject: RE: [PATCH v2 09/22] app/test: add lib pdcp tests >=20 > > > > diff --git a/app/test/meson.build b/app/test/meson.build index > > > > 52d9088578..0f658aa2ab 100644 > > > > --- a/app/test/meson.build > > > > +++ b/app/test/meson.build > > > > @@ -96,6 +96,7 @@ test_sources =3D files( > > > > 'test_meter.c', > > > > 'test_mcslock.c', > > > > 'test_mp_secondary.c', > > > > + 'test_pdcp.c', > > > > 'test_per_lcore.c', > > > > 'test_pflock.c', > > > > 'test_pmd_perf.c', > > > > diff --git a/app/test/test_cryptodev.h b/app/test/test_cryptodev.h > > > > index abd795f54a..89057dba22 100644 > > > > --- a/app/test/test_cryptodev.h > > > > +++ b/app/test/test_cryptodev.h > > > > @@ -4,6 +4,9 @@ > > > > #ifndef TEST_CRYPTODEV_H_ > > > > #define TEST_CRYPTODEV_H_ > > > > > > > > +#include > > > > +#include > > > > + > > > > > > Can we remove these includes from here and add in test_pdcp.c directl= y? > > > > [Anoob] Why? 'test_cryptodev.h' already has many references to > > rte_cryptodev symbols. Not including the dependencies is not correct. > > > In that case, it can be a separate patch. But not in this patch. [Anoob] Is your suggestion to push this specific change as a separate patch= ? I can do that if you suggest so. >=20 > > > > > > > > > > + if (conf->is_integrity_protected) { > > > > + if (conf->entity.pdcp_xfrm.pkt_dir =3D=3D > > > > RTE_SECURITY_PDCP_UPLINK) { > > > > + conf->entity.crypto_xfrm =3D &conf->a_xfrm; > > > > + > > > > + a_xfrm.auth.op =3D > > > RTE_CRYPTO_AUTH_OP_GENERATE; > > > > + a_xfrm.next =3D &conf->c_xfrm; > > > > + > > > > + c_xfrm.cipher.op =3D > > > > RTE_CRYPTO_CIPHER_OP_ENCRYPT; > > > > + c_xfrm.next =3D NULL; > > > > + } else { > > > > + conf->entity.crypto_xfrm =3D &conf->c_xfrm; > > > > + > > > > + c_xfrm.cipher.op =3D > > > > RTE_CRYPTO_CIPHER_OP_DECRYPT; > > > > + c_xfrm.next =3D &conf->a_xfrm; > > > > + > > > > + a_xfrm.auth.op =3D RTE_CRYPTO_AUTH_OP_VERIFY; > > > > + a_xfrm.next =3D NULL; > > > > + } > > > > + } else { > > > > + conf->entity.crypto_xfrm =3D &conf->c_xfrm; > > > > + c_xfrm.next =3D NULL; > > > > + > > > > + if (conf->entity.pdcp_xfrm.pkt_dir =3D=3D > > > > RTE_SECURITY_PDCP_UPLINK) > > > > + c_xfrm.cipher.op =3D > > > > RTE_CRYPTO_CIPHER_OP_ENCRYPT; > > > > + else > > > > + c_xfrm.cipher.op =3D > > > > RTE_CRYPTO_CIPHER_OP_DECRYPT; > > > > + } > > > > + /* Update xforms to match PDCP requirements */ > > > > + > > > > + if ((c_xfrm.cipher.algo =3D=3D RTE_CRYPTO_CIPHER_AES_CTR) || > > > > + (c_xfrm.cipher.algo =3D=3D RTE_CRYPTO_CIPHER_ZUC_EEA3 || > > > > + (c_xfrm.cipher.algo =3D=3D RTE_CRYPTO_CIPHER_SNOW3G_UEA2))) > > > > + c_xfrm.cipher.iv.length =3D 16; > > > > + else > > > > + c_xfrm.cipher.iv.length =3D 0; > > > > + > > > > + if (conf->is_integrity_protected) { > > > > + if (a_xfrm.auth.algo =3D=3D RTE_CRYPTO_AUTH_NULL) > > > > + a_xfrm.auth.digest_length =3D 0; > > > > + else > > > > + a_xfrm.auth.digest_length =3D 4; > > > > > > This if-else is not needed. If is_integrity_protected, digest_length > > > should always be 4. > > > > [Anoob] I had explained this in v1 patch set. Will try again. > > > > In PDCP, with AUTH_NULL it is expected to have 4 bytes of zeroized dige= st. > > > > With AUTH_NULL, it is lib PDCP which would add zeroized digest. No PMD > > currently supported in DPDK supports non-zero digest with AUTH-NULL. > > Also, it is not specified what is the digest added in case of AUTH-NULL= . >=20 > In auth_xform, digest_length is the expected length of digest coming out = of > crypto device. [Anoob] Yes. But the packet append is the duty lib PDCP. Crypto PMD is expe= cted to just write the digest at a specific location. > Now if the device is expected to support PDCP, and we are reusing the > crypto APIs, We can specify the digest length required for NULL auth. > The PMDs capability can be updated accordingly. [Anoob] Again, none of the current PMDs do a zeroized digest with NULL auth= . And it is not a requirement as well. Here, we are doing PDCP offload and = the crypto_xforms provided here are for specific crypto transformations. > You can add a comment in the rte_crypto_auth_xform specifically for NULL > auth for PDCP case. >=20 > The reason, I am insisting on this is, for the user, while configuring > auth_xform, it is setting digest length as 0 and when the packet is recei= ved > the packet length is increased by digest. This will create confusion. > And it will also help in identifying the case of no integrity and null in= tegrity. [Anoob] When working with protocol, the packet would change both at header = and trailer. It is just that for PDCP, the trailer is only digest. For IPse= c, the change is more than digest. >=20 > > > > > Also define a macro for MAC-I len. It is being used at multiple place= s. > > > Similarly for IV length macro can be defined. > > > > > > > [Anoob] Agreed. You want me to introduce RTE_PDCP_MAC_I_LEN or > > something local would do? > I am ok either way. Having defined in library would be better, to be used= in > lib and PMD as well. >=20 > > > > > > + > > > > + if ((a_xfrm.auth.algo =3D=3D RTE_CRYPTO_AUTH_ZUC_EIA3) || > > > > + (a_xfrm.auth.algo =3D=3D > > > RTE_CRYPTO_AUTH_SNOW3G_UIA2)) > > > > + a_xfrm.auth.iv.length =3D 16; > > > > + else > > > > + a_xfrm.auth.iv.length =3D 0; > > > > + } > > > > + > > > > + conf->c_xfrm =3D c_xfrm; > > > > + conf->a_xfrm =3D a_xfrm; > > > > + > > > > + conf->entity.dev_id =3D (uint8_t)cryptodev_id_get(conf- > > > > >is_integrity_protected, > > > > + &conf->c_xfrm, &conf->a_xfrm); > > > > + > > > > + if (pdcp_test_params[index].domain =3D=3D > > > > RTE_SECURITY_PDCP_MODE_CONTROL || > > > > + pdcp_test_params[index].domain =3D=3D > > > > RTE_SECURITY_PDCP_MODE_DATA) { > > > > + data =3D pdcp_test_data_in[index]; > > > > + hfn =3D pdcp_test_hfn[index] << > > > pdcp_test_data_sn_size[index]; > > > > + sn =3D pdcp_sn_from_raw_get(data, > > > > pdcp_test_data_sn_size[index]); > > > > + count =3D hfn | sn; > > > > + } > > > > > > The above logic can go inside lib PDCP as well. > > > This is specific to PDCP and not user dependent. > > > You can reuse the pdcp_xfrm.hfn as well. > > > > > > > [Anoob] Sorry, what exactly can go into lib PDCP? This snippet is > > reading SN used in a test vector and constructs the count based on SN & > HFN value from vector. >=20 > This count value is being used to establish entity. I am saying, instead = of > taking Count, take sn as input and in the libpdcp combine pdcp_xfrm.hfn a= nd > sn as needed to create count and store in entity_priv. > Just wanted to reduce the application headache to make bitshifting and > ORing to SN. [Anoob] I was not able to identify a use case where having two 32 bit value= s for HFN & SN would make sense. But then, it would align better with curre= nt rte_security specification. Will make the change in next version.