From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59580A0C43; Thu, 23 Sep 2021 13:08:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D12894124F; Thu, 23 Sep 2021 13:08:38 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id C73664122B for ; Thu, 23 Sep 2021 13:08:36 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18N7iqtU016698; Thu, 23 Sep 2021 04:08:35 -0700 Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2108.outbound.protection.outlook.com [104.47.55.108]) by mx0a-0016f401.pphosted.com with ESMTP id 3b8awj2t4q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Sep 2021 04:08:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EfhtcLvb0jSmhWogzzpMcipz9cYgwZKO6R2gzlKKREbqu7l+CzVPeFjqJvKDvQAMmTaxYd7nLp8IhDAA/P8KT7uzjgJS1bV1xBsoI/OQjkNCjmTmlO2mm/21DVfNRFxbUbAZiTOWh9qdBxFiRfe7KPBaba2SYScOncCVlShPCrRixui7crl5nQiXH4ygTiTndhi+z3F6UeWRnFWIumUfNjANZKpOGDYLRpxMnEa3Hx/1oHhDAVnjCT/8kbuY12VE65w8qRq623B2wgZPMVOl8A13l4P0ksU8tWQ6OOW+StjpZD3LpGkVCOfbNi4HQCJfE1X0PhrGi2NG28xm7R3ovw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=SlNNuRxrfOdBHBfGf3fPbLpUX2i0M+MIGmmKIFYKrKg=; b=THun8cKkdv5WFpR+nMCrXpe1Ni4msmLy7QwOxJOEZwDo7CFyiuRdYeysj1lNRNAy5zuE98a3UZpR2D8sU4m8aXI+zc4IUp9Yea76QugkV1wqr7OjIJRRUXnBkjL9urIA8lj9kxiakc7oeyXh//etoiik3QRXc6/3hdJT9rZ5qoouViKSNmS1C3yteOG3QIPld46dogQbIQVxDBeICIiJ/dwReta0KYQ2+rD4hKK15/HHr1qXFW15ONaFAUhtNfrjuAhC9MEev61I7HeyU8Op5nCrBraZWXft/oXtmh3jK5tSOY6ahCtTdte/MLIdtccd7/zfOsaZm7YGEzreM1Dxhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SlNNuRxrfOdBHBfGf3fPbLpUX2i0M+MIGmmKIFYKrKg=; b=fvCAU+pQsCgmo88H2xRtXzKzIAGBl/YIjtHwyGFc/w4Yk1GqhKjiHhK/xyS/lfheqPNwa0Xpo+6GQneFytgTAcdRNUaQtiRNnq9kgw2AVKe5rTY+PE6pX6zWoELFiFjTCS/VAE96nv3dU/eoYD2aQcXBP+zXI4W08ghKCS2dDDA= Received: from PH0PR18MB4672.namprd18.prod.outlook.com (2603:10b6:510:c9::16) by PH0PR18MB4476.namprd18.prod.outlook.com (2603:10b6:510:e7::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13; Thu, 23 Sep 2021 11:08:33 +0000 Received: from PH0PR18MB4672.namprd18.prod.outlook.com ([fe80::85aa:3d01:94f6:984]) by PH0PR18MB4672.namprd18.prod.outlook.com ([fe80::85aa:3d01:94f6:984%4]) with mapi id 15.20.4544.014; Thu, 23 Sep 2021 11:08:33 +0000 From: Anoob Joseph To: "Power, Ciara" , Akhil Goyal , "Doherty, Declan" , "Zhang, Roy Fan" , "Ananyev, Konstantin" CC: Jerin Jacob Kollanukkaran , Archana Muniganti , Tejasree Kondoj , Hemant Agrawal , "Nicolau, Radu" , Gagandeep Singh , "dev@dpdk.org" Thread-Topic: [PATCH v4 1/5] test/crypto: add lookaside IPsec tests Thread-Index: AQHXq8YlPuTK/Vsp1UCSiVhU2yefFauxdwSAgAACdQA= Date: Thu, 23 Sep 2021 11:08:33 +0000 Message-ID: References: <1630644420-1256-1-git-send-email-anoobj@marvell.com> <1631884523-836-1-git-send-email-anoobj@marvell.com> <1631884523-836-2-git-send-email-anoobj@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c6458c30-1008-460e-f0c0-08d97e827bd3 x-ms-traffictypediagnostic: PH0PR18MB4476: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oZVjKH2wG8pbksl3k0ufNZIMDFI6zF0Y5DhujwxUbtqTzjjQ1I9hDeVKqOJAChh+ntA/xOmLcWUSIOknJUhWEgUlNHyThBfMrCy+CuHlUcyHPCZn1nO/eKsdggdkaodYfBPLBfIhnaD5nT4ujYiUS4QsWn0nGMJRZAAppFdmMDtBnpZIXvi6iJpEs9V7D7XgNSxT/Q3l7IBy9juAarevfrsivZakZPhFmnmMysJkgq17MFkD+CP0r0VgZU86w8850UJIPA3xkca/N1Ph8k9srNoxVqqopZ1LhsX/dhoTeTvKpP5OGVcow+ZxMLW74BH4HnXoNgu4O2DzlM7HtNW7XLa962S+JJnog6K/sMIa1crZRoWdEs80J5Cn0EqXiq3ieQo+mqUjOipxAioxPu1/jhMaPJssYev82x5+ncP1y0QXStu9RxHCKtOKgs+Cb/5rd0/GXdaNf49kN0s6KMHSObYDxai8RHOtiMY5e7EQOcgA5X61DZCKBHc7iEk24Q+04Ck5/kykUygpbsHGMSx+HlAN0JNYSfsNnjJ6U8k6W/5owK3mAkXfy0UTY+2/SxBkFbFgQbm97KmgY3pUfflDFeLPgGyQSszQHU4V0GSK/FY9Iz/l5Pvg3+zxz6DsDXZDw1QBY1e7XK2ODTHxOf6i06RFhXNxfCQzY4FAixV0OenFrJ4uuXnmlYcsUwN1zKgT5jsMKXji5zasQcmEzQ7Vcw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4672.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(508600001)(54906003)(83380400001)(316002)(38100700002)(64756008)(76116006)(26005)(4326008)(7696005)(71200400001)(66556008)(66446008)(110136005)(38070700005)(33656002)(66476007)(186003)(55016002)(5660300002)(86362001)(9686003)(53546011)(122000001)(2906002)(6506007)(8676002)(8936002)(52536014)(66946007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?a1aFe2xj84853r9KApbuOymQ7gCBT6fvW4frvUW3l4RWJuJOzZQ+MdAfp9nr?= =?us-ascii?Q?0Cx5rlfeEN1emGKeNN9ggqQbX91GPD8EkbfqKB92+GsjFTBRk3WOEyzM2lv/?= =?us-ascii?Q?O8xPZWRrDAaaErpl76vmZIHrEKUJrmkKl57xrLMqn9pLGMh5gbQkPZlyUkAP?= =?us-ascii?Q?A4Lry5EOnSJilDxxvoJdk9feRS3J7aUAWECz0JqKPLnNWC+fxOkN3bhQf/pA?= =?us-ascii?Q?MsaJg8vmAgBGpYersDdmB3epUDtEZrqFr9NBemsfJw2hiBq8b6YU86H6UC5A?= =?us-ascii?Q?FN2o4QrAHCTYqyuA/wcY58wsnz5XrXB0GFD2GUkavkv8T1dyJ+c8y+Q4uhj5?= =?us-ascii?Q?YyZIOOS0c+2yrEpAAsrIco64ms1pVtHAEgWHKrnyCaFKUSR6WBxa1pVOpdi8?= =?us-ascii?Q?tKQLghFrZM/A5ZnYAR87sgHhZtYyjLXSBXyZ++BGX7a9SDDGg07czr4CiUXj?= =?us-ascii?Q?t78YN64o6Uu4ze4yfBL0NQrfK9FHjcgL/7WV35V01gvaReYzge+K/LRIiluS?= =?us-ascii?Q?fvogoveAeih/nf9ePgb0utB820J8Pi4m1/Qed7jrHzLHXi02WCMHbrgn29WB?= =?us-ascii?Q?pimo8NlDsBN41L18Ax04bvcByTRztukiY4LQplwbNgXXRO7AyD69K3/YQkGv?= =?us-ascii?Q?JwQvNgYyhfELyRgcpcUkH+hCj8KWJFrYbGvN+IC33clYLAIX+NpQNJGWgrGS?= =?us-ascii?Q?iVAkAYjV7tJ1F4rpNzTGtWvUotcSCfjp95gM44kCkKAdjIAv7Ga8vseVbVcZ?= =?us-ascii?Q?LbMxleubeK9pc1SqPYVBF28FmD5O9ELdnmT5sL7EU3LtAG35Mb9lxsknxbaX?= =?us-ascii?Q?O/q9VCWi6d4GpBHy0gVPcKMJLI3usqzI1Gj5ythf5YJVwnCuSzYsf8iTJ3Z4?= =?us-ascii?Q?JXShsB3pllTO3Op0sWrD+UbfhieDogLObjUOZOwfShWNTwNwy2IxBrc3qnYF?= =?us-ascii?Q?hh+9U9bVwbhj5/6XxjL9ncrGMKfn/beUxKvD0glzT3cOwZigBdp+ReVciD5+?= =?us-ascii?Q?SgeTgSIxsYfRddzIhw0BSDwROPu+sVzKLYYAfU3rnKHlJZ+rNv3tQr+4YeFs?= =?us-ascii?Q?Fk0IVZBC8jNZJ0Z5rR9maW8ENa/eYW2egzU+gr+i0vPjbYwFR+ZuXceYPuKV?= =?us-ascii?Q?4cXOKWBTQHjckDOg6GcvrhQ38RL4MD3s7mQZ71WhRmKjUBJbi9jVPawVpIXZ?= =?us-ascii?Q?QLGbj7waxkG6yheMQaOOS3pTQ1170To3hXQT2JociUmJb/DCoOySWOkU9iw3?= =?us-ascii?Q?nw1oCyGYOYkJPqVtjdkEEPs0NwhigH3FjZNA065FVApxjpURHshyKu+nuFyg?= =?us-ascii?Q?ym5KSiMMmV4Brq291ll/a3fP?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4672.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6458c30-1008-460e-f0c0-08d97e827bd3 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2021 11:08:33.5751 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OuGJtwn5tdYPAWw8iOru6Yv3pgbzat+xmAPWcFJLrjIUnVgO0pdJjaL6608UAAMQXQUf9GBmmOFJ/hz7076FAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB4476 X-Proofpoint-GUID: Erd0hIEo9ymlbpHfXqBpaG_wDSPR9iyj X-Proofpoint-ORIG-GUID: Erd0hIEo9ymlbpHfXqBpaG_wDSPR9iyj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-23_03,2021-09-23_01,2020-04-07_01 Subject: Re: [dpdk-dev] [PATCH v4 1/5] test/crypto: add lookaside IPsec tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ciara, Please see inline. Thanks, Anoob > -----Original Message----- > From: Power, Ciara > Sent: Thursday, September 23, 2021 4:09 PM > To: Anoob Joseph ; Akhil Goyal ; > Doherty, Declan ; Zhang, Roy Fan > ; Ananyev, Konstantin > > Cc: Jerin Jacob Kollanukkaran ; Archana Muniganti > ; Tejasree Kondoj ; Hemant > Agrawal ; Nicolau, Radu > ; Gagandeep Singh ; > dev@dpdk.org > Subject: [EXT] RE: [PATCH v4 1/5] test/crypto: add lookaside IPsec tests >=20 > External Email >=20 > ---------------------------------------------------------------------- > Hi Anoob, >=20 > One comment inline. >=20 > Thanks, > Ciara >=20 > >-----Original Message----- > >From: Anoob Joseph > >Sent: Friday 17 September 2021 14:15 > >To: Akhil Goyal ; Doherty, Declan > >; Zhang, Roy Fan ; > >Ananyev, Konstantin > >Cc: Anoob Joseph ; Jerin Jacob > >; Archana Muniganti ; > >Tejasree Kondoj ; Hemant Agrawal > >; Nicolau, Radu ; > >Power, Ciara ; Gagandeep Singh > >; dev@dpdk.org > >Subject: [PATCH v4 1/5] test/crypto: add lookaside IPsec tests > > > >Added test case for lookaside IPsec. Inbound known vector tests are adde= d. > > > >Cipher list: AES-GCM 128, 192 & 256 > > > >Signed-off-by: Anoob Joseph > >Signed-off-by: Tejasree Kondoj > > > >--- > > app/test/meson.build | 1 + > > app/test/test.h | 6 + > > app/test/test_cryptodev.c | 232 ++++++++++++++= + > > app/test/test_cryptodev_security_ipsec.c | 212 ++++++++++++++ > > app/test/test_cryptodev_security_ipsec.h | 66 +++++ > > .../test_cryptodev_security_ipsec_test_vectors.h | 321 > >+++++++++++++++++++++ > >=20 > > #ifdef RTE_LIB_SECURITY > > static int > >+ipsec_proto_testsuite_setup(void) > >+{ > >+ struct crypto_testsuite_params *ts_params =3D &testsuite_params; > >+ struct crypto_unittest_params *ut_params =3D &unittest_params; > >+ struct rte_cryptodev_info dev_info; > >+ int ret =3D 0; > >+ > >+ rte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info); > >+ > >+ if (!(dev_info.feature_flags & RTE_CRYPTODEV_FF_SECURITY)) { > >+ RTE_LOG(INFO, USER1, "Feature flag requirements for IPsec > >Proto " > >+ "testsuite not met\n"); > >+ return TEST_SKIPPED; > >+ } > >+ > >+ /* Reconfigure to enable security */ > >+ dev_configure_and_start(RTE_CRYPTODEV_FF_SYMMETRIC_CRYPTO > >| > >+ RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO); > >+ > >+ /* Set action type */ > >+ ut_params->type =3D > >RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL; > >+ > >+ if (security_proto_supported( > >+ > > RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL, > >+ RTE_SECURITY_PROTOCOL_IPSEC) < 0) { > >+ RTE_LOG(INFO, USER1, "Capability requirements for IPsec > >Proto " > >+ "test not met\n"); > >+ ret =3D TEST_SKIPPED; >=20 > The device still needs to be stopped here I believe if capabilities not m= et. [Anoob] Here we are just setting return value. Function returns below only = (after stopping device).=20 =20 >=20 > >+ } > >+ > >+ /* Stop the device */ > >+ rte_cryptodev_stop(ts_params->valid_devs[0]); > >+ > >+ return ret; > >+} > >+