Re: [dpdk-dev] [EXT] Re: [pull-request] next-crypto 21.08 rc1

[Anoob Joseph <anoobj@marvell.com>]

Hi Ali, David,

Thanks for pointing it out. The suggestion from David should do. Should we submit a patch with fix on master? How do you suggest we proceed?

Thanks,
Anoob

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of David Marchand
> Sent: Friday, July 9, 2021 1:46 AM
> To: Ali Alnubani <alialnu@oss.nvidia.com>; Tejasree Kondoj
> <ktejasree@marvell.com>
> Cc: Akhil Goyal <gakhil@marvell.com>; NBU-Contact-Thomas Monjalon
> <thomas@monjalon.net>; dev@dpdk.org
> Subject: [EXT] Re: [dpdk-dev] [pull-request] next-crypto 21.08 rc1
> 
> External Email
> 
> ----------------------------------------------------------------------
> On Thu, Jul 8, 2021 at 7:14 PM Ali Alnubani <alialnu@oss.nvidia.com> wrote:
> > """
> > $ meson --werror -Dc_args='-DRTE_ENABLE_ASSERT' --buildtype=debug
> > build && ninja -C build ...
> > ../../root/dpdk/drivers/crypto/cnxk/cn10k_cryptodev_ops.c: In function
> 'cn10k_cpt_sec_post_process':
> > ../../root/dpdk/drivers/crypto/cnxk/cn10k_cryptodev_ops.c:260:37: error:
> 'IPV6_VERSION' undeclared (first use in this function); did you mean
> 'IPVERSION'?
> >   260 |         RTE_IPV4_IHL_MULTIPLIER) == IPV6_VERSION);
> > """
> 
> The simplest fix:
> 
> @@ -275,7 +275,7 @@ cn10k_cpt_sec_post_process(struct rte_crypto_op
> *cop,
>                         m_len = rte_be_to_cpu_16(ip->total_length);
>                 } else {
>                         PLT_ASSERT(((ip->version_ihl & 0xf0) >>
> -                                   RTE_IPV4_IHL_MULTIPLIER) == IPV6_VERSION);
> +                                   RTE_IPV4_IHL_MULTIPLIER) == 6);
>                         ip6 = (struct rte_ipv6_hdr *)ip;
>                         m_len = rte_be_to_cpu_16(ip6->payload_len) +
>                                 sizeof(struct rte_ipv6_hdr);
> 
> 
> --
> David Marchand