From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17750A034F; Wed, 10 Nov 2021 12:48:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C97DD4068B; Wed, 10 Nov 2021 12:48:46 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 5DBE440683 for ; Wed, 10 Nov 2021 12:48:45 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1AAAI8Kn027325; Wed, 10 Nov 2021 03:48:44 -0800 Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam08lp2173.outbound.protection.outlook.com [104.47.73.173]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3c8c6wr97g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Nov 2021 03:48:44 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d7wzlmKKMdZP8OFEfWaB4XaH6SdT1wBM0AoGmuxAB+beTg3lUh2JsO/aVWZT1FmUN6v8s/RTwUfOtF/SX3QmGyPvijxUp67QyjVGOWsECN2F3xjBzsX2lFTtZiFaOhkH2KBoLrPqk1XflSwv5dL3ZK0dpkZ16SFNT8du8++3Hdkv6vV6RrzxWD3/fPH7TzVS9/Dgr2gAzs9NaH1xxivnOH5LS13xzJb1oyQopvzcwyQvdIHuROafxLIHyPeIeftw7gDTZrxwHG5UWYc1ugYeRiK8xarEQCfutDg0xzX6T14lcPizTD09dV3UuArUA2iZSsBFbcdEXQsWjk5PLm3cYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=crHwEwucrAE/MAgjwN2YVavrXMWj6u9cx3qfpoTyybk=; b=KBgDBzg3N1OfrxFQpuyppmv6h2u1594qLAmVCWAolR2ZrlB8HzUZ3lJyBh/tGbsb3+t0OZdaiCVAJH6FKmIEuiTjvgA/b43xuy39J6rLsYemgG1rc5xeq4w13AKn5rEiqdnTcbAmN/sEuVz3Vhm66mAt0B3fkIzJj1IoRVzkjcpP/QA9ZcqNvj8IZGgxp6kNxSZCfv2I5XKTE8sEHbCyUu36cSd5EMu8TFqqSTpsl/j7KsXCtAmJnKvj88SeFqWxD5ajtVjtH+iSqeYeC3G+uShLIp1hguWR5mWIrBsOV8/6y3nvesdcHihSqdfIBxfSkkpG/OINNAoQUMFk9UBjjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=crHwEwucrAE/MAgjwN2YVavrXMWj6u9cx3qfpoTyybk=; b=KuOfBDmgYKq1cxzIgMtNU2v3xPwySDr9kPhGUzgPeaaopz0L3wYOZ31XtU9w/lybyPcfcNi8bSc/htNaURUgdJdHubUYQ7sg45ez3hABp9If6MR5QXJaiYFpCq1PPvbJTGbIJo3FAFjtVMRLcnMSW+ITNutnBjFcx6ulOwQ0U6A= Received: from PH0PR18MB4672.namprd18.prod.outlook.com (2603:10b6:510:c9::16) by PH0PR18MB4670.namprd18.prod.outlook.com (2603:10b6:510:c7::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15; Wed, 10 Nov 2021 11:48:40 +0000 Received: from PH0PR18MB4672.namprd18.prod.outlook.com ([fe80::30fa:e30f:a8cc:92aa]) by PH0PR18MB4672.namprd18.prod.outlook.com ([fe80::30fa:e30f:a8cc:92aa%8]) with mapi id 15.20.4690.015; Wed, 10 Nov 2021 11:48:40 +0000 From: Anoob Joseph To: "De Lara Guarch, Pablo" , Akhil Goyal , "Doherty, Declan" , "Zhang, Roy Fan" CC: Jerin Jacob Kollanukkaran , Archana Muniganti , Tejasree Kondoj , Hemant Agrawal , "Nicolau, Radu" , "Power, Ciara" , Gagandeep Singh , "dev@dpdk.org" , "Ji, Kai" Thread-Topic: [dpdk-dev] [PATCH] test/crypto: skip plain text compare for null cipher OOP Thread-Index: AQHX1LQnXFgl6wwmBUyU6o4z3o1vXqv8oXCAgAAAbWA= Date: Wed, 10 Nov 2021 11:48:40 +0000 Message-ID: References: <1636384791-157-1-git-send-email-anoobj@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 68ecbaca-7679-403f-b433-08d9a4400a58 x-ms-traffictypediagnostic: PH0PR18MB4670: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: M0VCClepJJ/bdCcG1atFGQrQEJa8GEf5gMJXQ5jNSLuTIUZbttxPCKDhp+inJSFDTQSnzwDcjvdiJe4b0b7K37x7Us75sbqTTInFMxg6TcasQjw9CqWjHTi1pXSwF0f7kzEQLo5YagxMkRPIU5/aIf80nxtZxdIeanTZ3RemtrWEgOjbs0G+UJBokKoma3wJTDf/Vy9rGSfOTy4kk3MDFh4BTczi4BTLraAbzHQ0DHwBAut1MANbxPID3u26w1qkp/hPXnclSValLBIkKbMg5mcjdN2z7Y5H1xOEPamYEHquGoiLL7jkg2kBlD2o8km27j6rXTRk6ftfqQvuh4CuRTIwLuFdHL4JRonF/mA4atxpnbjjTBRVPLNrWt6HgS0jkYeZWD9D00aTciNc0Nb655FMm5y93W+fAdsfSaXJEc4EObapohgLWM4J46j9Kv0olEv0HUeVD6TBEqnthsOyVA3DtV+70/5cqDppO2L2z+qhgZUm7SYmBWCd3n2LFrf5WcX1sFCa3cNicD7sdqLPGv80CpIglHa+74iJ9gX4KFNR4JUzuspyzZnmCRzoTpIbEKt0Mugw+6RgP4DZ7sOY3/amFrVpvzCmPEqTseKRpUxlkhHbG8oRSayDS/CzRWzjsTNQBRGofuGT8K07YzfmmxBKdR6snAb0Uprc1tU9hzEqQ1u0DsG4DIgNqvURNlHU/2hAZVJSJ56Q+4UK7VCJFQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4672.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(122000001)(26005)(38100700002)(110136005)(54906003)(316002)(71200400001)(55016002)(9686003)(186003)(86362001)(83380400001)(4326008)(8676002)(38070700005)(66446008)(33656002)(52536014)(6506007)(53546011)(5660300002)(76116006)(508600001)(2906002)(66556008)(66476007)(64756008)(8936002)(7696005)(66946007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yzz3LTkM+jO/4VUYkJr9KK2as4zJH40idZRecZIXapbRZXUO3iLOGA1zceMR?= =?us-ascii?Q?REsY3qXSa9e2NByBACTtfUsMzCJxb+8gYXcXoK1JlKFbs0S6EfJY3w/u6RQa?= =?us-ascii?Q?smKkUaoE7sHkXmVYmYU1f1b3Vcq7zrcg95vOXbEFGDw3ipAZCSD3xkIngMmo?= =?us-ascii?Q?qnExJkPifEd/kMtQU2G3ETt+3e6N4lcMASxr5U6WKw9wDLb1ANqJyQkexE6e?= =?us-ascii?Q?MfzirX53ZoB69aG7XKrzo7KW4X869S9jWP/yH+xGD/r8iQB5gZ1QOiG37FlY?= =?us-ascii?Q?a/CQziCbcTMTjLjRtk1hZmNUIlhjt+Y0T7PO2Lu5Ij4P2+PtZ1Vh/cDN0IHy?= =?us-ascii?Q?cRSgdBUgrunZqfCcQoO74SzLC8c5RLEH336DibJpK/5NAJUJcPk+9Qss27LB?= =?us-ascii?Q?b0cjUOvkWoMQ3aBhKncrtHa7AzijD1t7HV1az6hc6wYB9EvgR8lqivtZxsd1?= =?us-ascii?Q?WHQ5WsEnUK/hzaKUCjKdU27h+VKXJv2AVSLTYwjKiPMkP/KyRDhsOVfej65k?= =?us-ascii?Q?MJAsbu6SHvFFOxAvWJ3u+pB5dG1kI3eqSV0tDm+VqYDWPsByYbzEdJ6fPuF6?= =?us-ascii?Q?57GLxz0VNKvK7TydSHsD0JoHQmYy5Ngspb9QveOlFF9Z4ZjaxAp+6pJOybPt?= =?us-ascii?Q?fFT4PGKqCaU7gnS6CjCVrn/fy8kFKhn6FO8bAjiFceP5ZFGTnbpYn4kaIzZ8?= =?us-ascii?Q?zqCSmlKamJVhmyRmpKier5qom/NBG6B+nDzx5FHjOGSwGfWwrE0eGXrEsZC5?= =?us-ascii?Q?3DrLli8fQ+un7k8IHFta6Q6hTy7r6wTCZD4JO2UCf1qywFX4qFlCUbpAmXlu?= =?us-ascii?Q?FB9d9Xz7kWqgtDSta3Tpm2/gk/X3xEzOEdJnCp1Tmkot/ACQTVRDPSP/pZWj?= =?us-ascii?Q?MIhfke2KG9rHVgdhOzISMr8W1+W/05x4K7BeWukhAeCHk4wjHhjAzu+d8w8E?= =?us-ascii?Q?SIKpw9xgMFKdzoSk3d/j5F5olAJ0up7w7gYaZsE1LnaZ1IVU+7VmVWlxvHLq?= =?us-ascii?Q?felAFj6EJS9FzEe5W2Dk1/OwSWcsAIfDtx5fsd4wLivTXXlgL0qKAFJay9XF?= =?us-ascii?Q?sY8WnJkWVdy1steYoKGq0Z3J2tBqKQAlLDM8ys/9zwmcAxllUP7hM65OL50c?= =?us-ascii?Q?GeLa/szn6vHFfw6d4JeCYWTiIeb4NEHiQ5vcLl8ftBz9M8I7aXyZ+oQ9ZvhO?= =?us-ascii?Q?TdJSsET+vR9K/DoClWL7dUuQVHORUSSIydlq4VEY2yQGXO2teVzZlxguWKmd?= =?us-ascii?Q?yRGhAwVW2nzr0zJ3A5jQnFAMCRvqB9599IHjQylbHQhzcpQsEG8H02oNWK3N?= =?us-ascii?Q?i0JG0Pr7+HVns1OgX2POoVq8vu8TxX8Nxi/A7Ea9Jw4AHpi+QXlOU/R9aacf?= =?us-ascii?Q?01kvdT7VI760FEfAzLcn1sv8sRq3MSUVl7zN7l+TeQRxWPIclPOgvvYb5Bj+?= =?us-ascii?Q?1+TwU7dBUn9PAaxlzov/D9UT/rBbIRFCUzQBww3SS6KWCpvoiF/RyB9VJeHj?= =?us-ascii?Q?fMugI3bOSylQI0f2+omNIAK8rcTuFd7+59vuJIcDIpeApqBrXvej7bt3JrED?= =?us-ascii?Q?Mf0YQutUArUkLYimBoMWxLzUKrHERE+IOiPbvoLesMmPF+Tfw0ZRfNfE5aSA?= =?us-ascii?Q?2VLOeS+dm5wSyQRlb4ZUhAg=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4672.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 68ecbaca-7679-403f-b433-08d9a4400a58 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2021 11:48:40.6321 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LaSHB96EZt9okaf8cWTc8ZGCHcy+98EwrdGkRzKAsIaRI75YLw++CWXathBENebJsHGl+hjIyvdiE/18w4iNUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB4670 X-Proofpoint-ORIG-GUID: 9XJaBPlw88gt2lO2Pywb6cCpm0MZ-BRb X-Proofpoint-GUID: 9XJaBPlw88gt2lO2Pywb6cCpm0MZ-BRb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-10_03,2021-11-08_02,2020-04-07_01 Subject: Re: [dpdk-dev] [PATCH] test/crypto: skip plain text compare for null cipher OOP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Pablo, Thanks for the review. Please see inline. Thanks, Anoob > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Wednesday, November 10, 2021 4:54 PM > To: Anoob Joseph ; Akhil Goyal > ; Doherty, Declan ; > Zhang, Roy Fan > Cc: Jerin Jacob Kollanukkaran ; Archana Muniganti > ; Tejasree Kondoj ; > Hemant Agrawal ; Nicolau, Radu > ; Power, Ciara ; > Gagandeep Singh ; dev@dpdk.org > Subject: [EXT] RE: [dpdk-dev] [PATCH] test/crypto: skip plain text compar= e > for null cipher OOP >=20 > External Email >=20 > ---------------------------------------------------------------------- > Hi Anoob, >=20 > > -----Original Message----- > > From: dev On Behalf Of Anoob Joseph > > Sent: Monday, November 8, 2021 3:20 PM > > To: Akhil Goyal ; Doherty, Declan > > ; Zhang, Roy Fan > > Cc: Anoob Joseph ; Jerin Jacob > > ; Archana Muniganti ; > > Tejasree Kondoj ; Hemant Agrawal > > ; Nicolau, Radu ; > > Power, Ciara ; Gagandeep Singh > > ; dev@dpdk.org > > Subject: [dpdk-dev] [PATCH] test/crypto: skip plain text compare for > > null cipher OOP > > > > NULL cipher is used for validating auth only cases. With out of place > > processing, validating plain text should not be done as the PMD is > > only expected to update auth data. > > > > Signed-off-by: Anoob Joseph > > --- > > app/test/test_cryptodev.c | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > > > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c > > index e54a1a9..964f44f 100644 > > --- a/app/test/test_cryptodev.c > > +++ b/app/test/test_cryptodev.c > > @@ -7490,6 +7490,22 @@ test_mixed_auth_cipher(const struct > > mixed_cipher_auth_test_data *tdata, > > tdata->digest_enc.len); > > } > > > > + /* > > + * NULL cipher is used for auth only cases where only authentication > > + * is done. With verify operation, MAC would be validated by the > PMD. > > + * With generate operation, verify MAC generated by the PMD. > > + */ > > + if (op_mode =3D=3D OUT_OF_PLACE && > > + tdata->cipher_algo =3D=3D RTE_CRYPTO_CIPHER_NULL) { >=20 > Why only checking for OUT_OF_PLACE? As far as cipher algorithm is NULL, > only digest should be checked. [Anoob] Agreed. I will make this change in v2. =20 > Also, looking at the code, there is this same check, but with hardcoded t= ag > length. > Could you rearrange the code to have less lines and generic? [Anoob] Yes. This looks better and the code would be self-explanatory as we= ll. Will make this change in v2. >=20 > Something like: >=20 > > if (!verify) > check_digest >=20 > if (cipher_algo !=3D NULL) > check_ciphertext/plaintext >=20 > check op status > >=20 > Also, I think this change is applicable in test_mixed_auth_cipher_sgl. [Anoob] Yes. I'll make that change as well. >=20 > Thanks, > Pablo