From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D236942466; Mon, 23 Jan 2023 10:21:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 88276400EF; Mon, 23 Jan 2023 10:21:17 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id C18C5400D4 for ; Mon, 23 Jan 2023 10:21:16 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30MNXnBT012777; Mon, 23 Jan 2023 01:21:15 -0800 Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2040.outbound.protection.outlook.com [104.47.66.40]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3n8ger8k08-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Jan 2023 01:21:15 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JDvDFxeZhl64Ks1GgwQMvlMqRbm9QCqBUdssIEVXDx6eSHew7EPpYJEvDz2NIWJ/7IHCsA53BCNJoekiPgUVwNJP6VxKiDDol/W4smKLyN7hj05nNrGs9CYu3DSifNeIYOpNGEL82oPF2ujplKk1QA3lvHqE2L4J3ePAqv4bK9Xt90LPv4JrkbuoGdD8cww0gcoSbi5WrHoSaE4pRJdCBrENTb5spPBAK/YERI2AviCvb8SaVGc76ebm3WcdKoxL5Op7QB1+GRwtpOAANvyuajw4l6uAwEuxdxV/jqb56dY9nytDVzH+9MMLdwNl9DgT2ejXEqUUdrnjNZgg7ZhHyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1yavr9on3d+darzylwToTuIiAMS7uuGbJCyNVzVVU5I=; b=bt6RbL3Y17se5ib6rqu06G1VxYbq0J5GI2iYbsyltFbhqUqdkMHWLLYjd7wt77LeHd+mP0gzS0wO2wr4fA59hIVPJB1/hZrKNIILBPiG5IRJEIttA5dLQ0jKN8/VaXva+iqDA9PYNx15EkGykYTYXtAfi7f0rxg2A11xWDYu77qyAV039IybLFKmFcHDCmvBRem7NOsx9LLaezSHIHg7oOuKOjU+XqCnd4vvXAje6Uo3Co9QdQPHYOGaLv/MaHawaEvuJ1RJuhl2kLbsEhSF4hRiBeNdx+JAiVm0z15RVdmgkLbRW8GzILXbgYFyBUHfPPknr398TC1MTDFboSlHPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1yavr9on3d+darzylwToTuIiAMS7uuGbJCyNVzVVU5I=; b=AIR/g4sPSIMZ8hg1amOezEz9/Tajw1R1FbUN3usyfmmG40v2nGCHylemKkoz9fse0hPtAtbO8drJLVl2RdeqAVhLtuIV8o/ZejnljLKmSu9wPS+AwRJtKEA3QxDiRrIDVByG6/l9VxBTIs9TTYRGnAdwYIWm6h3qI2IRkIXR1g0= Received: from PH0PR18MB4672.namprd18.prod.outlook.com (2603:10b6:510:c9::16) by MW5PR18MB5126.namprd18.prod.outlook.com (2603:10b6:303:1c0::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33; Mon, 23 Jan 2023 09:21:12 +0000 Received: from PH0PR18MB4672.namprd18.prod.outlook.com ([fe80::5df6:255f:41d5:dd1c]) by PH0PR18MB4672.namprd18.prod.outlook.com ([fe80::5df6:255f:41d5:dd1c%9]) with mapi id 15.20.6002.033; Mon, 23 Jan 2023 09:21:12 +0000 From: Anoob Joseph To: Thomas Monjalon CC: Akhil Goyal , Jerin Jacob Kollanukkaran , Konstantin Ananyev , Olivier Matz , "dev@dpdk.org" , Volodymyr Fialko , Hemant Agrawal , =?iso-8859-1?Q?Mattias_R=F6nnblom?= , Kiran Kumar Kokkilagadda , "dev@dpdk.org" Subject: RE: [EXT] Re: [PATCH 1/5] net: add PDCP header Thread-Topic: [EXT] Re: [PATCH 1/5] net: add PDCP header Thread-Index: AQHZK1sCE3dbpz9/z0OfC3CuR2b6eq6kb95wgADy4YCABl0sQA== Date: Mon, 23 Jan 2023 09:21:11 +0000 Message-ID: References: <20221027052140.155-1-anoobj@marvell.com> <2293639.0S5aU1g85B@thomas> <28193101.czjnFlTdjD@thomas> In-Reply-To: <28193101.czjnFlTdjD@thomas> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-rorf: true x-dg-ref: =?iso-8859-1?Q?PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcYW5vb2JqXG?= =?iso-8859-1?Q?FwcGRhdGFccm9hbWluZ1wwOWQ4NDliNi0zMmQzLTRhNDAtODVlZS02Yjg0?= =?iso-8859-1?Q?YmEyOWUzNWJcbXNnc1xtc2ctNDQ2NTc0NWItOWFmZi0xMWVkLTljNGMtNG?= =?iso-8859-1?Q?MwMzRmNWY5YjRmXGFtZS10ZXN0XDQ0NjU3NDVkLTlhZmYtMTFlZC05YzRj?= =?iso-8859-1?Q?LTRjMDM0ZjVmOWI0ZmJvZHkudHh0IiBzej0iMTU4MiIgdD0iMTMzMTg5Mz?= =?iso-8859-1?Q?kyNjgzMzY4NDU0IiBoPSI2ZGJWOHU1Y2pob0RUVXh0SXpFeWdTRVVCbFE9?= =?iso-8859-1?Q?IiBpZD0iIiBibD0iMCIgYm89IjEiIGNpPSJjQUFBQUVSSFUxUlNSVUZOQ2?= =?iso-8859-1?Q?dVQUFOZ0hBQUFHQUw0R0RDL1pBVUZLZEpIRVYrOGRRVXAwa2NSWDd4ME1B?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBSEFBQUFCb0J3QUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBRUFBUUFCQUFBQTNUekZBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUo0QUFBQmhBR1FBWkFCeUFHVUFjd0J6QUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQU?= =?iso-8859-1?Q?dNQWRRQnpBSFFBYndCdEFGOEFjQUJsQUhJQWN3QnZBRzRBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBUUFBQUFBQUFBQUNBQUFBQUFDZUFBQUFZd0IxQUhN?= =?iso-8859-1?Q?QWRBQnZBRzBBWHdCd0FHZ0Fid0J1QUdVQWJnQjFBRzBBWWdCbEFISUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFCakFIVUFjd0IwQUc4QW?= =?iso-8859-1?Q?JRQmZBSE1BY3dCdUFGOEFaQUJoQUhNQWFBQmZBSFlBTUFBeUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-refone: =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVBQUFBQUFBQUFBZ0FBQUFBQW5nQU?= =?iso-8859-1?Q?FBR01BZFFCekFIUUFid0J0QUY4QWN3QnpBRzRBWHdCckFHVUFlUUIzQUc4?= =?iso-8859-1?Q?QWNnQmtBSE1BQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFBQUNlQUFBQVl3QjFB?= =?iso-8859-1?Q?SE1BZEFCdkFHMEFYd0J6QUhNQWJnQmZBRzRBYndCa0FHVUFiQUJwQUcwQW?= =?iso-8859-1?Q?FRQjBBR1VBY2dCZkFIWUFNQUF5QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFKNEFBQUJqQUhVQWN3QjBBRz?= =?iso-8859-1?Q?hBYlFCZkFITUFjd0J1QUY4QWN3QndBR0VBWXdCbEFGOEFkZ0F3QURJQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBRUFBQUFBQUFBQUFnQUFBQUFBbmdBQUFHUUFiQUJ3QUY4QWN3QnJBSGtB?= =?iso-8859-1?Q?Y0FCbEFGOEFZd0JvQUdFQWRBQmZBRzBBWlFCekFITUFZUUJuQUdVQVh3Qj?= =?iso-8859-1?Q?JBREFBTWdBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQVFBQUFB?= =?iso-8859-1?Q?QUFBQUFDQUFBQUFBQ2VBQUFBWkFCc0FIQUFYd0J6QUd3QVlRQmpBR3NBWH?= =?iso-8859-1?Q?dCakFHZ0FZUUIwQUY4QWJRQmxBSE1BY3dCaEFHY0FaUUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reftwo: QUFBQUFBQUFBQUJBQUFBQUFBQUFBSUFBQUFBQUo0QUFBQmtBR3dBY0FCZkFIUUFaUUJoQUcwQWN3QmZBRzhBYmdCbEFHUUFjZ0JwQUhZQVpRQmZBR1lBYVFCc0FHVUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUdVQWJRQmhBR2tBYkFCZkFHRUFaQUJrQUhJQVpRQnpBSE1BQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBUUFBQUFBQUFBQUNBQUFBQUFDZUFBQUFiUUJoQUhJQWRnQmxBR3dBYkFCZkFIUUFaUUJ5QUcwQWFRQnVBSFVBY3dBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBQT09Ii8+PC9tZXRhPg== x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR18MB4672:EE_|MW5PR18MB5126:EE_ x-ms-office365-filtering-correlation-id: 4c32a711-125e-4cb9-087d-08dafd232b61 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /E005sMnod+uxtiZ1cWOu9Dx4FIZwIcluPMGYUn4PXXEm8oXvVSoBC9/t3VbkWzZP6P3+69PNxrJadCMNK+7TTnGpcnxXF+PiNH4zym9OPdBRlrSA5SP8F2j8I/YkX5P2uLMKcFTVlOqrzEIEZPJhQYPtbZTR11l4+duULzkI+K1uogT1lDhv9iHd1YDBW5rus/QLbH1SHP7LN0ijy5tFuiyNNAURTjcfRXDvDxyEYdYeoEsxLrMfQT2+oA6+MAAKrhblXlxqwFxbMqNrBbXwqv8+ufDPfNnAmcj9XM1vYdolfrdParTvQq+fPp9MVWfWzcgRNBhTPmoKzEch3QkB+duVcZsD+i/IIzXdVBr1i2nscdyDg6qidElClvEKG8ydArS8XLZJ7/4Xt28SgaEs3AAwK10LYY2y9k1bcdsv0O6EznDGfncEJPHOAnailLtuRdVO3R1G1Db7u2XZK74JLkcBYPeF14UNE4TAdXNuQKyBZ7KWe9krKn6jq+PFkJPBuxjo5PREW8YJzudzttI7cVlMn1ShJeP69xgTl8U/NTj/YxQARwL+uZ6P7zeD/mJPDszoB71lUwqoMlhcSTHauT3P0UWTPvot7n2BjuQ0yTNPf/X24v5w7UzZqdAVnVz6Wqk++PzI+27Qm3fBbLvDY9OznTdmv74vMClodoYwlrI+8bQDfUpsRhY5jqukYdAmZjd+9vgIpFC73uqb37AD6VtRBTGFg9BbkUuyIYt2jM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4672.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39840400004)(346002)(396003)(136003)(376002)(366004)(451199015)(19627235002)(122000001)(33656002)(38100700002)(86362001)(38070700005)(2906002)(8936002)(5660300002)(52536014)(41300700001)(66476007)(76116006)(4326008)(66946007)(6916009)(66556008)(64756008)(8676002)(66446008)(55016003)(83380400001)(7696005)(71200400001)(966005)(54906003)(6506007)(9686003)(26005)(478600001)(316002)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?vV0VUB1cNRGratBunAtNnfyVcxuXtlbvbib+jDQ15VPR46+xvCeFGRqGuW?= =?iso-8859-1?Q?GALSNeV5tMhUPv4ZrIkGm9XcCnauW8iVvHJV2vCnBw8qOzGkS8JR3GdzzX?= =?iso-8859-1?Q?pm5/Ng/RYM3lyK4pogwy2RgLuZvkury/XYCPiF6dWRRHGJK/wqDKSijqPA?= =?iso-8859-1?Q?vXr8Ae8WnpY/vtVl7PZOOOX6LzhpJv7UAE2VO35wJC7zX697J9s2M3gidS?= =?iso-8859-1?Q?sn1VQo6Yb1hOxoNMyn+GV3aXD4DKDanvxdcLuVQs+/eTMN0u9/sNkh8Bzs?= =?iso-8859-1?Q?MnUTnEnoJ1KBFiXr2TR2dPMnpWEbH+bN0ZLJ96cS/N9LX5wM+XSSPzPV8P?= =?iso-8859-1?Q?1SehkenuiZnLbr2/CeBbiZP/FqBl681nj+r63dbkIctlx1P74fj0QQDcaR?= =?iso-8859-1?Q?RIlm8UU3U8YM9q8+RabNW1gsUarL58zXXE25wIQkBA+A16E4CyA39lyA+J?= =?iso-8859-1?Q?usxKnX+QTsbu06mmacRcj3v40znWruG1+PfAE206zxqortZktIt3yEXQKX?= =?iso-8859-1?Q?iOqnlnnfaEB0mWtyi2PUjbbbaY62HVkRZjFBwZBm6gk1Anf/jcP3LWHvYl?= =?iso-8859-1?Q?QcHDtXXiLWywoF4XxENNEvC8I1fHIzD8rljR7wNQ0Ul+QA/9msLMGgKk/k?= =?iso-8859-1?Q?32nnrtPFHjWmNVqOYqFkxCCiQPVuxM5QehOMd0E4uu4x/haWpTehlQpdji?= =?iso-8859-1?Q?ugDNMEkkK/Ej2K8ieqJBWkN50I/ABxCcVYZoZPOJ8U6lHFUznbL1DkqsrW?= =?iso-8859-1?Q?yWlwIxgtFpT1r6UA0fqpmolb5rIyt2Hhau/vxkBJbHJU/pTkZVF+SvOZA8?= =?iso-8859-1?Q?CPUgfGKYieaqdtvRvGG0h+YCOMtg7RzApDIHwJq0oWyAhp9uyo4X/oNlrp?= =?iso-8859-1?Q?7sCtXPrPUSj7YzSNFron+X1pIFCiHL2UKh+ab0s9DguZJPBD0h0ZAaJSOf?= =?iso-8859-1?Q?bpkBA8VTKLKWv4OTUSHNj94/aB3F0+inpwYGV162Hcd9jHRf9qjzO2HUFA?= =?iso-8859-1?Q?RroRhb42fOxTheDQ6CQ8V6pn6kXwwyIKvcJ4qxmwVH0kX3Lb8esgd8rwlJ?= =?iso-8859-1?Q?G4+CMwWWioq9w2Dh9FyqdQsGbkE3jdSnRWWAAxqwzAHVaiRuHrbNq7jhYw?= =?iso-8859-1?Q?SE2q6NKt/Fh3eVywrOlafzEBMB21TZRtpC0Ua5K04aI2g8EafwCVH6ev6G?= =?iso-8859-1?Q?bUW7q5MPYJoc0NIFB/tiuLhczM58kx89xh7o6KRQqLe0n/RzbTHwiykc0+?= =?iso-8859-1?Q?URvS11yPr6aPRtv7GbbScHlboLtj7Hab8dFzRC6tE3T/Vgx9cn8gBnxrrJ?= =?iso-8859-1?Q?QgRFYfo3h4EWitVqbdS5CR7cZa27HLoQn3sHiO4tdlZ4AbY+alvZ+XD6vo?= =?iso-8859-1?Q?SolOuwDj6w17FKAOx1mA2HuYSxDj0Hrp+zy8BWC4LFaF3CyWxd1XKPISJT?= =?iso-8859-1?Q?BXo60GV+JTEimCR0CO5r5eyTJHooDwcMlTMmG/1Fd57YwskB67a14TJt10?= =?iso-8859-1?Q?Tt4UaH2uqN283u0k8rwVCKAibVLgZlMKLPyX9jtI847Go2wyGq0xDmGNCy?= =?iso-8859-1?Q?z/7ZRfpX9Jd/gb9j0+Hm6jLZTCFRbMdvU8fOXS4Z1JgacJKiXSZNZIlg0H?= =?iso-8859-1?Q?fCeou2l8qwcxo=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4672.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c32a711-125e-4cb9-087d-08dafd232b61 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2023 09:21:11.9340 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IIYt1epqsplSSGoJCM9hhjeu/+ntANxVWc8CKFJc0I7K8SPkF33/9w/0CMsVxOwhvNZiLxY+tO0Nw66+9tWj+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR18MB5126 X-Proofpoint-GUID: c9EmM_2HcYvBBnmR1Me1ud49Q9RIfNUp X-Proofpoint-ORIG-GUID: c9EmM_2HcYvBBnmR1Me1ud49Q9RIfNUp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-23_05,2023-01-20_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Thomas, Please see inline. Thanks, Anoob > Subject: Re: [EXT] Re: [PATCH 1/5] net: add PDCP header >=20 > 18/01/2023 18:39, Anoob Joseph: > > > 22/12/2022 10:25, Anoob Joseph: > > > > --- /dev/null > > > > +++ b/lib/net/rte_pdcp_hdr.h > > > > @@ -0,0 +1,93 @@ > > > > +/* SPDX-License-Identifier: BSD-3-Clause > > > > + * Copyright(C) 2022 Marvell. > > > > + */ > > > > + > > > > +#ifndef _RTE_PDCP_HDR_H_ > > > > +#define _RTE_PDCP_HDR_H_ > > > > > > No need of extra underscores before and after. > > > > [Anoob] I was following the example quoted in > https://urldefense.proofpoint.com/v2/url?u=3Dhttps- > 3A__doc.dpdk.org_guides_contributing_coding- > 5Fstyle.html&d=3DDwICAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DjPfB8rwwviRSxyL > Ws2n6B-WYLn1v9SyTMrT5EQqh2TU&m=3DBtr0wWqHo_dHGchyRWTnjO6xY- > 7p33pUSKSBLIXtL4DOAv-GsZmL2lZ2OHyJWoiZ&s=3D- > AQhSWF0bWFXTyxL0rPCW6fz6I7GYhwyQ9qjYG3FFn0&e=3D . >=20 > Oh thanks for the reference, I will fix it. >=20 > > Also, other files such as rte_esp.h, rte_udp.h, etc. follow the same. >=20 > Some other files don't have underscores. >=20 > > Isn't it better to have a uniform coding style? >=20 > No really I prefer no underscores, > they are supposed to be used for standard libraries. [Anoob] I see that most of the files do have underscores. While I do not ha= ve any personal preference, I would really prefer new code to not stand out= from the rest. If you have considered this already, then I'll make the cha= nge in next version. Please confirm.