* [PATCH] crypto/cnxk: fix condition check
@ 2022-06-09 9:27 Volodymyr Fialko
2022-06-09 10:31 ` Anoob Joseph
0 siblings, 1 reply; 3+ messages in thread
From: Volodymyr Fialko @ 2022-06-09 9:27 UTC (permalink / raw)
To: dev, Ankur Dwivedi, Anoob Joseph, Tejasree Kondoj,
Abhinandan Gujjar, Akhil Goyal, Volodymyr Fialko, Fan Zhang
Cc: jerinj
The value of ec_mdata cannot be NULL, instead check that value of
private_data_offset was set.
Fixes: c3a498c01121 ("crypto/cnxk: add event metadata set operation")
Coverity issue: 378861
Coverity issue: 378865
Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
---
drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 4 ++--
drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/crypto/cnxk/cn10k_cryptodev_ops.c b/drivers/crypto/cnxk/cn10k_cryptodev_ops.c
index c811504f93..f4aaa273c1 100644
--- a/drivers/crypto/cnxk/cn10k_cryptodev_ops.c
+++ b/drivers/crypto/cnxk/cn10k_cryptodev_ops.c
@@ -363,10 +363,10 @@ cn10k_ca_meta_info_extract(struct rte_crypto_op *op,
uint8_t cdev_id;
uint16_t qp_id;
+ if (unlikely(op->private_data_offset == 0))
+ return -EINVAL;
ec_mdata = (union rte_event_crypto_metadata *)
((uint8_t *)op + op->private_data_offset);
- if (!ec_mdata)
- return -EINVAL;
rsp_info = &ec_mdata->response_info;
cdev_id = ec_mdata->request_info.cdev_id;
qp_id = ec_mdata->request_info.queue_pair_id;
diff --git a/drivers/crypto/cnxk/cn9k_cryptodev_ops.c b/drivers/crypto/cnxk/cn9k_cryptodev_ops.c
index 10e7bb6e52..d9d41f9dab 100644
--- a/drivers/crypto/cnxk/cn9k_cryptodev_ops.c
+++ b/drivers/crypto/cnxk/cn9k_cryptodev_ops.c
@@ -419,10 +419,10 @@ cn9k_ca_meta_info_extract(struct rte_crypto_op *op,
uint8_t cdev_id;
uint16_t qp_id;
+ if (unlikely(op->private_data_offset == 0))
+ return -EINVAL;
ec_mdata = (union rte_event_crypto_metadata *)
((uint8_t *)op + op->private_data_offset);
- if (!ec_mdata)
- return -EINVAL;
rsp_info = &ec_mdata->response_info;
cdev_id = ec_mdata->request_info.cdev_id;
qp_id = ec_mdata->request_info.queue_pair_id;
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH] crypto/cnxk: fix condition check
2022-06-09 9:27 [PATCH] crypto/cnxk: fix condition check Volodymyr Fialko
@ 2022-06-09 10:31 ` Anoob Joseph
2022-06-15 15:45 ` Akhil Goyal
0 siblings, 1 reply; 3+ messages in thread
From: Anoob Joseph @ 2022-06-09 10:31 UTC (permalink / raw)
To: Volodymyr Fialko, dev, Ankur Dwivedi, Tejasree Kondoj,
Abhinandan Gujjar, Akhil Goyal, Volodymyr Fialko, Fan Zhang
Cc: Jerin Jacob Kollanukkaran
> Subject: [PATCH] crypto/cnxk: fix condition check
>
> The value of ec_mdata cannot be NULL, instead check that value of
> private_data_offset was set.
>
>
> Fixes: c3a498c01121 ("crypto/cnxk: add event metadata set operation")
> Coverity issue: 378861 Coverity issue: 378865
>
> Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
Acked-by: Anoob Joseph <anoobj@marvell.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH] crypto/cnxk: fix condition check
2022-06-09 10:31 ` Anoob Joseph
@ 2022-06-15 15:45 ` Akhil Goyal
0 siblings, 0 replies; 3+ messages in thread
From: Akhil Goyal @ 2022-06-15 15:45 UTC (permalink / raw)
To: Anoob Joseph, Volodymyr Fialko, dev, Ankur Dwivedi,
Tejasree Kondoj, Abhinandan Gujjar, Volodymyr Fialko, Fan Zhang
Cc: Jerin Jacob Kollanukkaran
>
> > Subject: [PATCH] crypto/cnxk: fix condition check
> >
> > The value of ec_mdata cannot be NULL, instead check that value of
> > private_data_offset was set.
> >
> >
> > Fixes: c3a498c01121 ("crypto/cnxk: add event metadata set operation")
> > Coverity issue: 378861 Coverity issue: 378865
> >
> > Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
>
> Acked-by: Anoob Joseph <anoobj@marvell.com>
Applied to dpdk-next-crypto
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-15 15:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-09 9:27 [PATCH] crypto/cnxk: fix condition check Volodymyr Fialko
2022-06-09 10:31 ` Anoob Joseph
2022-06-15 15:45 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).