From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 90F3045891; Thu, 29 Aug 2024 07:49:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3D1E0427AC; Thu, 29 Aug 2024 07:49:07 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 538B9402BE for ; Thu, 29 Aug 2024 07:49:05 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 47T4YWs3022992; Wed, 28 Aug 2024 22:49:00 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2169.outbound.protection.outlook.com [104.47.57.169]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 41aj3406wq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Aug 2024 22:48:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tnaWk/IVK6EpfvLYHqdMFV0m2VxAxGBKvpi3zVVLthMFMkPSdrY3AVvbIHosogc/hDGIKEjMA6mXYNtNfk0eSNC5VwEFcDg9BZBPCOe8DyDNIjw62/KKcSqAXZg1gWfBghB59buPzRxs0NHYbV/t4YOLtu8z+VBfHWSjVeleu4RpJVgAy2AIZgMO1XKTJYAeInfTXQhO+YZ/sXnpxCk5GpYX/iJ1sNGuJ6ZHYgi74Db4KMXA0C7hQFG2C7joMzwZqyOlfDK/wCS4uK8J+4hpdVZAR1CxUh/cQdxj5a+usFQkTkvubOEuPBiFyQnLv+VRrv8f7rlx+hVAL4KKO962nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vj6mj6zutsR4vu8PS/YpG6X1uf4T38JG5/zM6cJw43Y=; b=khUsG8RaQ/LdClrYjlomj5a6STBka4pR2Kq7Yk0om/n9FQ6RuDAImtmx9uLPK2Xkm7q+KSXK1jPh+bW8SwjQ0gkTc/orm+Yp4xRr4s4oLmgRRSI2wfTB72zQwvx1r6ozrOy/Iv+QcqdQcT5JEhbeC7GUcG9wExj8PSP52F52j26nugBS1mu+UwXR70WP+it55s44CnfrPkoWOQ8dJwN8sbH1nUFrEJWodbMizSEvy54Mu+7QSmWM6tPUui24AWvt+f4CoPx0MAvCLx9swLUcdX3r6sEx7A/nIq15FXgZk0Rq4kb8oJgd9OoO+4j/HVLF1j2yPfmkwBEUJsuwPSTMIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vj6mj6zutsR4vu8PS/YpG6X1uf4T38JG5/zM6cJw43Y=; b=AggaAAPdtSZz/cF9BOikVR/AIlyd/NrC2Ld2UqaQUyDR0CbM3Ue2KUmDJyfWEK2j1qnnPCm1IXLzIbe00B31U4cyBCcXV1MV3zs3GARDOTtPN4mP3JiwuflgUdrBSNCDOah+daHU4WaChtcDAoka2e/UVlfAckGwIsaJh7PPMiI= Received: from PH0PR18MB5071.namprd18.prod.outlook.com (2603:10b6:510:16b::15) by PH0PR18MB4573.namprd18.prod.outlook.com (2603:10b6:510:a6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.27; Thu, 29 Aug 2024 05:47:55 +0000 Received: from PH0PR18MB5071.namprd18.prod.outlook.com ([fe80::25e:7:91b:8f1c]) by PH0PR18MB5071.namprd18.prod.outlook.com ([fe80::25e:7:91b:8f1c%4]) with mapi id 15.20.7897.027; Thu, 29 Aug 2024 05:47:55 +0000 From: Kiran Kumar Kokkilagadda To: Robin Jarry , "dev@dpdk.org" , Jerin Jacob , Nithin Kumar Dabilpuram , Zhirun Yan Subject: RE: [EXTERNAL] [PATCH dpdk] graph: make graphviz export more readable Thread-Topic: [EXTERNAL] [PATCH dpdk] graph: make graphviz export more readable Thread-Index: AQHa+VAqbrykLO8Vpk6P06bI1F+mdbI9u0/w Date: Thu, 29 Aug 2024 05:47:55 +0000 Message-ID: References: <20240828134226.866655-2-rjarry@redhat.com> In-Reply-To: <20240828134226.866655-2-rjarry@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR18MB5071:EE_|PH0PR18MB4573:EE_ x-ms-office365-filtering-correlation-id: a6f9d7a8-ed1c-4f09-4736-08dcc7ee2123 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|1800799024|366016|38070700018; x-microsoft-antispam-message-info: =?utf-8?B?NEp6VENtM2x0Z2F3bHNqak5ncDkvUW4rc0lXRzM0NE1vMkJOdEF1WVFmbEVS?= =?utf-8?B?TW5TdFRrVEtxclNadnZjQ1F6b2JJY01vRVpLZFEzYmdDYW5CSUlsaDhEUGVx?= =?utf-8?B?QytycGV6T0pzckJiaHRzVTVjblZZQWJwQnlqQVdlZFNGUi9GMmt3a1BMalpi?= =?utf-8?B?T0pYY21wRHVKckIwNmw2SmNpUFo5RnozVitMak44QldyZjBRcWNFMTZGYldn?= =?utf-8?B?Z2F1c3dVYzIvUTcvd09zaXQvVHUrNVQ3U3VnM2dDY3Y5cExFaEhXUFpmemkv?= =?utf-8?B?eTJkSytZa1dObUxqZzRZQ0dJUndxUHFlWi9UOVNDdWxrRVhTOHVqQTg0bnpH?= =?utf-8?B?dXB5QWpNTzZ2UjNWdWMwZFZUeXpVNDZOa2pNcjNjV3ZCdTI0ZlZUZkFsYTNO?= =?utf-8?B?OVdraDNvZnRQRXNMZ2NCZTIwZkRwNE41OWRWWEE5SUxISFFRS2dNM0Rod2M0?= =?utf-8?B?NUs2OGFKbkJUd3pDS3hHTnBtNnRzcFI5Q0RQT0gwaFdOVDM5TUJvY2o3MGJj?= =?utf-8?B?SUtNMXZ3eEdTa01oZ0oxVGxDblM3NWhmOElwOFBySWM0cVVLNjdIdUZjRnFv?= =?utf-8?B?VFZiU05EM0dyM2tXZDRyR29RSlZ3eng3TEdicUttNkRpRldwTXhleG1xb3ZQ?= =?utf-8?B?RDlmYi9NMzNmd3ZZbVlqK29IUzlkeEJsQVI3U1ByZDVpZGpyWWZlUHBuNU4x?= =?utf-8?B?Y0R0L2NOY2h0d3VubDlLdm90SXNkcHpySGxEdVYxZXhLdmNvOGlSTnJHOVNM?= =?utf-8?B?UUY2SG9qZ0lBMVZDUGlxb2FoMFlXTnc2NndyekErRTFjR2lkY21NVFQ4RFBy?= =?utf-8?B?Y1JCMktMZXZCUjVkQ1BReFRnb2lnK09QcmxnRjJnK09JTmo2NTRGaitPVjR0?= =?utf-8?B?TStFd0g1cjcrKytvWmdxREJxTXNCekozL01ZWUxKMUYzQ3E0SFozQmhFQTJh?= =?utf-8?B?WVptUVppVldIaFJCQVFGaXNSNmRKeDR5UGZxbVErRlBpRVZockptWGtLTlJl?= =?utf-8?B?OFR4MjV5YXR0T0RSSVN4WjgxMXVHT2grTmF6ajdRczZvc2xHZ29YYWpDZUpK?= =?utf-8?B?WWQyM0dlQzJ0ZkRpbk9OeXRwY3ZjZUE1L0IzRjNkeFEzaitHRmlaOFUva1Zw?= =?utf-8?B?SjlGTEVwU2VtTSt5NHR3YkR6V0EwV1BOaEM1WDRUZUFWRFVPODNWSXduemZv?= =?utf-8?B?R01zdzhoeHJzckpwMVJ2dFZTamxCQ1dqakNKdFpoUmFYeFpVSjJxZzRYaGRS?= =?utf-8?B?V1FkRnRHNU03Qm5qaWZUbVlSL3pIY0ZtaVdxRmRJV2tqUjlXWEVtSnJVZVVV?= =?utf-8?B?Y3Q0ckplSEdaUm5VVWc3MWtVc2pwYkROME1kL1I5ZEI5YXZqYmJNbXhaVDQw?= =?utf-8?B?YjZhUlVGVHhQeEJ5T0ppbDZqSlIxdEZsS1pXVm81UVA3UWp4SzJBSlNkcUFE?= =?utf-8?B?RFJRU2xWaSs0aW11Z2JheFBtQXRKMS9kdHI3NkRqakJKNXJRSVUvSUpxL1Bs?= =?utf-8?B?U0ZSN3dJS2hCbDM2V1JTc0YzQ0ZxSG9DZnBJNHc5bVdGaURrVUhGbWMyck0w?= =?utf-8?B?cDA5LzJidjFXOTEvdFpLNlM5S2JoWWk3OTRVLzdJSFFxeDFxeHo3NTIzd2Nk?= =?utf-8?B?WDkwKzArWU9nVC8veGdKdkFMLzhVKzUrdlJyUDZCWGVwNlRLSHh3bTNqdjVH?= =?utf-8?B?dWgxOWplWDM4QmtaNEdXNnI1MEVsQkZaZW83b2hoS0VUQkd1SERFM0tmWENN?= =?utf-8?B?dG1tQnQ2KzZwRFdzc1NoOThmemx4RHV4NlAxVCtYTGFRMzgwZ1p5V0lFZ1R0?= =?utf-8?Q?SHKNsce+g2WQeaU0+KqzQ87RwkERzHLDHe2NM=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB5071.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bzgwditCaFhRWEVSR2ZtQmozUVpHU0szUUNJOWpkWjNpY01vdmc5NnlSWlVj?= =?utf-8?B?V0xPQnNvaFBkUzBNVS9rS2N0MWZucHpaTjdOR09BK2hpaXlWMWVMa0xtY1Vh?= =?utf-8?B?WTBZVWZNclRYakU1QVpZajV1eG05SmFVUEtscnhoblJ3OEFjdzR5aEJsL2FB?= =?utf-8?B?V1pUWVFmYkVhTnRkSUF3cVdxeWJYMWZhNnoxdjhXV0dRbkJzNEwzVi9vNDg4?= =?utf-8?B?bEkwWXVWd1lGTy96dmgwdnA0NUNWSDhwSWltSnRTR1VCV3VCQmZyUHNkLy9s?= =?utf-8?B?dEJjSkR5WmJXTENBUXJlbXhCWGlOMVVDTUpveXdZMzBaVXJBTWxtdC9kbGtB?= =?utf-8?B?ZW4zVE0xdWZUakhyV1ltRWFEZmZHSE4wZ3NjZmtuQmFITytpUFZ5b0JjTExB?= =?utf-8?B?TUlYMFlwODNFZ2krQy95aFhxVlpJTlhuSGhkZHJrcjQ0UXU2em1iNkd0Z3di?= =?utf-8?B?dFN6UDZJdW1UQlZuSkd2alNyK3FFY3RxYTdFdVZ0U2hOcEkxRElWdjNHQUFP?= =?utf-8?B?U0tPbmdqMzdRTVQrUjQ3U2N2bys3QkhLRzQrNTZ6Z1IwaGtvM0hZOWZHbXBh?= =?utf-8?B?SWRDWXoydFc3SzJuS2hlanF5M1hRb0gxRWNUa3hLMm5BNERnUDFaRTFRcmxK?= =?utf-8?B?S3p1aGNneHM5dStmcmJyd0dVamRIV1V6ZllmVXVrNVo5RHFzWGVBb043bUFn?= =?utf-8?B?QkhRVC9kNDU4TDR6OUZkTEdFQ1dZZmtoR1I5cTJQa0N3N0dkdFFxVXpKNGVC?= =?utf-8?B?dFNnWTlZREIzVnJ5TnB3Z3lHUXZyZXE4b05OK2RqR0ZiZ0dwdDhVNXBEekNw?= =?utf-8?B?b0tWNFJNdWlIZzVlQll2Y1lMTVdUMHFVSVpZWFJsK08vcWc1Q2VWZXJTV2ZE?= =?utf-8?B?R2ZRWTVTcnVpWlpFUlA3dFcxajRHcFBmeUZaUThLYVlvQmlSTndBbFluWm5C?= =?utf-8?B?SWpiN3lMT3YwUHFnTGJNTXhDMEk1cGcwR1JKam5Rem1vdndvY1NJR3dueGhX?= =?utf-8?B?b1k1c0V3NlZFak9aMXpVYVk0dFFDaWxWcnhUaGpSbXZSZ0h3MjRYeVpIanBk?= =?utf-8?B?a3VKM0RWL1JpL2FNN2RuWWFwVC9rTHk0cnBNQXliWW9NMWdlNDgrc1FNc09F?= =?utf-8?B?M2d5blhJQmprUHlrV0E2emtLdkRXdmk4WHJHMktZUlN6S3BmN3lOb0tWVDlC?= =?utf-8?B?eDFnaVl4WFp5bzBlSyt4ZU96NGVwa1ozWis5empXTjlCOXlWQWFUUGN2WFBR?= =?utf-8?B?OGprcWlXS2l0bFREWDlCNS9hMXVlS3BJU0Q3TjVWcjhXVFZsdW1OcUpaMlJI?= =?utf-8?B?QkFocTd6cXZuTUVPeGI2dSsvUG45ejBzbkh3OFZtVjZQQWdwelEwd2RCSjNp?= =?utf-8?B?eUI2WE0wblBOeFZUcWVBNzN1Y21pTGVtRWdIY1Y5bFhzZ1FOcFZwUDNUUW5D?= =?utf-8?B?dnVvb0NaZVJXNFJ6YVZVRHJveU1lUDNRZ05DbWxpUE40Z2RxdXB1VlBWZzJI?= =?utf-8?B?a0RLbDFDNXRweU9CeklpT3RTZEhaUnpyY1FIL1pmSlplZ1VJL3YzSkQ0UVFM?= =?utf-8?B?OGY5UTV1OEpleHpzVjEvbjB2L2FhczNEeWVla2tzVW0xd1BRZUtYVUUwM1Mz?= =?utf-8?B?T3hMNklJS3lRTWdTLzJkYXVHT2dZL296Smp1VVRVeWRRa1dmczRweUt4dHBr?= =?utf-8?B?WS9senVpS0xiaVVKYVJZSXNOVnFvUW1URjNsaTZkNytHcE5Wc0c5MHNJRk9J?= =?utf-8?B?SW5jUlduL05KTHo0clgyMXZjV2ZNYWs4Y1NWb1BybFo0amgvS1lsRGpUL283?= =?utf-8?B?dDJKUzBmZVVGb25neVdTbk1BSEZxMXlBWlowWW52a0t5WTYycEhSQlQzc1RS?= =?utf-8?B?RW40aE9YU1BDcDJGK0duU2hYL1R3U2RSTEh6S296YVRXdlNjUytPeDZ3eUNz?= =?utf-8?B?VXYvU0xzSUV2MDNudEFoODdHQ1N1NFc4TDFXcnI2VUl6MUsrc3MxUkN4L3N6?= =?utf-8?B?bFdRMDZhbThYMWZ1THd0dFAvZTJiU3piOUJqZGo0K1lYUExzNWVWeENKcTM2?= =?utf-8?B?N3hwbVE2NlF5SGNYd2kyMXlkQy8vZ3pJWC85MWZhVHZYUWZUQXduUjRxV3ox?= =?utf-8?Q?Ty0cXqxvvD6yW9/uGxLM1N2tQ?= MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB5071.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a6f9d7a8-ed1c-4f09-4736-08dcc7ee2123 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Aug 2024 05:47:55.1463 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6uxHpUiKdP/ullxEfJlPol6Y/zngPBBc2b+tMQBV81AA+VW0kBBIh5Xit7lnyQ2eocax9nBy6gMClwUG4tNHUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB4573 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: c-KuAXF-aSDV4YtUu1R2EyfOrepvVovz X-Proofpoint-ORIG-GUID: c-KuAXF-aSDV4YtUu1R2EyfOrepvVovz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-08-29_02,2024-08-29_01,2024-05-17_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Robin Jarry > Sent: Wednesday, August 28, 2024 7:12 PM > To: dev@dpdk.org; Jerin Jacob ; Kiran Kumar Kokkilaga= dda > ; Nithin Kumar Dabilpuram > ; Zhirun Yan > Subject: [EXTERNAL] [PATCH dpdk] graph: make graphviz export more readable >=20 > Change the color of arrows leading to sink nodes to dark orange. Remove t= he > node oval shape around the sink nodes and make their text dark orange. Th= is > results in a much more readable output for large graphs. See the link bel= ow for an > example.=20 > Change the color of arrows leading to sink nodes to dark orange. Remove t= he > node oval shape around the sink nodes and make their text dark orange. Th= is > results in a much more readable output for large graphs. > See the link below for an example. >=20 > Link: https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__f.jarry.cc_r= te- > 2Dgraph- > 2Ddot_ipv6.svg&d=3DDwIDAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DowEKckYY4FTmil1 > Z6oBURwkTThyuRbLAY9LdfiaT6HA&m=3DD41w8N- > HiTO9kFbxr3kWwW4TVmWav2Zozr9byDbHSj7TRx6egfC1ut70K2HKJQ0y&s=3D0gZZ > VRoev4w7I_KowoRkSn40vymIJgyxS8vBPgEk90c&e=3D > Signed-off-by: Robin Jarry > --- Acked-by: Kiran Kumar Kokkilagadda > lib/graph/graph.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) >=20 > diff --git a/lib/graph/graph.c b/lib/graph/graph.c index > d5b8c9f918cf..dff8e690a80d 100644 > --- a/lib/graph/graph.c > +++ b/lib/graph/graph.c > @@ -745,7 +745,7 @@ graph_to_dot(FILE *f, struct graph *graph) > if (rc < 0) > goto end; > } else if (graph_node->node->nb_edges =3D=3D 0) { > - rc =3D fprintf(f, " [color=3Ddarkorange]"); > + rc =3D fprintf(f, " [fontcolor=3Ddarkorange shape=3Dplain]"); > if (rc < 0) > goto end; > } > @@ -753,9 +753,12 @@ graph_to_dot(FILE *f, struct graph *graph) > if (rc < 0) > goto end; > for (i =3D 0; i < graph_node->node->nb_edges; i++) { > + const char *node_attrs =3D attrs; > + if (graph_node->adjacency_list[i]->node->nb_edges =3D=3D > 0) > + node_attrs =3D " [color=3Ddarkorange]"; > rc =3D fprintf(f, "\t\"%s\" -> \"%s\"%s;\n", node_name, > graph_node->adjacency_list[i]->node- > >name, > - attrs); > + node_attrs); > if (rc < 0) > goto end; > } > -- > 2.46.0