RE: [PATCH v4 5/5] node: add error stats for ip4 reassembly node

[Kiran Kumar Kokkilagadda <kirankumark@marvell.com>]

[-- Attachment #1: Type: text/plain, Size: 1913 bytes --]



> -----Original Message-----
> From: pbhagavatula@marvell.com <pbhagavatula@marvell.com>
> Sent: Friday, August 16, 2024 8:39 PM
> To: Jerin Jacob <jerinj@marvell.com>; Nithin Kumar Dabilpuram
> <ndabilpuram@marvell.com>; Kiran Kumar Kokkilagadda
> <kirankumark@marvell.com>; zhirun.yan@intel.com; Pavan Nikhilesh
> Bhagavatula <pbhagavatula@marvell.com>
> Cc: dev@dpdk.org
> Subject: [PATCH v4 5/5] node: add error stats for ip4 reassembly node
> 
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> 
> Add reassembly failure error counter for ip4 reassembly node.
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
Acked-by: Kiran Kumar Kokkilagadda <kirankumark@marvell.com>

>  lib/node/ip4_reassembly.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/lib/node/ip4_reassembly.c b/lib/node/ip4_reassembly.c index
> 04823cc596..ab71ef1331 100644
> --- a/lib/node/ip4_reassembly.c
> +++ b/lib/node/ip4_reassembly.c
> @@ -120,6 +120,7 @@ ip4_reassembly_node_process(struct rte_graph *graph,
> struct rte_node *node, void
>  		rte_node_next_stream_put(graph, node,
> RTE_NODE_IP4_REASSEMBLY_NEXT_PKT_DROP,
>  					 dr->cnt);
>  		idx += dr->cnt;
> +		NODE_INCREMENT_ERROR_ID(node, 0, dr->cnt, dr->cnt);
>  		dr->cnt = 0;
>  	}
> 
> @@ -165,11 +166,19 @@ ip4_reassembly_node_init(const struct rte_graph
> *graph, struct rte_node *node)
>  	return 0;
>  }
> 
> +static struct rte_node_errors ip4_reassembly_errors = {
> +	.nb_errors = 1,
> +	.err_desc = {
> +		[0] = "ip4_reassembly_error",
> +	},
> +};
> +
>  static struct rte_node_register ip4_reassembly_node = {
>  	.process = ip4_reassembly_node_process,
>  	.name = "ip4_reassembly",
> 
>  	.init = ip4_reassembly_node_init,
> +	.errs = &ip4_reassembly_errors,
> 
>  	.nb_edges = RTE_NODE_IP4_REASSEMBLY_NEXT_PKT_DROP + 1,
>  	.next_nodes = {
> --
> 2.25.1


[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 15957 bytes --]