DPDK patches and discussions
 help / color / mirror / Atom feed
From: Kiran Kumar Kokkilagadda <kirankumark@marvell.com>
To: Huichao Cai <chcchc88@163.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
	Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
	"yanzhirun_163@163.com" <yanzhirun_163@163.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: RE: Re:RE: [EXTERNAL] [PATCH] test/graph: fix graph autotest second test failure
Date: Wed, 23 Oct 2024 12:42:51 +0000	[thread overview]
Message-ID: <PH0PR18MB5071FEC0611D87DCF49E4941AC4D2@PH0PR18MB5071.namprd18.prod.outlook.com> (raw)
In-Reply-To: <7ee78c74.2f25.192b743020c.Coremail.chcchc88@163.com>



> -----Original Message-----
> From: Huichao Cai <chcchc88@163.com>
> Sent: Wednesday, October 23, 2024 8:15 AM
> To: Kiran Kumar Kokkilagadda <kirankumark@marvell.com>
> Cc: Jerin Jacob <jerinj@marvell.com>; Nithin Kumar Dabilpuram
> <ndabilpuram@marvell.com>; yanzhirun_163@163.com; dev@dpdk.org
> Subject: Re:RE: [EXTERNAL] [PATCH] test/graph: fix graph autotest second test
> failure
> 
> At present rte_graph_destroy will only clean up the struct rte_node and struct
> graph_node, not the struct node, rte_node_clone creates the struct node,
> inserts the global node_list linked list, there is no function to clean up the
> node_list 
> 
> At present rte_graph_destroy will only clean up the struct rte_node and struct
> graph_node,
> 
> not the struct node, rte_node_clone creates the struct node, inserts the global
> node_list linked list,
> 
> there is no function to clean up the node_list linked list, if you want to clean up
> the node
> 
> created by rte_node_clone, Perhaps a new function needs to be added to
> clean up node_list linked lists.
> 
> Or write a test case function to clean up the nodes that are cloned by this test
> case.

It makes sense to have an API to clean up the nodes. Are you planning to add this?
If not, we can plan and add new API.





      reply	other threads:[~2024-10-23 12:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-22 11:28 Huichao cai
2024-10-22 13:38 ` [EXTERNAL] " Kiran Kumar Kokkilagadda
2024-10-23  2:44   ` Huichao Cai
2024-10-23 12:42     ` Kiran Kumar Kokkilagadda [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR18MB5071FEC0611D87DCF49E4941AC4D2@PH0PR18MB5071.namprd18.prod.outlook.com \
    --to=kirankumark@marvell.com \
    --cc=chcchc88@163.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=ndabilpuram@marvell.com \
    --cc=yanzhirun_163@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).