From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 848BC41B7E; Mon, 30 Jan 2023 11:18:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6093740EDE; Mon, 30 Jan 2023 11:18:53 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id A103840C35 for ; Mon, 30 Jan 2023 11:18:52 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30U8ZlwF001590; Mon, 30 Jan 2023 02:18:52 -0800 Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2042.outbound.protection.outlook.com [104.47.66.42]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3nd442grd4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Jan 2023 02:18:51 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ja4lU5hkW6DJ7XZC43NiETTXlP83KSLsjz89FbepjcqpPVnwL8OqmNjae6y++AHOh155r+WLU6dAufB/tFFm5BAI5RV88ftsNFKZiTXkI+Nmdoc0RjwSmGUW1y9PnLjIyixgsTLQ5igQxXNoWqQNTukCEO8yZFwzhC9OSONGBrYuRKONvFaTiDWxOowwzMs6h6QfosoR9vNSKgHRQ8Y9JOo6qEpJg/3JWKIGfoNlbMqcOkIcWvky/mpBW3Sb5xfOff8MhY1wApG/KRNMsvqAgZUGlz42UE9WjqYYPax8EZMLEdVnzrbe9tTJ9g6oBBx0iPUbFEsiPbFNeVS966RVtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KU7o6p16UqpX1oG3i50tR5aZSWrd0nKvhuE/rGUtJWU=; b=MlLFK+VszU0xz3i7rbHL9T+74Vv9e8IOJIn87LjR/9ak9AXZhN4nOK0dUSgC+mzdWPVPT7AASFuu9Rg6qX1sZGCoHivaZF3eBhI2EHSPOJ32lAVqtQsCllo6KxQLVbVEiALfLI1+ZP5f/KZr+EJ1pMq2Rm/7boqt0AbTEgvl+/CN7mpyrTXhFBIpCF0Rczmr+LY3kn0KtdN9pMlkoxK79k9rjz4iW9ffugHPT9AJrGipagZaSlrn5auO3TxY5aNvTplszlrggrSqRwKUaq3bya1SxMh4ttREDRrXnI50AKBMdmzIqLiYfC7D0kfRFR5p9UdRjv5K+GWeKV/5qRZ0ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KU7o6p16UqpX1oG3i50tR5aZSWrd0nKvhuE/rGUtJWU=; b=ZExijlJcnUvAvwzKSwg5rzX5fBiHW94C4sU5H3ptDW80BDfk3DGHT+8W9ZZEbpK5o9G49Vr1c4l5Km/bqZskl/XT++n16SuGA3cdaQmYHn4PpmA5XqWDYnGbbqXq1G1LMLO+fQLesiRraAEwy8QXPTnO0ZKXcxf/1r8ZVrkbAVM= Received: from PH0PR18MB5167.namprd18.prod.outlook.com (2603:10b6:510:168::7) by PH8PR18MB5292.namprd18.prod.outlook.com (2603:10b6:510:25c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33; Mon, 30 Jan 2023 10:18:48 +0000 Received: from PH0PR18MB5167.namprd18.prod.outlook.com ([fe80::71b3:f3d6:e353:ae39]) by PH0PR18MB5167.namprd18.prod.outlook.com ([fe80::71b3:f3d6:e353:ae39%9]) with mapi id 15.20.6043.033; Mon, 30 Jan 2023 10:18:48 +0000 From: Amit Prakash Shukla To: "david.marchand@redhat.com" CC: "dev@dpdk.org" , Jerin Jacob Kollanukkaran , "bruce.richardson@intel.com" , "ciara.power@intel.com" , "dmitry.kozliuk@gmail.com" , Anatoly Burakov Subject: RE: [PATCH v7] mem: telemetry support for memseg and element information Thread-Topic: [PATCH v7] mem: telemetry support for memseg and element information Thread-Index: AQHY6HIMw07gtCluZ0ic/8YxH/ekDK5g/2sQgFZYDJA= Date: Mon, 30 Jan 2023 10:18:48 +0000 Message-ID: References: <20221025115138.4071745-1-amitprakashs@marvell.com> <20221025130216.4141896-1-amitprakashs@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-ref: =?us-ascii?Q?PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcYW1pdHByYWth?= =?us-ascii?Q?c2hzXGFwcGRhdGFccm9hbWluZ1wwOWQ4NDliNi0zMmQzLTRhNDAtODVlZS02?= =?us-ascii?Q?Yjg0YmEyOWUzNWJcbXNnc1xtc2ctNzhlZDI0NjQtYTA4Ny0xMWVkLWI2Y2Ut?= =?us-ascii?Q?MDBlMDRjY2FkNzJiXGFtZS10ZXN0XDc4ZWQyNDY2LWEwODctMTFlZC1iNmNl?= =?us-ascii?Q?LTAwZTA0Y2NhZDcyYmJvZHkudHh0IiBzej0iMTg2NTIiIHQ9IjEzMzE5NTQ3?= =?us-ascii?Q?NTIzODMzNDAwMSIgaD0ibkJGRmNYcmNidzcvSnoyOFlvM3FDRkIxNXhvPSIg?= =?us-ascii?Q?aWQ9IiIgYmw9IjAiIGJvPSIxIiBjaT0iY0FBQUFFUkhVMVJTUlVGTkNnVUFB?= =?us-ascii?Q?TmdIQUFBeExrVTdsRFRaQWN3dCt3S1F2TXNpekMzN0FwQzh5eUlNQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUhBQUFBQm9Cd0FBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUVBQVFBQkFBQUEzVHpGQUFBQUFBQUFBQUFBQUFBQUFKNEFBQUJo?= =?us-ascii?Q?QUdRQVpBQnlBR1VBY3dCekFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBRUFBQUFBQUFBQUFnQUFBQUFBbmdBQUFHTUFkUUJ6QUhRQWJ3QnRB?= =?us-ascii?Q?RjhBY0FCbEFISUFjd0J2QUc0QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQVFBQUFBQUFB?= =?us-ascii?Q?QUFDQUFBQUFBQ2VBQUFBWXdCMUFITUFkQUJ2QUcwQVh3QndBR2dBYndCdUFH?= =?us-ascii?Q?VUFiZ0IxQUcwQVlnQmxBSElBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUJBQUFBQUFBQUFBSUFBQUFBQUo0QUFB?= =?us-ascii?Q?QmpBSFVBY3dCMEFHOEFiUUJmQUhNQWN3QnVBRjhBWkFCaEFITUFhQUJmQUhZ?= =?us-ascii?Q?QU1BQXlBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-refone: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFu?= =?us-ascii?Q?Z0FBQUdNQWRRQnpBSFFBYndCdEFGOEFjd0J6QUc0QVh3QnJBR1VBZVFCM0FH?= =?us-ascii?Q?OEFjZ0JrQUhNQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBUUFBQUFBQUFBQUNBQUFBQUFDZUFBQUFZd0IxQUhNQWRB?= =?us-ascii?Q?QnZBRzBBWHdCekFITUFiZ0JmQUc0QWJ3QmtBR1VBYkFCcEFHMEFhUUIwQUdV?= =?us-ascii?Q?QWNnQmZBSFlBTUFBeUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQkFB?= =?us-ascii?Q?QUFBQUFBQUFJQUFBQUFBSjRBQUFCakFIVUFjd0IwQUc4QWJRQmZBSE1BY3dC?= =?us-ascii?Q?dUFGOEFjd0J3QUdFQVl3QmxBRjhBZGdBd0FESUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVBQUFBQUFBQUFBZ0FBQUFB?= =?us-ascii?Q?QW5nQUFBR1FBYkFCd0FGOEFjd0JyQUhrQWNBQmxBRjhBWXdCb0FHRUFkQUJm?= =?us-ascii?Q?QUcwQVpRQnpBSE1BWVFCbkFHVUFYd0IyQURBQU1nQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFBQUNlQUFBQVpBQnNBSEFB?= =?us-ascii?Q?WHdCekFHd0FZUUJqQUdzQVh3QmpBR2dBWVFCMEFGOEFiUUJsQUhNQWN3QmhB?= =?us-ascii?Q?R2NBWlFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reftwo: QUFBQUFBQUFBQUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFKNEFBQUJrQUd3QWNBQmZBSFFBWlFCaEFHMEFjd0JmQUc4QWJnQmxBR1FBY2dCcEFIWUFaUUJmQUdZQWFRQnNBR1VBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQUFnQUFBQUFBbmdBQUFHVUFiUUJoQUdrQWJBQmZBR0VBWkFCa0FISUFaUUJ6QUhNQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFFZ0FBQUFBQUFBQUFBQUFBQVFBQUFBQUFBQUFDQUFBQUFBQ2VBQUFBYlFCaEFISUFkZ0JsQUd3QWJBQmZBSFFBWlFCeUFHMEFhUUJ1QUhVQWN3QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUJBQUFBQUFBQUFBSUFBQUFBQUE9PSIvPjwvbWV0YT4= x-dg-rorf: true x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR18MB5167:EE_|PH8PR18MB5292:EE_ x-ms-office365-filtering-correlation-id: bc4bd682-b7cc-4cf6-f347-08db02ab606a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Xgx97lUobWtVNVIyxxdw2Tfp7/lm+5zrD3hLD4XVtubJW0NKXq+xQPGZD8bRjhm4tlDh0DHWxFy8X8T2yUQBQZuJgyF8G9E8ZI5Olk8vrI4RzRsVrtxRUdblT3ecUpmnMlnfNWubtxila5B0Co51pdgPeo3aYfhJ9r8QpllFkYkWNjRU3lEzyMlwvyYIr7pK43vzAt+b+c2lfQmZTAd480lF/J4HaE01Kb8RCVP+AN0qYt/QH0fqmpghKkSYaAqntLW+XGfwewb4kLUK54yBaZCWueCc878vDW1dZ4jdo/+xX3pBZBOvbq14Z5y4dM56tPwVV0pfWQktxs1tBX1nU41jSVz1iR2fa4PqNs5+Z5Qsn2OmzhMO+bKFP0J5bR3WSZOIqU4DGlWa9xRL0ZpAiNAu9Kz1cqh0j6GapTnBDeWOLCGJlSG1x8nKRHQ2Zl/cFrq2RVWKQ+n3POoZ24/F3vnl/v7mHIISjhb0BlzcwmSxUhR/qknQLEmd075rGleYCpGHzrH0mF09ZxBikNE5/qHxUOrJOQ0n0/sPs+BLrPD8zjg/aWaWOBWCJevULtaVoVhHfP3kPYUrzrGej5RRXZpRGxms7+kH2GHi1/ZnWJlKnpbJdFCREbxPwJEFXgAg4LuVOSodPetvUD9e3SLYmzxsZ9WJhgXjQKW3KSUvXL1+aWRk32bJqk5wlpFahAASV+f8SxlIr8/RXZmYIf9tnw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB5167.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(346002)(396003)(376002)(136003)(39860400002)(366004)(451199018)(83380400001)(86362001)(55016003)(52536014)(33656002)(4326008)(66476007)(9686003)(478600001)(316002)(71200400001)(7696005)(8936002)(30864003)(2906002)(186003)(53546011)(38100700002)(41300700001)(8676002)(66556008)(76116006)(38070700005)(64756008)(54906003)(6916009)(5660300002)(66446008)(122000001)(6506007)(66946007)(579004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zUDUJdvC7C3nSZPAQA6hv36lUJblJdX09WJi8DCXgmZa1fFEOsNAZKRwr/p5?= =?us-ascii?Q?b5zi4GHgTRKYEfjITrmPQXcVaSkzdZngabk2RAAK1sQ3plxaVou0bBiPpGfj?= =?us-ascii?Q?unbAaIB+AkH4DmOi+cWeEvIaAQh9CG5nXnUKVJA2ymz1VaJPAil4TeYxW+gE?= =?us-ascii?Q?AOgRrsMJRcFRoRhSp38ltTA5w9sRQ3Y0jAPei//BCKKwquQu/BMxJ5Le6+Fh?= =?us-ascii?Q?an2jHPB1yZxbsQdyU5Dcm05jFfBUWR0myIknGSd1N2XMoOpIWa4OjJAKu5zS?= =?us-ascii?Q?jK60/kQHkq3F46Q93tfichAWMh3+6NtllolubCbI0BMUL7DWHGpRW/fybnkr?= =?us-ascii?Q?DRI8ieGDnp/0Kajbq48gMowF6kjXWhUCle/T6+G3sXPp4VbiqSr4Z2OV8h3N?= =?us-ascii?Q?UTdKHup8+po3xvrRGBy+TITWfAOgX8OJl90QE15OjXEV8KxkLZ+ay8R5njb8?= =?us-ascii?Q?fLkCt0fpTskilN7WllOTvNpMQfAWw8uPUO/T4hgqBQ8rTE8UOLln48ECcQ4I?= =?us-ascii?Q?5c3VeCHH/Kd2YwR9p491Fm1/E4gzaNBedxeajM5MZ5n3hUGtFFjjrej59gCG?= =?us-ascii?Q?KSt2rZEYgoEzyRYxXXL04uDbbEnFcTC1WJSloruw96rlMZCQTnYo/3LwjmEP?= =?us-ascii?Q?F7ucaGLuNchVJZLK/ejRr6dTJ2xsw6+b0zwHqhPb/Y9UwuoR6yKHHU9zQdQk?= =?us-ascii?Q?PIiM7YNEtVNErBsl7+6n4d+/KkM5e2h2WuR5FqBndDTsbL26GTuVNj+TG2Bm?= =?us-ascii?Q?ZdUiQgaaFyLhgmKUMxFPWmFOP54KUQpQVMxvYE/xjaGHYCRUFNksJWkhz0lm?= =?us-ascii?Q?SOsVcU6eAE3ktQtdzYv2UFyamneoMYGQRLiWlJLD9VGWAZIXRMevHnsXcqx1?= =?us-ascii?Q?hnSazcgDSGqsEPbsVHud9bHxQpLWJjPGcTcOADhKakq85Jc0SJu+izS3j0Mu?= =?us-ascii?Q?G645ORGguY8lvjZZVQ+6k0aD+vW/q7H5M8raOuJUShH8rbneNWzqLKBhRJLt?= =?us-ascii?Q?ZULnWeqDihc0fG1AqMhH8lVmDd+BpzlecgfmH2Vpcj/h4Vnhii0ea2tHvNXO?= =?us-ascii?Q?XODS5UcaTFJ67dkiMjnZqauhlGkh58DlcMOgQD9eGWkzPe9owjPqvPmR+Hip?= =?us-ascii?Q?v35z9dUKUCB368RPgnEPC0yyAKoM3zrs3cwJiHVQrtB2DLGp8CpmAiB9DjEn?= =?us-ascii?Q?wRCPSKkq9qKZNE9VfDfrUcDZW5YnVJ66ugFPoz3e8vgGDy6tOFq7zlr9L6SZ?= =?us-ascii?Q?5iua1JLS691j/j+NNDu5k/P0hUEykOtnmTQub8ZHO9fLgUlz3mSA+itRw15d?= =?us-ascii?Q?ILXET3aYjaPLtwSnBChJnE3+yuCm/ocr4TqR4+UPu/8/bNSwGJJ/jiP4q6En?= =?us-ascii?Q?8XQ5D3Y9yGAjR8TttFXYdnCRKq1jKajuUYekUz1DF0UYx0y+mZAflSIh2UgC?= =?us-ascii?Q?A+LptlBqftJTEh3eAqZZlcaf25swo7dmh3ID+aqPC/gBWl+NdZWWFIj9peWY?= =?us-ascii?Q?Y6IfcHFoBL6eDIKHFJ5uZH38fadb5JvDoRApI8CVH0Olrr2yCdL0kiWF5Bas?= =?us-ascii?Q?d122dJQZeuMydalb+iTEKhyLJ4B7+RyOjfbsNBL2NXDnWWdDu4kWdewgaq+f?= =?us-ascii?Q?EqqVsUTAh9PaEKR3UNhABSTWn0tIP7PWl6LaxuYiOTlwajTApsEb2b4KQ9Zb?= =?us-ascii?Q?1W29Tw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB5167.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bc4bd682-b7cc-4cf6-f347-08db02ab606a X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jan 2023 10:18:48.2717 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Kg3QgNq/+u4Y3e8G1hE9aEULvIPorPMeJfWrKbKeRTbb2wnCmG14zGeuaraXKzK/NNjQQn+EDojdOesctA1F4to4l17iUk4w6fHUtfimx+s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR18MB5292 X-Proofpoint-GUID: axF0VIDqGnE33fyGj1ODsDgXClMYD6ej X-Proofpoint-ORIG-GUID: axF0VIDqGnE33fyGj1ODsDgXClMYD6ej X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-30_10,2023-01-27_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Ping. > -----Original Message----- > From: Amit Prakash Shukla > Sent: Tuesday, December 6, 2022 5:17 PM > To: david.marchand@redhat.com > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; > bruce.richardson@intel.com; ciara.power@intel.com; > dmitry.kozliuk@gmail.com; Anatoly Burakov ; > Amit Prakash Shukla > Subject: RE: [PATCH v7] mem: telemetry support for memseg and element > information >=20 > Ping. >=20 > > -----Original Message----- > > From: Amit Prakash Shukla > > Sent: Tuesday, October 25, 2022 6:32 PM > > To: Anatoly Burakov > > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; > > david.marchand@redhat.com; bruce.richardson@intel.com; > > ciara.power@intel.com; dmitry.kozliuk@gmail.com; Amit Prakash Shukla > > > > Subject: [PATCH v7] mem: telemetry support for memseg and element > > information > > > > Changes adds telemetry support to display memory occupancy in memseg > > and the information of the elements allocated from a memseg based on > > arguments provided by user. This patch adds following endpoints: > > > > 1. /eal/memseg_lists > > The command displays the memseg list from which the memory has been > > allocated. > > Example: > > --> /eal/memseg_lists > > {"/eal/memseg_lists": [0, 1]} > > > > 2. /eal/memseg_list_info, > > The command outputs the memsegs, from which the memory is allocated, > > for the memseg_list given as input. > > Example: > > --> /eal/memseg_list_info,0 > > {"/eal/memseg_list_info": [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, \ > > 12, 13, 14, 15]} > > > > 3. /eal/memseg_info,, > > The command outputs the memseg information based on the memseg-list > > and the memseg-id given as input. > > Example: > > --> /eal/memseg_info,0,10 > > {"/eal/memseg_info": {"Memseg_list_index": 0, \ > > "Memseg_index": 10, "Start_addr": "0x101600000", \ > > "End_addr": "0x101800000", "Size": 2097152, "Hugepage_size": 2097152, > > \ > > "Socket_id": 0, "flags": 0}} > > > > --> /eal/memseg_info,0,15 > > {"/eal/memseg_info": {"Memseg_list_index": 0, "Memseg_index": 15, \ > > "Start_addr": "0x102000000", "End_addr": "0x102200000", \ > > "Size": 2097152, "Hugepage_size": 2097152, "Socket_id": 0, "flags": > > 0}} > > > > 4. /eal/mem_element_list,,, > > The command outputs number of elements in a memseg based on the > heap- > > id, memseg-list-id and memseg-id given as input. > > Example: > > --> /eal/mem_element_list,0,0,10 > > {"/eal/mem_element_list": {"Element_count": 52}} > > > > --> /eal/mem_element_list,0,1,15 > > {"/eal/mem_element_list": {"Element_count": 52}} > > > > 5. /eal/mem_element_info,,,, \ > > , > > The command outputs element information like element start address, > > end address, to which memseg it belongs, element state, element size. > > User can give a range of elements to be printed. > > Example: > > --> /eal/mem_element_info,0,0,15,1,2 > > {"/eal/mem_element_info": {"element_1": {"msl_id": 0, "ms_id": 15, \ > > "memseg_start_addr": "0x102000000", "memseg_end_addr": > > "0x102200000", \ > > "element_start_addr": "0x102000b00", "element_end_addr": > > "0x102003380", \ > > "element_size": 10368, "element_state": "Busy"}, "element_2": \ > > {"msl_id": 0, "ms_id": 15, "memseg_start_addr": "0x102000000", \ > > "memseg_end_addr": "0x102200000", "element_start_addr": > > "0x102003380", \ > > "element_end_addr": "0x102005c00", "element_size": 10368, \ > > "element_state": "Busy"}, "Element_count": 2}} > > > > Signed-off-by: Amit Prakash Shukla > > --- > > v2: > > - Fixed compilation error related int-to-pointer-cast > > - Changes for code review suggestions > > > > v3: > > - Commit message changes > > - Renaming end-points > > - Changing input parameters to comma-seperated > > - Reverting telemetry output buffer size > > > > v4: > > - Patch-2 adds telemetry support to display system memory > > > > v5: > > - Removed command help related changes > > > > v6: > > - Changes for code review suggestions > > - Dropped Patch-2 from the series > > > > v7: > > - Fixed compilation error > > > > lib/eal/common/eal_common_memory.c | 391 > > ++++++++++++++++++++++++++++- > > 1 file changed, 386 insertions(+), 5 deletions(-) > > > > diff --git a/lib/eal/common/eal_common_memory.c > > b/lib/eal/common/eal_common_memory.c > > index 688dc615d7..bce18046ce 100644 > > --- a/lib/eal/common/eal_common_memory.c > > +++ b/lib/eal/common/eal_common_memory.c > > @@ -3,6 +3,7 @@ > > */ > > > > #include > > +#include > > #include > > #include > > #include > > @@ -26,6 +27,7 @@ > > #include "eal_memcfg.h" > > #include "eal_options.h" > > #include "malloc_heap.h" > > +#include "malloc_elem.h" > > > > /* > > * Try to mmap *size bytes in /dev/zero. If it is successful, return > > the @@ - > > 1113,11 +1115,17 @@ rte_eal_memory_init(void) } > > > > #ifndef RTE_EXEC_ENV_WINDOWS > > -#define EAL_MEMZONE_LIST_REQ "/eal/memzone_list" > > -#define EAL_MEMZONE_INFO_REQ "/eal/memzone_info" > > -#define EAL_HEAP_LIST_REQ "/eal/heap_list" > > -#define EAL_HEAP_INFO_REQ "/eal/heap_info" > > -#define ADDR_STR 15 > > +#define EAL_MEMZONE_LIST_REQ "/eal/memzone_list" > > +#define EAL_MEMZONE_INFO_REQ > "/eal/memzone_info" > > +#define EAL_HEAP_LIST_REQ "/eal/heap_list" > > +#define EAL_HEAP_INFO_REQ "/eal/heap_info" > > +#define EAL_MEMSEG_LISTS_REQ "/eal/memseg_lists" > > +#define EAL_MEMSEG_LIST_INFO_REQ "/eal/memseg_list_info" > > +#define EAL_MEMSEG_INFO_REQ "/eal/memseg_info" > > +#define EAL_ELEMENT_LIST_REQ "/eal/mem_element_list" > > +#define EAL_ELEMENT_INFO_REQ "/eal/mem_element_info" > > +#define ADDR_STR 15 > > + > > > > /* Telemetry callback handler to return heap stats for requested heap > > id. */ static int @@ -1265,6 +1273,362 @@ > > handle_eal_memzone_list_request(const char *cmd __rte_unused, > > return 0; > > } > > > > +/* n_vals is the number of params to be parsed. */ static int > > +parse_params(const char *params, uint32_t *vals, size_t n_vals) { > > + char dlim[2] =3D ","; > > + char *params_args; > > + size_t count =3D 0; > > + char *token; > > + > > + if (vals =3D=3D NULL || params =3D=3D NULL || strlen(params) =3D=3D 0= ) > > + return -1; > > + > > + /* strtok expects char * and param is const char *. Hence on using > > + * params as "const char *" compiler throws warning. > > + */ > > + params_args =3D strdup(params); > > + if (params_args =3D=3D NULL) > > + return -1; > > + > > + token =3D strtok(params_args, dlim); > > + while (token && isdigit(*token) && count < n_vals) { > > + vals[count++] =3D strtoul(token, NULL, 10); > > + token =3D strtok(NULL, dlim); > > + } > > + > > + free(params_args); > > + > > + if (count < n_vals) > > + return -1; > > + > > + return 0; > > +} > > + > > +static int > > +handle_eal_memseg_lists_request(const char *cmd __rte_unused, > > + const char *params __rte_unused, > > + struct rte_tel_data *d) > > +{ > > + struct rte_mem_config *mcfg; > > + int i; > > + > > + rte_tel_data_start_array(d, RTE_TEL_INT_VAL); > > + > > + rte_mcfg_mem_read_lock(); > > + mcfg =3D rte_eal_get_configuration()->mem_config; > > + > > + for (i =3D 0; i < RTE_MAX_MEMSEG_LISTS; i++) { > > + struct rte_memseg_list *msl =3D &mcfg->memsegs[i]; > > + if (msl->memseg_arr.count =3D=3D 0) > > + continue; > > + > > + rte_tel_data_add_array_int(d, i); > > + } > > + rte_mcfg_mem_read_unlock(); > > + > > + return 0; > > +} > > + > > +static int > > +handle_eal_memseg_list_info_request(const char *cmd __rte_unused, > > + const char *params, struct rte_tel_data *d) > > { > > + struct rte_mem_config *mcfg; > > + struct rte_memseg_list *msl; > > + struct rte_fbarray *arr; > > + uint32_t ms_list_idx; > > + int ms_idx; > > + /* size of an array =3D=3D num params to be parsed. */ > > + uint32_t vals[1] =3D {0}; > > + > > + if (parse_params(params, vals, RTE_DIM(vals)) < 0) > > + return -1; > > + > > + ms_list_idx =3D vals[0]; > > + if (ms_list_idx >=3D RTE_MAX_MEMSEG_LISTS) > > + return -1; > > + > > + rte_tel_data_start_array(d, RTE_TEL_INT_VAL); > > + > > + rte_mcfg_mem_read_lock(); > > + mcfg =3D rte_eal_get_configuration()->mem_config; > > + msl =3D &mcfg->memsegs[ms_list_idx]; > > + if (msl->memseg_arr.count =3D=3D 0) > > + goto done; > > + > > + arr =3D &msl->memseg_arr; > > + > > + ms_idx =3D rte_fbarray_find_next_used(arr, 0); > > + while (ms_idx >=3D 0) { > > + rte_tel_data_add_array_int(d, ms_idx); > > + ms_idx =3D rte_fbarray_find_next_used(arr, ms_idx + 1); > > + } > > + > > +done: > > + rte_mcfg_mem_read_unlock(); > > + > > + return 0; > > +} > > + > > +static int > > +handle_eal_memseg_info_request(const char *cmd __rte_unused, > > + const char *params, struct rte_tel_data *d) { > > + struct rte_mem_config *mcfg; > > + uint64_t ms_start_addr, ms_end_addr, ms_size, hugepage_size; > > + struct rte_memseg_list *msl; > > + const struct rte_memseg *ms; > > + struct rte_fbarray *arr; > > + char addr[ADDR_STR]; > > + uint32_t ms_list_idx =3D 0; > > + uint32_t ms_idx =3D 0; > > + int32_t ms_socket_id; > > + uint32_t ms_flags; > > + /* size of an array =3D=3D num params to be parsed. */ > > + uint32_t vals[2] =3D {0}; > > + > > + if (parse_params(params, vals, RTE_DIM(vals)) < 0) > > + return -1; > > + > > + ms_list_idx =3D vals[0]; > > + if (ms_list_idx >=3D RTE_MAX_MEMSEG_LISTS) > > + return -1; > > + > > + ms_idx =3D vals[1]; > > + > > + rte_mcfg_mem_read_lock(); > > + > > + mcfg =3D rte_eal_get_configuration()->mem_config; > > + msl =3D &mcfg->memsegs[ms_list_idx]; > > + if (msl->memseg_arr.count =3D=3D 0) { > > + rte_mcfg_mem_read_unlock(); > > + return -1; > > + } > > + > > + arr =3D &msl->memseg_arr; > > + ms =3D rte_fbarray_get(arr, ms_idx); > > + if (ms =3D=3D NULL) { > > + rte_mcfg_mem_read_unlock(); > > + RTE_LOG(DEBUG, EAL, "Error fetching requested > > memseg.\n"); > > + return -1; > > + } > > + > > + ms_start_addr =3D ms->addr_64; > > + ms_end_addr =3D (uint64_t)RTE_PTR_ADD(ms_start_addr, ms->len); > > + ms_size =3D ms->len; > > + hugepage_size =3D ms->hugepage_sz; > > + ms_socket_id =3D ms->socket_id; > > + ms_flags =3D ms->flags; > > + > > + rte_mcfg_mem_read_unlock(); > > + > > + rte_tel_data_start_dict(d); > > + rte_tel_data_add_dict_int(d, "Memseg_list_index", ms_list_idx); > > + rte_tel_data_add_dict_int(d, "Memseg_index", ms_idx); > > + snprintf(addr, ADDR_STR, "0x%"PRIx64, ms_start_addr); > > + rte_tel_data_add_dict_string(d, "Start_addr", addr); > > + snprintf(addr, ADDR_STR, "0x%"PRIx64, ms_end_addr); > > + rte_tel_data_add_dict_string(d, "End_addr", addr); > > + rte_tel_data_add_dict_u64(d, "Size", ms_size); > > + rte_tel_data_add_dict_u64(d, "Hugepage_size", hugepage_size); > > + rte_tel_data_add_dict_int(d, "Socket_id", ms_socket_id); > > + rte_tel_data_add_dict_int(d, "flags", ms_flags); > > + > > + return 0; > > +} > > + > > +static int > > +handle_eal_element_list_request(const char *cmd __rte_unused, > > + const char *params, struct rte_tel_data *d) { > > + struct rte_mem_config *mcfg; > > + struct rte_memseg_list *msl; > > + const struct rte_memseg *ms; > > + struct malloc_elem *elem; > > + struct malloc_heap *heap; > > + uint64_t ms_start_addr, ms_end_addr; > > + uint64_t elem_start_addr, elem_end_addr; > > + uint32_t ms_list_idx =3D 0; > > + uint32_t heap_id =3D 0; > > + uint32_t ms_idx =3D 0; > > + int elem_count =3D 0; > > + /* size of an array =3D=3D num params to be parsed. */ > > + uint32_t vals[3] =3D {0}; > > + > > + if (parse_params(params, vals, RTE_DIM(vals)) < 0) > > + return -1; > > + > > + heap_id =3D vals[0]; > > + if (heap_id >=3D RTE_MAX_HEAPS) > > + return -1; > > + > > + ms_list_idx =3D vals[1]; > > + if (ms_list_idx >=3D RTE_MAX_MEMSEG_LISTS) > > + return -1; > > + > > + ms_idx =3D vals[2]; > > + > > + rte_mcfg_mem_read_lock(); > > + > > + mcfg =3D rte_eal_get_configuration()->mem_config; > > + msl =3D &mcfg->memsegs[ms_list_idx]; > > + ms =3D rte_fbarray_get(&msl->memseg_arr, ms_idx); > > + if (ms =3D=3D NULL) { > > + rte_mcfg_mem_read_unlock(); > > + RTE_LOG(DEBUG, EAL, "Error fetching requested > > memseg.\n"); > > + return -1; > > + } > > + > > + ms_start_addr =3D ms->addr_64; > > + ms_end_addr =3D (uint64_t)RTE_PTR_ADD(ms_start_addr, ms->len); > > + rte_mcfg_mem_read_unlock(); > > + > > + rte_tel_data_start_dict(d); > > + > > + heap =3D &mcfg->malloc_heaps[heap_id]; > > + rte_spinlock_lock(&heap->lock); > > + > > + elem =3D heap->first; > > + while (elem) { > > + elem_start_addr =3D (uint64_t)elem; > > + elem_end_addr =3D > > + (uint64_t)RTE_PTR_ADD(elem_start_addr, elem- > > >size); > > + > > + if ((uint64_t)elem_start_addr >=3D ms_start_addr && > > + (uint64_t)elem_end_addr <=3D ms_end_addr) > > + elem_count++; > > + elem =3D elem->next; > > + } > > + > > + rte_spinlock_unlock(&heap->lock); > > + > > + rte_tel_data_add_dict_int(d, "Element_count", elem_count); > > + > > + return 0; > > +} > > + > > +static int > > +handle_eal_element_info_request(const char *cmd __rte_unused, > > + const char *params, struct rte_tel_data *d) { > > + struct rte_mem_config *mcfg; > > + struct rte_memseg_list *msl; > > + const struct rte_memseg *ms; > > + struct malloc_elem *elem; > > + struct malloc_heap *heap; > > + struct rte_tel_data *c; > > + uint64_t ms_start_addr, ms_end_addr; > > + uint64_t elem_start_addr, elem_end_addr; > > + uint32_t ms_list_idx =3D 0; > > + uint32_t heap_id =3D 0; > > + uint32_t ms_idx =3D 0; > > + uint32_t start_elem =3D 0, end_elem =3D 0; > > + uint32_t count =3D 0, elem_count =3D 0; > > + char str[ADDR_STR]; > > + /* size of an array =3D=3D num params to be parsed. */ > > + uint32_t vals[5] =3D {0}; > > + > > + if (parse_params(params, vals, RTE_DIM(vals)) < 0) > > + return -1; > > + > > + heap_id =3D vals[0]; > > + if (heap_id >=3D RTE_MAX_HEAPS) > > + return -1; > > + > > + ms_list_idx =3D vals[1]; > > + if (ms_list_idx >=3D RTE_MAX_MEMSEG_LISTS) > > + return -1; > > + > > + ms_idx =3D vals[2]; > > + start_elem =3D vals[3]; > > + end_elem =3D vals[4]; > > + > > + if (end_elem < start_elem) > > + return -1; > > + > > + rte_mcfg_mem_read_lock(); > > + > > + mcfg =3D rte_eal_get_configuration()->mem_config; > > + msl =3D &mcfg->memsegs[ms_list_idx]; > > + ms =3D rte_fbarray_get(&msl->memseg_arr, ms_idx); > > + if (ms =3D=3D NULL) { > > + rte_mcfg_mem_read_unlock(); > > + RTE_LOG(DEBUG, EAL, "Error fetching requested > > memseg.\n"); > > + return -1; > > + } > > + > > + ms_start_addr =3D ms->addr_64; > > + ms_end_addr =3D (uint64_t)RTE_PTR_ADD(ms_start_addr, ms->len); > > + > > + rte_mcfg_mem_read_unlock(); > > + > > + rte_tel_data_start_dict(d); > > + > > + heap =3D &mcfg->malloc_heaps[heap_id]; > > + rte_spinlock_lock(&heap->lock); > > + > > + elem =3D heap->first; > > + while (elem) { > > + elem_start_addr =3D (uint64_t)elem; > > + elem_end_addr =3D > > + (uint64_t)RTE_PTR_ADD(elem_start_addr, elem- > > >size); > > + > > + if (elem_start_addr < ms_start_addr || > > + elem_end_addr > ms_end_addr) { > > + elem =3D elem->next; > > + continue; > > + } > > + > > + if (count < start_elem) { > > + elem =3D elem->next; > > + count++; > > + continue; > > + } > > + > > + c =3D rte_tel_data_alloc(); > > + if (c =3D=3D NULL) > > + break; > > + > > + rte_tel_data_start_dict(c); > > + rte_tel_data_add_dict_int(c, "msl_id", ms_list_idx); > > + rte_tel_data_add_dict_int(c, "ms_id", ms_idx); > > + snprintf(str, ADDR_STR, "0x%"PRIx64, ms_start_addr); > > + rte_tel_data_add_dict_string(c, "memseg_start_addr", str); > > + snprintf(str, ADDR_STR, "0x%"PRIx64, ms_end_addr); > > + rte_tel_data_add_dict_string(c, "memseg_end_addr", str); > > + snprintf(str, ADDR_STR, "0x%"PRIx64, elem_start_addr); > > + rte_tel_data_add_dict_string(c, "element_start_addr", str); > > + snprintf(str, ADDR_STR, "0x%"PRIx64, elem_end_addr); > > + rte_tel_data_add_dict_string(c, "element_end_addr", str); > > + rte_tel_data_add_dict_int(c, "element_size", elem->size); > > + snprintf(str, ADDR_STR, "%s", elem->state =3D=3D 0 ? "Free" : > > + elem->state =3D=3D 1 ? "Busy" : elem->state =3D=3D 2 ? > > + "Pad" : "Error"); > > + rte_tel_data_add_dict_string(c, "element_state", str); > > + > > + snprintf(str, ADDR_STR, "%s_%u", "element", count); > > + if (rte_tel_data_add_dict_container(d, str, c, 0) !=3D 0) { > > + rte_tel_data_free(c); > > + break; > > + } > > + > > + elem_count++; > > + count++; > > + if (count > end_elem) > > + break; > > + > > + elem =3D elem->next; > > + } > > + > > + rte_spinlock_unlock(&heap->lock); > > + > > + rte_tel_data_add_dict_int(d, "Element_count", elem_count); > > + > > + return 0; > > +} > > + > > RTE_INIT(memory_telemetry) > > { > > rte_telemetry_register_cmd( > > @@ -1279,5 +1643,22 @@ RTE_INIT(memory_telemetry) > > rte_telemetry_register_cmd( > > EAL_HEAP_INFO_REQ, > > handle_eal_heap_info_request, > > "Returns malloc heap stats. Parameters: int > heap_id"); > > + rte_telemetry_register_cmd( > > + EAL_MEMSEG_LISTS_REQ, > > + handle_eal_memseg_lists_request, > > + "Returns array of memseg list IDs. Takes no > > parameters"); > > + rte_telemetry_register_cmd( > > + EAL_MEMSEG_LIST_INFO_REQ, > > + handle_eal_memseg_list_info_request, > > + "Returns memseg list info. Parameters: int > > memseg_list_id"); > > + rte_telemetry_register_cmd( > > + EAL_MEMSEG_INFO_REQ, > > handle_eal_memseg_info_request, > > + "Returns memseg info. Parameter: int > > memseg_list_id,int memseg_id"); > > + rte_telemetry_register_cmd(EAL_ELEMENT_LIST_REQ, > > + handle_eal_element_list_request, > > + "Returns array of heap element IDs. Parameters: int > > heap_id, int memseg_list_id, int memseg_id"); > > + rte_telemetry_register_cmd(EAL_ELEMENT_INFO_REQ, > > + handle_eal_element_info_request, > > + "Returns element info. Parameters: int heap_id, int > > memseg_list_id, > > +int memseg_id, int start_elem_id, int end_elem_id"); > > } > > #endif > > -- > > 2.25.1