From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8323042BEF; Wed, 31 May 2023 10:27:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 57BFA40ED7; Wed, 31 May 2023 10:27:14 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 6FE9040A82 for ; Wed, 31 May 2023 10:27:13 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34V6orMe032164; Wed, 31 May 2023 01:27:12 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2173.outbound.protection.outlook.com [104.47.57.173]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3quhcmbrdf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 31 May 2023 01:27:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=laPpp/8rX31SE21HcynbO4hhhfPAJM3Qc8H7/MyHALJ6meOgC0kbN7o78IzWi+NWs+7fQkL60h9QICA4drXa91nb4xCKV8tZQnzLU7B81bzrQi03V+AjoFbedMslT7b/jathq1Zkoj32YcrjThF619HZsBQOV7JOyF4HFFzPYpRSNXGt81PgqhXaYG9Dd7fgTwbMMVA4g7x86AN+stYLXFh+Q1H7n+iKlShRIMhbAYhxiXCKNHXsFiDPx3N38ml4SpJiNPKFgIrbtQSF4J021deOpcPd2FlMMpnbN6A9qsq5ajtnnsxOq1AYpgj+krceEd11hUquGafB6CxxeYtlrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RpQCDV/mDIcY0sGeEfG1hvaNGLkYgelbeEC/2J5cQWo=; b=Sep+gw9ys6KbE3XMqblfxg3fymj7bWVqc4he3ndYG1iykxI8WxMfi+wYIggqr52e6xC/xXxFrx6AOdVpPUZ8ktwDEG0Cm1CPzzvSswdYCQb7zxEAQI7EVwF3eVqSIL/L70qTW4SnYZWfuhbYslZyvOAN9JXVeJ7d/TQoQeneJCPgz0402upPuwusSLPoUtHTQSs8lCGDpcRxQdmQ/+UKf+bRrpoMszqCezB9cxU84vrCdovgKMLC1SKdTUZiQr3LVRuSI8pIzwxQyYsf3pJy8Aq80Ot/ykDv7f/tQ+2vOihvw9acE59HjnhNezTll9GcJLbi/jngtiJfdlHyiEGU+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RpQCDV/mDIcY0sGeEfG1hvaNGLkYgelbeEC/2J5cQWo=; b=SM8RaJvje43rrcWZyjoYpxtFAQpIKtqjGjn47Y2Tpo5uTKEzPc0cM/gmHgVvAYFWzXlXARr9ptEl4+LegZjI11807geEoknk/CirvreTqOY75blYEASpB20Jug3/+YCfwrMCViCeDJHaeN4eW7TWEPNe1JLkEcocU89f3CF8duQ= Received: from PH0PR18MB5167.namprd18.prod.outlook.com (2603:10b6:510:168::7) by SJ0PR18MB4011.namprd18.prod.outlook.com (2603:10b6:a03:2ca::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.23; Wed, 31 May 2023 08:27:10 +0000 Received: from PH0PR18MB5167.namprd18.prod.outlook.com ([fe80::75fe:8527:aaf:bbda]) by PH0PR18MB5167.namprd18.prod.outlook.com ([fe80::75fe:8527:aaf:bbda%7]) with mapi id 15.20.6455.020; Wed, 31 May 2023 08:27:09 +0000 From: Amit Prakash Shukla To: Stephen Hemminger , "dev@dpdk.org" CC: Jerin Jacob Kollanukkaran , Kiran Kumar Kokkilagadda , Nithin Kumar Dabilpuram Subject: RE: [EXT] [RFT] graph: fix pcapng file support Thread-Topic: [EXT] [RFT] graph: fix pcapng file support Thread-Index: AQHZkyop0Czdb4jGNUGgV6P8hQhm1q90CvhQ Date: Wed, 31 May 2023 08:27:09 +0000 Message-ID: References: <20230530190834.142932-1-stephen@networkplumber.org> In-Reply-To: <20230530190834.142932-1-stephen@networkplumber.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-ref: =?us-ascii?Q?PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcYW1pdHByYWth?= =?us-ascii?Q?c2hzXGFwcGRhdGFccm9hbWluZ1wwOWQ4NDliNi0zMmQzLTRhNDAtODVlZS02?= =?us-ascii?Q?Yjg0YmEyOWUzNWJcbXNnc1xtc2ctZTliYTJlNWItZmY4Yy0xMWVkLWI2ZDUt?= =?us-ascii?Q?MDBlMDRjY2FkNzJiXGFtZS10ZXN0XGU5YmEyZTVjLWZmOGMtMTFlZC1iNmQ1?= =?us-ascii?Q?LTAwZTA0Y2NhZDcyYmJvZHkudHh0IiBzej0iMjM4NSIgdD0iMTMzMjk5OTUy?= =?us-ascii?Q?Mjc3MjgyMzE5IiBoPSJpbC9uaDhJWXBQaEY0OC9qb2NhdnYvdGZRZk09IiBp?= =?us-ascii?Q?ZD0iIiBibD0iMCIgYm89IjEiIGNpPSJjQUFBQUVSSFUxUlNSVUZOQ2dVQUFO?= =?us-ascii?Q?NFBBQUFQWGhDd21aUFpBVCtrdlFTSUNtT2JQNlM5QklnS1k1c1pBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBSEFBQUFCdUR3QUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBRUFBUUVCQUFBQUk3cVRwQUNBQVFBQUFBQUFBQUFBQUo0QUFBQmhB?= =?us-ascii?Q?R1FBWkFCeUFHVUFjd0J6QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUdNQWRRQnpBSFFBYndCdEFG?= =?us-ascii?Q?OEFjQUJsQUhJQWN3QnZBRzRBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUF3QUFBQUFBQUFBQUFBQUFBUUFBQUFBQUFB?= =?us-ascii?Q?QUNBQUFBQUFDZUFBQUFZd0IxQUhNQWRBQnZBRzBBWHdCd0FHZ0Fid0J1QUdV?= =?us-ascii?Q?QWJnQjFBRzBBWWdCbEFISUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFC?= =?us-ascii?Q?akFIVUFjd0IwQUc4QWJRQmZBSE1BY3dCdUFGOEFaQUJoQUhNQWFBQmZBSFlB?= =?us-ascii?Q?TUFBeUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-refone: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVBQUFBQUFBQUFBZ0FBQUFBQW5n?= =?us-ascii?Q?QUFBR01BZFFCekFIUUFid0J0QUY4QWN3QnpBRzRBWHdCckFHVUFlUUIzQUc4?= =?us-ascii?Q?QWNnQmtBSE1BQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFBQUNlQUFBQVl3QjFBSE1BZEFC?= =?us-ascii?Q?dkFHMEFYd0J6QUhNQWJnQmZBRzRBYndCa0FHVUFiQUJwQUcwQWFRQjBBR1VB?= =?us-ascii?Q?Y2dCZkFIWUFNQUF5QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFCQUFB?= =?us-ascii?Q?QUFBQUFBQUlBQUFBQUFKNEFBQUJqQUhVQWN3QjBBRzhBYlFCZkFITUFjd0J1?= =?us-ascii?Q?QUY4QWN3QndBR0VBWXdCbEFGOEFkZ0F3QURJQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQUFnQUFBQUFB?= =?us-ascii?Q?bmdBQUFHUUFiQUJ3QUY4QWN3QnJBSGtBY0FCbEFGOEFZd0JvQUdFQWRBQmZB?= =?us-ascii?Q?RzBBWlFCekFITUFZUUJuQUdVQVh3QjJBREFBTWdBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQVFBQUFBQUFBQUFDQUFBQUFBQ2VBQUFBWkFCc0FIQUFY?= =?us-ascii?Q?d0J6QUd3QVlRQmpBR3NBWHdCakFHZ0FZUUIwQUY4QWJRQmxBSE1BY3dCaEFH?= =?us-ascii?Q?Y0FaUUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reftwo: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUJBQUFBQUFBQUFBSUFBQUFBQUo0QUFBQmtBR3dB?= =?us-ascii?Q?Y0FCZkFIUUFaUUJoQUcwQWN3QmZBRzhBYmdCbEFHUUFjZ0JwQUhZQVpRQmZB?= =?us-ascii?Q?R1lBYVFCc0FHVUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUdVQWJRQmhBR2tBYkFCZkFHRUFa?= =?us-ascii?Q?QUJrQUhJQVpRQnpBSE1BQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUNBQUFBQUFBQUFBQUFBQUFBUUFBQUFBQUFBQUNB?= =?us-ascii?Q?QUFBQUFDZUFBQUFiUUJoQUhJQWRnQmxBR3dBWHdCd0FISUFid0JxQUdVQVl3?= =?us-ascii?Q?QjBBRjhBYmdCaEFHMEFaUUJ6QUY4QVl3QnZBRzRBWmdCcEFHUUFaUUJ1QUhR?= =?us-ascii?Q?QWFRQmhBR3dBWHdCaEFHd0Fid0J1QUdVQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFCdEFH?= =?us-ascii?Q?RUFjZ0IyQUdVQWJBQmZBSEFBY2dCdkFHb0FaUUJqQUhRQVh3QnVBR0VBYlFC?= =?us-ascii?Q?bEFITUFYd0J5QUdVQWN3QjBBSElBYVFCakFIUUFaUUJrQUY4QVlRQnNBRzhB?= =?us-ascii?Q?YmdCbEFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUVBQUFBQUFBQUFBZ0FBQUFBQW5nQUFBRzBBWVFCeUFIWUFaUUJzQUY4?= =?us-ascii?Q?QWNBQnlBRzhBYWdCbEFHTUFkQUJmQUc0QVlRQnRBR1VBY3dCZkFISUFaUUJ6?= =?us-ascii?Q?QUhRQWNnQnBBR01BZEFCbEFHUUFYd0JvQUdVQWVBQmpBRzhBWkFCbEFITUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFB?= =?us-ascii?Q?Q0FBQUFBQUNlQUFBQWJRQmhBSElBZGdCbEFHd0FiQUJmQUdFQWNnQnRBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-rorf: true x-dg-refthree: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFCQUFBQUFB?= =?us-ascii?Q?QUFBQUlBQUFBQUFKNEFBQUJ0QUdFQWNnQjJBR1VBYkFCc0FGOEFad0J2QUc4?= =?us-ascii?Q?QVp3QnNBR1VBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQUFnQUFBQUFBbmdB?= =?us-ascii?Q?QUFHMEFZUUJ5QUhZQVpRQnNBR3dBWHdCd0FISUFid0JxQUdVQVl3QjBBRjhB?= =?us-ascii?Q?WXdCdkFHUUFaUUJ6QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQVFBQUFBQUFBQUFDQUFBQUFBQ2VBQUFBYlFCaEFISUFkZ0Js?= =?us-ascii?Q?QUd3QWJBQmZBSEFBY2dCdkFHb0FaUUJqQUhRQVh3QmpBRzhBWkFCbEFITUFY?= =?us-ascii?Q?d0JrQUdrQVl3QjBBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUJBQUFB?= =?us-ascii?Q?QUFBQUFBSUFBQUFBQUo0QUFBQnRBR0VBY2dCMkFHVUFiQUJzQUY4QWNBQnlB?= =?us-ascii?Q?RzhBYWdCbEFHTUFkQUJmQUc0QVlRQnRBR1VBY3dCZkFHTUFid0J1QUdZQWFR?= =?us-ascii?Q?QmtBR1VBYmdCMEFHa0FZUUJzQUY4QWJRQmhBSElBZGdCbEFHd0FiQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFu?= =?us-ascii?Q?Z0FBQUcwQVlRQnlBSFlBWlFCc0FHd0FYd0J3QUhJQWJ3QnFBR1VBWXdCMEFG?= =?us-ascii?Q?OEFiZ0JoQUcwQVpRQnpBRjhBWXdCdkFHNEFaZ0JwQUdRQVpRQnVBSFFBYVFC?= =?us-ascii?Q?aEFHd0FYd0J0QUdFQWNnQjJBR1VBYkFCc0FGOEFid0J5QUY4QVlRQnlBRzBB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reffour: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBUUFBQUFBQUFBQUNBQUFB?= =?us-ascii?Q?QUFDZUFBQUFiUUJoQUhJQWRnQmxBR3dBYkFCZkFIQUFjZ0J2QUdvQVpRQmpB?= =?us-ascii?Q?SFFBWHdCdUFHRUFiUUJsQUhNQVh3QmpBRzhBYmdCbUFHa0FaQUJsQUc0QWRB?= =?us-ascii?Q?QnBBR0VBYkFCZkFHMEFZUUJ5QUhZQVpRQnNBR3dBWHdCdkFISUFYd0JuQUc4?= =?us-ascii?Q?QWJ3Qm5BR3dBWlFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFCdEFHRUFj?= =?us-ascii?Q?Z0IyQUdVQWJBQnNBRjhBY0FCeUFHOEFhZ0JsQUdNQWRBQmZBRzRBWVFCdEFH?= =?us-ascii?Q?VUFjd0JmQUhJQVpRQnpBSFFBY2dCcEFHTUFkQUJsQUdRQVh3QnRBR0VBY2dC?= =?us-ascii?Q?MkFHVUFiQUJzQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUVBQUFBQUFBQUFBZ0FBQUFBQW5nQUFBRzBBWVFCeUFIWUFaUUJzQUd3QVh3?= =?us-ascii?Q?QndBSElBYndCcUFHVUFZd0IwQUY4QWJnQmhBRzBBWlFCekFGOEFjZ0JsQUhN?= =?us-ascii?Q?QWRBQnlBR2tBWXdCMEFHVUFaQUJmQUcwQVlRQnlBSFlBWlFCc0FHd0FYd0J2?= =?us-ascii?Q?QUhJQVh3QmhBSElBYlFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FB?= =?us-ascii?Q?QUFBQUNlQUFBQWJRQmhBSElBZGdCbEFHd0FiQUJmQUhRQVpRQnlBRzBBYVFC?= =?us-ascii?Q?dUFIVUFjd0FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFKNEFBQUJ0QUdF?= =?us-ascii?Q?QWNnQjJBR1VBYkFCc0FGOEFkd0J2QUhJQVpBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBRUFBQUFBQUFBQUFnQUFBQUFBIi8+PC9tZXRhPg=3D=3D?= x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR18MB5167:EE_|SJ0PR18MB4011:EE_ x-ms-office365-filtering-correlation-id: ae6b1489-8c05-478d-6769-08db61b0d3c8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SvaPmjkAGeW7d+ydUAjuvmtyiGpkKKq32c9ZBKoQdJm7pDNVho2jFMZiNlC08MMHp1Ym7F9HChXVAdRA2uCipz//xckcRynfIpTwR82PyxBeTLc2aZha3Mjve325HEz7Am+rzkab1HrI5EudoggWoQczVp5DMc5L621+PJSYshjw6/MzgAx7F3b4IaoJUDU+vn/zcI3UhHB17hwaSe7Uh/wFUqB3dJ3INgNENWjoAOTlNj1hPyq9YsI1M6wXP9Jm6Xssr1NW3v2HahMimuaQ2w1/UawIsuKWjLoBst4ot2pZlzymHl6GPOmvcywolNwtOUqA7FvkdmD6P7ckIxhvFZwoWDeZ2LrZ+pQS4tbbdgKeZWWOYfU4vRTqoZSN7efq+WjFpB83p9tmYxN+IWx8ggiX7JA7MBdxDcuy3FuL1k51bn4+7SUn5TXfOgaGpQoTwnTBGO+dm4IJkNHUmi3rcHpmHUADRW+pwbXxbE+Wtoa0ls2Pkr2HvUg6St6+Yfza2v860zLxuqN8BDCz4Dl6o9AvupU6Hf0nLfLsGrWFnqzA6w8JdZg/NGrnHAy2z2SlpbmTGrH/fxezkLJTg7/UTpPKHDpdHlgt7IQi3FWUwb3RMRxdusLYEtnWTjdq1Vlc x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB5167.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(366004)(346002)(376002)(396003)(39850400004)(451199021)(86362001)(33656002)(110136005)(316002)(478600001)(7696005)(4326008)(54906003)(66476007)(64756008)(76116006)(66446008)(66946007)(66556008)(38070700005)(71200400001)(5660300002)(83380400001)(55016003)(2906002)(52536014)(8676002)(8936002)(122000001)(38100700002)(41300700001)(9686003)(186003)(6506007)(26005)(107886003)(53546011); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tMgQu465aNcgZ1aGWZvpwozONMCR0N2Ag0Vo/9Qs4BJN/rmxeda5N9Wx8Tre?= =?us-ascii?Q?n9FNNr6t8CXXy1DmW/qV3AD+BEjNPmCDsZajui4DGRb4yM8zLkFcusS8cw4S?= =?us-ascii?Q?ppQ0k8rlk3FYlJMgU4nyH456yLNx2Jaqzh+MRqAvlerttlH9IZE7yQG4QxZ3?= =?us-ascii?Q?oelCLYTWvDW603qsxRN7BCdhGzQO/JsRCeQqFKSCDeCmHzqcGVw7cFK84hI3?= =?us-ascii?Q?hGfd4YfYY/z0dSnZkjoWekNB0LlqdELq7h2QilRG+zs2b2cDsNFS1bOHjpC+?= =?us-ascii?Q?b5krrpaouScA0KODFUhco0g1SqASN/Hv51jKux8/eMMh6xU1DRvga+L3Ry05?= =?us-ascii?Q?uab2iDDKaul8RCNwQgAp6UDcCcy7vIom6vyVWjqQfAqJgID7b4rFs426Sl4I?= =?us-ascii?Q?xyLN5Oq3jdu/bZ6a96HkifFv8BzUBt0o0aTDUVt3eEpdMSD0MDrNmdzWQB9q?= =?us-ascii?Q?PMKXaF1t6zwCdD1E2wXDjPuPxzBuTiLtCmdys+AtN7hq2vo61WV+q+tpdBCE?= =?us-ascii?Q?u07tnbzEamwyMbrVvdEs9GrmBYkbtm3zdweOgYNQ8qrObgDsVLB+L6fvDmZ9?= =?us-ascii?Q?IwAGpVVoOMzPUTdubv3siCGOJmKoBOAZOHJbrjMBz8nMJamDQUWLvhv5PzXZ?= =?us-ascii?Q?tZJfv9E2T4VHRWMJ0MbnSPAxVCLnR3oKibF+YHwXiI20mEqCDe+/7SZfk2iY?= =?us-ascii?Q?Ng623u3efJNu6wiEnNGfTHng2r221simuSrSEPf49AVr702rVqL4gEdsj4/6?= =?us-ascii?Q?SxYvnqrX6p3kA6oOMWnt0aEYO+Md6uyRJsJjjLOTLh9QMM8ORcP1Y60n8C4B?= =?us-ascii?Q?QnPLpvnLpaNuZyVZTfup3psqfV5ld2w/VzHPDRz7z0t+QVyN6qPWDW2NtDru?= =?us-ascii?Q?WMKddyd8GFq4opib9g1Hlj/V8ryeobuZslTHeJfifsxfGc1nOpL6jLjkDT+Z?= =?us-ascii?Q?zU/GqldtYOZ9iuR4hvwzgk76jkXmUtZAumZaURLqRROZziF55WZ359HYUo52?= =?us-ascii?Q?bFXmlPRcWQQ+yJmzgP+VlYOdyO8ledHdjUNTleuk6il9beHpaRFRuHL2On6v?= =?us-ascii?Q?Mb3tuslvNFGKlskr67Ws9lmXssE5INbKUiq3S4b57AcQN28DQ2UuN6Y1Q9kh?= =?us-ascii?Q?C0/sUY0IwWj7VbizXNr4OkSIL7fHcJ7m5K6pqCVFrjqU37qZn1kKkTpZ+Nja?= =?us-ascii?Q?vdkrPY0jhs6i7rZk9h9ZnjtWpU9N5rAQA/VfnsqNA/q5U7dnsz8QCjQ2HvTu?= =?us-ascii?Q?LWfCingGbGyrC/jtShSI7NW7ic5m0jScbB6A56Xb11XAEXj7qp7451EXDcCo?= =?us-ascii?Q?6ADVgZsIOX5bpuNgYuGCmzrbCa2Dlkag6jo9nVyl3RPQsC5DLHFQEZH02Dn9?= =?us-ascii?Q?kR3DojkAAqb56yO9Gp6zghsUlTjcDquf8AaI8jrQ9Ch+rO4Mxz+my9k3gFiG?= =?us-ascii?Q?IiYKjSgHAOLeDV0YzRI8y+0H+CTKesYfgTZIHkFoWiLnJOwdJKZkkL8QPqvD?= =?us-ascii?Q?KqE8Q2UdeNQ3D44LcPvFUJGD4j8bvEeCFGWElwEPGS06QzFKYXno7zrLzgku?= =?us-ascii?Q?dTjy+4sP9kXDJye8IjFsx0pwt0zpYV04iu+COlqv?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB5167.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ae6b1489-8c05-478d-6769-08db61b0d3c8 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2023 08:27:09.7815 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KqutW+OfRSMtGvFQNEaDSUjqTHQa+RL8A6bC5Rp+WcNP8oVCF+EmxnXJA/xSKWCizo1eW6fkAzxl23VbOdnN04XJsSGOn3aERqsrOWx83qA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR18MB4011 X-Proofpoint-GUID: tVRCWuMe2upsvcWE5AVAHvt6VKM3wyTo X-Proofpoint-ORIG-GUID: tVRCWuMe2upsvcWE5AVAHvt6VKM3wyTo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-05-31_04,2023-05-30_01,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Stephen Hemminger > Sent: Wednesday, May 31, 2023 12:39 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Jerin Jacob > Kollanukkaran ; Kiran Kumar Kokkilagadda > ; Nithin Kumar Dabilpuram > > Subject: [EXT] [RFT] graph: fix pcapng file support >=20 > External Email >=20 > ---------------------------------------------------------------------- > The interface to rte_pcapng changed in last release so that the interface= s > used need to be added to the pcapng file via the API. If this step is mis= sing > the pcapng file will not be valid and can't be read by wireshark etc. >=20 > I don't have setup to test graph, so needs a validation test. >=20 > Fixes: d1da6d0d04c7 ("pcapng: require per-interface information") > Signed-off-by: Stephen Hemminger > --- > lib/graph/graph_pcap.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) >=20 > diff --git a/lib/graph/graph_pcap.c b/lib/graph/graph_pcap.c index > 6c433300290b..eff7b2d060ed 100644 > --- a/lib/graph/graph_pcap.c > +++ b/lib/graph/graph_pcap.c > @@ -7,6 +7,7 @@ > #include > #include >=20 > +#include > #include > #include >=20 > @@ -80,7 +81,8 @@ graph_pcap_default_path_get(char **dir_path) int > graph_pcap_file_open(const char *filename) { > - int fd; > + int fd, ret; > + uint16_t portid; > char file_name[RTE_GRAPH_PCAP_FILE_SZ]; > char *pcap_dir; >=20 > @@ -114,6 +116,18 @@ graph_pcap_file_open(const char *filename) > return -1; > } >=20 > + /* Add the configured interfaces as possible capture ports */ > + RTE_ETH_FOREACH_DEV(portid) { > + ret =3D rte_pcapng_add_interface(pcapng_fd, portid, > + NULL, NULL, NULL); > + if (ret < 0) { > + graph_err("Graph rte_pcapng_add_interface failed: > %d", > + ret); In error case, pcapng_fd shall be closed. rte_pcapng_close(pcapng_fd). > + close(fd); > + return -1; > + } > + } > + > done: > return 0; > } > -- > 2.39.2 with above change, looks good to me. Acked-by: Amit Prakash Shukla