RE: [EXT] Re: [PATCH v2] eventdev: add trace points

[Amit Prakash Shukla <amitprakashs@marvell.com>]

Thanks Jerin for the review and feedback. Sure, I will send next version of the patch without symbols.

> -----Original Message-----
> From: Jerin Jacob <jerinjacobk@gmail.com>
> Sent: Monday, January 30, 2023 8:02 PM
> To: Amit Prakash Shukla <amitprakashs@marvell.com>
> Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Abhinandan Gujjar
> <abhinandan.gujjar@intel.com>; Naga Harish K S V
> <s.v.naga.harish.k@intel.com>; Erik Gabriel Carrillo
> <erik.g.carrillo@intel.com>; dev@dpdk.org
> Subject: [EXT] Re: [PATCH v2] eventdev: add trace points
> 
> External Email
> 
> ----------------------------------------------------------------------
> On Mon, Jan 30, 2023 at 3:44 PM Amit Prakash Shukla
> <amitprakashs@marvell.com> wrote:
> >
> > Add trace points for eventdev functions.
> >
> > Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>
> > ---
> 
> > diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map index
> > 4405cd38eb..f6ab242a3d 100644
> > --- a/lib/eventdev/version.map
> > +++ b/lib/eventdev/version.map
> > @@ -121,6 +121,60 @@ EXPERIMENTAL {
> >
> >         # added in 23.03
> >         rte_event_timer_remaining_ticks_get;
> 
> Following updates are not needed in version.map based on the discussion
> happened ethdev trace thread as it is not required to expose the symbol.
> 
> > +       __rte_eventdev_trace_eth_rx_adapter_caps_get;
> > +       __rte_eventdev_trace_eth_tx_adapter_caps_get;
> > +       __rte_eventdev_trace_timer_adapter_caps_get;
> > +       __rte_eventdev_trace_crypto_adapter_caps_get;
> > +       __rte_eventdev_trace_crypto_adapter_event_port_get;
> > +       __rte_eventdev_trace_crypto_adapter_service_id_get;
> > +       __rte_eventdev_trace_eth_rx_adapter_cb_register;
> > +       __rte_eventdev_trace_eth_rx_adapter_create_with_params;
> > +       __rte_eventdev_trace_eth_rx_adapter_queue_conf_get;
> > +       __rte_eventdev_trace_eth_rx_adapter_service_id_get;
> > +       __rte_eventdev_trace_eth_rx_adapter_vector_limits_get;
> > +       __rte_eventdev_trace_eth_tx_adapter_event_port_get;
> > +       __rte_eventdev_trace_eth_tx_adapter_service_id_get;
> > +       __rte_eventdev_trace_port_attr_get;
> > +       __rte_eventdev_trace_port_default_conf_get;
> > +       __rte_eventdev_trace_port_links_get;
> > +       __rte_eventdev_trace_port_quiesce;
> > +       __rte_eventdev_trace_port_unlinks_in_progress;
> > +       __rte_eventdev_trace_queue_attr_get;
> > +       __rte_eventdev_trace_queue_attr_set;
> > +       __rte_eventdev_trace_queue_default_conf_get;
> > +       __rte_eventdev_trace_ring_create;
> > +       __rte_eventdev_trace_ring_free;
> > +       __rte_eventdev_trace_ring_init;
> > +       __rte_eventdev_trace_ring_lookup;
> > +       __rte_eventdev_trace_timer_adapter_get_info;
> > +       __rte_eventdev_trace_timer_adapter_lookup;
> > +       __rte_eventdev_trace_timer_adapter_service_id_get;
> > +       __rte_eventdev_trace_attr_get;
> > +       __rte_eventdev_trace_close;
> > +       __rte_eventdev_trace_configure;
> > +       __rte_eventdev_trace_dump;
> > +       __rte_eventdev_trace_get_dev_id;
> > +       __rte_eventdev_trace_info_get;
> > +       __rte_eventdev_trace_selftest;
> > +       __rte_eventdev_trace_service_id_get;
> > +       __rte_eventdev_trace_socket_id;
> > +       __rte_eventdev_trace_start;
> > +       __rte_eventdev_trace_stop;
> > +       __rte_eventdev_trace_stop_flush_callback_register;
> > +       __rte_eventdev_trace_vector_pool_create;
> > +       __rte_eventdev_trace_dequeue_timeout_ticks;
> > +       __rte_eventdev_trace_crypto_adapter_stats_get;
> > +       __rte_eventdev_trace_crypto_adapter_stats_reset;
> > +       __rte_eventdev_trace_eth_rx_adapter_stats_get;
> > +       __rte_eventdev_trace_crypto_adapter_vector_limits_get;
> > +       __rte_eventdev_trace_eth_rx_adapter_queue_stats_get;
> > +       __rte_eventdev_trace_eth_rx_adapter_stats_reset;
> > +       __rte_eventdev_trace_eth_rx_adapter_queue_stats_reset;
> > +       __rte_eventdev_trace_eth_rx_adapter_event_port_get;
> > +       __rte_eventdev_trace_eth_rx_adapter_instance_get;
> > +       __rte_eventdev_trace_eth_tx_adapter_stats_get;
> > +       __rte_eventdev_trace_eth_tx_adapter_stats_reset;
> > +       __rte_eventdev_trace_eth_tx_adapter_instance_get;
> >  };
> >
> >  INTERNAL {
> > --
> > 2.25.1
> >