From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC11BA0543; Tue, 25 Oct 2022 09:25:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6406E42B6C; Tue, 25 Oct 2022 09:25:27 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 5FFC1410FB for ; Tue, 25 Oct 2022 09:25:26 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29ONBUfC003750; Tue, 25 Oct 2022 00:25:25 -0700 Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2049.outbound.protection.outlook.com [104.47.66.49]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3kcdvrj83g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Oct 2022 00:25:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KOO9M8LgZSdyOmCwNaEJe6KY6OMOv1v3Prw7XARRoMG10hUP73qPPgMvgAYD7rUktksou6wmMZqwBM6Wkty/8F0VotZshjm4+wJvvPM+vi/zPvNC+UfJzCBTwhNoPB9axnnMknSg+Blcwpv7dsv9hLJZiclsBRe04qrt7gYcH0+4wldBfKdq3fSsLhNcgzJIQqFqi5W7rLeLk8IyqmxSzTtwyFQ5K8cW+D4HEUpBfDU2CY3+EjLTZ2Ypk3wiRsvBxFwYMZPpHcX+47oZoygIvgydZ8xqZOcbQDz0K8Z24NKjobG0RZ2zKeCoiAhx/+Xnl5gTqC2FH+VGT+u9JgDiHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t+1wIdDvUxzjjbulxjnST+zRWfjRS1f02P3kFXxenO8=; b=YkUH16bh0kMEGA89z1NEh0r6ltKXCfCQpLM8+Y+PQ/gIuc/tUz9uwZZh24J6+MNNlv13B4egavxHkoK2/fZng2KvRhg7Z+cFO58DG0skT6Cyp3Nq8JeQ4NaDPgzKm4Am56HM9lZ6UmjTKZuBzAjLWbht+qE6r2cyQGtNhRleIf1TVBXVO02rqjN2KEtXwTi/IAySDCbXHNfBTgnyv3l3+n7p5UBXpP7QhRRYKHresXDnuZq/00nLsI1wYZUBcy8ddygxllD7tGSAPJN+v1AgyQr7zBEWphuQMg1y7zEFmxVi7Jw2R9K/tl1t2OVPd+CTGwE9szmvVibVaFX1AXAAhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t+1wIdDvUxzjjbulxjnST+zRWfjRS1f02P3kFXxenO8=; b=llskTv2CMqfftgi8M9Y3vrN13TvVnsPSqJIAQYNt1FY2pNfMLIt/FgMNjJZYgiAiYh9Vuyd30A/dXoQQa+IYDWKp1yZMHtN7J2ez2HNR70YZNb70LPGv3GpbUMs+ahkQ6Q9QcN/q1eBsiQYLASIlTGJXYdrB8le4h2A5K0MVwrc= Received: from PH0PR18MB5167.namprd18.prod.outlook.com (2603:10b6:510:168::7) by CH0PR18MB4323.namprd18.prod.outlook.com (2603:10b6:610:d2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Tue, 25 Oct 2022 07:25:22 +0000 Received: from PH0PR18MB5167.namprd18.prod.outlook.com ([fe80::babe:8efb:2ef6:1acf]) by PH0PR18MB5167.namprd18.prod.outlook.com ([fe80::babe:8efb:2ef6:1acf%6]) with mapi id 15.20.5723.032; Tue, 25 Oct 2022 07:25:22 +0000 From: Amit Prakash Shukla To: Dmitry Kozlyuk CC: Anatoly Burakov , "dev@dpdk.org" , Jerin Jacob Kollanukkaran , "david.marchand@redhat.com" , "bruce.richardson@intel.com" , "ciara.power@intel.com" Subject: RE: [EXT] Re: [PATCH v5 1/2] mem: telemetry support for memseg and element information Thread-Topic: [EXT] Re: [PATCH v5 1/2] mem: telemetry support for memseg and element information Thread-Index: AQHY0/i09WhvvvieGEa9Y8zxwl1gYK4XSaQAgAHkHLCAADvmgIAFcrgA Date: Tue, 25 Oct 2022 07:25:22 +0000 Message-ID: References: <20220525103352.1806937-1-amitprakashs@marvell.com> <20220929114313.1346972-1-amitprakashs@marvell.com> <20221020144046.13b98d76@sovereign> <20221021230751.0b5cbb38@sovereign> In-Reply-To: <20221021230751.0b5cbb38@sovereign> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR18MB5167:EE_|CH0PR18MB4323:EE_ x-ms-office365-filtering-correlation-id: d02d5845-dda9-4376-1cfc-08dab65a1400 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YCTSp5j9j/KP9g4lKMScwRrvfnC+QQ5jwyrufMyP9HPz5h8gkMDbE1aPT7MpjFSCbjDzvk4mrvza7nBKHgr54JhQRhCqKtT3ng0l2iF1+9hTmHcqA172SQCf14GHaDo3kYrdMCOP1yALB63AHxb91Es0Zz4Z4uGzPcrpgaY+3mx2za2+vM/538W66MIsdcCb/EOr9OQjRPYwsuFUJZ2D5DHmo57RiQ5Fp5ag5841pH8bZelhw0wk/VUqgjuwdF6QAzj+fssFWHhQGwVKwuyh7pKnmbS5pe8ibNIkiLQQVG9qpR+McnL6ieK7pr/vExJ8uLUAZdegWAVhxZ0obq10qdoKiHgTrJn9eIHR8ruzsdickzuh6KqsSYmZaZYn8zA2/4DI/iKiMdXk89oTXnN0FnZJets/0cIDXWuRql/bJvQluLJds0hVOVYFQQBrnO3MSpyLA/4peq/y1LeCCQOPDu2ibMbscIxgxBuyfVJloipjuaH6BkH7KvZGXfCG+shNLBQLRqsRiZF/Ot1DUDVEroGkLc2V38KOz/GpdzHv+GUmt9orDHI937ctWZxOXsvoNaubL3QMSrsFMBjXgDgqG+JCYltbmyUMiWLK6DHZ1zbhEMNx0BUGmeqABb3Rioba1Gdrzcyf2jebMHG+bnxD6hToB9nzeVMHmicOq/kSOH+bM+KgZRmZay2RbdnVZ7anB3rKNU5fbwFOirPbKJT/LvauuGMRoKqDKx7Ub2r2I53+zsPbRGY5QSwiiCtrtN6YOlU5zYJP4N7DSg0gCvPXhg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB5167.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(346002)(376002)(366004)(396003)(39860400002)(136003)(451199015)(38100700002)(38070700005)(122000001)(55016003)(86362001)(33656002)(4001150100001)(2906002)(71200400001)(478600001)(316002)(41300700001)(4326008)(8676002)(66446008)(54906003)(66556008)(66946007)(76116006)(66476007)(8936002)(5660300002)(6916009)(52536014)(64756008)(83380400001)(9686003)(7696005)(6506007)(26005)(53546011)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mFx3druvV6DRnkLTnHsvGKUUISxaaFeHMdlRLk7wUQ3zx23bZWPHWe8Gtsl2?= =?us-ascii?Q?AN8h2kvbG9TyTJaTk8DdRbyLFNv2m1RX2QLQ54YpYVFBx/SrHLVlhr7+brMt?= =?us-ascii?Q?jbOvD2CX2PZoPjLCINUVDGTY78ts/UaypX2BUlinHB1IZw5mIGjvoAIF5yn1?= =?us-ascii?Q?1U8eRK5qFzVuCxPVjb01OCUZTZsS3qadCiJE+frgijGgRx9HBiAWOlq/tuXM?= =?us-ascii?Q?KR4W1QLE5UupcE1Beb6e+XyYIBo3YRNN+zwrcWF6sgLF98nbGdJgOLHRqvNG?= =?us-ascii?Q?jz4Nb85QcJp0cK2BPE1TkAge4uc1sl9VG2qAbANk0Q8D34HVtj1cKLHWA92m?= =?us-ascii?Q?pdNmXW9JaG9ZiaWPwJox5p4P9JSMFoeO9DLIGNz9fgGo/AYLNdjqMN/5qMxO?= =?us-ascii?Q?X+b8jJHPv0Ws8v/p8+qPrRAK8DTRvHWvyNfPHZGamSxliMt2Ld31BBbZ5vxo?= =?us-ascii?Q?v8YV756lMR/LiX26Sbamu04Kh9T4VOhLmU/fiaUO8Bm8PuVJ9L3n/ygDEyiK?= =?us-ascii?Q?pPH+hib6MrZJBosZSG7VNZlN9vj11oOxfpX5muz5CKP5liHegp/DTmmCeEZF?= =?us-ascii?Q?xi9iAc7bMHMPHD22LDy1xpDVU+3Kpp+FcLyM9eAvv/hTKnHYBJaVaMxtsjdF?= =?us-ascii?Q?WLstJ3bZd2F9WjqsISocr7trc4nJybxNUGEaag3Ns0jRXyLPV3hG41vMdtni?= =?us-ascii?Q?rce46GlzBc46mmBApxsGqhiUY6+ONV9NB8ElNpZNkkp16716ugGqFwLID/ve?= =?us-ascii?Q?bK/HPsj3zlXdeNOrMS88lXaIDzKvtYpRwcRuHe5VRuSwg6Fvhf3uK0kp75D3?= =?us-ascii?Q?TbRxFDSZpUgOatY+Rm9mOF4Laq8Bq5ILT2u0eeyB54IZBZS673BeaTgrzIno?= =?us-ascii?Q?jFetUEvipncRJhMpn3DJoxm+0NYRuGvLp8K0y4ZehHvLtpBUSqZSKg50PigA?= =?us-ascii?Q?Shsqiob+eCOuSEoTISdWCfxmxCiqQUSNrXPK+bBmjt7ZIfaQjiHDgtg3wrBD?= =?us-ascii?Q?f7BJvKbOEfeaAHIdWxXJPv6sQ/6PIsuv27RYRaUfmQIw6En9lczOXo+LLDS+?= =?us-ascii?Q?xhayQv6JzMbJgNljCYo1gQyzV8RyaTjKtbsXucGxlIEMc2vO0H2TeBxSenAQ?= =?us-ascii?Q?XSTP4IbrAU05NJ2kFcs3GBzJC9uboZK0N7l+yUeg3Py/HNUFYeK/lbOZK4xO?= =?us-ascii?Q?7WcTPMYiguP751cyuyhLDRQXN+uuRcw6frryNiDmo/m0XdVbO2fqgD11puTF?= =?us-ascii?Q?hBrw95UtY+bvZBcvrAkScEnPcUyiuh8PqdOD0k5d+ZOmulKTG+ZCRgHm9rIr?= =?us-ascii?Q?1JivYseZ5E2ORDqAaOdsN7+vtYO4NRcs8kx9+kUvcmOThRqLnclIUNXwltiP?= =?us-ascii?Q?hzAyXGm7qWRgGwY+UGUqTmK5kWwrXBHDe6AIf6eAtqM49M+3PUNCquNJNSKZ?= =?us-ascii?Q?F0TSrGnUgBdoqXPmWjS+QqDdjuA5MwZT4PJ8S/kX/u51+ZZkuY5SXY7MC68s?= =?us-ascii?Q?nIkh6aWN5DRq/YpIpej3GPegixFIoly6KFNUt4w5JRLxMIES+lKjiM46+yol?= =?us-ascii?Q?jhlYc2gYwmiRtxtw9hDQgGOxPDwk/QmDySGRiDiE?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB5167.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d02d5845-dda9-4376-1cfc-08dab65a1400 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2022 07:25:22.4741 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: i/Bung34ORtUcKIhppuneCsjNKpULwlUEPFuTJP7T74aDwqd2aBDbKEKGf7QjXZ/45zOPeSp3UV41Qqxrs6z1EoLAPFTzROh0RjTfSOr4Rg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR18MB4323 X-Proofpoint-GUID: Quf2JKoh3tTl9WmO3pMEDBio2X0H8BqB X-Proofpoint-ORIG-GUID: Quf2JKoh3tTl9WmO3pMEDBio2X0H8BqB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-25_02,2022-10-21_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Dmitry, Sure, will implement 2 new request (1. Msl properties, 2. Address lookup) i= n a separate patch.=20 I will work on other review suggestions as part of v6. Thanks, Amit Shukla > -----Original Message----- > From: Dmitry Kozlyuk > Sent: Saturday, October 22, 2022 1:38 AM > To: Amit Prakash Shukla > Cc: Anatoly Burakov ; dev@dpdk.org; Jerin > Jacob Kollanukkaran ; david.marchand@redhat.com; > bruce.richardson@intel.com; ciara.power@intel.com > Subject: Re: [EXT] Re: [PATCH v5 1/2] mem: telemetry support for memseg > and element information >=20 > Hi Amit, >=20 > 2022-10-21 19:26 (UTC+0000), Amit Prakash Shukla: > [...] > > > How does the user learn heap_id? > > > There probably should be /eal/heap_id returning a list of heap IDs. > > > > Request for list of active heap Id's is already present. > > " /eal/heap_list" >=20 > My bad! >=20 > > > > --> /eal/element_list,0,1,15 > > > > {"/eal/element_list": {"Element_count": 52}} > > > > > > > > 5. /eal/element_info,,,, \ > > > > , > > > > The command outputs element information like element start > > > > address, end address, to which memseg it belongs, element state, > element size. > > > > User can give a range of elements to be printed. > > > > Example: > > > > --> /eal/element_info,0,1,15,1,2 > > > > {"/eal/element_info": {"element.1": {"msl_id": 1, \ > > > > "ms_id": 15, "memseg_start_addr": "0xb20000000", \ > > > > "memseg_end_addr": "0xb40000000", \ > > > > "element_start_addr": "0xb201fe680", \ > > > > "element_end_addr": "0xb20bfe700", \ > > > > "element_size": 10485888, "element_state": "Busy"}, \ > > > > "element.2": {"msl_id": 1, "ms_id": 15, \ > > > > "memseg_start_addr": "0xb20000000", \ > > > > "memseg_end_addr": "0xb40000000", \ > > > > "element_start_addr": "0xb20bfe700", \ > > > > "element_end_addr": "0xb215fe780", "element_size": 10485888, \ > > > > "element_state": "Busy"}, "Element_count": 2}} > > > > > > How this request is going to be used? > > > Elements don't have permanent IDs like MSL/memseg index or heap ID. > > > Heap layout may change between /eal/element_list and this request. > > > > Idea here was to print information related to memory element. This > > information Can be printed for a single element or for a range of eleme= nts. >=20 > I understand what this request does, the question is: what info the user = has > initially, what they want to learn, and whether the request helps them. > For example, if the user wants to understand which elements hold the > known hugepage from being freed, then your request is good as it is. > On the other hand, if the user initially has an address from some debug p= rint > and wants to know if it's free, and if not, what's there, then my suggest= ion > about query by address is more suitable. > Or maybe both are good to have eventually. >=20 > > > Maybe instead there should be a filter by address with maybe a > > > context parameter (like "grep -C")? > > > > You mean that the user shall be able to grep for a memory address to > > check which element it belongs to ? If my understanding is correct, > > can I implement it as new request post rc2 and keep this request as-is? >=20 > Yes, this is what I mean. > AFAIU, rc1 is API freeze, and telemetry is API, so the new request must w= ait. > If the current request helps solving actual issues, of course let's have = it.