From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 19844A00C2; Tue, 27 Sep 2022 15:50:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F36541133; Tue, 27 Sep 2022 15:50:58 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 50D1540694 for ; Tue, 27 Sep 2022 15:50:56 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28R4917E031941; Tue, 27 Sep 2022 06:48:48 -0700 Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam02lp2042.outbound.protection.outlook.com [104.47.56.42]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3jucsq4cbs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Sep 2022 06:48:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cyJPsTCxmk9nNzE9UCI5OngkjCYjrdQBOd4cJpbwVD3t0++pu7NnhmQMHvS8dlRuBsoSS5IbvdcgtHcQLFHNYGloXEpwQyzRLcOmPAfyFFl+YQV6VeM3MU/nw0dCdRVWdzHHSDNX/Jyz6lxdQNIOTE9OV6+0ps5A+6nhXNbWojcPRqOlsirHvAPc2StHRySYGQkq3eACf1R0xwMB1Kj/hcSTkTuBfwOeenqJxf8XQnYOQZyH9AKtone4aADFa61DD5TnuUWf2W+vKqciC0biL5Jqkuwbi+C/JUtH4SIjmtzTPUQDrOaODQ6ebqiGnddfuGlkT08FDRyFGSCmE/cQ7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iWdeQO7cl5b9UWOMWqrlM3ntSmDFBB4c9wuwBtKdpZE=; b=BCddb7hBRgjUbqyB9WPeoxUB9PY3J3gTeWDVUyMK0K89+a87PT7KieLjJq6dIq4JE77Xfb149pWc1SjG7HgUL/2dmRmCAyKvRt79mknjLh1r+QMPjWBg25SuwpbDfZrMSxUZOFuOz1WOvJAa1uBEmUDIpAKbO6BCPlYnoqlg5Z60jOuKBgCqTGTDW2VwMBsBev8KuJXzeKGrqfaVEjH+umx/RnH3KdcAunxeldERbJRCf/0UK2J/CSbvF6XP3k7wMvEycayGAfbvhVNOlQdLgYX0roxw+pAJi9PoBOK2UjqQxfxq8d6VsHY27GsM8kdJOFRGvvUaX2bAtNv5/kR/4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iWdeQO7cl5b9UWOMWqrlM3ntSmDFBB4c9wuwBtKdpZE=; b=sSFsueyXssNISj3JTR1Nobl0GPAA7wYMXUhAb6TwEisFUuDiuYbY+uKIu+V2182okVVt7mZJfEUrdgQIQOmbyJH4GydDnb1O1c9nNmtAPHASffZlp79tg3u304nfCm3GNoPU/KU1DWzNt0b1mxeQjTRtVXPkQ0rkfFCEoDvsS8w= Received: from PH0PR18MB5167.namprd18.prod.outlook.com (2603:10b6:510:168::7) by MW3PR18MB3547.namprd18.prod.outlook.com (2603:10b6:303:2e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Tue, 27 Sep 2022 13:48:45 +0000 Received: from PH0PR18MB5167.namprd18.prod.outlook.com ([fe80::e4f1:7ff8:4f8b:e2ef]) by PH0PR18MB5167.namprd18.prod.outlook.com ([fe80::e4f1:7ff8:4f8b:e2ef%3]) with mapi id 15.20.5676.015; Tue, 27 Sep 2022 13:48:45 +0000 From: Amit Prakash Shukla To: Akhil Goyal , Fan Zhang , Ray Kinsella CC: "dev@dpdk.org" , Jerin Jacob Kollanukkaran Subject: RE: [PATCH] cryptodev: add trace points Thread-Topic: [PATCH] cryptodev: add trace points Thread-Index: AQHYyfJXVznr8Luv5UWsuOeGNJD1yK3y/FKAgABdtXA= Date: Tue, 27 Sep 2022 13:48:45 +0000 Message-ID: References: <20220916173227.27758-1-amitprakashs@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR18MB5167:EE_|MW3PR18MB3547:EE_ x-ms-office365-filtering-correlation-id: 8880c82d-ef13-4ed9-90e0-08daa08eff55 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: h/qrANJsX+uU5f2HX2/EwF0nBQK8EyfFUo9Wu7xs2ta+iCX2QnwXF/w5cWN501sQVkT2IvMZXyGXzaYEG6dj/ls+WVc09EbY5z6AJ+/U21lYMbC6Th/41MwHixtZBMPi5q3CQHqozTtnbLsVktduU3SKcEhqicv76Qszc+ItrBSq7ZwB+XIAHpaGE8Ch/pTC3IxOylW5uNr2QDv8NZyfXYJTBtoNrEMLFo8I4lbf0TyUtPcwE+iMpwd7S1GsogLyinKXPtWzKjV2HcZJhN0jnXoEcRCRcN7Y7qWbwbYQH4piSbJh7uidwRodA/WknxPTf1nLve1LnE6DWc5Qc6yymTbqst1tOC0RP/BDBRrw6OlOHK2mNCUms69lgEPilZrTC/ANpqHZNjSW2Qvv0I6YCsi/O2DheJkOmd+voQvo2vsm/at2lz6UIkw+Xott5Zc8zNnNlCqAXkgkOFzm1TgEEt4spVa9PL/EBQQiCCxxcVwKHOyG/kXNfEqB/7HRYGVg3z716J2JZYZRTf1HTW5aB1/vowgiMX6kZnKQjQekk20oIRIY8nNj7mY0deBhxUvzgP+z/rp9XFjtMff7o8HPwOcfo2RtaPfK4E+iqQw4Bt9EFXRcOkcg0pODbGRTrbtVAZk5sdC5ForeBiUIYFVqve58vCsbMPDtsMrPEbncaQzz6u0FnKclsq4Tx7wKyYXzUJ1JY2Ph+zZ/z8lBZ/PC7Yu0Y589wD0L+lLHRCGVX9loe7g1xHtjQ+n5tFxwZmp957iqjQryjY//Bt7jdebfCg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB5167.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(396003)(376002)(39860400002)(346002)(136003)(366004)(451199015)(7696005)(33656002)(38100700002)(122000001)(71200400001)(86362001)(478600001)(5660300002)(2906002)(55016003)(4326008)(66476007)(66946007)(316002)(66446008)(54906003)(52536014)(110136005)(66556008)(8936002)(76116006)(186003)(38070700005)(8676002)(83380400001)(107886003)(64756008)(26005)(6506007)(9686003)(53546011)(41300700001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wkI5+gq0DooZB+Vljh4J+3yLGwOEQxJsoWn2CYo0KXrOALsKPonfQBNFdsSe?= =?us-ascii?Q?ewFfChrlhslNLd3nRgjk89+z6wJDYoijqiv0Ytjhbn8z86z50w1RIzwC9kQH?= =?us-ascii?Q?IKk9kovwr7cmcwtmYUSUmnTYZQm/aZHa3WnXwOjWLZFGPvUv2yJJuy5tIfiK?= =?us-ascii?Q?ita4hinxeBXy4w0jZBXUokPQd+X8LuLmOu5ZexmJu6pyqYYfjjWRfxtqC4dO?= =?us-ascii?Q?EmoKsPk0F4YgY5xulCyKFtM0BLJwqK4V/LIqI44bZae6L1uu2hcDxhvbwer6?= =?us-ascii?Q?wSrdN+BKpiWAjO6U1y0+c+dHUyFykdWpm6OCbHlacGaJP5ITFBgHC+1r6ut0?= =?us-ascii?Q?XTjziBj1TGuy+zyKuvmmu8GVDjgM5sndi0wD/aR8sXQAFXFrEHJB15h1EN8T?= =?us-ascii?Q?SqvIQ+n97f3B6QJqHQLoj9EUtobOqB/eM8rLCLjxOsm4FBZWhBdFV1uAsltX?= =?us-ascii?Q?8xGeLzFBWPTQieNoBX3jYLIH76ESwrk3zX+zutxaLXp1SLOGcziJ74gpGT1v?= =?us-ascii?Q?WWdNQs4P2cb0kWYYtj0VKyJmlti0D2YA5FYikS4yMakcey6tGH9Suvparq90?= =?us-ascii?Q?NAUjcsg0/NYXKTNURtXE47o+nU2mHwKfj4OYf7GjA3D1l6A+b3VLMnLtLm1p?= =?us-ascii?Q?XyXZIeKScp/VBo3gHR7d2unWZV7jp9JZLvDcel2mKxh/MZbUigW/cBuCDLzW?= =?us-ascii?Q?U5qx41LYNAMoMmtMtuMCc1Q2gRT52bxtxZ4WKbU/GInxFG3SqoxzXH7tKsbL?= =?us-ascii?Q?/2Mtir/HKjmsBMrzQd9F0I+ZDgYiQ+1BY/A9W8mhK2aaBRZQRucH1NMLZtHr?= =?us-ascii?Q?ZGz1f1qS5PwrAOE2IOnScGb27wCmUS+UFBNeW9iinBr1loNm0mZSg+rn0L9J?= =?us-ascii?Q?NlssLnQ0HJ2rU2orpYY94GnTj7Z4MHgjf8cZNWniBDS9RajINpvDLzLhdRBl?= =?us-ascii?Q?2c6PxZ1a3S2Td4y8wNKi8QOacXthFqoIDBQS1Svp+gXsWf8cq29nf///Gaun?= =?us-ascii?Q?KXjazxQqc8z0fGPQEHSHsNaD1rkD8vdtVFssSNv1BbVJ/ktd2N6zE+MexPTo?= =?us-ascii?Q?kKFhuiHeZWMaTxt2X47EmV8F8ryyu8jgmif93cUgNjJAsmV1oE8sxRg+B6gR?= =?us-ascii?Q?P3l6p5sEYNatr9ZnJs0+EdISE06xEDzUgzt2Bs1TheKTpxoaT5jMH0NIq+db?= =?us-ascii?Q?HQzloUwTcSpOOJDzfGycBMGRTiGZPjs+BXG5ZubUeRUo0u2SRhg0K9eORDma?= =?us-ascii?Q?89lOPTr219nXlmTTmx2CAqjZnVLWCT7IWTevvhV18/6cCAz85082Aa1TQO8v?= =?us-ascii?Q?GnaKQZG+X6qUgcmL4msi7y8j4AGg6lcs+GB/w5a2U4IvkuQR8Xjv12rENYuX?= =?us-ascii?Q?/brYZ938Zg/ajnTNgATsABybVgepfUjTAjItwI8XHuJYZlT5XoJY3xsu7NXe?= =?us-ascii?Q?gfTEdEfokvhhdTJ/wASMPBnIDGGthjsnue4AY97gsXegFBx9/jxrKZ3ETck7?= =?us-ascii?Q?wLVVrmlz3/mivsNgVPmtvQ43lecHOOYR4iDQMDfEVxr2bcTbbutwlEcX8pl/?= =?us-ascii?Q?XxWIGmILk1SBAnLuBh52VM0a+q8s9XcxqCxlC43B?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB5167.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8880c82d-ef13-4ed9-90e0-08daa08eff55 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2022 13:48:45.5163 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: i3BwEn4Sca1uRUjDxaFhjhrhzMsAKHe0owjTpybPO6CXWNyARO4AyGvsqWOecuJ4fXqdIw3eqU4smtV401WcOI7zxmzso4FmTvR66zr1A88= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR18MB3547 X-Proofpoint-GUID: GbflgHGDlIxD7IU6pjCWRhMwSZRGmBlb X-Proofpoint-ORIG-GUID: GbflgHGDlIxD7IU6pjCWRhMwSZRGmBlb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-27_05,2022-09-27_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Akhil, Thanks for your feedback. I will do the suggested changes in next version o= f the patch. > -----Original Message----- > From: Akhil Goyal > Sent: Tuesday, September 27, 2022 1:37 PM > To: Amit Prakash Shukla ; Fan Zhang > ; Ray Kinsella > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Amit > Prakash Shukla > Subject: RE: [PATCH] cryptodev: add trace points >=20 > > diff --git a/lib/cryptodev/rte_cryptodev_trace.h > > b/lib/cryptodev/rte_cryptodev_trace.h > > index a3f6048e7d..84991c5b0a 100644 > > --- a/lib/cryptodev/rte_cryptodev_trace.h > > +++ b/lib/cryptodev/rte_cryptodev_trace.h > > @@ -18,6 +18,7 @@ extern "C" { > > #include > > > > #include "rte_cryptodev.h" > > +#include "cryptodev_pmd.h" >=20 > We cannot include library internal header into external header. > We can either have a have a separate file for pmd specific APIs And hide = it > from user or do not allow tracing for pmd APIs. >=20 >=20 > > diff --git a/lib/cryptodev/version.map b/lib/cryptodev/version.map > > index 5aee87c6f7..a788185229 100644 > > --- a/lib/cryptodev/version.map > > +++ b/lib/cryptodev/version.map > > @@ -109,6 +109,63 @@ EXPERIMENTAL { > > #added in 22.07 > > rte_cryptodev_session_event_mdata_set; > > rte_crypto_asym_ke_strings; > > + > > + #added in 22.11 >=20 >=20 > > + __rte_cryptodev_trace_pmd_allocate; > > + __rte_cryptodev_trace_pmd_callback_process; > > + __rte_cryptodev_trace_pmd_create; > > + __rte_cryptodev_trace_pmd_create_dev_name; > > + __rte_cryptodev_trace_pmd_destroy; > > + __rte_cryptodev_trace_pmd_get_dev; > > + __rte_cryptodev_trace_pmd_get_named_dev; > > + __rte_cryptodev_trace_pmd_parse_input_args; > > + __rte_cryptodev_trace_pmd_probing_finish; > > + __rte_cryptodev_trace_pmd_release_device; >=20 > These can only be internal or just remove these.