From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44363459E0; Fri, 20 Sep 2024 19:15:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 323C243469; Fri, 20 Sep 2024 19:15:03 +0200 (CEST) Received: from BYAPR05CU005.outbound.protection.outlook.com (mail-westusazon11020079.outbound.protection.outlook.com [52.101.85.79]) by mails.dpdk.org (Postfix) with ESMTP id B143042F3B; Fri, 20 Sep 2024 19:15:01 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fYUyuLF1jkaHYptBkX50nbS/KwOPw7FL/B6bJHhTRskZUrRYJ/kep80tNrXt72rxkWwIOph5ql+69CKEOLSsFK7RICHMxemIQbUKMgiDfgwG6wWPjFcDN7Gfy8GoY9G7yjwbycnB1GaZiwTKiTc41cYMwZpgyjVkSMsb/kTu6EdUHUU4LseKDD+3X3nXMk06T3zflHHSLK8FS1UAY708TbOggg2ItITLSwHXzvmy5fA2ZRWXrB1VsldrSbHw5INY+PWCVtPWbW1XH6lFMT7IMvIkez0tFo6UPXm4G/A457V3jo3ovay99GHydJX56lrJhAHqbIRYcvuiBrGwIah4FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OwfzDujybnmhif4kfjsZCZuPHi/nw1T3zFDIuHtIz/g=; b=iHLHRcSQSWWl0InqJ1mxNW6aeHySQ40uo3NJ/We0IL2ZlDCe4zNbtxcNSvy18MBqN+RlZFot+n08pG0ImkPGfpMQ+nBY4AbMJ/zsFXaKekoSPF3bY7RGuRChwa44VWiw7/Sz63jI3FszO+tT+0w61L/qlhHiPW4TTgf6RRcyw5kk8LJi7a0F+w8FElcrpGePXrd6+C8GmcvBaTlFSnX0TnvysqLNKCaxwJTK8IqUoNgWXZbnpWfteXQ2b3YCqoJGpS22h1+F/H0NTUCd4cYAVFEG/vpa30quOmgxrT/UbbUDGVKUPIT8sQFcWT+PAGTwhRR729OFDQRT29kvIH1o7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OwfzDujybnmhif4kfjsZCZuPHi/nw1T3zFDIuHtIz/g=; b=eJkUQ4Uopz/h6HTphS/rG4rMrObu5vY0tdLTylPLg+V66TIK4XbRLwIPlENtMAcui3l/jYoGBW0A50tla/r8kmaX/o0W39cLMobjHldPs3iLgF/MIJvMKzsCgalOzc6JHhj8hDU1PCxcSTiM4QWpeUWdKfj7ZvJLGCjo6RzoCes= Received: from PH0PR21MB4456.namprd21.prod.outlook.com (2603:10b6:510:337::12) by PH7PR21MB3334.namprd21.prod.outlook.com (2603:10b6:510:1db::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8005.11; Fri, 20 Sep 2024 17:14:55 +0000 Received: from PH0PR21MB4456.namprd21.prod.outlook.com ([fe80::3a57:1b5a:a61f:eb1c]) by PH0PR21MB4456.namprd21.prod.outlook.com ([fe80::3a57:1b5a:a61f:eb1c%5]) with mapi id 15.20.8005.001; Fri, 20 Sep 2024 17:14:55 +0000 From: Long Li To: Shreesh Adiga <16567adigashreesh@gmail.com>, Wei Hu CC: "dev@dpdk.org" , "stable@dpdk.org" , "thomas@monjalon.net" Subject: RE: [PATCH] net/mana: support rdma-core via pkg-config in meson Thread-Topic: [PATCH] net/mana: support rdma-core via pkg-config in meson Thread-Index: AQHbC03YYKH0bdRTZEWiLG2YqdtVb7Jg6keQ Date: Fri, 20 Sep 2024 17:14:54 +0000 Message-ID: References: <20240920111116.1486095-1-16567adigashreesh@gmail.com> In-Reply-To: <20240920111116.1486095-1-16567adigashreesh@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=4a7da1e8-bb7d-451a-8841-68f7c3a060a2; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2024-09-20T17:13:42Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR21MB4456:EE_|PH7PR21MB3334:EE_ x-ms-office365-filtering-correlation-id: e9abd2be-9d5a-4562-70bd-08dcd997bf16 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|376014|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?T5ZjQA8N/wxV9JIeRCpavUi/RdFkARrU2V5ueV4IndYy86H4WqNsj5jd2sH/?= =?us-ascii?Q?Wv8MbKvnS9f22zS27dMrwT9wTO0W4eNDLNQNy2L7fd/zfIWf5R3H2VZkz/NX?= =?us-ascii?Q?7+UTpvQLPrxUTBfkOK6mZhDcQf+/HY5YcMfqelWCGG7RhMgG9M0HbMIz+PHP?= =?us-ascii?Q?VJ/8KnMY7bvBqmRnmEKo1MKyAW6UzRA09JoolYmKDjaWWk9Wrz7e/Ox0ATrE?= =?us-ascii?Q?T3TiaLIqOi2YI+KzFpORF4xD46NXlDgV5Snj7v1TmsfM4I//TOnqKD/f80cK?= =?us-ascii?Q?9dw1i/iyRXycho1CNo2UR1qbM4G/JhhEFD6YCHUpkNDBo/JsmgnE4n0ZL49f?= =?us-ascii?Q?QoNbmnB1x1Ued1vMh/CQxX3n1PJkOocCZ0lf7p71Rs5lxCGxChTfJs5jKwU0?= =?us-ascii?Q?2TeF5tlO1Fs/00fJCKFk83ESwr5v551s5zn4olHMs25C9Hh+KCKcoI0IqzL8?= =?us-ascii?Q?7+Jo26ry2zQm4FxGlKYLEN+Shb8FX7MDiLC8RsemWOqh/gczRl5KefTsixWn?= =?us-ascii?Q?e0k0jgrecL2la/WGXtC9wT6GlpBpMiMFeQiskXeB9nSQydD+LuhLtbJS+jmR?= =?us-ascii?Q?dwAeAyzvFjg5VOSGJ+MyiOJQH13MzzgkbARRY1GQXkxnB/s8+HZ6Xkq8apFN?= =?us-ascii?Q?wyvHqoGe507BC1TFT2zZY5OjbgWjbJjl1H6joMjTg9iQumOVpTP2/P6LlCGL?= =?us-ascii?Q?xxboYNF7HPC6BVbfdrRg6KR3LWw88jUJPxJJDGjXOmksv3u+R1SdFNEwMAIZ?= =?us-ascii?Q?TBbYde0cHuxBqa+D+wkqfRFs4GnT5XTQDz4nyKpJnOvYq+B+xTL8emIs1f1S?= =?us-ascii?Q?VoL3R6+UFw14flemkt0IbuWYDZjzYXLp419Bo4EeTm/YIFTS46ZN/MlpLmLl?= =?us-ascii?Q?BFyNYJMIMCwuDgKhXIq2fKEG5z0LXMnl8a8UNT7oav8fHqcoPOuwan3oaA86?= =?us-ascii?Q?piaQ9aDtdpBqr5wUdNgVedr3q+UYl0CJpEgxZXhpPPqAa9KPSEdbYxMvG2uE?= =?us-ascii?Q?XEVB7s3i+7/fj2e0nd6EYlmieLuVfT8201SBTjRKGmUC8nOTkyjFi7IXfT1r?= =?us-ascii?Q?kdigNtvRpF7iW2hkvQL8mEl62+EsqIg7NLYsyfEg4moYJcGzhL67RLrXavsD?= =?us-ascii?Q?TI3dPNHwwDvf4EspH4xUeTmcsbCGkxOwKQwk+y6SRe51gGDvyezNqElqt+NP?= =?us-ascii?Q?ihX5rOlWcYAsyY4REc6pGDE1agv1sGIY87db04xxxHErq5dhtaxIno3LpSaY?= =?us-ascii?Q?4QjVzwETeF6O+5G+rsWtAlknEDLT87ImGESFdlw/S7lxmAIlNOdVvme5M4Iw?= =?us-ascii?Q?7SYpArfuM8IF+YEhSObczJIDjCPwrSpxxsMRm/Joer0smQ=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR21MB4456.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Vi3Ncm/12okFcbevzBtMxRuCg/b9HZHdp2B3OFJtM5Yd/PwMF8pZV6dS6Fzm?= =?us-ascii?Q?LqBlsrWrgds/c/cM+lOF9aop4yUTBFji5JoXvDZ4FU2QhIZoloUuCDxZZIX3?= =?us-ascii?Q?unWX9QH9ZbrjeS6zqsmeThPKuMfwonX2SyFTO0QWpDuIkDkxiMeBv7oOYLck?= =?us-ascii?Q?P6dxM9vlZubR0gAEWp0WUEANsBKSaCoROj4zzpqae/6FOB9bkyFIVkLhMSJM?= =?us-ascii?Q?bsPvGKBg245ekl4bHIoCckhrDm8L5Idz1N2ssyxmUKGFdPyiSF91/OC2wkKB?= =?us-ascii?Q?ayBJU9BVQ/9ojmd/rVEAbUes6ER89+xoAJGHYS+U8CbaL4uYAfLiHxabnVTZ?= =?us-ascii?Q?rQmuIwRWioz1c/I4HsFYVeFN3gBvLuQg9p9ha/es8WwrtoHxrMHcMQ0Kw3B9?= =?us-ascii?Q?0aNsA5thw1GxbrSnR6+N+2uhjYabL2tdgolZSaXB4JJFLmwICqiwHwVi5pp/?= =?us-ascii?Q?pPKNcSrxM0G7Rnuhq2s+3MytLCJ4soQsXeEBPjWxRWqdzA0DN/T0j3+8eOSG?= =?us-ascii?Q?KVqpvv762ihAt/rutVpDq12yJUb7BhC7zp7rFAfu/LJfUaYrwIsMYvRlTHc8?= =?us-ascii?Q?ocXNLtbzHM4ttwokrQdaH8nbY/ArY9r9U6s4eQGKNI2alMS1jHtl2b8h/RiV?= =?us-ascii?Q?j3ptT/lG3MkQKBp4UuR+GeT5rBc8bpQfpXNMk9CflRq1ZITgCo2ar9WRQmXb?= =?us-ascii?Q?aI3T9lF/wnbqk9QurF/xZ7brZAYXXSM59E0oLy7pnrzhn93Voz5F4BWM3ouY?= =?us-ascii?Q?9WIaEMLS4in0OcntWjDAdwXvSkor4AvlCMAcnl2f5HxhBAbZ2g/c9Ou2wrDM?= =?us-ascii?Q?PIED8K7fhNsrOx4CpF9x2UglEPCghSlFtDJ8WF7+GTpal3Nbr3NuU0k/4D7Z?= =?us-ascii?Q?o19pMGFkvMIENsmBe3JyeO6DBQVCgwlX313qsxD3nD50eHdKQZXjwayfxcM9?= =?us-ascii?Q?Iw5mrP8fkCUUS46oXTRyj6StR35dPn2JLvmVJKkSiZdOkDQ2LPbmIZT7f65I?= =?us-ascii?Q?Shek5KD1J/v/o8rp8I4tAQYaPtUtAUnUJlhL/UNFaow85RbN9WtX+SX3GuQ5?= =?us-ascii?Q?CH/9QtZAlcQBKlGJ0yPGNq9G187tCKPpSoOiKnaYFzpGpGJU5KLEBbin678s?= =?us-ascii?Q?xMh/ga7eGnO7tEaKMFtWaDAZ52wG9bdP1NkGl1KR4aP8opynv7tb58Bgv+Dl?= =?us-ascii?Q?BCYOuLmysxYJPalIz7NCDazf7EBpkZfa2ZF8xEPrnWMCX+CbOfn78Jh0ckr6?= =?us-ascii?Q?poqd7HbyGtxhow/pblJ3xGsvB/ufq6DOg45YnttYsCDIw0ZgWdnFvLYKTorm?= =?us-ascii?Q?qpj0lbEElIkNgIa5KIU9NQRwJAUvLjt2mheKVy6CNfZu1SboOnjKX23jQWeW?= =?us-ascii?Q?qSVpa9dkOncE6Q6WsshT8D3zcklLF4JkhfQnNq31aihhSHNMZuG5oGIMI6r9?= =?us-ascii?Q?W9fQiFyIwS5u7OT3l1W2GK6PwG8rblnQVUxdRxTTW3qeiTZL65LqJWUebi0n?= =?us-ascii?Q?QwZf8F1Mo9ilElsuy+X33TeNGzevf0YUm+UIFqTEX3uO4pQSaNjh7jkB1S5a?= =?us-ascii?Q?bs+givoQBNWplbi1tDF9sPl7NUya/1VljJzUwziN?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR21MB4456.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e9abd2be-9d5a-4562-70bd-08dcd997bf16 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Sep 2024 17:14:54.8371 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8Xz06SoFgIyPKWqjWnIxrLv7FajuRmKv3jn9Z8GD6hlFwQkgcaKzdmYLT+/o8mxMu/xVa88z8PlG12jdd/298w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR21MB3334 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Subject: [PATCH] net/mana: support rdma-core via pkg-config in meson >=20 > Currently building with custom rdma-core installed in /opt/rdma-core afte= r > setting PKG_CONFIG_PATH=3D/opt/rdma-core/lib64/pkgconfig/ results in the = below > meson logs: > Run-time dependency libmana found: YES 1.0.54.0 Header > "infiniband/manadv.h" has symbol "manadv_set_context_attr" : NO >=20 > Thus to fix this, the libs is updated in meson.build and is passed to the > cc.has_header_symbol call using dependencies. After this change, the libm= ana > header files are getting included and net/mana is successfully enabled. >=20 > Fixes: 517ed6e2d590 ("net/mana: add basic driver with build environment") > Cc: longli@microsoft.com > Cc: stable@dpdk.org > Signed-off-by: Shreesh Adiga <16567adigashreesh@gmail.com> Acked-by: Long Li > --- > drivers/net/mana/meson.build | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mana/meson.build b/drivers/net/mana/meson.build = index > 2d72eca5a8..3ddc230ab4 100644 > --- a/drivers/net/mana/meson.build > +++ b/drivers/net/mana/meson.build > @@ -19,12 +19,14 @@ sources +=3D files( > ) >=20 > libnames =3D ['ibverbs', 'mana'] > +libs =3D [] > foreach libname:libnames > lib =3D dependency('lib' + libname, required:false) > if not lib.found() > lib =3D cc.find_library(libname, required:false) > endif > if lib.found() > + libs +=3D lib > ext_deps +=3D lib > else > build =3D false > @@ -43,7 +45,7 @@ required_symbols =3D [ > ] >=20 > foreach arg:required_symbols > - if not cc.has_header_symbol(arg[0], arg[1]) > + if not cc.has_header_symbol(arg[0], arg[1], dependencies: libs, > + args: cflags) > build =3D false > reason =3D 'missing symbol "' + arg[1] + '" in "' + arg[0] + '"' > subdir_done() > -- > 2.44.2