From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70E27A04FF; Tue, 24 May 2022 01:22:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F0FD4067B; Tue, 24 May 2022 01:22:14 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 2A2504003C for ; Tue, 24 May 2022 01:22:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653348132; x=1684884132; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=JuI1KQ8lPlHWP+2CKX+GQPwlmFDmf0n6Rv2+OWHRmlU=; b=jBlJChppgKYU92iyiDpU9+ByaAIrJWDjnSgHIOGZXNLVc1/KsJoAd3at LRqO/xTzU8OpqalZI/oV7LfGcIoPeoG1cYTySKakJBHa5J4995REYdTKw RQG3nxlaS839DSDJPRHHA+Z08K9yG/lwG0e0IFcP9X7zp77I7zsm0FwyP xQTW31zQzzKl8FfWkYM8FfWyB7wUcUadXdiS73miFf/kivilaysDri0Kr XwvLft/8x+7ffLpojHXr2og+BWIW4KZQmho0HozrkE3YoxSPYOMK7/ZU7 /jsfVEvjBOSOpFbnAsUVjYlZ67w/u0Kj41enHH7oBGhXQXtZS/xaEUpPF w==; X-IronPort-AV: E=McAfee;i="6400,9594,10356"; a="298699602" X-IronPort-AV: E=Sophos;i="5.91,247,1647327600"; d="scan'208";a="298699602" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 May 2022 16:22:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,247,1647327600"; d="scan'208";a="744981590" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga005.jf.intel.com with ESMTP; 23 May 2022 16:22:10 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 23 May 2022 16:22:10 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 23 May 2022 16:22:10 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 23 May 2022 16:22:10 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.44) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 23 May 2022 16:22:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oGTHZ9p8ZBZwmsema53K5XrMJWPBhbpOgGf2YTAU1AJlhZgMQxZTl5HAHhCjmR5LBlR3Z25KXmZc4WWQZ3ooRLSSYJDJOr1w0Cic4AkDPVlEBuBpmeNQsiwnvh5FOGREz3UeTIrJfKGhCV1ufTkr3G6H0mBe8BrOJhMRUYVJrbOqcPJth8C8S95gXYfRgcLM0fZ5Y2S8cbrOSEJmhQrk8ygmVpYx4d9X728Ant8AUf6eSr9YQiqNsfHxJcmmRijuhPkOPawODhOcofLun3chlrWom6pFs4RlLw/wchhL0j/pDDUCNGzUH47fDrenwJgb63JFa3KciDWMW+p+Z41GqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rsETBZF5Pyw014v2BBx0eaRDs5HKyUvvV70ub65e7aI=; b=H6/7W6ifjfi5CNC/CJV5zDw5WeMUlxwaW0j8AVV4l25FJWRku0FOtMtoGRI/I0BoApeHQ3+h65fZU8YyI8mHHyIqhjKkj7mLppqqyZgh6TQNv19s0kq4QcpLdtq1OENL57qYTEuGC/68F/QL9zoIoXhIq/6mnAE5xv/5SQgSY9Zy53zQtPeGnypriGz591fiOFt5+K0wZxXhKk3vLt8nkrQBwd089c0PsTa1uAKXrBIM3UyHw6HD+cvgXG8GWLvCAN9I1FGSw+L1n9haH3OUAJopWR16KOwHXtYdeV2Q9oLRgQPCCdG3iCUXwv/BYxeq0iNjEOnhrXbYXL17/XEpgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB5982.namprd11.prod.outlook.com (2603:10b6:510:1e1::20) by BYAPR11MB2632.namprd11.prod.outlook.com (2603:10b6:a02:c4::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Mon, 23 May 2022 23:22:07 +0000 Received: from PH7PR11MB5982.namprd11.prod.outlook.com ([fe80::317e:73cc:d3fc:4fac]) by PH7PR11MB5982.namprd11.prod.outlook.com ([fe80::317e:73cc:d3fc:4fac%3]) with mapi id 15.20.5273.023; Mon, 23 May 2022 23:22:06 +0000 From: "Zhang, Qi Z" To: "Daly, Jeff" , Thomas Monjalon , "dev@dpdk.org" CC: Stephen Douthit , "Yang, Qiming" , "Wu, Wenjun1" Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices Thread-Topic: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices Thread-Index: AQHYMnOyeQTUxssyHEy+SSEKCDh1Cqzuk+wAgDi80mCAATIIgIAD4m+QgACUc4CAAJHc8A== Date: Mon, 23 May 2022 23:22:06 +0000 Message-ID: References: <20220307223442.28012-1-jeffd@silicom-usa.com> <1681763.yIU609i1g2@thomas> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0e06d6bd-27a3-4f5a-83a9-08da3d130d8c x-ms-traffictypediagnostic: BYAPR11MB2632:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fCi8B/csZiibUSYtIhN3H/52ebPwCpqBzK4N0nLD4A5uAmIbpKzALxyw7WbZlrFjiHhxitKc0AXZ00vRF09VAhndqapSCFeVQ9zVbmNm4yyBJUVh9Cp7kuwve41joKh4jD1bi/tTuOWgYlBdoEGZ0+Dx53S2PA4B0Z3Msff2dDpGjx0WZiJiqS9S3+kiSvuHibif6n5ZbZWVXiYymGLD6ZefSg4EJGJYKb6NAEtI7hQt39VNkLh0X7cpAmYNlcc5yucReMUziKnin18mC68ka+VL65FV+SkYVdn+zs9+X0WYUmby1EhCcjE9t/4q/PwIzGZhktrfBAeIqI+ShRCd8fnV6zkWyiVpiHwRamN9QTIK7zOjOQAGLn7HF7jyi4xxTg9zBUyvc7577KOK3AYE8DKAOF76yOpzJxEbb45ZQUZ/fNT0CwDr+5OV1nOgaMdym4U1vdUYnCTQ8sfz3JaVh5MeoVbFtSxPsPYoFiXT4kuQj3tSqMLUTKgknWY3iHKJ2OSpvwbTuYhmV5EFKGxxG7i9zhNviz2CCAfgqKx4GCV+wT2znYIngyDGpT5pf7T5YDNf9ylR+7ojfBSJpjRbF1De42hDRdfhkNZUW9nzk9H+r1jMs5KiuFDe/3MNI0zbWyZNQhWC7KtT66i3w8ek2Dgf/vEWYtOXNmF9Frge6KnGwZQAsXvBilCYe/0bA54pBJ9DOkqMXWMWdD5IzcKkyLAv8jFudmUVGcayKceVMCrNqymhH4aP0W7Hhe5V+hTLbuOwv2/FE4cAa2zgASEU6BgN+DZmBfPfZUuEfsdk2CXXBWhhP/Re8tA5XPpoZz0X+tEg5T2BWDULMks9fLNnrA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR11MB5982.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(82960400001)(38070700005)(8936002)(52536014)(5660300002)(38100700002)(2906002)(122000001)(55016003)(83380400001)(7696005)(6506007)(54906003)(316002)(186003)(66946007)(33656002)(8676002)(76116006)(26005)(9686003)(107886003)(110136005)(86362001)(71200400001)(966005)(66556008)(66476007)(66446008)(64756008)(4326008)(508600001)(53546011); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IGfrFsDMTRzf6qw209q+YufWLYkoLeKF42fHJuHDdUio/Sf8MmtNW7++PeT3?= =?us-ascii?Q?z+koLw66IMOQyI2IQAJ7EMXhDrT4cPHqVYR5AQ/X9RP8rsqTeOElnxy4bDuB?= =?us-ascii?Q?S2LSWLh6w46mZ6OYJ6NS5FEHaRUZTuLqg0e75yInsEJLRY0fHhhQ6Kj3sj6n?= =?us-ascii?Q?2B22TF4RlGxhUXNllx3i4VU/z6jvLkXM4z8v1Rl59buCItaYXyxgQqDR7spM?= =?us-ascii?Q?jVf14xShFVLYKHYs8DQFevqmHTjTOSvVVgPzDWisTHSRJ+kvGq6zk3vYQq9i?= =?us-ascii?Q?c1/PJYGsuOtCC6Ux6zjDKMV7Foe8ZsD3qI1OK5gtpHMo03t0jhoD0etieA1B?= =?us-ascii?Q?3eBYmHRlnDoBJ4BClsoDxooNVH9VU7tE/seaL08pgdSVinr2hXEE9B7F/egF?= =?us-ascii?Q?0RsPTngBfhRCw4i/pr303LbtUEYWQKbsY0GtDMHVLq1pwYD5IRbcgsZMr8dk?= =?us-ascii?Q?eWGa8gjlo6aBqq4OxypUL7ZGOCeWE6b5NpjqJB0rowNU0CpszgB+Vri8bkjM?= =?us-ascii?Q?5d4JYXXG45tcwW0cTtDSryvwCqViz7MVuTyd3GemynvbFTirVv0QTEmDv0b3?= =?us-ascii?Q?vqXeNpywduT66VwiZX61bEBy9f3Z+KbG+W+rr4yS1BPD32D4KYtljrEW/gAM?= =?us-ascii?Q?TkehnPHGxO2uAXTQK6Sz1t5fjk5seULxeXAbMjY/2quq6wb2ywgcIZs4WMW4?= =?us-ascii?Q?u92MHA3pM62P0+ysWQWDHZriH6TVIBRMBg7tmgSL6hNt1aXosE3UgvJin1eK?= =?us-ascii?Q?vKj++ig5+G1pHqRpZRMyV4lOWCiXfPY+cMqEbGoWB1k5ELhd13ehwkxGssiC?= =?us-ascii?Q?19RMsmu9m4AvBj9jfJwY+iJQRZ4ufkx5ZsGRgnqIbdx15lcE0qqtymjDh9bR?= =?us-ascii?Q?+PSpLEUvYEM4PdowIXHNCPU+6SEkbG9yr5wcIjByqkcXJTyjhL/cNZ5WACxE?= =?us-ascii?Q?/N+TVFRSB87v1ajdFiXV5TDhDUJ7xFdU570FS1czk0fhxksNeiIG6ckxVjsE?= =?us-ascii?Q?9UBhOZBV3jiLdmA4l3YNzPzPHXaFOC1kxVbLR/IX2L+JyBT0T3EQ3qRFHWYk?= =?us-ascii?Q?DobnbfnbXkp64wBOQyMdNZUwM4zJCmPkELKW0TDI1gusXHayDzSNt+SY55dj?= =?us-ascii?Q?Fyk3m9n5cLMPqqTTYsHrFJhbOsi7dlQSl8s7SFyK7Qv5644Q8ZymHILZM0/3?= =?us-ascii?Q?BC0w4TLjdX62xY7A5s127zcH44Ni95n0uYXviAIS9EZWV1p4uZ17jhXxXnBE?= =?us-ascii?Q?UnMl0PxP0ewD4NWO1AWYenbs3MVY5L9AHPPwuNuqRtWQoH/W+dSxpuFnXrLZ?= =?us-ascii?Q?/LQqlR3r6xY1uwdtzlh2ManN8/xkwW6oQAZ7+r9gOUVQJJMtsXSKaImThA0Y?= =?us-ascii?Q?HNfN2FnzHxfvqcUuj8cafqeLJEfqfM6N732C76rcDtBJTHNQzuMFd/ii/7v/?= =?us-ascii?Q?0pNXYQnoEftjGImoObFshnBhoW/GE9iNpkc5H6Dl0CvmDOmr4sgIWQTqGLpb?= =?us-ascii?Q?+guYnNok8rR62ESxJHooSBxHwAhMgh9+O11kql4uN+q4PKP1vMujS3kHLP7c?= =?us-ascii?Q?/yTNow7kIUAl88Z5V5fi/YXRjLeWorkr/mSaz6FT1V/VU3362LxIglcyMCZ2?= =?us-ascii?Q?FmvFwoH528zHbJF7kQojVKhhiItvwaKapwFJ2THQMDNtTHmSpKlTp1S1V35m?= =?us-ascii?Q?q2OYdFk+62GOCsnlchfgqM7lawXOscu0XL6ga/c0uOt6PimGPOFq60rVdsbe?= =?us-ascii?Q?rLXIV5sfHw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5982.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e06d6bd-27a3-4f5a-83a9-08da3d130d8c X-MS-Exchange-CrossTenant-originalarrivaltime: 23 May 2022 23:22:06.6863 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: t00DdSHcCQSBp62FTnegSr9a4SkijAEJX42eIzBecmwC2ICdzA/AW3ShVSdhiTEgypULwERDZ07I1t90CKF0Sg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2632 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Jeff Daly > Sent: Monday, May 23, 2022 10:14 PM > To: Zhang, Qi Z ; Thomas Monjalon > ; dev@dpdk.org > Cc: Stephen Douthit ; Yang, Qiming > ; Wu, Wenjun1 > Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 dev= ices >=20 >=20 >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Monday, May 23, 2022 1:37 AM > > To: Jeff Daly ; Thomas Monjalon > > ; dev@dpdk.org > > Cc: Stephen Douthit ; Yang, Qiming > > ; Wu, Wenjun1 > > Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 > > devices > > > > Caution: This is an external email. Please take care when clicking > > links or opening attachments. > > > > > > > -----Original Message----- > > > From: Jeff Daly > > > Sent: Saturday, May 21, 2022 2:03 AM > > > To: Zhang, Qi Z ; Thomas Monjalon > > > ; dev@dpdk.org > > > Cc: Stephen Douthit ; Yang, Qiming > > > ; Wu, Wenjun1 > > > Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the > > > X550 devices > > > > > > > > > > > > > -----Original Message----- > > > > From: Zhang, Qi Z > > > > Sent: Thursday, May 19, 2022 8:15 PM > > > > To: Thomas Monjalon ; dev@dpdk.org > > > > Cc: Stephen Douthit ; Jeff Daly > > > > ; Yang, Qiming ; > > > > Wu, > > > > Wenjun1 > > > > Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the > > > > X550 devices > > > > > > > > Caution: This is an external email. Please take care when clicking > > > > links or opening attachments. > > > > > > > > > > > > > -----Original Message----- > > > > > From: Thomas Monjalon > > > > > Sent: Wednesday, April 13, 2022 10:21 PM > > > > > To: dev@dpdk.org > > > > > Cc: Stephen Douthit ; Jeff Daly > > > > > ; Wang, Haiyue ; > > > > > Yang, Qiming ; Wu, Wenjun1 > > > > > > > > > > Subject: Re: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the > > > > > X550 devices > > > > > > > > > > Please, could we have a review of this patch? > > > > > +Cc new ixgbe maintainers > > > > > > > > > > > > > > > 07/03/2022 23:34, jeffd@silicom-usa.com: > > > > > > From: Stephen Douthit > > > > > > > > > > > > 1G Cu SFPs are not officially supported on the X552/X553 > > > > > > family of devices but treat them as 1G SX modules since they us= ually > work. > > > > > > Print a warning though since support isn't validated, similar > > > > > > to what already happens for other unofficially supported SFPs > > > > > > enabled via the allow_unsupported_sfps parameter inherited > > > > > > from the mainline > > > > Linux driver. > > > > > > > > > > > > Signed-off-by: Stephen Douthit > > > > > > Signed-off-by: Jeff Daly > > > > > > > > I think we need a devargs for this feature with well documentation > > > > So, it should not break existing behavior by default, but allow > > > > people to take risk if they know what they are doing. > > > > > > > > > > there was already a patch submitted to IWL mailing list for this > > > feature in the base driver, which was rejected. > > > https://patchwork.ozlabs.org/project/intel-wired- > > > lan/patch/20220414201329.27714-1-jeffd@silicom-usa.com/ > > > > OK, thanks for sharing this, > > > > But base on the concern of the previous comment > > > > " As for 1G Cu SFP treating it as 1G SX, some 1G-Base-T SFP modules > > require the use of RX_ILOS and some Intel Ethernet products don't suppo= rt > that." > > > > We may have a risk to accept the code as default behavior > > > > But devargs is allowed in DPDK for device-specific features. > > >=20 > ok, I will submit a revised patch that uses a devargs (or whatever) switc= h to > allow the behavior when selected explicitly. >=20 > But, can we *please* STOP marking patches as superseded when a follow-up > patch > hasn't been submitted yet!? I've marked the patch as 'Changes Requeste= d' for > now. Sure, I should follow, thanks to correct his, but a little bit surprise, wh= y this looks like a big deal, it just a shortcut when I expected a new vers= ion will come then I skip one status change, I think mailing list already h= ave everything about the patch status for you. =20 > When I submit a follow-up I will set this one to superseded Actually you did NOT change the below patch to superseded after you send a = new version (I did this) and you didn't reply my last question yet. https://patchwork.dpdk.org/project/dpdk/list/?series=3D23046 >=20 > > > > > > > > > Thanks > > > > Qi > > > > > > > > > > > > > > --- > > > > > > drivers/net/ixgbe/base/ixgbe_x550.c | 14 +++++++++++++- > > > > > > 1 file changed, 13 insertions(+), 1 deletion(-) > > > > > > > > > > > > diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c > > > > > > b/drivers/net/ixgbe/base/ixgbe_x550.c > > > > > > index 8810d1658e..8d1bc6c80d 100644 > > > > > > --- a/drivers/net/ixgbe/base/ixgbe_x550.c > > > > > > +++ b/drivers/net/ixgbe/base/ixgbe_x550.c > > > > > > @@ -1538,9 +1538,21 @@ STATIC s32 > > > > > ixgbe_supported_sfp_modules_X550em(struct ixgbe_hw *hw, bool > > > > > *linear) > > > > > > case ixgbe_sfp_type_1g_lha_core1: > > > > > > *linear =3D false; > > > > > > break; > > > > > > - case ixgbe_sfp_type_unknown: > > > > > > + /* Copper SFPs are not officially supported for x550em > > > > > > + devices, but > > > > can > > > > > > + * often be made to work at fixed 1G speeds. Pretend > > > > > > + they're > > 1g_sx > > > > > > + * modules here to allow g.Fast DSL SFPs to work. > > > > > > + */ > > > > > > case ixgbe_sfp_type_1g_cu_core0: > > > > > > + EWARN(hw, "Pretending that unsupported 1g_cu SFP > > > > > > + is > > > > > 1g_sx\n"); > > > > > > + *linear =3D false; > > > > > > + hw->phy.sfp_type =3D ixgbe_sfp_type_1g_sx_core0; > > > > > > + break; > > > > > > case ixgbe_sfp_type_1g_cu_core1: > > > > > > + EWARN(hw, "Pretending that unsupported 1g_cu SFP > > > > > > + is > > > > > 1g_sx\n"); > > > > > > + *linear =3D false; > > > > > > + hw->phy.sfp_type =3D ixgbe_sfp_type_1g_sx_core1; > > > > > > + break; > > > > > > + case ixgbe_sfp_type_unknown: > > > > > > default: > > > > > > return IXGBE_ERR_SFP_NOT_SUPPORTED; > > > > > > } > > > > > > > > > > > > > > > > > > > > > > > > >