From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: Min Zhou <zhoumin@loongson.cn>,
"Yang, Qiming" <qiming.yang@intel.com>,
"Wu, Wenjun1" <wenjun1.wu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"maobibo@loongson.cn" <maobibo@loongson.cn>
Subject: RE: [PATCH v2] net/ixgbe: consider DCB/VMDq conf when getting RSS conf
Date: Thu, 4 May 2023 13:53:27 +0000 [thread overview]
Message-ID: <PH7PR11MB5982A7DAA98F33B4578E485BD76D9@PH7PR11MB5982.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230428084257.3440913-1-zhoumin@loongson.cn>
> -----Original Message-----
> From: Min Zhou <zhoumin@loongson.cn>
> Sent: Friday, April 28, 2023 4:43 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>; Wu, Wenjun1 <wenjun1.wu@intel.com>;
> zhoumin@loongson.cn
> Cc: dev@dpdk.org; maobibo@loongson.cn
> Subject: [PATCH v2] net/ixgbe: consider DCB/VMDq conf when getting RSS
> conf
>
> The mrqe field of MRQC register is an enum. From the Intel 82599 datasheet,
> we know that these values below for the mrqe field are all related to RSS
> configuration:
> 0000b = RSS disabled.
> 0001b = RSS only -- Single set of RSS 16 queues.
> 0010b = DCB enabled and RSS disabled -- 8 TCs, each allocated 1
> queue.
> 0011b = DCB enabled and RSS disabled -- 4 TCs, each allocated 1
> queue.
> 0100b = DCB and RSS -- 8 TCs, each allocated 16 RSS queues.
> 0101b = DCB and RSS -- 4 TCs, each allocated 16 RSS queues.
> 1000b = Virtualization only -- 64 pools, no RSS, each pool allocated
> 2 queues.
> 1010b = Virtualization and RSS -- 32 pools, each allocated 4 RSS
> queues.
> 1011b = Virtualization and RSS -- 64 pools, each allocated 2 RSS
> queues.
>
> The ixgbe pmd will check whether the rss is enabled or not when getting rss
> conf. So, beside comparing the value of mrqe field with xxx0b and xxx1b, we
> also need to consider the other configurations, such as DCB + RSS or VMDQ +
> RSS. Otherwise, we may not get the correct rss conf in some cases, such as
> when we use DCB and RSS with 8 TCs which corresponds to 0100b for the
> mrqe field.
>
> Signed-off-by: Min Zhou <zhoumin@loongson.cn>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
prev parent reply other threads:[~2023-05-04 13:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 8:42 Min Zhou
2023-05-04 13:53 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH7PR11MB5982A7DAA98F33B4578E485BD76D9@PH7PR11MB5982.namprd11.prod.outlook.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=maobibo@loongson.cn \
--cc=qiming.yang@intel.com \
--cc=wenjun1.wu@intel.com \
--cc=zhoumin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).