From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A86CA00C5; Mon, 26 Dec 2022 10:04:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2AFA140146; Mon, 26 Dec 2022 10:04:00 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 4DFED40143 for ; Mon, 26 Dec 2022 10:03:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672045438; x=1703581438; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=zbIC9ScfdHmMtdO+wrLaNH4HNR5zvyICrPcHrjviKoQ=; b=eHTjk6tnQV7BVLZh6+9YzoCQtH0NvyhbKcAxuR49NVVvGUYvGNjWPAuK 6G8f34EGm/BLd/uvruoer7OYbyGzjCfJb96x0j9o6zfyWQt3rArFl68qE jqYsP+yhiu15LeikeD5KcG614fAMZhipFaDCYDC08L4H4qCkGXZ+OLX2Q OQeX0uXaDNEhBYWRbffeBe9cO+lvd13GlDytWYFzSjDWVLRftH5LsMfp0 IHQgvDi2DycSot/ZgNJglwlvZxzuiy8gDsmN903vWz/4ay+qVmhkTz/kB dMHZnnWvJwDZaxBqz8Q6bPFB2A4e4Muzq+mX+QJTO/dPsIkf7WMgbGTDd A==; X-IronPort-AV: E=McAfee;i="6500,9779,10571"; a="320635111" X-IronPort-AV: E=Sophos;i="5.96,275,1665471600"; d="scan'208";a="320635111" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Dec 2022 01:03:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10571"; a="646121841" X-IronPort-AV: E=Sophos;i="5.96,275,1665471600"; d="scan'208";a="646121841" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga007.jf.intel.com with ESMTP; 26 Dec 2022 01:03:56 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 26 Dec 2022 01:03:55 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 26 Dec 2022 01:03:55 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.43) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 26 Dec 2022 01:03:55 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XUlylctqRAngpe1gql35Wc/wtOuO26nLSIsFEmiVKxnpaO6Co7/44qYjMkKSkQagrSYYRq/Q+lbY7gD5hKxThUu8X6DfT+xbJ4BxpGylc60FlmyvZm0cONvgJFR66GbnWvLI3Q5yTLy5DoLrmgDa1ChHabGYKjtHLwE1rmq3bCkZwBBjFQrHz3di5IIoI65OeyyFPJxfpuxGkUs4FmGHtC71M1L/TbAE64J46+e1F93yiU55xJC+2zBNK6KwvTbmKongbGm5PxPswrl35YHIdsVIyRSHUgkNaIH1GNDKen0zCxRThLQi18fCOsIpKFNpERvePuvp/B/Lq9AIZPYU6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H0Ki5nefsbPZqHMqjGTpKAGAB3DKVA2xUyfKDdFhYkI=; b=BW5VepbUYatsQMC/cfYnqlV1mRUzV39VSVMGxG4KCrX1w0IBox5GQ/yfQrPzqTjp/F4fN5cuzhAbvvDrlcO1wa+zFYaWynMDEQT4qfeNtbtsef8ut5YkF9aafMeBXA5xQoIokCYGweczUxEIeD2a3oVFYePiogF/ATQK/SDxrjV+rJ72s2MAjs4GTZEBcNI8eJLag37CpJbL6hG+y7KYVzxkHUwQvmgpT7KD2udnGYDOIoFWFQOvTsQR+3l8l2V3irv/TRJU1zTi3RDjWsfnNvYjrHLRZMemJ3cP54E1syLJ6Ylf33STEG3s2bcBpGfAKKzgLyIiii3vjbiL9iYo1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB5984.namprd11.prod.outlook.com (2603:10b6:510:1e3::15) by IA1PR11MB7344.namprd11.prod.outlook.com (2603:10b6:208:423::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.16; Mon, 26 Dec 2022 09:03:53 +0000 Received: from PH7PR11MB5984.namprd11.prod.outlook.com ([fe80::4750:caf0:7127:adc7]) by PH7PR11MB5984.namprd11.prod.outlook.com ([fe80::4750:caf0:7127:adc7%9]) with mapi id 15.20.5924.016; Mon, 26 Dec 2022 09:03:52 +0000 From: "Zhang, Ke1X" To: =?iso-8859-1?Q?Morten_Br=F8rup?= , "Jiang, YuX" , Alvin Zhang , "Xing, Beilei" , "Guo, Junfeng" CC: "dev@dpdk.org" , "Zhang, AlvinX" Subject: RE: [dpdk-dev] [PATCH v3] net/i40e: disable source pruning Thread-Topic: [dpdk-dev] [PATCH v3] net/i40e: disable source pruning Thread-Index: AQHXxVHVOtMgwSa1lECrabu3Rl5jN6yebejwgAAOJbCB5AjckA== Date: Mon, 26 Dec 2022 09:03:52 +0000 Message-ID: References: <20211019093835.3492-1-alvinx.zhang@intel.com> <20211020012831.8480-1-alvinx.zhang@intel.com> <98CBD80474FA8B44BF855DF32C47DC35D86ECE@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D86ECE@smartserver.smartshare.dk> Accept-Language: en-US Content-Language: en-US X-Mentions: mb@smartsharesystems.com X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB5984:EE_|IA1PR11MB7344:EE_ x-ms-office365-filtering-correlation-id: c15987d8-53ab-4b7c-a952-08dae7201c1c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ga4FAjM8z5H9t0OOdH36PRRZju0rsIEkaxO1bxqZga5l1elBjVeILnEzNCvG5Lal8FbySKrd3ECTiXPVFWhPWsGL0/gy2OeebIldL7unEFl+Y8qGJbE+2BPBXCmFv+ACibexzEINDASlZVg9xSqx4ycVPaUuSg4LoI4miaVCbCRSX3l4nCdbDsN2cWtoTHf7rA5+q9QckBLLUHZQfWbfqpJ87486ej1rulBz2G08jqdjETMThBTMPaa9UyvsFOFbjTknmC30S+1ehFlIlbAbY9GyltFvJc43L2gZpBugEoiFe09+ZGzjKl1mSxHvTlVx3LRrb0IRshTdWBxvgzscXfjmI0FFoECZFpyEv+egr8TPnP1qIY60FJDdJogjMaOTb5d7D+t/LtJxWM78fJy3AmLWBZ8ldZfE5Js4vEj/DlJh155EFxlwNbbp0yiVZ14YNEL5T/8WyRWLo/Yutiz8jec9rf8CKrwmH7cC6DTyvB28nfDzJaVbiMWfOaKZPSNnhxJL+0W7nqA5/7PrjXGMNzgu/7N/jWaQtKnQE1o5nCjamZ/MRn/JsMbnsW441eDtR4wJDRBn3VInM6uSW1l0kWwzSGrFDk32mtQLVTIYrhzT4pV0e1wHPmG5OY7DqyPhEhcyX2jH7dTBYVbkCAF/II9p+4NuUmASQUKfi+b/Hu34Yqtn6/MRK0ZE8SwCYIkEi1Y74ao0DdonKqLnYk42yq0P5lHFDlYSyvbLfjgr39o= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR11MB5984.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(366004)(376002)(396003)(39860400002)(346002)(451199015)(33656002)(2906002)(82960400001)(38100700002)(122000001)(5660300002)(8936002)(41300700001)(52536014)(83380400001)(66574015)(86362001)(966005)(64756008)(71200400001)(316002)(66556008)(110136005)(54906003)(6636002)(38070700005)(66946007)(66446008)(66476007)(107886003)(478600001)(7696005)(6506007)(55016003)(8676002)(4326008)(9686003)(186003)(53546011)(26005)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?CgRbqK9MTlSLopvujwF2J5pjOU4oK/6fPW9fCeaGu1OxZyd1jhpk31oKHW?= =?iso-8859-1?Q?cTTlu7Zk2VUBGwzqMxGbqiqvz+2CG9Qj1zrHZLEZPtlPLwyUhS6z9b2FZT?= =?iso-8859-1?Q?8x/cTx1c1prglzXM/z+f81H8+4+i3dAfTlfWt8Ay0r9XZ1b9tED5y4HsZI?= =?iso-8859-1?Q?VwMJUXfogqND7NFyXxUMwSr6RxGtn5PGR0FFU0BvstZtcTtsIfLGH0oVwA?= =?iso-8859-1?Q?sZruyomP+2MbjyM3bH0akm+F10VNH5+cyR6YPjsihWskaIM6vzEpsgybPX?= =?iso-8859-1?Q?s7YdhRSrjH4hLYyuaVlYQ01g/YGliJl6WesyC234YHMOcBszlvk1Gu72It?= =?iso-8859-1?Q?h/aa3hApXqOs7O2mTcXIbDbS6bL9uElYeIXIWgbo/HNrIhiwj6bELeRC5X?= =?iso-8859-1?Q?vfnsGhkBA7rQWM/Co0LxIDsPoeERgKjrC3R7bhaxJHbBLzavJlOhXk90q9?= =?iso-8859-1?Q?XcaqY9u3v4OAxbcMN+TbVIBZZS7KXJ/oLUj1GhibQDDHjVuEdwRT0hos7w?= =?iso-8859-1?Q?9Qh7GfVQTm83w2Ynkq/hp8yHqTdEiFO/B3ufea6WlAANjXkULtDxS131Sx?= =?iso-8859-1?Q?u2Ljo3k0ngUOcM7jts9WkjuVVijUAIghnbNRlWQWdfkkSk2/kqZ9kig//e?= =?iso-8859-1?Q?BaeMndevSz4AabptAH5ikwQvLwvPPWWqYiVECdmOjHIhs7cTSJuFP9juCf?= =?iso-8859-1?Q?aeMss3tktrOtY4/cYKE01XGlFvEycPdJV3/okgB8hNB0HRvPQQtFWHra77?= =?iso-8859-1?Q?VEdnzZj32+tzSXZbHqNVoXtdWJ3g4XcRtpcp7HQ2Q5BvRVHYkAnd1WuHd7?= =?iso-8859-1?Q?FnHW1pc1ANLzBypoMeV1JDIU1bwufX/N8UxtqOrZxn5HKU3RTgU1O7HPhC?= =?iso-8859-1?Q?WUWzG213qo/zJL5Q+NgBKRMJ1045FvEu+PmvhwaRms1MJjNA15pN7ulPzF?= =?iso-8859-1?Q?Fr0hYWvzARGy/7BG06Rd+SYDKu52gkMEU4PJyuZe/GVf46+PGlYA5WzrTy?= =?iso-8859-1?Q?Ir5oxIoO+4BZ1L137DDvqca8JI0OTD/SQdEEX/Oae8LjuzKzF+4RhVMaPT?= =?iso-8859-1?Q?FXSqZTzaoLsAFN6BTmF2seFie6lNgiMrv6eoiEY0VCf7x0SQoyzj0BszMm?= =?iso-8859-1?Q?ZAo0oCFiURtsRNTyCtAznlgodkiebqSKVLo/c/fOBbCMg0k/+HENXSGR7M?= =?iso-8859-1?Q?jmAifp3374l99IVV70YLgvU/thIOL0EDS0OYBYRxw6dU/318w5Dg3zxR1d?= =?iso-8859-1?Q?jVIrGHLei3NBhjjl+8mpv6EjuH+5wuzZuK7D46fAtMZ9bxHoWAjJhX45uF?= =?iso-8859-1?Q?zsqGVpi4oY2acxVWb9w16SasjV1WL0rL7D2t6Xz9gtVY+1Ot2OA3TAMx8F?= =?iso-8859-1?Q?xX0btXW5w6Aazjomf+mPVCTmCTsENnX2ZiZkIH4ewR5KH3BIMcvbW9fMjT?= =?iso-8859-1?Q?BT8SSbcKgsFIiclaNHU/6Be1r5/RDd6bmHUm+rjkThnleo3swVnnLOjmU5?= =?iso-8859-1?Q?h8ordciIrkxFydnAgg0EDxbYirljoWv/Ws2yFtvm0+7hxH7xZJzbV6Kzks?= =?iso-8859-1?Q?+YcxW5VXPfJDQGKgod4WhOZ7OtzemX1KNZAUkKjru7o9mp5E+avaN+Vfve?= =?iso-8859-1?Q?ZjQI9qYX3kN5ATq6MyXRfJIv/zXgHj2nZj?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c15987d8-53ab-4b7c-a952-08dae7201c1c X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Dec 2022 09:03:52.2644 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tMKJS3vb0i9ra3GxJHQqDfoW60MEaEfzxDdzYlmwI8woUkoK4v+wcxaBZqv1XUgMtQRRQtZHZqh2HHOXbeyEjw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7344 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Morten Br=F8rup > Sent: Monday, February 21, 2022 5:35 PM > To: Jiang, YuX ; Alvin Zhang ; > Xing, Beilei ; Guo, Junfeng > Cc: dev@dpdk.org; Zhang, AlvinX > Subject: RE: [dpdk-dev] [PATCH v3] net/i40e: disable source pruning >=20 > > From: Jiang, YuX [mailto:yux.jiang@intel.com] > > Sent: Monday, 21 February 2022 09.31 > > > > > From: dev On Behalf Of Alvin Zhang > > > Sent: Wednesday, October 20, 2021 9:29 AM > > > > > > VRRP advertisement packets are dropped on i40e PF devices because > > when > > > a MAC address is added to a device, packets originating from that > > > MAC address are dropped. > > > > > > This patch adds a devarg to support disabling source pruning to work > > around > > > above issue. > > > > > > Bugzilla ID: 648 > > > > > > Signed-off-by: Alvin Zhang > > > --- > > Tested-by: Yu Jiang > > > > Verified patchset > > http://patches.dpdk.org/project/dpdk/patch/20211020012831.8480-1- > > alvinx.zhang@intel.com/ on baseline dpdk22.03-rc1:ecc0dd455e > > "raw/cnxk_gpio: add option to select subset of GPIOs" > > Tested pass on Ethernet Controller XL710 for 40GbE QSFP+ 1583, OS: > > Fedora Linux 35/5.14.10-300.fc35.x86_64 Test step as below: > > ./dpdk-testpmd -l 1,2 -n 1 -a 18:00.0,disable_source_pruning=3D1 -- -i > > pkt =3D Ether(src=3D"00:00:5E:00:01:0A")/IP()/Raw("x"*60) > > test steps: > > 1). testpmd>set verbose 1 > > testpmd>start > > 2). Send the pkt, the pkt can be received by testpmd 3). > > testpmd>mac_addr add 0 00:00:5E:00:01:0A 4). Re-send the pkt, the pkt > > still can be received by testpmd. >=20 > If source pruning is not the default behavior of all NICs, it should be d= isabled > by default in the i40e NIC too. >=20 > A NIC shouldn't drop any packets unless it has explicitly been configured= for it! > And a NIC shouldn't treat any packets differently than other NICs do, unl= ess > the NIC has explicitly been configured so! >=20 > Furthermore, I would prefer that configurations for explicitly dropping > certain types of packets is available through runtime APIs, e.g. RTE_FLOW= S, > or dedicated functions like rte_eth_promiscuous_enable/disable(). This > patch doesn't support runtime detection of installed NICs performed by th= e > application. >=20 > I am very surprised by this default behavior of a NIC. Please confirm tha= t > Source Pruning is at least disabled in Promiscuous mode? >=20 > -Morten Thanks for your comments @Morten Br=F8rup After testing with other NIC like ice, source pruning is the default action= , it means it is the same action for both ice and i40e when receiving in default. In this patch, the default is "not disable", it is same with other NICs. =20