From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D409CA0540; Tue, 13 Dec 2022 06:44:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C998F40684; Tue, 13 Dec 2022 06:44:25 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 0631F40146 for ; Tue, 13 Dec 2022 06:44:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670910264; x=1702446264; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=XyRJ33NVzqhllQJKYfKi/vvrDBC9hrvo7nzXaUieXws=; b=i6xmN9H2F04Fe5LkwXfrJYHLCjQWz/T8CpBgp+6jp+PfAs5NVxT3tfX+ VLBezGaIlY8nz/B39+mdwP/k+zT9KBw5p6RgEYzS9NAjUtAkJkTCkjP4j mFWEXn93PdMGRc0uhp1cImiRxqaj1ymJf4p0i+SgU5LiOaLsk9xF7F8aA MsOaylCHcYf0A2ekbO6Cs+cDcWGdAB0TQztoRjqgX3mNUoySVd1Pcsf1x HQhnZI5pxhArEQU6XHpmTfGZbOn7a05FSQVlCu/INPeLHAFjiGSRiY9NP 3UbUrVXanH09wugQ0fkuRi1INCEcisIgch3xTnaxiAElB0alzp9yVrFXX w==; X-IronPort-AV: E=McAfee;i="6500,9779,10559"; a="382354305" X-IronPort-AV: E=Sophos;i="5.96,240,1665471600"; d="scan'208";a="382354305" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Dec 2022 21:44:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10559"; a="772863195" X-IronPort-AV: E=Sophos;i="5.96,240,1665471600"; d="scan'208";a="772863195" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga004.jf.intel.com with ESMTP; 12 Dec 2022 21:44:23 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 12 Dec 2022 21:44:22 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 12 Dec 2022 21:44:22 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 12 Dec 2022 21:44:22 -0800 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.48) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 12 Dec 2022 21:44:22 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jZFLin9bbAG6ESXnUZnCqzIjxz14ck4l2UbMF+z5AIRQbN/YqkzPzGRJiyddyR9vQ+oFsp+2LGYihaeCB/h2F8jCUzFQ72Cf+rw0qhIoel1U92zqs3/T68M4VNSbraMZ5TP/yt4Zjq/2TVlbqVhl55WXTJJizPfbdKOIv76QxjOhc5qzmQwhNhMW1PZV6gNRlV6mKQ4/mWML3kHzZ9RUCgv4wY05NUaL2dz7i3y3DaA1N+hbcxUpUb7L0++EGoG+a42KnaxVDPAdQ7hbORGWS0ABWtHLMNCJyOILJEjV/JT0gmoamC8plzQLUQrTaZopyQI1FhT++yfps4PAWavuHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6DDN4Unokmagwjm7M3dlaQd0nl2l4eORmvEFHIsEcgc=; b=Cuo85ltxE9s0gDR6+5OgdbP3NscLb0MbI5cs7jlCW2+uYKaFLyPsi/BBmRo9j0cu/pvS/3OlShw/4/+Cv9Zo+HoC5czCzTw9jLDAzgTMNbEn96atSm/p13FP0O9g/9m3dwO2vfEi/16XDihgOsFr/RmC66RIXZxQDZk+o/jUvff/I/L4o1hBYZECY5IQRnvE4br/0q9UEUIy/nGBcYr+2Uh/UMUNgd6wjTPpdT2msVm25nd0hUe3a8mAxlF213hN7I78cmRaogY+5k4xrDh0loqDpdt1/7ykOnr2rhTEwyEQV8ViCiD3oV3ab8x1vpxKgYs5imI9roOSoukaJgI4+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB5984.namprd11.prod.outlook.com (2603:10b6:510:1e3::15) by BL3PR11MB6458.namprd11.prod.outlook.com (2603:10b6:208:3bd::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Tue, 13 Dec 2022 05:44:15 +0000 Received: from PH7PR11MB5984.namprd11.prod.outlook.com ([fe80::4750:caf0:7127:adc7]) by PH7PR11MB5984.namprd11.prod.outlook.com ([fe80::4750:caf0:7127:adc7%9]) with mapi id 15.20.5880.019; Tue, 13 Dec 2022 05:44:15 +0000 From: "Zhang, Ke1X" To: Stephen Hemminger CC: "Zhang, Qi Z" , "Zhang, Yuying" , "dev@dpdk.org" Subject: RE: [PATCH] net/ice: add devargs for disabling mac filter Thread-Topic: [PATCH] net/ice: add devargs for disabling mac filter Thread-Index: AQHZAHrTIfFRhUbqNk2zizWA4uScHa5rS14AgAAfd3A= Date: Tue, 13 Dec 2022 05:44:15 +0000 Message-ID: References: <20221125025124.805466-1-ke1x.zhang@intel.com> <20221212195122.5b1cbd15@hermes.local> In-Reply-To: <20221212195122.5b1cbd15@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB5984:EE_|BL3PR11MB6458:EE_ x-ms-office365-filtering-correlation-id: 9c711698-e982-49bd-3b35-08dadccd11dc x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QYE2TqAqR9TJwcSlJT7GtYrTotQKhGuRUhcUKGwpufhWmwbeeUPWuMzHMAXTlYfCBjfJUg0lOc9mvLX9qGn2dQkKKe/1NeWkXxIksMJ5wF/Pb7YMxCVxAhCiX/Lv1qwhwGVjBfyG9mZmBIcFL1i1yOh14usEFohogDS3v+f5Weu1N63OEHnkJZ8oOdEVuCkfrAlJo9lp0Oza0CmKFbcq3FYXB4JyoJx2iYt90bN1ucJdztCgFNln6OxEjpmE3KtE01bKEVQhRsaUarxezUueba0BMZU2LMvcAoa5+4ijjKkBq0L+HVGYZCqBaezq9QOa8B+jrKvDWkK+9Fx5F9Gs1wWUWiMHpSiA2xLx9GwirBHtoePhN5y81WmlBZzH6ZSO3hriYnSCj/hHweNTB5gtmMDiWqW3auecAkv5FBLkASSxmCv5JIRilsYv26UC1Ic4NioRTX2e4F19vy2Zx5BusB48u5TpumlEv/VGDsvWXynqXb6BKf9qsk9wn72I7zRpSEy6WmmWHgxJOXuYacDiKZNXM3ljiqSrvmARMk8bJdvHPXlDfukZQowK9RSo0Sxji0XSxpZhGwPokUAGsUeZMtj4XrqhrJTTu6CqxIAUO9y7/VOkUH+5AnQH5Cm9N00QlKXDlgtICkWHVqtQw0IpyJ8drE0bleP6dguvS7PyJ6X/9DdF5fMQc7CAufqS2HdkLcI0b9MaM6eacX9dQxwH6A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR11MB5984.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(39860400002)(396003)(136003)(366004)(346002)(451199015)(55016003)(82960400001)(2906002)(38100700002)(122000001)(71200400001)(52536014)(5660300002)(54906003)(8936002)(6916009)(316002)(38070700005)(83380400001)(41300700001)(26005)(9686003)(478600001)(186003)(7696005)(6506007)(33656002)(8676002)(4326008)(64756008)(66476007)(86362001)(66446008)(53546011)(76116006)(66946007)(66556008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qAGNQBumbdGd8atFD8YVM5TMcdaja8MgtqSv5bn9wo7LPPiQYpzM5MlXNeqn?= =?us-ascii?Q?7PlsCZ5AUKzlExGSn9SY7cMWemgQQhmVLJ4vVo7nnCLUToOvg2rjzMWay9qE?= =?us-ascii?Q?ZA4U17GMk9OIdxwBTDg/hrIR1s6lQ9jM4d+L5HmCB1P76Ww589MCZ5rA+H7q?= =?us-ascii?Q?G090nVBiaITgnC/taWNbDwqD9wuCyqPkWEDsC+RCRuSFH6xvmxHQHD1QTm/U?= =?us-ascii?Q?1ctz4zcWXgBW4xa/7SFWzk/N/lhlvObJ3559SBIouu5Cs9FXBdtnU1bfX+/j?= =?us-ascii?Q?rKMDLbXQbf5RqQKLuJiahNMxEzToMR+ad37QiBUVe4UrbDNBNwu6hnZ8fTSy?= =?us-ascii?Q?GR540kNq3yWCZH1IPp3SQ5Y7EnvikeClKFWI4drEoU8rF44UQ5mzvJLjTFap?= =?us-ascii?Q?Yq4nusKlAXakoF4kIDEGxQs+8hYWD0Inxg8BtrfDseV7ZSIR86wkV6V0A3w9?= =?us-ascii?Q?gyfwUnrpTmVtjPVo0e5hsVuPaZKdhhMLyrp16S+Fm0hTL7G0YEipuw2pz8kD?= =?us-ascii?Q?H2KWvMHc4s7g7MBe/f1/ztA8kPfwE74m7hsq6v402EigxWVjeaTMitd+E/DV?= =?us-ascii?Q?H1A5no46rF5nIbfaoMOzIFTCFuhDfGmEaQmG51ch/zSqFN6syLT2F3l4rNwd?= =?us-ascii?Q?LSJE7I1GM47qTcZK73Kllp0kNvICINHntprAMoG7QskPxxb7A6dUhx2Ro36T?= =?us-ascii?Q?wRShZyxvaWQLXO7wU2NegqkR6CU/dR0cwrL5mPuxTEQHwbjAMhpRjrrnuWni?= =?us-ascii?Q?rlzmVVoL1XBkvNVXqMwlHXv6X54f0KRFwV/b+UgbqKTiYWIShtNSkixvnlzq?= =?us-ascii?Q?Avv/FbS9uHF0qJtMaNtoj7B7glViI6MCBg+JPc6jeMizqr5QW0P0Gnmv7mAX?= =?us-ascii?Q?9yGPiWsQSzpSq8o5QjfcFZ78X4SQxgIH6FM6NLNItsWMjDmcw4wj+yKGFf+p?= =?us-ascii?Q?R/11pxfcPdOPCUAfaY8aBqN37bB8ed+clDbRKtrN731fYLxTt+33vZy0LxSg?= =?us-ascii?Q?dXysy2i2DrhUzVNHEdp/qgO4PVg0AHEEXd6iHS22pcqJoMx+qYMYszhS9BAm?= =?us-ascii?Q?1G+SwLiK9dIpbEHXmLsonYG9D2CVSvgU/oiskX6pd98jsTL3lk45ixZS7+KO?= =?us-ascii?Q?imF7xqC1f/oHQdIJzFIIAcBp5FbNzXs2NL/zradeLE/pz+gc+t1ddjoAer50?= =?us-ascii?Q?0+fSWNGPKdKpXbWZ12hcK9Bc0VI2Z3b+hz9GXzTbIEiJPFcyi+BR96tEVlzm?= =?us-ascii?Q?loLCHpgskWdnQDiC5JAA0yNza7AOnOxdx16QChMBJBL+NYFzYsRSs1doRe5n?= =?us-ascii?Q?aS3/NmnQI1YtPYR8eLn3E5yq4WtYPk8bKD3AhdkqDcLqyyuojtUvey14/HY7?= =?us-ascii?Q?8Sq+Ru0nlMxB/YMtaRjYI7Xw+Lr6IAroGTKp94b7m5JddpH39YqHgvO3XQQv?= =?us-ascii?Q?piEhIfNtTR6brVQDdFAXOi1z+kFsp3aRtheHg4DvSb/je/er1gqGiEPCZ76I?= =?us-ascii?Q?UA5ROGptEbrc2Eo34nqbnw5t2z2Dc5Db1j2PMQxv5ddifj7mMEzQE847NDp1?= =?us-ascii?Q?wpyL4JKdaUglHCo/9zesT1iRAdFNlNsIq/Sj9i3e?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9c711698-e982-49bd-3b35-08dadccd11dc X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2022 05:44:15.2086 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YZnAH/oI0kPFJbt2AYw0C3qAIjzzehj/HaLGXlXD/wKYz1Tr9jxzgWQFFVfRlJllg/eDi3wPO9Ac6xZDRZ0Q5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6458 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Stephen Hemminger > Sent: Tuesday, December 13, 2022 11:51 AM > To: Zhang, Ke1X > Cc: Zhang, Qi Z ; Zhang, Yuying > ; dev@dpdk.org > Subject: Re: [PATCH] net/ice: add devargs for disabling mac filter >=20 > On Fri, 25 Nov 2022 10:51:24 +0800 > Ke Zhang wrote: >=20 > > diff --git a/drivers/net/ice/ice_ethdev.h > > b/drivers/net/ice/ice_ethdev.h index c8311be179..0350c6584a 100644 > > --- a/drivers/net/ice/ice_ethdev.h > > +++ b/drivers/net/ice/ice_ethdev.h > > @@ -563,6 +563,7 @@ struct ice_devargs { > > int safe_mode_support; > > uint8_t proto_xtr_dflt; > > int pipe_mode_support; > > + int mac_filter_disable; >=20 > Why use 4 bytes for a flag when a single bit would do. Thanks for your comments. I just follow the definition of other variables like pipe_mode_support, saf= e_mode_support. And when I run the testpmd , I could write the command like this: ./dpdk-testpmd -l 16-32 -a ca:00.0,mac-filter-disable=3D1 -a ca:00.1 -- -i = The value could 1 or 0. Would you please give me some guidance about the definition of the variable= ?