DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Xu, Ke1" <ke1.xu@intel.com>
To: "Zeng, ZhichaoX" <zhichaox.zeng@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhou, YidingX" <yidingx.zhou@intel.com>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>,
	"Wu, Jingjing" <jingjing.wu@intel.com>,
	"Xing, Beilei" <beilei.xing@intel.com>,
	"Nicolau, Radu" <radu.nicolau@intel.com>
Subject: RE: [PATCH v2] net/iavf: fix outer udp checksum offload
Date: Wed, 14 Dec 2022 01:50:59 +0000	[thread overview]
Message-ID: <PH7PR11MB60561C833A5870ACEFC58625D3E09@PH7PR11MB6056.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221213014512.150575-1-zhichaox.zeng@intel.com>



> -----Original Message-----
> From: Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> Sent: Tuesday, December 13, 2022 9:45 AM
> To: dev@dpdk.org
> Cc: Zhou, YidingX <yidingx.zhou@intel.com>; Xu, Ke1 <ke1.xu@intel.com>;
> Zhang, Qi Z <qi.z.zhang@intel.com>; Zeng, ZhichaoX
> <zhichaox.zeng@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Xing,
> Beilei <beilei.xing@intel.com>; Nicolau, Radu <radu.nicolau@intel.com>
> Subject: [PATCH v2] net/iavf: fix outer udp checksum offload
> 
> Currently, when dealing with UDP tunnel pkts checksum offloading, the
> outer-udp checksum will be offloaded by default. So the 'csum set outer-udp
> hw/sw' command does not work.
> 
> This patch fixes judgment of the EIPT flag and enables the 'csum set outer-
> udp hw/sw' command by adding judgment for the outer-udp checksum
> offload flag.
> 
> Fixes: 0c550022fb82 ("net/iavf: fix Tx descriptors for IPsec")
> 
> Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>

Verified and passed.

Verified applying only outer IP checksum without outer UDP checksum. Outer UDP checksum will be errors as this feature is to ignore this checksum error. Inner checksum is not influenced. Outer IP checksum is not influenced.

Verified applying all checksum HW offload.

> ---
>  drivers/net/iavf/iavf_rxtx.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 


  reply	other threads:[~2022-12-14  1:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-18  7:03 [PATCH] " Zhichao Zeng
2022-12-02  9:46 ` Xu, Ke1
2022-12-13  1:45 ` [PATCH v2] " Zhichao Zeng
2022-12-14  1:50   ` Xu, Ke1 [this message]
2022-12-26  2:34     ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH7PR11MB60561C833A5870ACEFC58625D3E09@PH7PR11MB6056.namprd11.prod.outlook.com \
    --to=ke1.xu@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=radu.nicolau@intel.com \
    --cc=yidingx.zhou@intel.com \
    --cc=zhichaox.zeng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).