RE: [PATCH v3] net/vhost: support asynchronous data path

["Wang, YuanX" <yuanx.wang@intel.com>]

Hi Chenbo,

> -----Original Message-----
> From: Wang, YuanX
> Sent: Tuesday, September 27, 2022 3:34 PM
> To: Xia, Chenbo <Chenbo.Xia@intel.com>; maxime.coquelin@redhat.com;
> dev@dpdk.org
> Cc: Hu, Jiayu <Jiayu.Hu@intel.com>; He, Xingguang
> <xingguang.he@intel.com>; Jiang, Cheng1 <Cheng1.Jiang@intel.com>; Ma,
> WenwuX <WenwuX.Ma@intel.com>
> Subject: RE: [PATCH v3] net/vhost: support asynchronous data path
> 
> Hi Chenbo,
> 
> > -----Original Message-----
> > From: Xia, Chenbo <chenbo.xia@intel.com>
> > Sent: Monday, September 26, 2022 2:55 PM
> > To: Wang, YuanX <yuanx.wang@intel.com>;
> maxime.coquelin@redhat.com;
> > dev@dpdk.org
> > Cc: Hu, Jiayu <jiayu.hu@intel.com>; He, Xingguang
> > <xingguang.he@intel.com>; Jiang, Cheng1 <cheng1.jiang@intel.com>; Ma,
> > WenwuX <wenwux.ma@intel.com>
> > Subject: RE: [PATCH v3] net/vhost: support asynchronous data path
> >
> > > -----Original Message-----
> > > From: Wang, YuanX <yuanx.wang@intel.com>
> > > Sent: Wednesday, August 24, 2022 12:36 AM
> > > To: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>;
> > > dev@dpdk.org
> > > Cc: Hu, Jiayu <jiayu.hu@intel.com>; He, Xingguang
> > > <xingguang.he@intel.com>; Jiang, Cheng1 <cheng1.jiang@intel.com>;
> > > Wang, YuanX <yuanx.wang@intel.com>; Ma, WenwuX
> > <wenwux.ma@intel.com>
> > > Subject: [PATCH v3] net/vhost: support asynchronous data path
> >
[snip]
> > > +static cmdline_parse_token_string_t cmd_tx_async_vhost =
> > > +	TOKEN_STRING_INITIALIZER(struct cmd_tx_poll_result, async_vhost,
> > > "async_vhost");
> > > +static cmdline_parse_token_string_t cmd_tx_tx =
> > > +	TOKEN_STRING_INITIALIZER(struct cmd_tx_poll_result, tx, "tx");
> > > +static cmdline_parse_token_string_t cmd_tx_poll =
> > > +	TOKEN_STRING_INITIALIZER(struct cmd_tx_poll_result, poll, "poll");
> > > +static cmdline_parse_token_string_t cmd_tx_completed =
> > > +	TOKEN_STRING_INITIALIZER(struct cmd_tx_poll_result, completed,
> > > "completed");
> > > +static cmdline_parse_token_string_t cmd_tx_what =
> > > +	TOKEN_STRING_INITIALIZER(struct cmd_tx_poll_result, what,
> > "on#off");
> > > +
> > > +static void
> > > +cmd_tx_poll_parsed(void *parsed_result, __rte_unused struct cmdline
> > > +*cl,
> > > __rte_unused void *data)
> > > +{
> > > +	struct cmd_tx_poll_result *res = parsed_result;
> > > +
> > > +	if (!strcmp(res->what, "on"))
> > > +		rte_eth_vhost_async_tx_poll_completed(true);
> > > +	else if (!strcmp(res->what, "off"))
> > > +		rte_eth_vhost_async_tx_poll_completed(false);
> >
> > We should print log when the user input is not on/off.
> 
> Thanks for your suggestion, will add the log in v4.

Sorry, I made a mistake. Entering other values will cause testpmd to report a "Bad arguments" error.
So, I don't think additional log is needed, what do you think?

Thanks,
Yuan
> 
> Thanks,
> Yuan
> 
> >
> > Thanks,
> > Chenbo
> >
> > > +}
> > > +
> > > +static cmdline_parse_inst_t async_vhost_cmd_tx_poll = {
> > > +	.f = cmd_tx_poll_parsed,
> > > +	.data = NULL,
> > > +	.help_str = "async-vhost tx poll completed on|off",
> > > +	.tokens = {
> > > +		(void *)&cmd_tx_async_vhost,
> > > +		(void *)&cmd_tx_tx,
> > > +		(void *)&cmd_tx_poll,
> > > +		(void *)&cmd_tx_completed,
> > > +		(void *)&cmd_tx_what,
> > > +		NULL,
> > > +	},
> > > +};
> > > +
> > > +static struct testpmd_driver_commands async_vhost_cmds = {
> > > +	.commands = {
> > > +	{
> > > +		&async_vhost_cmd_tx_poll,
> > > +		"async_vhost tx poll completed (on|off)\n"
> > > +		"    Poll and free DMA completed packets in Tx path.\n",
> > > +	},
> > > +	{ NULL, NULL },
> > > +	},
> > > +};
> > > +
> > > +TESTPMD_ADD_DRIVER_COMMANDS(async_vhost_cmds)
> > > --
> > > 2.25.1