From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0D1EA0542; Fri, 28 Oct 2022 04:05:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9124840223; Fri, 28 Oct 2022 04:05:25 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 94B9C40146 for ; Fri, 28 Oct 2022 04:05:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666922723; x=1698458723; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=vp9PoOGZhpEtmSo30YH/VzGa+Kir1Fs8yz2SmVqE4VE=; b=k5muhUvtkAmlLfUPCnnx+A9UyqPamhMq/lCXYp2VlIiY/FNlxn3+92Dk laMovQbvLt93IgOqq2AzwovKyVbhPp4Z5RasA4bVy+HJws4tSLqDxXYxe pK2xDSLmlq0Alt1MYrTNIGcQSaqXgOrZPuADP5eR3goxBButgaIktJuvB 8LJbQh/kktXRJjymKkohS3d/0/Fi60gl2UYSSAJmctzozDFSz3rkHQjWI UDD4LOptYiBMVXUN5+5sVgQbqCVsHLx/5V8o9snfONyVPxEYfOsOFsnD0 Cdjr/pwBQ4avwzyhA2Dge/QLYtKSX1ab4NExeIsfday3zZrI8GZCvJhj3 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10513"; a="309480608" X-IronPort-AV: E=Sophos;i="5.95,219,1661842800"; d="scan'208";a="309480608" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2022 19:05:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10513"; a="632618450" X-IronPort-AV: E=Sophos;i="5.95,219,1661842800"; d="scan'208";a="632618450" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga002.jf.intel.com with ESMTP; 27 Oct 2022 19:05:22 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 27 Oct 2022 19:05:21 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 27 Oct 2022 19:05:21 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 27 Oct 2022 19:04:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SH/25cRbp9s0BHIG+vlEfY97xL10QKmDAN1naa0R0rsntR0JfhWXx+sqafzql0QHCvZfQZpEGsAgBNf+oUO/p6nPFYac8b35BvEfJsFTAoE6zotTd2Dup4wz5Yo6xAc5wcG6Lsc/rEiJvgK6AMvJQaUb+dmt3CNJp61ThZ8jU6dJnfZU2BmJ0oSz8a2gqkajG0l/14o++CPFcaDIetwQq1o/YCdsPunljO3qL1ebVFsQYgW22mxp1iPTcDTN/4fwVI+LJc9BAcbfeJkgRlJP3qlkhq+UTQzYL7dVvBxEXcayQGACr/g0BGHiSoHRz6O+znD6cwhUbidQH9jo1sE7yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Nm4Hrbu4zMprlPCJLuxEy9uHSc/FRqW9f95wwHb14kw=; b=N2Gi8HOEqEfg8gyEb4nw+GiaSF3rV+BisHOxV16jRADyEtVLnl+RNgaXaS5bw8Je0y7V8ZMSawW0WFbxRhlRFrXFPqa428cSWrQ4/hdDuBdcshdn0y4hbBe3SGvRu90Ly2wVZhQ1ZoWFfzFzu12161od3whY3eQ//Y6U7KGo0MznSb9qBIuOO+Xopj97z49cZuXS70IFo8du8rPfGxSq6qpPkQNXYDdf1z725r+c1aC/B0+mQvp4X0zY7MnuUIitLYITpiTH00ydpXSFnsNEi2mqFAQ2qyiRZh3+FCgdE+wtWXhTtyoL8LIW5cP/0n0RmBpbrn4j9tvMjC+yX7BVpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB6953.namprd11.prod.outlook.com (2603:10b6:510:204::6) by BN9PR11MB5226.namprd11.prod.outlook.com (2603:10b6:408:133::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Fri, 28 Oct 2022 02:04:48 +0000 Received: from PH7PR11MB6953.namprd11.prod.outlook.com ([fe80::3946:2d2d:ca98:6f81]) by PH7PR11MB6953.namprd11.prod.outlook.com ([fe80::3946:2d2d:ca98:6f81%5]) with mapi id 15.20.5769.015; Fri, 28 Oct 2022 02:04:48 +0000 From: "Wang, YuanX" To: "Singh, Aman Deep" , "Zhang, Yuying" CC: "dev@dpdk.org" , "Ding, Xuan" , "Tang, Yaqi" , "andrew.rybchenko@oktetlabs.ru" Subject: RE: [PATCH v2] app/testpmd: fix protocol headers display for Rx buffer split Thread-Topic: [PATCH v2] app/testpmd: fix protocol headers display for Rx buffer split Thread-Index: AQHY4r/sktpTXDU6xU6U+kkCfD0siK4jG/Rw Date: Fri, 28 Oct 2022 02:04:48 +0000 Message-ID: References: <20221017174054.800259-1-yuanx.wang@intel.com> <20221018145012.914586-1-yuanx.wang@intel.com> In-Reply-To: <20221018145012.914586-1-yuanx.wang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB6953:EE_|BN9PR11MB5226:EE_ x-ms-office365-filtering-correlation-id: bae9cf34-1db4-4cf8-7b61-08dab888ca9c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rPFFhuQvybKvEXTVEaw/qkacL4PVbB2uBU75pVTTYvm9eQbMBbndZzgbQQXoKspCUYAUe1JPKM2vBCHCjg8WVnlRrGPcn9MXZHBbDflKwZoGnHH1td6df3x58WbJ0a7qkaq0c6wLlxqCj7bWvOfomq4IKkz5EvH6YHAlT9kqUZNehpTwaRLqsRJmnYIoWqzQtpmyfsQq7tQlLCl8VVPOW9/G/wuW/2fLDSp8pUAe8TPOwO78uJGAhwzUk/gS3t+5rQiQ2OwZ5Pp0AvO/LEjLvTmnAfkQENB6B47rYSfBOCA/b2wwUPwLRHc1D5CiATEeQZ5uCmShuwGObvBS/LjQYMI9TPYnDi1FhuzclDrEvcYnZMrwOieiTaf8Uo3rq/h+kNVUmIjPhyN/8qP3Bz3HoUXa7GRh5p5ZdnwO6treSQ0RwV5Fj1Ya8AA9IwhxRUyybDN4e5tlHeCWZ+/N7Ga02oQbI9/Mx7Cf25LHveiH0gEHPkbmDYp4IcLv8a7P6ULZC0PT7V/yldYtz5KYsQaOBtAm3hfgM7VG9wOzR9YEIqs0benxD610xzocNQpD2x7psI4JcO2Lhn1cQiMoGzi6RHfjB43xFVxrsm61CCHq9AZcYiUKIb/zRHiduSbEmMf0/04k46GdH85oMrxiQB/2jjYpct8Ec5+56ccPrjDdSwSmlfzrUmsrj+28fsU8suWmJ79xXNKYnohDY061pkU92ktob6quN6+aBTVKZ1N66zvYoz238LU2wsB2bj0GPUUDLZ8NouGT0A0LkKSoDCxWKA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR11MB6953.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(346002)(376002)(39860400002)(366004)(136003)(451199015)(38100700002)(6636002)(8676002)(55016003)(52536014)(66476007)(33656002)(64756008)(66946007)(38070700005)(5660300002)(83380400001)(71200400001)(41300700001)(66556008)(110136005)(478600001)(4326008)(54906003)(8936002)(316002)(66446008)(76116006)(2906002)(9686003)(186003)(122000001)(82960400001)(86362001)(26005)(7696005)(6506007)(53546011); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KdIZ3+Xm0CX8VDc0c0FYUGJGI2xHh9ZRDff78yohDdEY8knE0BK5k54YeGUx?= =?us-ascii?Q?vwJoXyC06LD+M6ZS6yqDdQnqwZsgmPBRNKvfLb3aC8+frR2mGU3i4hFZWdwN?= =?us-ascii?Q?M94euFLA/1d6QIxAD9YXDw0ucynDNXEwqElPNxkzIIVErnVXzVO0vZJNJewm?= =?us-ascii?Q?g6jM/Z3fjNPxnu3rEqUrr3CbvyaN0BfVvwzJ+tpwYBKHpRRmcXGRmHxR3nVK?= =?us-ascii?Q?Yw2K9trTtkRqTggZ+k1MuybMZVGZe7KciwRT8Yk3+EH7JiNwEn0ppx5qcT4i?= =?us-ascii?Q?q57TgdCfzfvgzGMAlZeaoeW+iBF/fM1ytslpfJVDDnj2Qfb8kcAFTNkDpZCE?= =?us-ascii?Q?TbFIlmv7OCNGMxcyGOIVLMRmobffwkaNI/mOlxyaOcdZ/bhqV0sv2ge6n3q9?= =?us-ascii?Q?N1p+Z2OeNGpKonqrCSTlv5iW6a/RxhcLCUuireyL9tpvSuINAV7PmLA6s/c0?= =?us-ascii?Q?Y6BdU847n+RIPnu+pcUCv6u8avfjyEPvsWUUg5HHbHeHtiXIJjSDzsAylEB7?= =?us-ascii?Q?9BcnkDhSiQZofpAK7cAsBcqsbF0ynnGqYxW89L7D2Y2X4KkgAOeUZhIRGH2e?= =?us-ascii?Q?dr163lczFbBBkDKcFjlFjOcgkOZ+Au+omKwKoymt9AORHy1bfFne9BA6YJYk?= =?us-ascii?Q?fIMg9DM9b4EqtENl2nLKc66RUNgc9QcCtl/HQF4YBoHBRegsnsYKtXJ29cpC?= =?us-ascii?Q?I111DrTkz8/HtdMM+ANL046JKlzsn8tDm77SXJRjE5O+9lp9/NMgiMf7nvIw?= =?us-ascii?Q?t+SkGqjLnn4WIthpsdq/ENgBhkqUEIJc3aL5dqtIuISYDqok9Is0IeL5qQMM?= =?us-ascii?Q?7tUOEKO9tB2LF/dlR5knC+z444HXdPN8C06uF1ebNfycti7G27FdV7cw/Ukb?= =?us-ascii?Q?NLSTdVKSSOxzUZmMmde6sEPn3AhBIqd2F8DWBCGy0WYN6IfiT7JrzNjY9sRt?= =?us-ascii?Q?jqER4ZD8a7l+cqMmJB4PvYHOv4ZHlXfw5ZyQr9F6t855aOT44tElDqT5G9rV?= =?us-ascii?Q?IW8Xv7KgK4GKhMhkfwqLotobpi8dxoxr7t+ohU4inP6q9jsSa/juGMQK/nnp?= =?us-ascii?Q?4g6pXIO8wHteRhszmgGFIOg4LD8cJ07ZGnF0Zm63JkqHGmqmEM+WuWU2L7nJ?= =?us-ascii?Q?NFm4jwih3wuq1ugtEXorG477LzPoppYxJOoGEgbn4JFlZ7lkSFSBe4LxXot0?= =?us-ascii?Q?QR0viCN6OiVRDypNlJuckuzmflvrPmOCmhK0QaAMmRVaflJWpAKF7TMg80ct?= =?us-ascii?Q?0eG/qrmr6OJo8MwvyIcMHJiIfynXnx1UdAqC3ngyNZqumd62GzvP2aqT/Piq?= =?us-ascii?Q?iNZcRvOvp3Z7BCLDP8HXtCG0KEz/WtMRa7dMlUtQwdv89WO+p5tBQM0vvjM3?= =?us-ascii?Q?GykUUFGouzp7xoLX0cdFmV/Dli4RVrlpQ72MdWEBEp5WyLMQusM8toOu5QZb?= =?us-ascii?Q?UwRbnH03G7EVTesL9hbLfB6dS67W49gOjrA46kxgaDEk/wGj2g2hTJWHvct3?= =?us-ascii?Q?Mo1XUKVbwAIt2s+gAHYftjNcXnkWVmyXZ9ywcMMPBPK4vkjcnrWMekA3LJxc?= =?us-ascii?Q?G2KKB4uBoEtlMVl70PqvZymCv1n+MOCR4H5fvAZK?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6953.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bae9cf34-1db4-4cf8-7b61-08dab888ca9c X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2022 02:04:48.0506 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zAMR77SoIFjdb0w+Ntzm5sG0W9Hmqic2aTnDt/KboexdirYXkC4ini1gNID2PKnmIMprY+acwbhPSSRIk79kiA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5226 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi All, Could you please review and provide suggestions if any. Thanks, Yuan > -----Original Message----- > From: Wang, YuanX > Sent: Tuesday, October 18, 2022 10:50 PM > To: andrew.rybchenko@oktetlabs.ru; Singh, Aman Deep > ; Zhang, Yuying > Cc: dev@dpdk.org; Ding, Xuan ; Tang, Yaqi > ; Wang, YuanX > Subject: [PATCH v2] app/testpmd: fix protocol headers display for Rx buff= er > split >=20 > The "show config rxhdrs" cmd displays the configured protocol headers tha= t > are used for protocol-based buffer split. > However, it shows "inner-ipv6" as "inner-ipv4". >=20 > This patch fixes that by adjusting the order of condition judgments. >=20 > Fixes: 52e2e7edcf48 ("app/testpmd: add protocol-based buffer split") >=20 > Signed-off-by: Yuan Wang > Tested-by: Yaqi Tang >=20 > --- > v2: add fixline. >=20 > --- > app/test-pmd/config.c | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) >=20 > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index > 0f7dbd698f..82fbbc9944 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -4937,15 +4937,6 @@ static const char *get_ptype_str(uint32_t ptype) > else if ((ptype & RTE_PTYPE_L2_ETHER) =3D=3D RTE_PTYPE_L2_ETHER) > return "eth"; >=20 > - else if ((ptype & (RTE_PTYPE_INNER_L3_IPV4_EXT_UNKNOWN | > RTE_PTYPE_INNER_L4_TCP)) =3D=3D > - (RTE_PTYPE_INNER_L3_IPV4_EXT_UNKNOWN | > RTE_PTYPE_INNER_L4_TCP)) > - return "inner-ipv4-tcp"; > - else if ((ptype & (RTE_PTYPE_INNER_L3_IPV4_EXT_UNKNOWN | > RTE_PTYPE_INNER_L4_UDP)) =3D=3D > - (RTE_PTYPE_INNER_L3_IPV4_EXT_UNKNOWN | > RTE_PTYPE_INNER_L4_UDP)) > - return "inner-ipv4-udp"; > - else if ((ptype & (RTE_PTYPE_INNER_L3_IPV4_EXT_UNKNOWN | > RTE_PTYPE_INNER_L4_SCTP)) =3D=3D > - (RTE_PTYPE_INNER_L3_IPV4_EXT_UNKNOWN | > RTE_PTYPE_INNER_L4_SCTP)) > - return "inner-ipv4-sctp"; > else if ((ptype & (RTE_PTYPE_INNER_L3_IPV6_EXT_UNKNOWN | > RTE_PTYPE_INNER_L4_TCP)) =3D=3D > (RTE_PTYPE_INNER_L3_IPV6_EXT_UNKNOWN | > RTE_PTYPE_INNER_L4_TCP)) > return "inner-ipv6-tcp"; > @@ -4955,18 +4946,27 @@ static const char *get_ptype_str(uint32_t ptype) > else if ((ptype & (RTE_PTYPE_INNER_L3_IPV6_EXT_UNKNOWN | > RTE_PTYPE_INNER_L4_SCTP)) =3D=3D > (RTE_PTYPE_INNER_L3_IPV6_EXT_UNKNOWN | > RTE_PTYPE_INNER_L4_SCTP)) > return "inner-ipv6-sctp"; > + else if ((ptype & (RTE_PTYPE_INNER_L3_IPV4_EXT_UNKNOWN | > RTE_PTYPE_INNER_L4_TCP)) =3D=3D > + (RTE_PTYPE_INNER_L3_IPV4_EXT_UNKNOWN | > RTE_PTYPE_INNER_L4_TCP)) > + return "inner-ipv4-tcp"; > + else if ((ptype & (RTE_PTYPE_INNER_L3_IPV4_EXT_UNKNOWN | > RTE_PTYPE_INNER_L4_UDP)) =3D=3D > + (RTE_PTYPE_INNER_L3_IPV4_EXT_UNKNOWN | > RTE_PTYPE_INNER_L4_UDP)) > + return "inner-ipv4-udp"; > + else if ((ptype & (RTE_PTYPE_INNER_L3_IPV4_EXT_UNKNOWN | > RTE_PTYPE_INNER_L4_SCTP)) =3D=3D > + (RTE_PTYPE_INNER_L3_IPV4_EXT_UNKNOWN | > RTE_PTYPE_INNER_L4_SCTP)) > + return "inner-ipv4-sctp"; > else if ((ptype & RTE_PTYPE_INNER_L4_TCP) =3D=3D > RTE_PTYPE_INNER_L4_TCP) > return "inner-tcp"; > else if ((ptype & RTE_PTYPE_INNER_L4_UDP) =3D=3D > RTE_PTYPE_INNER_L4_UDP) > return "inner-udp"; > else if ((ptype & RTE_PTYPE_INNER_L4_SCTP) =3D=3D > RTE_PTYPE_INNER_L4_SCTP) > return "inner-sctp"; > + else if ((ptype & RTE_PTYPE_INNER_L3_IPV6_EXT_UNKNOWN) =3D=3D > + RTE_PTYPE_INNER_L3_IPV6_EXT_UNKNOWN) > + return "inner-ipv6"; > else if ((ptype & RTE_PTYPE_INNER_L3_IPV4_EXT_UNKNOWN) =3D=3D > RTE_PTYPE_INNER_L3_IPV4_EXT_UNKNOWN) > return "inner-ipv4"; > - else if ((ptype & RTE_PTYPE_INNER_L3_IPV6_EXT_UNKNOWN) =3D=3D > - RTE_PTYPE_INNER_L3_IPV4_EXT_UNKNOWN) > - return "inner-ipv6"; > else if ((ptype & RTE_PTYPE_INNER_L2_ETHER) =3D=3D > RTE_PTYPE_INNER_L2_ETHER) > return "inner-eth"; > else if ((ptype & RTE_PTYPE_TUNNEL_GRENAT) =3D=3D > RTE_PTYPE_TUNNEL_GRENAT) > -- > 2.25.1