From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0C7F423C1; Fri, 13 Jan 2023 13:00:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D8A7B42DD7; Fri, 13 Jan 2023 13:00:10 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2063.outbound.protection.outlook.com [40.107.244.63]) by mails.dpdk.org (Postfix) with ESMTP id B69E1410EF; Fri, 13 Jan 2023 13:00:08 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GB53Z5PfTF9+9WhJ6G7pGvk3Nx1cwHUd8aY6zZ34S4WAOvIU8GA+oa3x+GkDjmPCSz8PEYhPIWGsvLMrdBonzwdBdAt59+/q173XUSxuOLtS773YzZRhs8ZPDvnjzypKVPyT033NUCz8MQhDexR6uxB1LLVvVSu12hYXDJgOho85VGgvumO/5DkoQVdx5hG3LEMKD0levwG1LiraNAd7zjf0m+QmjW+JscVB6jY/UMj0+7z6gSy5eB+9Ivy7ZbPneD+gVAB0gew2bWuawS5rGhjXZbVH8/XxpcKYxI3k35qqbHB1FHgd+WAJKwIjlFvHciaaSDjMsD9cXfwx4lYyPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AyNk1IYWLG/vJllJtbQr8q5OVqYySVttKzegvmDblSA=; b=Ec8e0DQ/DhlVWuQU3dKQ1VhD5fy3wWNujsw3qZEaHrhiZhN4icAwe5Y3CT3Hf+rWE7on4E9FLFG/fKRlGDgy4tPqwAbgtXr4e8TJTlNwa4fuiOedl4OkWdcu1aZEmxwIIbYDxqxpNt2mwpXDsHsIKrE2XQ/z87ZvHP/DMct8kcpAdwfgPQs6sgMcwDkWPIXJ301BjrA+S+zzfLuiu+Ag88aEP5lLdAuX9N0H1GfnQ3m5HjP7OMTmMgW/nXC5WdgCeVXmEn/M2lqiUnFM62pAX1ZDfzXLlWVvvUUSTO9RurMZV+BiqgYEz0MmRFLdgoTLFVrwPq37vL5b8YDlMgqwnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AyNk1IYWLG/vJllJtbQr8q5OVqYySVttKzegvmDblSA=; b=e9Xo0YqzUmEZWc2R/WuZOKHLwnmB2TX6IseSCsX53Wh9RWTcLDjvB9+LB0ki6TebHl9y9YzvXMs4qTMAREdU4cmzGiiPjRiZhmn1SylCLJvteQZxO8NKteZyj2qTjUMY4/5+Rg3WHgt+9SikKxSf+Sk+f5MWyxGEigqCoQwgq6w= Received: from PH7PR12MB6694.namprd12.prod.outlook.com (2603:10b6:510:1b1::8) by DM4PR12MB6134.namprd12.prod.outlook.com (2603:10b6:8:ad::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Fri, 13 Jan 2023 12:00:06 +0000 Received: from PH7PR12MB6694.namprd12.prod.outlook.com ([fe80::e09f:be08:39fb:4490]) by PH7PR12MB6694.namprd12.prod.outlook.com ([fe80::e09f:be08:39fb:4490%6]) with mapi id 15.20.5986.018; Fri, 13 Jan 2023 12:00:06 +0000 From: "Uttarwar, Sunil Prakashrao" To: David Marchand , "dev@dpdk.org" CC: "gakhil@marvell.com" , "stable@dpdk.org" , "Somalapuram, Amaranath" Subject: RE: [PATCH v2 2/4] crypto/ccp: remove some dead code for UIO Thread-Topic: [PATCH v2 2/4] crypto/ccp: remove some dead code for UIO Thread-Index: AQHY19bxMuEn6337JUmntBT0NXjZ3q6c3WKg Date: Fri, 13 Jan 2023 12:00:06 +0000 Message-ID: References: <20220909150411.3702860-1-david.marchand@redhat.com> <20221004095132.198777-1-david.marchand@redhat.com> <20221004095132.198777-3-david.marchand@redhat.com> In-Reply-To: <20221004095132.198777-3-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2023-01-13T12:00:03Z; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=7e34c691-7916-481c-a880-3c0fcc55a517; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR12MB6694:EE_|DM4PR12MB6134:EE_ x-ms-office365-filtering-correlation-id: c34e4a7c-1570-43b1-acb6-08daf55db61b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZNhk740V7eqRNY4mM9+7jj5OIGeTGuaLC6K84doNaZ76Ko6KUwv00u6E45H+dIAMRQcoUwcnhUqBbI6eHruJRGh5Fy6e94uAcgBTkwgeotZW3wTxNRBBwhmLXA+IHxN1KJDnxs4yFcWYVFww/9TwoWLn5jLanyaRG+CANgHN0jPdBoWpF4eVMAb+pUe22UN2iJxLil+SaZ+fcez+Ntm4Lh/zNpHmzuJA33D1dL3bYADwu36J2f4pTU8myZo6/YADbKTpeesGyWpPuufct8nE9u2fwJifUwxmqx4sBjBUthTSZK9pGdVn6qm9tNvJ5apZYKFSPjgkb8hM6QgkSQGiRMKA/xAJuOzfVWeccEk7iGlwghI7DLlgCtwoa15D8fTeIBwFd5r9ekviNg+1OvwYV/AGfhOQQuk7RIPjA1VmXun0wPPPY2UzuS6o0QzkVTDkMqnrn6UHOg1/P9IXrId4XJa0IFDmM16P1uXLdWIEyAQ86EGGZ2GAgUyn4exlnBCI0aymbkntYQSh+HhSG0qtSm5dC9VhgRxnsy69A+IWiC7chtvtCDfmJdLdx3aL3wS+/46h3vd11Cn6/x9Vo4z9cemlfREsaSEgn+vvCIZq5odXfE0LlKq3PCLGz1mpac6wCQRp+ryieEdFclFUZOu0cwp+/tXhUzDT3J5jt2zR/onc1yAAB3fPHlsZIAmp8+N5qVXe2iikQuE4EJtddmLhIg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR12MB6694.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(376002)(136003)(39860400002)(346002)(396003)(451199015)(86362001)(33656002)(7696005)(316002)(26005)(71200400001)(9686003)(186003)(478600001)(5660300002)(83380400001)(64756008)(41300700001)(54906003)(66476007)(66446008)(4326008)(66556008)(110136005)(66946007)(76116006)(52536014)(8936002)(38070700005)(8676002)(55016003)(53546011)(6506007)(38100700002)(122000001)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/mA1M4UrBskZ7S0WuZ6gxk7YYLQxTGgKlz+HlM3QF/7m6wKAn8f3jqElWlfd?= =?us-ascii?Q?titAwz77nVzpq4vaDmXskoEnEmtLe6EfbpewxIERg2va3SLkHPCxn6E6gukv?= =?us-ascii?Q?LiCXvHjNuJNrR0sUhfMmSl9TuAa1sDOa9j8fqqr7RVOvkwLTiZQiDyNstdWm?= =?us-ascii?Q?U+BDqZ+5ur94piB72/jQWqN2L3ZzjFKrsQQIQ04VoGNeg64mwMlPCMyv+AJ4?= =?us-ascii?Q?uX85w1nMgjGW3vTz2lCsxGWFH7Yh99mcVgR+mlSfi4zl38c0lN2lwYZrPHcs?= =?us-ascii?Q?hAe8Q+9sDXSMqilx/Gb0UsWQADb6KV/qet+FTZ1x5EfIT2Epy1SE+ySawo/O?= =?us-ascii?Q?skyCwJPxkQokqalV3YBDfq6aydlFTJgwpskjlJT+WWVIoFkygg05VEN1sOYT?= =?us-ascii?Q?UiBtpWdJw1nb3D51YG1Unz2Gr+kLEbEddFNfZFsbbhGwMWCC0yLQwWJO1H1C?= =?us-ascii?Q?yktDcIPFCA9bwFxQ54muQuwOJmEWGKXZMVYWwnMk8Fckum+gOfITa++0gUHh?= =?us-ascii?Q?uXAH45vaJTlPStujAWp6n26b1YBA4QbHBTioWJvbHa9NuQDziQljcGgbtr+F?= =?us-ascii?Q?+YZvBN2lrIaWRvIAZ9AkeJxCrYD0hLCmg99Zy4AqbP59hb6RWsPP31Ga7gZ1?= =?us-ascii?Q?TNAhFmsaRztB85MgTmMxCBVF6VYxIfNaw0P3hunoVdu0h35AMpBVnZEqjanu?= =?us-ascii?Q?SILN9n6kUi0SntPJ1KJ90jLpfuoOqvzRYN3LMXZMDht0JMe4UvEapL/UXbMw?= =?us-ascii?Q?zjggGqLyJECSL0o77miE4v0BacgS7HB7OjxtKCOJnc2lkfTub6qVz6hqyJ+e?= =?us-ascii?Q?0NgdAwxSTjFyYabrATDcHl9Tl7QKvNsnrKS/yHxJtCCkNxkuO9tZYrag70eu?= =?us-ascii?Q?TCAyIQF5LxF9owbbWloZJdIR/fpqYLYALoTzIVGcEqmiJ2Y5lHa8ZdDUiwHm?= =?us-ascii?Q?60i/Qa8s6OQcAER5+9O3QeLv+exWq51k6oVSf9EuHQ5UkAh6p5hNzLV/QFiE?= =?us-ascii?Q?FlWUy6iOehKmaHZsaY2p0CKc/uPKuz0xvZnXjj6WW/hNwj236Aj00mSBaBow?= =?us-ascii?Q?ITLH1bxUZ+u5yy26AFYgxPXBA4+hdp4HZ8sg1svRT20qCU4D1EBGOkKf6Ksb?= =?us-ascii?Q?Gc2GIBroSDGLcTLJDW1VfLnfSas0Zhqbo4zx8IlYKkMOo5rrQ+FxTeq3UdsS?= =?us-ascii?Q?iV596EL9OitBh0gtHby6BExk6hM9F/CkKTQjDqlJEbXBWVbWvhA6B6SgEZl6?= =?us-ascii?Q?mZeTwPELLHn1RGaw8CP7GWAYB27Ktpso061xeRY/4mHxHZy7uG0N/j4P3A+d?= =?us-ascii?Q?b6HL45mlzqeDm0j9CGJMpr5vPvglZaDihbXNsQif7QQibqZ9K5i5GA60hIzz?= =?us-ascii?Q?nQ0Q4ptfzvZ+GuNxmkP9pV993Aes0MvNVjJXLicdW5HTkoxiM6vftYjqFVUF?= =?us-ascii?Q?r+Q4kBauxLEtBxfcRI3tDtnuB0sBuoPvVOywj6ROQduY61pUw/EXYsqCRNWM?= =?us-ascii?Q?txSHmA7FQga9hekKobTNXqyfkmbdu+8xb01XSRlCjJMEV77PWlZUJsGQlxk/?= =?us-ascii?Q?cvMZ1SRt1/WIl4e+UUw=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6694.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c34e4a7c-1570-43b1-acb6-08daf55db61b X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2023 12:00:06.1908 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wV8Jfvjy4HsjF0/sq0uruZvIUtJN1I04oxd8G61k4E2/MSvnfVwG0odtoKs1U73u0W1oxU/F+YLx6X/44/89PA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6134 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org [Public] Acked-by: Sunil Uttarwar -----Original Message----- From: David Marchand =20 Sent: Tuesday, October 4, 2022 3:22 PM To: dev@dpdk.org Cc: gakhil@marvell.com; Uttarwar, Sunil Prakashrao ; stable@dpdk.org; Somalapuram, Amaranath Subject: [PATCH v2 2/4] crypto/ccp: remove some dead code for UIO Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. uio_fd is unused. Fixes: 09a0fd736a08 ("crypto/ccp: enable IOMMU") Cc: stable@dpdk.org Signed-off-by: David Marchand --- drivers/crypto/ccp/ccp_dev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/crypto/ccp/ccp_dev.c b/drivers/crypto/ccp/ccp_dev.c in= dex 9c9cb81236..410e62121e 100644 --- a/drivers/crypto/ccp/ccp_dev.c +++ b/drivers/crypto/ccp/ccp_dev.c @@ -653,7 +653,6 @@ static int ccp_probe_device(int ccp_type, struct rte_pci_device *pci_dev) { struct ccp_device *ccp_dev =3D NULL; - int uio_fd =3D -1; ccp_dev =3D rte_zmalloc("ccp_device", sizeof(*ccp_dev), RTE_CACHE_LINE_SIZE); @@ -671,8 +670,6 @@ ccp= _probe_device(int ccp_type, struct rte_pci_device *pci_dev) return 0; fail: CCP_LOG_ERR("CCP Device probe failed"); - if (uio_fd >=3D 0) - close(uio_fd); rte_free(ccp_dev); return -1; } -- 2.37.3