[PATCH] net/mlx5: fix transceiver warning when not exist

[PATCH] net/mlx5: fix transceiver warning when not exist

[Yogev Chaimovich]

[-- Attachment #1.1: Type: text/plain, Size: 2 bytes --]



[-- Attachment #1.2: Type: text/html, Size: 562 bytes --]

[-- Attachment #2: 0001-net-mlx5-fix-transceiver-warning-when-not-exist.patch --]
[-- Type: application/octet-stream, Size: 1252 bytes --]

From ffe666291bc531b89620cc28a7b45fa209700f35 Mon Sep 17 00:00:00 2001
From: yogev <yogev@cgstowernetworks.com>
Date: Sun, 4 May 2025 23:11:46 +0300
Subject: [PATCH] net/mlx5: fix transceiver warning when not exist

In case no transceiver exist when trying to get the transceiver's info
There should not be an error message from the library.
The caller may print an appropriate error message using the relevant rte_errno if required.

Signed-off-by: yogev <yogev@cgstowernetworks.com>
---
 drivers/net/mlx5/linux/mlx5_ethdev_os.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
index e192f698d8..ba5fd2d253 100644
--- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c
+++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
@@ -1253,8 +1253,10 @@ mlx5_get_module_info(struct rte_eth_dev *dev,
 	}
 	ret = mlx5_ifreq(dev, SIOCETHTOOL, &ifr);
 	if (ret) {
-		DRV_LOG(WARNING, "port %u ioctl(SIOCETHTOOL) failed: %s",
-			dev->data->port_id, strerror(rte_errno));
+		if (rte_errno != EIO) {
+			DRV_LOG(WARNING, "port %u ioctl(SIOCETHTOOL) failed: %s",
+				dev->data->port_id, strerror(rte_errno));
+		}
 		return ret;
 	}
 	modinfo->type = info.type;
-- 
2.34.1

Re: [PATCH] net/mlx5: fix transceiver warning when not exist

[Stephen Hemminger]

On Mon, 5 May 2025 12:14:51 +0000
Yogev Chaimovich <yogev@cgstowernetworks.com> wrote:

> From ffe666291bc531b89620cc28a7b45fa209700f35 Mon Sep 17 00:00:00 2001
> From: yogev <yogev@cgstowernetworks.com>
> Date: Sun, 4 May 2025 23:11:46 +0300
> Subject: [PATCH] net/mlx5: fix transceiver warning when not exist
> 
> In case no transceiver exist when trying to get the transceiver's info
> There should not be an error message from the library.
> The caller may print an appropriate error message using the relevant rte_errno if required.
> 
> Signed-off-by: yogev <yogev@cgstowernetworks.com>

Signed off by is a legal requirement and must use your full name.
As in:
   Signed-off-by: Yogev Chaimovich <yogev@cgstowernetworks.com>

RE: [PATCH] net/mlx5: fix transceiver warning when not exist

[Maayan Kashani]

Hi, Yogev,
Thank you for contributing,
Can you fix the failing CI TEST?
https://patches.dpdk.org/project/dpdk/patch/20250506133107.4432-1-yogev@cgstowernetworks.com/

Regards,
Maayan Kashani

> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Tuesday, 20 May 2025 21:49
> To: Yogev Chaimovich <yogev@cgstowernetworks.com>
> Cc: Dariusz Sosnowski <dsosnowski@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Bing Zhao <bingz@nvidia.com>; Ori Kam
> <orika@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>; Matan
> Azrad <matan@nvidia.com>; dev@dpdk.org
> Subject: Re: [PATCH] net/mlx5: fix transceiver warning when not exist
> 
> External email: Use caution opening links or attachments
> 
> 
> On Mon, 5 May 2025 12:14:51 +0000
> Yogev Chaimovich <yogev@cgstowernetworks.com> wrote:
> 
> > From ffe666291bc531b89620cc28a7b45fa209700f35 Mon Sep 17 00:00:00
> 2001
> > From: yogev <yogev@cgstowernetworks.com>
> > Date: Sun, 4 May 2025 23:11:46 +0300
> > Subject: [PATCH] net/mlx5: fix transceiver warning when not exist
> >
> > In case no transceiver exist when trying to get the transceiver's info
> > There should not be an error message from the library.
> > The caller may print an appropriate error message using the relevant
> rte_errno if required.
> >
> > Signed-off-by: yogev <yogev@cgstowernetworks.com>
> 
> Signed off by is a legal requirement and must use your full name.
> As in:
>    Signed-off-by: Yogev Chaimovich <yogev@cgstowernetworks.com>

[PATCH] net/mlx5: fix transceiver warning when not exist

[yogev]

In case no transceiver exist when trying to get the transceiver's info
There should not be an error message from the library.
The caller may print an appropriate error message using the relevant rte_errno if required.

Bugzilla ID: 1690

Signed-off-by: yogev <yogev@cgstowernetworks.com>
---
 drivers/net/mlx5/linux/mlx5_ethdev_os.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
index e192f698d8..ba5fd2d253 100644
--- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c
+++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
@@ -1253,8 +1253,10 @@ mlx5_get_module_info(struct rte_eth_dev *dev,
 	}
 	ret = mlx5_ifreq(dev, SIOCETHTOOL, &ifr);
 	if (ret) {
-		DRV_LOG(WARNING, "port %u ioctl(SIOCETHTOOL) failed: %s",
-			dev->data->port_id, strerror(rte_errno));
+		if (rte_errno != EIO) {
+			DRV_LOG(WARNING, "port %u ioctl(SIOCETHTOOL) failed: %s",
+				dev->data->port_id, strerror(rte_errno));
+		}
 		return ret;
 	}
 	modinfo->type = info.type;
-- 
2.34.1