From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1432845C14; Wed, 30 Oct 2024 13:37:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F3A3C4331C; Wed, 30 Oct 2024 13:37:14 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2070.outbound.protection.outlook.com [40.107.94.70]) by mails.dpdk.org (Postfix) with ESMTP id C37C1402EE for ; Wed, 30 Oct 2024 13:37:13 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=n+sEhLfORyYdSjeQEp5Ks88UyY9+ygb4PBLaJt8yeHovzOzc/CbSIKDOHxi5qFR6JmDlaIH4bclyBHvU1oCcMwyQM4siq7DHug4vtZW8POie269lTsOIAh8rvd0DZZhcoX+27cW3rSzZ7EX/S/qRJgd/bcbCF6qsRMY1s/+xK2yNNDtLjuicA8Jhq3pWGEuON3DnNyOKvOIqCTDpkl4h+MAhJon/wwYGFZkb2gsJFWa3/TVljNd4j8OiFweMFqxnlU9OUjSMTDOhFP9NWGwwpNERgy1DTDAiG482shC6ZFKRoM4lfDZcZqKrKnxGJ1oljZAJfdgAlSSPBm+r91EB8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V/AAUII1q1MuOHcQfOQz2lcF2s2ZaVvNRrYoEZHGp3w=; b=ptZQE2SWFmgpl2k5jJCJjw158lEaLo5nWtmSpI65mnoLeyg2Np+yH71e+7v4p6jd22j97g3Zd3y5JgSwcksOJVqcqjE0opsBfKNv0LqP99S/N+q6igMB5zJQgtfio77fqZZ2Cnhm98BLG+lcIzYrNaRCN7jkO1sfaur/6oSHdiGaWV4yv1TFNZsD4FN8CQXwPp1xEvmk2e0ibzfsE0LnWwFF1wudb6fcJlYo1T600Irv2FR7B5m3tIZQnEUuVbZ9C9bjFh57wCJvfKBQuj/y8fwoNb/HcZG+Us+Wbj7UjYmsovPiisfpQ3XhU+XbG7PNgt9j8f+3N63N5nv5ELKwcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V/AAUII1q1MuOHcQfOQz2lcF2s2ZaVvNRrYoEZHGp3w=; b=AgBk41JmPriFo/sLCHLsoRYadLW4QKrYzA71N80BIIywz8VYsD8TcFWMA6J5clZVr3aCZAk6Dvtwt5HEm+haPtGU3rF0tldrjmzaYQ9InkEwkxRguwXgAHt3x2xPsjFPELyDgIkNB8eQW+wXyh8IG0rbwzGlIHFetgNM2Fwhtkc= Received: from PH7PR12MB8596.namprd12.prod.outlook.com (2603:10b6:510:1b7::6) by BL1PR12MB5947.namprd12.prod.outlook.com (2603:10b6:208:39a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.29; Wed, 30 Oct 2024 12:37:10 +0000 Received: from PH7PR12MB8596.namprd12.prod.outlook.com ([fe80::a011:943d:7291:8069]) by PH7PR12MB8596.namprd12.prod.outlook.com ([fe80::a011:943d:7291:8069%6]) with mapi id 15.20.8093.024; Wed, 30 Oct 2024 12:37:10 +0000 From: "Varghese, Vipin" To: "Varghese, Vipin" , Pavan Nikhilesh Bhagavatula , "dev@dpdk.org" , "roretzla@linux.microsoft.com" , "bruce.richardson@intel.com" , "john.mcnamara@intel.com" , "dmitry.kozliuk@gmail.com" , Jerin Jacob CC: "ruifeng.wang@arm.com" , "mattias.ronnblom@ericsson.com" , "anatoly.burakov@intel.com" , "stephen@networkplumber.org" , "Yigit, Ferruh" , "honnappa.nagarahalli@arm.com" , "wathsala.vithanage@arm.com" , "konstantin.ananyev@huawei.com" Subject: RE: [EXTERNAL] [RFC v3 3/3] examples: add lcore topology API calls Thread-Topic: [EXTERNAL] [RFC v3 3/3] examples: add lcore topology API calls Thread-Index: AQHbKo8d+PlDPcnsUk25KFLC/V+cZLKfLmkAgAAEG6CAAAgtMA== Date: Wed, 30 Oct 2024 12:37:10 +0000 Message-ID: References: <20241030054133.520-1-vipin.varghese@amd.com> <20241030054133.520-4-vipin.varghese@amd.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_94523dde-f9d1-4aa7-80a9-c0900420d3c3_ActionId=d50bce2c-364f-4d54-b6e7-d27bd1d994c8; MSIP_Label_94523dde-f9d1-4aa7-80a9-c0900420d3c3_ContentBits=0; MSIP_Label_94523dde-f9d1-4aa7-80a9-c0900420d3c3_Enabled=true; MSIP_Label_94523dde-f9d1-4aa7-80a9-c0900420d3c3_Method=Privileged; MSIP_Label_94523dde-f9d1-4aa7-80a9-c0900420d3c3_Name=Non-Business_New; MSIP_Label_94523dde-f9d1-4aa7-80a9-c0900420d3c3_SetDate=2024-10-30T12:04:21Z; MSIP_Label_94523dde-f9d1-4aa7-80a9-c0900420d3c3_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR12MB8596:EE_|BL1PR12MB5947:EE_ x-ms-office365-filtering-correlation-id: 191c13d8-0534-4556-5d8b-08dcf8df92a2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|7416014|1800799024|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?H0RP8iBstQxmVqLBq4Ittxo9wEncPs8RR1jPt+HiYpnCL2hzAmp+joUuoZ/d?= =?us-ascii?Q?3Jf8of5nfODBRi2YuuNcPRY9RPE8zoXEdyssW8MRKz0kreA/pMhuK/SlExoJ?= =?us-ascii?Q?xcx3jzT65eX88rEbR5iskDLjzLd7MsGmUYWPMcSOHJxf0JVeqHSt4m343McF?= =?us-ascii?Q?p/vfQPiUjOOyWfSE65bECqS1EUUQnlOUanq5eO2aJvDT+uJtn7LBnhRYX8Mk?= =?us-ascii?Q?ndfA5/ZkHfK28yM0LVwNtknwJRpmxod1n/XehgY+2YayiTgnrqQTdSXMwJ3Y?= =?us-ascii?Q?t1DzIORTgozSVDudCrEkWgvN5hZzcKB1OmVt2k6lSeGtX+EddfKOYP0KUlBa?= =?us-ascii?Q?HOsVKJXoptFOBD/Awe1KPRJvx6pVAB/crJVz33kNpRwNko83KJ3qYzpRzK/6?= =?us-ascii?Q?Qv5SO8lZkd9XHUuDDRyKT38BED4iid6peXmlhoQ1muj4E3oPaJ00wQByKbYl?= =?us-ascii?Q?Kbsy/eXNeLHkqHD8UTZzUEKXucLtL4BsF4gCnhEc8TsiZZestxGmu8NG//B8?= =?us-ascii?Q?gFN1lHN0UngUvLlPetUB9JmHqagso+A1Sk93J5ihCHyj9o+l2e7lGag/b8VT?= =?us-ascii?Q?hUQlBb3lU4WdXvPHFbjLiJ/mVrz/P5jResMokAIf96tBnIeKkIMcsypez2Fw?= =?us-ascii?Q?aF8YBd39LZSx6YnaDx3A1j2lTkB2H/wfnGxd2/e6deIqjguzVmA1zEYoBoz3?= =?us-ascii?Q?pBYAAHRPfhCDoUJ4KhKQDxD1Yrueslsfgq447YlvVcTOSVyDP4sTtLqeUG8+?= =?us-ascii?Q?055QGQnuGssVCNjJ0X4R5kzNH7MdxKwPQRLvJUVZSYPAVgxxRM/rFKTDF+Nz?= =?us-ascii?Q?2F1pufBb7Jw9jqItE9/73kGkdwO/2xl6ebRkF6CclsFejBMJ9lcCEHj+Ijw3?= =?us-ascii?Q?qrC5ZkFrlPqfMhYAJd/iY8kwpUKUR3iW/Zm6ORDbWYzb3FNZVGzBJ9AinlVg?= =?us-ascii?Q?DXNgHOsIYmrE7pXKHm4sTItOO0YOZTIO6mkdNwY3nPbPjrDcJHlbx623aeSs?= =?us-ascii?Q?zSV2ot3k0P09j0wzAQxoYdRLplwSMHfrccg0WUCVz8KUwve6qQr+J7F/DQ1k?= =?us-ascii?Q?wTd8Q5J/lgR4NDoAPagF9qytz37Oky+qMtCyu1GsFboFOjU2F8BjhExdnaH2?= =?us-ascii?Q?4zt8tFa71v2uMBf5j+ER3DUBG6ik/kpMGdnPoegE1TgMmTrFrHS+YSdFnUL9?= =?us-ascii?Q?x7XU6g+4IBrPYtZ9t6tnidfy7ETYKkpP0q3zclMt2+hqP++uzBfC/N+he7eW?= =?us-ascii?Q?JXB6nuVC26Xyt+tIe6ZMZA+znwvcOQ5oWRrEXiB5+kSlsYQWE7j2DCXjeVfC?= =?us-ascii?Q?fxFd0pMRb5QK7qi4xiZLWsscqp58ArdyZMzDscxnQYqUz3M1VQ62QDSg1ftq?= =?us-ascii?Q?wAkbAoU=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR12MB8596.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(7416014)(1800799024)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JE6K+30WeUp4N5JWlf9zaihsPLfDNVTcsH7NTW5dTii2hJH5fjCoOwIJWcua?= =?us-ascii?Q?s9uWI8nku5Au3ad7rv1ds4kexG6CIs5pYWDmLWZRhmkg2S3veBEIbZtzyWSO?= =?us-ascii?Q?94XkiAUOLxB3yBn7se7dqWrZv7nGCCTw4nVAukKcmfbhybLy0ylp386G9Rqi?= =?us-ascii?Q?UK6lmS65b+fHLdk0Plw4uvMstUVpWYllO33KNY8Yd0acy60WmD9Mcy84MlCd?= =?us-ascii?Q?l2N7T7BVIGYmZYQAvRKzM6gaEEP9NGjUHepr3Nf6iAEBkiHow2zkS+U/A8sH?= =?us-ascii?Q?pkjG7yO4Vh5QA/HSvv/kz8hZu+so8VtTlkcdqhcqSVhYvkYT63xJQtZDdgsl?= =?us-ascii?Q?VWXZDdjQl7YLbim94rAGTXpK1aV2FY/mNAlUWgBHUTV2zPsoyBGWB8B+kvFA?= =?us-ascii?Q?r3rq74I9jTmZ8zF6snQJW/O40kdWWx7xI2zpank5QIziZEbbVf4VxJLG1kNO?= =?us-ascii?Q?5lI4o4I6sT3CNdoFeefx/QYHTxT5TpOCrs0JdtQQlHOjD/6W9GGbQKJqYdKB?= =?us-ascii?Q?FiSvgH3DeWQvLjILdWMUimKPK0K946nJXypp85ZjxlEx5C7bJce8Ow4SvNlD?= =?us-ascii?Q?0SHQTAV7BUeFYHNdEUYsrdIZ56sj6BlqN/1Sv39ltw1a66imGqRJ4O5835Wn?= =?us-ascii?Q?Y6lU/q0iV/xZV8J3nlxEJDYDzjOwxoD1ILvzPyQjbSDrKlFopQW3f/FLz3wN?= =?us-ascii?Q?P1N8getrcTiQ2iv3Xpi03Usjix4v4pgH/xiabW2XNqwZ8Disic7Ot58E2iHh?= =?us-ascii?Q?S2pQWT9lleufKZ6mmCXq8uSd1rMv1vuAqvCAgUSATQvet+Kgq2MLAM1rRulP?= =?us-ascii?Q?dHcoV00DcHBc2FynEOsTVcq16fRdBfgfC6uQEt7NjCByVoyBSAHTpBE/Zber?= =?us-ascii?Q?vMlLLfHOrLmhW9yY9CjHVkeeR0QsWk0oFjCe8jgC6UNkDh6R9uGR+2RAuQl/?= =?us-ascii?Q?FrM/AXKW2ozrTK9fzQ9ja76P2DzXYCff3WaUrss7Nx/lOdrlTQDpOSBQxMVe?= =?us-ascii?Q?6BsK7rXp03JEWYzzGz9AQ/II5BFlWZca13HS+bCAKyykW1+yQB88T7lZY0q1?= =?us-ascii?Q?3dsSx8rJGH7h9wGuPKXRS9r/ZXF2oPcatFPj4VYoS62M/sEoQ2/YeKl0029L?= =?us-ascii?Q?zUIcfRpNyItY4vaRNuggo2EU5xna/ozIjpj5Yhu2onztb+sD8dnsCS2Y1Gqy?= =?us-ascii?Q?1vfA/xRsXfNcT4V4aBC0MHMu6235XioN99NY5yyIJcn6H0kT+2TkSrwN96iH?= =?us-ascii?Q?+8IZWqxkjDx/H2GRSzYQrBgrRN8H8yJOGoh2xnyae4hcFg13jaQKDC/i8i+X?= =?us-ascii?Q?jE/NrVJZhfsCe4F7ba4CvSqR3GUduZQqU9Yd/HhPm4dJFVoC/fnENyFkdJ4/?= =?us-ascii?Q?r81xob1zgfEiIazfzi23ZLx82OtkXfTCmp38g6Ax9QC5JnmqzC8EQShgf/cc?= =?us-ascii?Q?1dlfphCqAjESodpCjTca7Wfv56s1SXVjrrxR1nSwA+YE/MlsCMKgIMeLBkVL?= =?us-ascii?Q?M6brFbFsh7cnKWhtUojT9rUuFRpl7vjmaHczhyIAzkKyBw3FglPT+lYC7EfY?= =?us-ascii?Q?59llOXdj9yl1AQOcpMg=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB8596.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 191c13d8-0534-4556-5d8b-08dcf8df92a2 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Oct 2024 12:37:10.0974 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: I6ZG3/pQsFo2oQOYQ3bpvxokmXJG/Oledl/5D7S7QI3XJAg4fVBK8OusGRyY86RUzp9JJppUqSuQA7QWHROOCg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5947 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org =20 > Hi Pavan, >=20 > Snipped >=20 > > > > I see compilation failure on ARM platforms due to missing header includ= e. > > > > ../examples/helloworld/main.c: In function 'parse_topology': > > ../examples/helloworld/main.c:83:13: error: implicit declaration of > > function 'strtoul'; did you mean 'strtok'? [-Wimplicit-function-declara= tion] > > 83 | n =3D strtoul(q_arg, &end, 10); > > | ^~~~~~~ > > | strtok > > ../examples/helloworld/main.c:83:13: warning: nested extern > > declaration of 'strtoul' [- Wnested-externs] > > ../examples/helloworld/main.c: In function 'helloworld_parse_args': > > ../examples/helloworld/main.c:115:42: error: 'EXIT_FAILURE' undeclared > > (first use in this function) > > 115 | rte_exit(EXIT_FAILURE, "Invalid= Topology > selection\n"); > > | ^~~~~~~~~~~~ > > ../examples/helloworld/main.c:13:1: note: 'EXIT_FAILURE' is defined in > > header ''; this is probably fixable by adding '#include ' > > 12 | #include > > +++ |+#include > > 13 | #include > > ../examples/helloworld/main.c:115:42: note: each undeclared identifier > > is reported only once for each function it appears in > > 115 | rte_exit(EXIT_FAILURE, "Invalid= Topology > selection\n"); > > | ^~~~~~~~~~~~ > > ../examples/helloworld/main.c: In function 'main': > > ../examples/helloworld/main.c:153:26: error: 'EXIT_FAILURE' undeclared > > (first use in this function) > > 153 | rte_exit(EXIT_FAILURE, "Invalid arguments\n"); > > | ^~~~~~~~~~~~ > > ../examples/helloworld/main.c:153:26: note: 'EXIT_FAILURE' is defined > > in header ''; thi > > > > Below header include should fix it. > > > > diff --git a/examples/helloworld/main.c b/examples/helloworld/main.c > > index > > 9845c3775c3a..f49bd0108f74 100644 > > --- a/examples/helloworld/main.c > > +++ b/examples/helloworld/main.c > > @@ -3,6 +3,7 @@ > > */ > > > > #include > > +#include > > #include > > #include > > #include >=20 > Thank you for helping me here, I did run with `check_includes & developer= _mode`, > it did not throw this error. > Before patch submission I tried `devtools/test-meson-builds.sh` too. I th= ink internally > this is not using ` check_includes & developer_mode `. > Let me recheck and fix this in version 4. Thank you, I found the reason for my miss on this. When build using cross compiler manually, no issues with the steps ``` meson arm64-build --cross-file config/arm/arm64_armv8_linux_gcc ninja -C arm64-build cd example/helloworld make ``` But building using cross compiler with examples manually, no issues with th= e steps ``` meson arm64-build --cross-file config/arm/arm64_armv8_linux_gcc -Dexamples= =3Dhelloworld ninja -C arm64-build ``` We get the logs as ``` ../examples/helloworld/main.c: In function 'parse_topology': ../examples/helloworld/main.c:83:13: warning: implicit declaration of funct= ion 'strtoul'; did you mean 'strtok'? [-Wimplicit-function-declaration] 83 | n =3D strtoul(q_arg, &end, 10); | ^~~~~~~ | strtok ../examples/helloworld/main.c:83:13: warning: nested extern declaration of = 'strtoul' [-Wnested-externs] ../examples/helloworld/main.c: In function 'helloworld_parse_args': ../examples/helloworld/main.c:115:42: error: 'EXIT_FAILURE' undeclared (fir= st use in this function) 115 | rte_exit(EXIT_FAILURE, "Invalid Top= ology selection\n"); | ^~~~~~~~~~~~ ../examples/helloworld/main.c:13:1: note: 'EXIT_FAILURE' is defined in head= er ''; did you forget to '#include '? 12 | #include +++ |+#include 13 | #include ../examples/helloworld/main.c:115:42: note: each undeclared identifier is r= eported only once for each function it appears in 115 | rte_exit(EXIT_FAILURE, "Invalid Top= ology selection\n"); | ^~~~~~~~~~~~ ../examples/helloworld/main.c: In function 'main': ../examples/helloworld/main.c:153:26: error: 'EXIT_FAILURE' undeclared (fir= st use in this function) 153 | rte_exit(EXIT_FAILURE, "Invalid arguments\n"); | ^~~~~~~~~~~~ ../examples/helloworld/main.c:153:26: note: 'EXIT_FAILURE' is defined in he= ader ''; did you forget to '#include '? [2963/4590] Compiling C object drivers/libtmp_rte_event_cnxk.a.p/event_cnxk= _tx_cn10k_tx_112_127_seg.c.o ninja: build stopped: subcommand failed. ```