From: "Varghese, Vipin" <Vipin.Varghese@amd.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"roretzla@linux.microsoft.com" <roretzla@linux.microsoft.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"john.mcnamara@intel.com" <john.mcnamara@intel.com>,
"dmitry.kozliuk@gmail.com" <dmitry.kozliuk@gmail.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"ruifeng.wang@arm.com" <ruifeng.wang@arm.com>,
"mattias.ronnblom@ericsson.com" <mattias.ronnblom@ericsson.com>,
"anatoly.burakov@intel.com" <anatoly.burakov@intel.com>,
"Yigit, Ferruh" <Ferruh.Yigit@amd.com>,
"honnappa.nagarahalli@arm.com" <honnappa.nagarahalli@arm.com>,
"wathsala.vithanage@arm.com" <wathsala.vithanage@arm.com>,
"konstantin.ananyev@huawei.com" <konstantin.ananyev@huawei.com>
Subject: RE: [RFC v3 1/3] eal/lcore: add topology based functions
Date: Mon, 4 Nov 2024 03:13:04 +0000 [thread overview]
Message-ID: <PH7PR12MB859672BC3056A84477B6BAE382512@PH7PR12MB8596.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20241030084437.24fe8265@hermes.local>
Snipped
>
> On Wed, 30 Oct 2024 11:11:31 +0530
> Vipin Varghese <vipin.varghese@amd.com> wrote:
>
> > + if (topo_cnfg.io) {
> > + free(topo_cnfg.io);
> > + topo_cnfg.io = NULL;
> > + }
>
> No need to check for NULL before calling free.
Thank you Stepehen on this, the reason why we specifically added to address 2 scenarios
1. as pointed out by Wathsala where System Level Cache will be disabled; where L3 will be not available at all
2. for version where hwloc does not detect the specific cache level.
By checking the NULL we can avoid such cases.
Note: I will recheck and add|remove this in v4
next prev parent reply other threads:[~2024-11-04 3:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 5:41 [RFC v3 0/3] Introduce Topology NUMA grouping for lcores Vipin Varghese
2024-10-30 5:41 ` [RFC v3 1/3] eal/lcore: add topology based functions Vipin Varghese
2024-10-30 15:43 ` Stephen Hemminger
2024-11-04 3:09 ` Varghese, Vipin
2024-10-30 15:44 ` Stephen Hemminger
2024-11-04 3:13 ` Varghese, Vipin [this message]
2024-11-04 8:45 ` Mattias Rönnblom
2024-10-30 15:45 ` Stephen Hemminger
2024-11-04 3:13 ` Varghese, Vipin
2024-10-30 15:47 ` Stephen Hemminger
2024-11-04 3:16 ` Varghese, Vipin
2024-11-04 7:57 ` Morten Brørup
2024-11-04 9:56 ` Varghese, Vipin
2024-11-04 11:21 ` Morten Brørup
2024-11-04 12:14 ` Varghese, Vipin
2024-11-04 12:29 ` Morten Brørup
2024-11-04 13:08 ` Varghese, Vipin
2024-11-04 14:04 ` Morten Brørup
2024-11-05 2:17 ` Varghese, Vipin
2024-10-30 5:41 ` [RFC v3 2/3] test/lcore: enable tests for topology Vipin Varghese
2024-10-30 11:50 ` [EXTERNAL] " Pavan Nikhilesh Bhagavatula
2024-11-04 3:07 ` Varghese, Vipin
2024-10-30 5:41 ` [RFC v3 3/3] examples: add lcore topology API calls Vipin Varghese
2024-10-30 11:49 ` [EXTERNAL] " Pavan Nikhilesh Bhagavatula
2024-10-30 12:06 ` Varghese, Vipin
2024-10-30 12:37 ` Varghese, Vipin
2024-10-30 19:34 ` Pavan Nikhilesh Bhagavatula
2024-11-04 3:02 ` Varghese, Vipin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH7PR12MB859672BC3056A84477B6BAE382512@PH7PR12MB8596.namprd12.prod.outlook.com \
--to=vipin.varghese@amd.com \
--cc=Ferruh.Yigit@amd.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=jerinj@marvell.com \
--cc=john.mcnamara@intel.com \
--cc=konstantin.ananyev@huawei.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=roretzla@linux.microsoft.com \
--cc=ruifeng.wang@arm.com \
--cc=stephen@networkplumber.org \
--cc=wathsala.vithanage@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).