From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4642445C14; Wed, 30 Oct 2024 13:06:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2C80A4332E; Wed, 30 Oct 2024 13:06:58 +0100 (CET) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2065.outbound.protection.outlook.com [40.107.102.65]) by mails.dpdk.org (Postfix) with ESMTP id 578B04331C for ; Wed, 30 Oct 2024 13:06:57 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UYhdWKpb8MtIJpjhQiQKXIKIiSeAR7UfkMET+RFYtHuxI5SCn2u4aD2G1UiluQmn135NzBcBv+hMiZ7u5Rg6s/kVeey5Ve0kWO4FigrKzebexgr5VEd8hPSHPzVM1MkGa9aqwaPylpFv2FADSYC9DfestNiWVzVpy0i0aTqYh9/nh0RH7PtRKObhoO+FZdmPEPw/1k4lSDVd01AbTqc82tVwo5qfLBIsZc59MhsjLKs5AyW+OW/LERubc4RvrbFCefMJ89blWBL5u7l9uUazd2knfdBmcnYvZ8AkcSVIf+uZ3qBVuwPYcVptALLyx2ae2M0yAn59SeeK02rvFho5nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pY8zx19D1MFY0unFU2VoBlRi45lWqaIq9BsPcRFTCYQ=; b=pS+Vh9Oebtubg+wMl7xOkkKCaXHdL2yBOZ3kQK2k5lcU29K5hFyw4IkTOQ+H9rUU/gp/zhLKsXKMte66oUOICCfSuQ61Ry7bdEItoVi7jvtGjjOjUs+Qi4JuwzvgjcjO2K6jLndAC3ZwJSXZp5juYynevclOs711TcXDnWCr8uqOwUCoVkoowmBzydYaVRlXJcn3Ls2lIBPTaysNW9UmrJZDw+FERgPBj2NN8NoTtjhSEwtDJhkhkmcbPuHQQjoJGj2L/G6iZj/EMlTVsP9VmpDO3jOPpuyR6u8r4uWs2rsrhoEPskxXvKa8l0vYtRIJBSL8CmfuSnKcu61T+LbkIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pY8zx19D1MFY0unFU2VoBlRi45lWqaIq9BsPcRFTCYQ=; b=ph2ICw9ZmO9da0P1Vgk02vCe1QUgy7qxzeuCXw4NjAcCkVJ9pCiTHCJh1OwbnHNc+n8EnnCVQVz9BgV6G6NPazBelowNs07hwHwTrime0171cjlzqZaw+dhMI1WxNnoFphEVKOob0O336ZFk5e8budxM7Vtf7xV2AlBSHwn58xc= Received: from PH7PR12MB8596.namprd12.prod.outlook.com (2603:10b6:510:1b7::6) by SJ2PR12MB9006.namprd12.prod.outlook.com (2603:10b6:a03:540::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.29; Wed, 30 Oct 2024 12:06:55 +0000 Received: from PH7PR12MB8596.namprd12.prod.outlook.com ([fe80::a011:943d:7291:8069]) by PH7PR12MB8596.namprd12.prod.outlook.com ([fe80::a011:943d:7291:8069%6]) with mapi id 15.20.8093.024; Wed, 30 Oct 2024 12:06:55 +0000 From: "Varghese, Vipin" To: Pavan Nikhilesh Bhagavatula , "dev@dpdk.org" , "roretzla@linux.microsoft.com" , "bruce.richardson@intel.com" , "john.mcnamara@intel.com" , "dmitry.kozliuk@gmail.com" , Jerin Jacob CC: "ruifeng.wang@arm.com" , "mattias.ronnblom@ericsson.com" , "anatoly.burakov@intel.com" , "stephen@networkplumber.org" , "Yigit, Ferruh" , "honnappa.nagarahalli@arm.com" , "wathsala.vithanage@arm.com" , "konstantin.ananyev@huawei.com" Subject: RE: [EXTERNAL] [RFC v3 3/3] examples: add lcore topology API calls Thread-Topic: [EXTERNAL] [RFC v3 3/3] examples: add lcore topology API calls Thread-Index: AQHbKo8d+PlDPcnsUk25KFLC/V+cZLKfLmkAgAAEG6A= Date: Wed, 30 Oct 2024 12:06:54 +0000 Message-ID: References: <20241030054133.520-1-vipin.varghese@amd.com> <20241030054133.520-4-vipin.varghese@amd.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_94523dde-f9d1-4aa7-80a9-c0900420d3c3_ActionId=d50bce2c-364f-4d54-b6e7-d27bd1d994c8; MSIP_Label_94523dde-f9d1-4aa7-80a9-c0900420d3c3_ContentBits=0; MSIP_Label_94523dde-f9d1-4aa7-80a9-c0900420d3c3_Enabled=true; MSIP_Label_94523dde-f9d1-4aa7-80a9-c0900420d3c3_Method=Privileged; MSIP_Label_94523dde-f9d1-4aa7-80a9-c0900420d3c3_Name=Non-Business_New; MSIP_Label_94523dde-f9d1-4aa7-80a9-c0900420d3c3_SetDate=2024-10-30T12:04:21Z; MSIP_Label_94523dde-f9d1-4aa7-80a9-c0900420d3c3_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR12MB8596:EE_|SJ2PR12MB9006:EE_ x-ms-office365-filtering-correlation-id: 4cc281e6-c0b2-4d32-8307-08dcf8db58bb x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|7416014|366016|1800799024|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?2jXv+WB9Kb7EFgtoLEEhcLlDuP2aKLQfTlg8RgOj7lTgNP77ILKlRCVKAI5p?= =?us-ascii?Q?Q/jKo7/KfaXMweNrn7Q+XZV0FgBCR7MQg8SH8Z12CFF69RTUddAiaflUWk8D?= =?us-ascii?Q?06DhVywquabTsr1VbhorZu7w3aMG6Gc45qNF9QUzb+Q6hanJjQN1F10R2hD7?= =?us-ascii?Q?o2ruvdiH+VnqXVfilfXp3h1Ve7+03ON3Mc9C7JhjvUIIc6tzhfB520lsvZ7S?= =?us-ascii?Q?PaGtW7ZKK8Br0e6pu8c3VcxkRUlXxpXdHqvSZeR2Y3H+Xf+UDKtFFT50ZRBV?= =?us-ascii?Q?8aT8GFGCrlzGo5ueYQ1oq4vBgAwn1e40HStIDRPpPUMeS6WGbZHTBTZ8IgR6?= =?us-ascii?Q?LtPM3INvq2rFgwVMXBmH7JvDdZBvH6aknPhq1diTnB16tMHHEIqvaoOxVFQO?= =?us-ascii?Q?OzIePvsJvKpUTwC7U5KdqT55wc/zPcBWHyc6VWy1RugrU0/wpHPhQQ1y7xKa?= =?us-ascii?Q?tfU1RQAdXqpjI5lBQZFS/rtHu6ksHvd25YGNyh3Cggpil8uNM6x/zM31Va6A?= =?us-ascii?Q?s6+kN3IWOt38GJoGFlOLKdS8xU/t1kaMHbqSOpTiyi3WmR09q9bBNxQJY3YE?= =?us-ascii?Q?/BgvzwrLDBmutlNHUW7tX8GzwvMXxOjU2VEilHtmItreAMNkU49TmhrdCTPV?= =?us-ascii?Q?1hpM166Yw9oQiNG89NJMFylmHlPD5r7ZBCj6I1MzLHlJTnM30DDc9/EJMnqL?= =?us-ascii?Q?PeQHtwZYVb/ZJkmklsUQZkJeOX6LaGi4vtfPMoFPP04FXq5NGLgyJKpI4W5g?= =?us-ascii?Q?KgcPKZtWOCpm4UtuGOfAlxMZDROJthlBCPWCmiRUPpa9NAXQR24FOz+i86cJ?= =?us-ascii?Q?TeaD+8P4o8ExFimc/xN+IidAU76f80gSZR5qTNg5rdJVLK5cm2bLRZ4VInWa?= =?us-ascii?Q?tzqScvRvb6YvPUy8XLoJ+f2gYdzF+j1G5QvCJX6/2ZZ1f4JdOyaUiTEI8UQC?= =?us-ascii?Q?AhVkk/RFuRq6l5cOde4VAnswWvZ9ZWI6ZiKrfypSQhJZQL0gLMO2gFSp1sFO?= =?us-ascii?Q?JP6qUdD+xPHK58ENgJLHnIeJJlzk24rW2uIGcXGA1l/6gDg/AKWEgCy17hBs?= =?us-ascii?Q?8eAD5wFNqR4S6KYlHEGoWsyglAenQAQ0hruT/64m9181kvlCIM3jFz0HTNDs?= =?us-ascii?Q?5B9gmFiUKB0Rti+HwwTckjFQa7aZ9cP2DJOzzACVjIdoKlKN5yjqy8dUcd1d?= =?us-ascii?Q?N+zQWrt4lxfDDEclIvkFa8YA2pa5Zo2IuMrmf916vAO3GsPBKISjwRN6g7Gh?= =?us-ascii?Q?S5tBrKlcIdvn+L5gGB2W8zUg1raWUsHzJTB3FOBerBxNL5mDs8Xrq4XZEAO5?= =?us-ascii?Q?ju0DSw1tqJmYWikj8toHS0rJL21NCUx/+5lHLR8GAivu8TDWiIvqb24WF2B9?= =?us-ascii?Q?ebbZe/8=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR12MB8596.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(7416014)(366016)(1800799024)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sW8IXu/ep/y103XRpqN9+bqGcwvLORbukwsOZpiHnV/jHdXXS2xi8PIhMMo/?= =?us-ascii?Q?1wgJxzrWr9P1pJ4ITpviVdNVi5ek4hO/D2j8DQC7PFBiobM+zsmRt23R1RfR?= =?us-ascii?Q?9H9+dVYntiTAx1/1PFhUl22njykqVLSFisv5Opa7fR7tjhRRyL20d9ncMVoz?= =?us-ascii?Q?BINPngu9rDXwxqRm2yce3HthFQdYfy5BV9+CmMWQ3nL2ukLa21M44Qhs/lI0?= =?us-ascii?Q?v4BYg1GnP3PQrEu+jU8CL0H9fLHx/kk+3Za7SXba90aICagWGMlCg1HtU/nj?= =?us-ascii?Q?6E7iiB9/xEbFRoFY1xSsmvp27sa9jOm1rudKmKiqA3RxHNpawUf/lmq9c3wS?= =?us-ascii?Q?B7LV/Lysy+KPvh6m5zbn8nre5OjbZC8eT4+9KG/B7hcjIvum5cw4hCLLW8NL?= =?us-ascii?Q?ZDZgyxsQdRnyIxzSMocsTt2HGaVOrCw7appRxRMc0SEhxXYFt9Fo/Xnb8/Dd?= =?us-ascii?Q?jrw+8iqyQ8Keu45htGkrrY/M7tRrb7NmSSlkTa4qoIokumPneofl76azBCLj?= =?us-ascii?Q?gGG8NCC7/emWyBswVfbbWdJ+OKwUNYoG803gRDzgInAsjm/xy/mwi3GvSFQn?= =?us-ascii?Q?lOHYuC8c/0Wf4/ewKZUK/oQJlSvjmU0iETr+tiwyA7tYi3mWONFeFq9gsvZ4?= =?us-ascii?Q?AxkvkEkooTVoKWcdBkYPwH0sdMmUYE97GzNg4UKMesepY80ryUpQNQrm08e1?= =?us-ascii?Q?7ejyqv94M2MtugMlxZL8AhynKpbIfUwtbhiy9izml+yYmb+fNjkE5pioui+O?= =?us-ascii?Q?rM4ySIO9Vb1NgksQ3rrPk6OCuBqaM+843WAOlJAhq2ettetBiizhNRiMYIfF?= =?us-ascii?Q?FJ9TfXD2jx16NGnUT+QnzcIB0UqsUpYesjkxUbmAo4AQ5k34ZF+pTW2miKKP?= =?us-ascii?Q?iUbUZEuCtDGyAuEJ6Ez6gEN2cgytKsgNDlep1lpb8h7KjW2Udrfhte5xusfs?= =?us-ascii?Q?nj7uRl7dTArLvS+1D+En49Cudhs6zfJ+Ocls7TN/KCaqk5qIJx9I2LWBtj/r?= =?us-ascii?Q?0G/WVd1T8kqMRcsu1FED6l4CxieobW6rZ0GRlR2L05nN+8SaKaSHPVTTaELJ?= =?us-ascii?Q?dX8+9jOL1VslIqJPmMIH7wPzdLx2S0SE/2DZR2kXRT0ymmtedd/yv0a/7N+x?= =?us-ascii?Q?ChDvFFj1MGhv1vufza1KCKfkeZg6fZBjj9aEaA/KF7rorpa+nOt8qb9wK8+V?= =?us-ascii?Q?XU2D10QUQWyFg2rTp96t9iwrwUg1BjEqBLed+OsVwNdyGyslNIrFyYtwuRwL?= =?us-ascii?Q?YuA8whMTm+Va0miWU3LLRZWL4QcOkAfpqmbm3pMFXH8G0trmK0xU1JQTXxBz?= =?us-ascii?Q?mCr5Nw+pQ7iAX9LE3Le0WnNib+wQHwR5NpBK7qu8kOP9bsQDhvVGu3DzozFe?= =?us-ascii?Q?6ynHSF8htfeDuA7OLuSQKvygwxiXjR6B4QUklcZIbQlrJxbQzki8HYZn5+XO?= =?us-ascii?Q?5JGvJ6BVom0TNdtK2N8DmVeQlR86sROI45i8ONHRcX7HIqjVHTmSeZDKdxya?= =?us-ascii?Q?GNOr6qGEdStPmBUFRUdDuUPER9/rf5bMO/bRjMFJGj+vr01LiFz7/9OXX114?= =?us-ascii?Q?m10Oj2W59Noo41GrY4k=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB8596.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4cc281e6-c0b2-4d32-8307-08dcf8db58bb X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Oct 2024 12:06:54.9931 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PG6Z4aMEpbGX9Ghv4oKIk2Wrh7jeJ5nce9408MwsKQmEDYsq6USmaM08bAg+0ikepY31pwlQX9DrFyN3fBvSHQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB9006 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Pavan, Snipped >=20 > I see compilation failure on ARM platforms due to missing header include. >=20 > ../examples/helloworld/main.c: In function 'parse_topology': > ../examples/helloworld/main.c:83:13: error: implicit declaration of funct= ion 'strtoul'; > did you mean 'strtok'? [-Wimplicit-function-declaration] > 83 | n =3D strtoul(q_arg, &end, 10); > | ^~~~~~~ > | strtok > ../examples/helloworld/main.c:83:13: warning: nested extern declaration o= f 'strtoul' [- > Wnested-externs] > ../examples/helloworld/main.c: In function 'helloworld_parse_args': > ../examples/helloworld/main.c:115:42: error: 'EXIT_FAILURE' undeclared (f= irst use > in this function) > 115 | rte_exit(EXIT_FAILURE, "Invalid T= opology selection\n"); > | ^~~~~~~~~~~~ > ../examples/helloworld/main.c:13:1: note: 'EXIT_FAILURE' is defined in he= ader > ''; this is probably fixable by adding '#include ' > 12 | #include > +++ |+#include > 13 | #include > ../examples/helloworld/main.c:115:42: note: each undeclared identifier is= reported > only once for each function it appears in > 115 | rte_exit(EXIT_FAILURE, "Invalid T= opology selection\n"); > | ^~~~~~~~~~~~ > ../examples/helloworld/main.c: In function 'main': > ../examples/helloworld/main.c:153:26: error: 'EXIT_FAILURE' undeclared (f= irst use > in this function) > 153 | rte_exit(EXIT_FAILURE, "Invalid arguments\n"); > | ^~~~~~~~~~~~ > ../examples/helloworld/main.c:153:26: note: 'EXIT_FAILURE' is defined in = header > ''; thi >=20 > Below header include should fix it. >=20 > diff --git a/examples/helloworld/main.c b/examples/helloworld/main.c inde= x > 9845c3775c3a..f49bd0108f74 100644 > --- a/examples/helloworld/main.c > +++ b/examples/helloworld/main.c > @@ -3,6 +3,7 @@ > */ >=20 > #include > +#include > #include > #include > #include Thank you for helping me here, I did run with `check_includes & developer_m= ode`, it did not throw this error. Before patch submission I tried `devtools/test-meson-builds.sh` too. I thin= k internally this is not using ` check_includes & developer_mode `. Let me recheck and fix this in version 4.