RE: [PATCH v6 2/9] dts: add TestSuiteSpec class and discovery

[Ali Alnubani <alialnu@nvidia.com>]

> -----Original Message-----
> From: Luca Vizzarro <luca.vizzarro@arm.com>
> Sent: Friday, November 8, 2024 1:40 PM
> To: dev@dpdk.org
> Cc: Paul Szczepanek <paul.szczepanek@arm.com>; Patrick Robb
> <probb@iol.unh.edu>; Luca Vizzarro <luca.vizzarro@arm.com>; Nicholas Pratte
> <npratte@iol.unh.edu>
> Subject: [PATCH v6 2/9] dts: add TestSuiteSpec class and discovery
> 
> Currently there is a lack of a definition which identifies all the test
> suites available to test. This change intends to simplify the process to
> discover all the test suites and identify them.
> 
> Signed-off-by: Luca Vizzarro <luca.vizzarro@arm.com>
> Reviewed-by: Paul Szczepanek <paul.szczepanek@arm.com>
> Reviewed-by: Nicholas Pratte <npratte@iol.unh.edu>
> Reviewed-by: Patrick Robb <probb@iol.unh.edu>
> ---

Hello,

Documentation seems to be failing to build on top of this patch on Fedora 40:

"""
$ ninja-build -C build doc
[..]
Warning, treated as error:
autodoc: failed to import module 'runner' from module 'framework'; the following exception was raised:
Traceback (most recent call last):
  File "/usr/lib/python3.12/site-packages/sphinx/ext/autodoc/importer.py", line 69, in import_module
    return importlib.import_module(modname)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.12/importlib/__init__.py", line 90, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 995, in exec_module
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
  File "dts/framework/runner.py", line 42, in <module>
    from .test_result import (
  File "dts/framework/test_result.py", line 37, in <module>
    from .test_suite import TestCase, TestSuite
  File "dts/framework/test_suite.py", line 715, in <module>
    AVAILABLE_TEST_SUITES: list[TestSuiteSpec] = TestSuiteSpec.discover_all()
                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "dts/framework/test_suite.py", line 707, in discover_all
    if test_suite.class_obj:
       ^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.12/functools.py", line 993, in __get__
    val = self.func(instance)
          ^^^^^^^^^^^^^^^^^^^
  File "dts/framework/test_suite.py", line 658, in class_obj
    for class_name, class_obj in inspect.getmembers(self.module, is_test_suite):
                                                    ^^^^^^^^^^^
  File "/usr/lib64/python3.12/functools.py", line 993, in __get__
    val = self.func(instance)
          ^^^^^^^^^^^^^^^^^^^
  File "dts/framework/test_suite.py", line 629, in module
    return import_module(f"{self.TEST_SUITES_PACKAGE_NAME}.{self.module_name}")
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.12/importlib/__init__.py", line 90, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "dts/tests/TestSuite_hello_world.py", line 20, in <module>
    @requires(topology_type=TopologyType.no_link)
     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "dts/framework/testbed_model/capability.py", line 479, in add_required_capability
    topology_capability = TopologyCapability.get_unique(topology_type)
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "dts/framework/testbed_model/capability.py", line 331, in get_unique
    if topology_type.name not in cls._unique_capabilities:
       ^^^^^^^^^^^^^^^^^^
AttributeError: 'int' object has no attribute 'name'
"""

Regards,
Ali