RE: [PATCH v6 4/9] dts: use pydantic in the configuration

[Ali Alnubani <alialnu@nvidia.com>]

> -----Original Message-----
> From: Luca Vizzarro <luca.vizzarro@arm.com>
> Sent: Friday, November 8, 2024 1:40 PM
> To: dev@dpdk.org
> Cc: Paul Szczepanek <paul.szczepanek@arm.com>; Patrick Robb
> <probb@iol.unh.edu>; Luca Vizzarro <luca.vizzarro@arm.com>; Nicholas Pratte
> <npratte@iol.unh.edu>
> Subject: [PATCH v6 4/9] dts: use pydantic in the configuration
> 
> This change brings in pydantic in place of warlock. Pydantic offers
> a built-in model validation system in the classes, which allows for
> a more resilient and simpler code. As a consequence of this change:
> 
> - most validation is now built-in
> - further validation is added to verify:
>   - cross referencing of node names and ports
>   - test suite and test cases names
> - dictionaries representing the config schema are removed
> - the config schema is no longer used and therefore dropped
> - the TrafficGeneratorType enum has been changed from inheriting
>   StrEnum to the native str and Enum. This change was necessary to
>   enable the discriminator for object unions
> - the structure of the classes has been slightly changed to perfectly
>   match the structure of the configuration files
> - the test suite argument catches the ValidationError that
>   TestSuiteConfig can now raise
> - the DPDK location has been wrapped under another configuration
>   mapping `dpdk_location`
> - the DPDK locations are now structured and enforced by classes,
>   further simplifying the validation and handling thanks to
>   pattern matching
> 
> Bugzilla ID: 1508
> 
> Signed-off-by: Luca Vizzarro <luca.vizzarro@arm.com>
> Reviewed-by: Paul Szczepanek <paul.szczepanek@arm.com>
> Reviewed-by: Nicholas Pratte <npratte@iol.unh.edu>
> Reviewed-by: Patrick Robb <probb@iol.unh.edu>
> ---

Hello,

Documentation fails to build on 24.11.0-rc3 in Fedora 40 because of this patchset:

"""
$ ninja-build -C build doc
[..]
[4/6] Generating doc/api/dts/dts_api_html with a custom command
FAILED: doc/api/dts/html
/usr/bin/python3 ../..buildtools/call-sphinx-build.py /usr/bin/sphinx-build 24.11.0-rc2 doc/api/dts build/doc/api/html/dts -E -c doc/guides -W
[..]
Warning, treated as error:
Failed to get a method signature for framework.config.TestSuiteConfig.convert_from_string: <classmethod(<function TestSuiteConfig.convert_from_string at 0x7f4922675e40>)> is not a callable object
[5/6] Generating doc/guides/html_guides with a custom command
"""

Can you please have a look?

Thanks,
Ali