DPDK patches and discussions
 help / color / mirror / Atom feed
From: Long Li <longli@microsoft.com>
To: Vladimir Ratnikov <vratnikov@netgate.com>,
	Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH v2] bus/vmbus: add device_order field to rte_vmbus_dev
Date: Sat, 6 Jul 2024 00:21:32 +0000	[thread overview]
Message-ID: <PH7PR21MB3071F49B4A539140BC6B7BC0CED82@PH7PR21MB3071.namprd21.prod.outlook.com> (raw)
In-Reply-To: <CABxizg5wgS7BA2kerxoVR17GLvOAfe1-swC_ph35Bofx2=Dkzg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1791 bytes --]

Hi Vladimir,

Is there another way that you can determine the device probe order from your application? (like going through the /sys/class/uio devices)

Long

From: Vladimir Ratnikov <vratnikov@netgate.com>
Sent: Tuesday, June 25, 2024 4:50 AM
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Long Li <longli@microsoft.com>; dev@dpdk.org
Subject: Re: [PATCH v2] bus/vmbus: add device_order field to rte_vmbus_dev

You don't often get email from vratnikov@netgate.com<mailto:vratnikov@netgate.com>. Learn why this is important<https://aka.ms/LearnAboutSenderIdentification>
Thanks for review!

Regarding to
The patch only has the device_order field, but it is set but not used anywhere in the DPDK.
Unfortunately, It's not for DPDK usage, it's for DPDK based applications.
After some time of testing, if nothing's changed in the host OS(no new devices, no removed devices) - the device list is always the same with the same order.

On Tue, Jun 25, 2024 at 2:02 AM Stephen Hemminger <stephen@networkplumber.org<mailto:stephen@networkplumber.org>> wrote:
On Mon, 24 Jun 2024 11:15:21 +0000
Vladimir Ratnikov <vratnikov@netgate.com<mailto:vratnikov@netgate.com>> wrote:

> Field can be used to have static interface naming
> in DPDK based applications instead of uuid.
> RTE_FOREACH_DEV won't return the correct order of
> such devices due to vmbus_ignore_device in case of
> blocklisting/allowlisting. So device_order field
> will be helpful in that case.
>
> Signed-off-by: Vladimir Ratnikov <vratnikov@netgate.com<mailto:vratnikov@netgate.com>>
> ---

Not sure the order of device discovery is predictable.
The order of devices on vmbus is when they were reported by the host OS.
That is why Linux driver use other ways to have persistent naming.

[-- Attachment #2: Type: text/html, Size: 6371 bytes --]

  reply	other threads:[~2024-07-06  0:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-24 11:04 Vladimir Ratnikov
2024-06-24 11:15 ` Vladimir Ratnikov
2024-06-24 15:15   ` Stephen Hemminger
2024-06-25  0:02   ` Stephen Hemminger
2024-06-25 11:49     ` Vladimir Ratnikov
2024-07-06  0:21       ` Long Li [this message]
2024-06-24 15:13 ` Stephen Hemminger
2024-06-25 12:01   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH7PR21MB3071F49B4A539140BC6B7BC0CED82@PH7PR21MB3071.namprd21.prod.outlook.com \
    --to=longli@microsoft.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=vratnikov@netgate.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).