From: Long Li <longli@microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
"longli@linuxonhyperv.com" <longli@linuxonhyperv.com>
Cc: Ferruh Yigit <ferruh.yigit@xilinx.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Ajay Sharma <sharmaajay@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>
Subject: RE: [Patch v3 10/17] net/mana: implement memory registration
Date: Thu, 7 Jul 2022 22:12:16 +0000 [thread overview]
Message-ID: <PH7PR21MB326309FF904E2DD9E31399FECE839@PH7PR21MB3263.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20220707145052.3917144a@hermes.local>
> Subject: Re: [Patch v3 10/17] net/mana: implement memory registration
>
> On Thu, 7 Jul 2022 13:30:15 -0700
> longli@linuxonhyperv.com wrote:
>
> > +int mana_new_pmd_mr(struct mana_mr_btree *local_tree, struct mana_priv
> *priv,
> > + struct rte_mempool *pool)
> > +{
> > + struct ibv_mr *ibv_mr;
> > + struct mana_range ranges[pool->nb_mem_chunks];
> > + uint32_t i;
> > + struct mana_mr_cache *mr;
> > + int ret;
> > +
> > + rte_mempool_mem_iter(pool, mana_mempool_chunk_cb, ranges);
> > +
> > + for (i = 0; i < pool->nb_mem_chunks; i++) {
> > + if (ranges[i].len > priv->max_mr_size) {
> > + DRV_LOG(ERR, "memory chunk size %u exceeding max
> MR\n",
> > + ranges[i].len);
> > + return -ENOMEM;
>
> Did a quick search for extra newlines.
> Looks like this message will end up double spaced in log.
> DRV_LOG already adds a newline.
Yes, I will remove all extra spaces in other places as well.
next prev parent reply other threads:[~2022-07-07 22:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 20:30 [Patch v3 00/17] Introduce Microsoft Azure Network Adatper (MANA) PMD longli
2022-07-07 20:30 ` [Patch v3 01/17] net/mana: add basic driver, build environment and doc longli
2022-07-07 21:44 ` Stephen Hemminger
2022-07-07 22:12 ` Long Li
2022-07-07 21:52 ` Stephen Hemminger
2022-07-07 20:30 ` [Patch v3 02/17] net/mana: add device configuration and stop longli
2022-07-07 20:30 ` [Patch v3 03/17] net/mana: add function to report support ptypes longli
2022-07-07 20:30 ` [Patch v3 04/17] net/mana: add link update longli
2022-07-07 20:30 ` [Patch v3 05/17] net/mana: add function for device removal interrupts longli
2022-07-07 20:30 ` [Patch v3 06/17] net/mana: add device info longli
2022-07-07 20:30 ` [Patch v3 07/17] net/mana: add function to configure RSS longli
2022-07-07 20:30 ` [Patch v3 08/17] net/mana: add function to configure RX queues longli
2022-07-07 20:30 ` [Patch v3 09/17] net/mana: add function to configure TX queues longli
2022-07-07 20:30 ` [Patch v3 10/17] net/mana: implement memory registration longli
2022-07-07 21:50 ` Stephen Hemminger
2022-07-07 22:12 ` Long Li [this message]
2022-07-07 20:30 ` [Patch v3 11/17] net/mana: implement the hardware layer operations longli
2022-07-07 20:30 ` [Patch v3 12/17] net/mana: add function to start/stop TX queues longli
2022-07-07 20:30 ` [Patch v3 13/17] net/mana: add function to start/stop RX queues longli
2022-07-07 20:30 ` [Patch v3 14/17] net/mana: add function to receive packets longli
2022-07-07 20:30 ` [Patch v3 15/17] net/mana: add function to send packets longli
2022-07-07 20:30 ` [Patch v3 16/17] net/mana: add function to start/stop device longli
2022-07-07 20:30 ` [Patch v3 17/17] net/mana: add function to report queue stats longli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH7PR21MB326309FF904E2DD9E31399FECE839@PH7PR21MB3263.namprd21.prod.outlook.com \
--to=longli@microsoft.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=longli@linuxonhyperv.com \
--cc=sharmaajay@microsoft.com \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).