From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3D30BA0543; Fri, 8 Jul 2022 00:12:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 252224069D; Fri, 8 Jul 2022 00:12:19 +0200 (CEST) Received: from na01-obe.outbound.protection.outlook.com (mail-centralusazon11021024.outbound.protection.outlook.com [52.101.62.24]) by mails.dpdk.org (Postfix) with ESMTP id 9030A40041 for ; Fri, 8 Jul 2022 00:12:18 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gihgIhAj1oXRvoMWAidxc7xzwtRVxUkEx0yl/cbyPYQ97qfn2MS9mQLNXmLB4kbu3YUVcgRPjysHaUkf0/x0z4op+rpKve45+PfVM/ROA7OMIo4NPi8hRi5hctC868zeWB2B16cK8pncn+WimRzRDRKwz+qW3AAphjgg5s1qXg7IwX6hLrJZJ2tLXPjsTY3tAS3/TU866o8fkfjRG2fVna0y+Bo75Ng2e06hxoG9wxmx4cvK9KDP9xkPZFe+D0+fC3RyxpfHXsgERGInnV7WJlrPCOFCUkb097Fw9emVW4kRO2vdM504eFfXBVlaOhSX5ikkowcLitrIP12FEheflQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vg4F9+h+YomnhQ9MLe4ftdqtrGlWtvjSDJDQKXEw6vU=; b=A+W0rYKXXdVuo486TWm+xAmBdnntrLIVJQTmPc8yPfXR7VbbZYdKbTGJB0cbRTfH4DDY5IkhoQvmKvTtxczVefi5kuZW7q/1rQTMy+0v8hbO/QFKK/BXxuEzfeeqii8y/MkmCobUzjcQQcUO/+IHhH1lqnqGYro6ewoFzl0zN2f1JDayQC6Pp1iakV9+Jh1aWXXzLj4d3SSEU8HuKopJ3JCn7ywfpW/BpTSakvWU0cyAs2FrJAGzYunRZ1Fjbrfkv3QZARNLUZpXXCcmTme/TGAg9Mz80nEMSnpMqZI3CU1vQoGq9NIB55F6sIhvplsso0rha3tTMIgG9YIaoTRtsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vg4F9+h+YomnhQ9MLe4ftdqtrGlWtvjSDJDQKXEw6vU=; b=FG0By5JEu+iOqfjOQ+2EViW/mU3R+UJrxzbEna/QB4VZxbyuRkzWzQHdwaz57gv8vdd0GWX5bvVDbMdZs+9sTcudlZqfme01OyeNPhFv80bVxFpO/sSzUMCzxWENfXfoaU2u3X01XKqSOmv55P7oOK6hxzsFj0LAJDQuanASj+s= Received: from PH7PR21MB3263.namprd21.prod.outlook.com (2603:10b6:510:1db::16) by PH7PR21MB3237.namprd21.prod.outlook.com (2603:10b6:510:1d9::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.4; Thu, 7 Jul 2022 22:12:16 +0000 Received: from PH7PR21MB3263.namprd21.prod.outlook.com ([fe80::88cc:9591:8584:8aa9]) by PH7PR21MB3263.namprd21.prod.outlook.com ([fe80::88cc:9591:8584:8aa9%7]) with mapi id 15.20.5438.005; Thu, 7 Jul 2022 22:12:16 +0000 From: Long Li To: Stephen Hemminger , "longli@linuxonhyperv.com" CC: Ferruh Yigit , "dev@dpdk.org" , Ajay Sharma , Stephen Hemminger Subject: RE: [Patch v3 10/17] net/mana: implement memory registration Thread-Topic: [Patch v3 10/17] net/mana: implement memory registration Thread-Index: AQHYkkBudzErWsNWVUSVY8MVLMUI2a1zcsAAgAAF0NA= Date: Thu, 7 Jul 2022 22:12:16 +0000 Message-ID: References: <1657225822-3512-1-git-send-email-longli@linuxonhyperv.com> <1657225822-3512-11-git-send-email-longli@linuxonhyperv.com> <20220707145052.3917144a@hermes.local> In-Reply-To: <20220707145052.3917144a@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=c9a2fe05-8a79-4c62-96ca-6fb470726752; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2022-07-07T22:11:40Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 20943c14-b9b0-4251-d8a3-08da6065c052 x-ms-traffictypediagnostic: PH7PR21MB3237:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8OFtPUNlDStZIBBjMgAvZfVvs6wZerMIPM84YMTw2PAy3KolUFgiWXuiW4ZI15+HQ/pbAqTmIL1xq0MJd3w5YNonVGzVKWP/VowBra/jZ+1F1a1I16JG2V2mWLH9pWbOcDlEVxXBk0W8ZNAguHhrK09Prf6P1yNjpDohij4v6Ny3EiYcIq8fTCppu1ORBlI2bOy0W4pE0Sb4PBo5cQpE0oJUDqhv5woI/n576iv89DEmY33p0E4Byud2ejN/1OtWPeWt5EI+AolOGWyrTH2QhUbIXcdj1Yiz9ZwoAA93KP6TQUAJSI5KN8T61HDbkaJYZ2snJkmzHSosfq4mb7JyL/1BWwhQB1pwfXHHdTP/IUjMGPYWSkyv4TXpiKgRl0tLX+bF63WBJ3NrfhHoRoUHxgKQpeUe5hpH94x2OFqBCqgj6/meXv8D6LWQRCfVmMZJ+xFatnRLr8/ABL9E8ssK9Bcyt06MJqRlBJ23xBIBW+io7hZP0Vf1lwqj/Xi8ZJRTC+kQeDtkvL8d5wPzjnuWqM5gP0/OzEMdzSjlf1J59WsSCJwvUBlJwlcKXQotHgbBqoDGIbSC7cej0FcjKmfDVAdqVvF+xQLMx5Y27bkTiXBhGHuDjJWzFg4ry94N8RsddhkaDc2xXN8f43QEB7vRbOYEQUmhPHfY7Za0dlEAjSoIopL9sPAIYUCsq+RJWHKRTr1PHIQNKTXIuf49jTJm192eo6qJz/eTgFZDGCfTkmlkweGRLNRq7PTSi1CpebBNYPqjjBm6yIEW/PoVxoLk4AFx0t5qUTW9RICxfPc887ytiHAIHF/iCC6ABYzziLUQ80ItDwUQBK7udwycnB921kDZQ3chaaIHoGCuGNrGnxI3Bupc9nTZKSVTNqDQDLEH x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR21MB3263.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(396003)(376002)(346002)(39860400002)(136003)(451199009)(54906003)(4744005)(26005)(8676002)(2906002)(186003)(66556008)(110136005)(82950400001)(107886003)(82960400001)(10290500003)(64756008)(76116006)(66476007)(38070700005)(122000001)(9686003)(66946007)(83380400001)(7696005)(6506007)(478600001)(41300700001)(55016003)(5660300002)(8936002)(66446008)(4326008)(38100700002)(316002)(8990500004)(52536014)(86362001)(71200400001)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ONj9kt5lfZbZLxgviCvc0d9OyA8WuC5SknsfsYQTatXQxFyYIlIQHcoKueEY?= =?us-ascii?Q?zdjnBRu5XWKJmJ+ue6Y2rq2O3kaKwgNTxH5ZihLCiPRp5/AZ9rQCjv/TUzmx?= =?us-ascii?Q?3QvgOUJeiGFkmcf0lTwPnYEd0QTxrlC7zqM4V6KH0ssB1xsnNF/h+IjqCiI7?= =?us-ascii?Q?vybAM6GgzE1adXcHloMMFEP3qVSyftCBhhgyffa+hI/Cu4aHNhIbvyTxZwMi?= =?us-ascii?Q?vjRR+Q9dedXtzseNQRdeqxhK5v+y867vXLWmQY9KgumMUjhBAb2eskws2tS7?= =?us-ascii?Q?/n+dytxC2CDEhnDRzHHZCztiTDywR1qykWi/twloW4VWhWIicEAWLgQNV9A0?= =?us-ascii?Q?JwZGuFb6eFnKpxiz4MxdCiMohqLTrAKKYI8xsEHE+iKyrOtybbSeBp7Q0ZK4?= =?us-ascii?Q?Pge+zFdrQvSMFS53iCDPeX/P6BgoDgrh+8nno0o0IZ3nzBz64blD9nuHIUDY?= =?us-ascii?Q?ScuQDriqJENUIGaxz5E/dFWCx53Vdy/v6zgcR8hUXRDBjVOw+/iKha03DSqd?= =?us-ascii?Q?VTbrG9qFz1v/jYqYkOIIQCXDsiHG0MF/23TJkuFdLyFyJM4xOV1dYcHVAQsM?= =?us-ascii?Q?XT6i96027wGGMOL0IOLSB5i2AgXwJmhqvgdlS62GGTmvQg8Pd0GE32WSkO0o?= =?us-ascii?Q?vsnYGL2HYMiVZnrjca5hwohDPzx7hE7HFqzenT1uaEFYLrUupPCUB835ycDe?= =?us-ascii?Q?a5CtqqwwFaxAdG71PSSZ3/x8r8mzrvksJGody1rELu85qdp7Rk4TQ3wwmof0?= =?us-ascii?Q?03Wyxnxkv68zj4PNBUxsgcxTfHGp13qvkAEeux03Rg9V0vj7Rrf6xX50RPw3?= =?us-ascii?Q?5LfDxmUiSscdm3a1wn90NYdE5swe31B/7pmFY37VttH0iuNOix+EgNyPAOev?= =?us-ascii?Q?/6FrQ6frmEe1JR24yaCUUnvqWwREAcfHNWmilHDO2A02axusMxItvsgPvwod?= =?us-ascii?Q?e7FkMMujHBzyDCz4je+JkEqSFz5zWbwA4iBdKXgKGpt0CL99A2JCzZCV0kge?= =?us-ascii?Q?UGdQww6QVyH+RGK3aChny2g0sAScj6Iik18kPaVSEwyr6ZGw43Cdz3wJoJ09?= =?us-ascii?Q?1nrdwWvEXwchjZRDpDjDN2/OIpO7eFcqV0HxcFKJb0uzNXE8IhoumHPN5D3B?= =?us-ascii?Q?fS4Dc48ZVyT5DsXEbYPbz9Ir0/6lXwxDSPhoc1/rt4IL2xDkAoODHvv7YhCS?= =?us-ascii?Q?/zKYbcqzuypfS3sPZgiHN1ODhqY4PU0B4PCQriuA4s8NkLO3KQzv/uag+AiJ?= =?us-ascii?Q?2oy1DMT/g7zubS836xxLtBkAQwPBU0fLHPEzI31Lw8VExi8hrzTwHmmrcHKP?= =?us-ascii?Q?o2HmQ3BlfszBpTqczVfydhJlij9rEcNRKOzXhWpTGeY7Zkeo5yyPpb5don8W?= =?us-ascii?Q?Z9u5O3n5s9dO+k0Wgk4OKJ/aI8VhTTB8CFc9fJz+/RnIoxBEpbl7VeAjn0WV?= =?us-ascii?Q?t0tpERBO9A0VeXkS4VdfAfbyCgpf9c6cAIWTUhT4YglZeHw+g8x03iz+yH5C?= =?us-ascii?Q?etX6qW/caBtOnf8/i+2lrsuCRkgAQaFi9pcQ2fgJwEormvxt4fW6vz7qLQfs?= =?us-ascii?Q?o61AByHFaLoGXTpuiEZs3/1J9+0kN0UOXO85moX/?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR21MB3263.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20943c14-b9b0-4251-d8a3-08da6065c052 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2022 22:12:16.0652 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 118PljtoPKQplA+gX7Gb+bWWBu9xHSJsrOGoXT6MNRKIy2w3EcHEoEPmHvB2OilJLJuAJgyyVK1WNySUBLC0Jg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR21MB3237 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Subject: Re: [Patch v3 10/17] net/mana: implement memory registration >=20 > On Thu, 7 Jul 2022 13:30:15 -0700 > longli@linuxonhyperv.com wrote: >=20 > > +int mana_new_pmd_mr(struct mana_mr_btree *local_tree, struct mana_priv > *priv, > > + struct rte_mempool *pool) > > +{ > > + struct ibv_mr *ibv_mr; > > + struct mana_range ranges[pool->nb_mem_chunks]; > > + uint32_t i; > > + struct mana_mr_cache *mr; > > + int ret; > > + > > + rte_mempool_mem_iter(pool, mana_mempool_chunk_cb, ranges); > > + > > + for (i =3D 0; i < pool->nb_mem_chunks; i++) { > > + if (ranges[i].len > priv->max_mr_size) { > > + DRV_LOG(ERR, "memory chunk size %u exceeding max > MR\n", > > + ranges[i].len); > > + return -ENOMEM; >=20 > Did a quick search for extra newlines. > Looks like this message will end up double spaced in log. > DRV_LOG already adds a newline. Yes, I will remove all extra spaces in other places as well.