DPDK patches and discussions
 help / color / mirror / Atom feed
From: Long Li <longli@microsoft.com>
To: thomas <thomas@monjalon.net>, Jason Gunthorpe <jgg@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"ferruh.yigit@amd.com" <ferruh.yigit@amd.com>,
	"andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>,
	"stephen@networkplumber.org" <stephen@networkplumber.org>,
	"rasland@nvidia.com" <rasland@nvidia.com>,
	Lior Margalit <lmargalit@nvidia.com>,
	"asafp@nvidia.com" <asafp@nvidia.com>
Subject: RE: [PATCH] net/mana: fix dependencies
Date: Mon, 10 Oct 2022 20:20:06 +0000	[thread overview]
Message-ID: <PH7PR21MB32633374BBA90C079047A50FCE209@PH7PR21MB3263.namprd21.prod.outlook.com> (raw)
In-Reply-To: <6911974.aoefvbuG5b@thomas>

> Subject: Re: [PATCH] net/mana: fix dependencies
> 
> 10/10/2022 20:53, Long Li:
> > I will send respin as soon as patch submission window reopens.
> 
> So what do we do in DPDK?
> Do you agree with the patch I sent to correct wrong assumptions in the doc?

Yes, the patch looks good to me.

> 
> My fear is that if we keep mana PMD as-is, it could break compilation when
> libmana will be released if there is an incompatibility with what you have in
> staging.

I hope that will not happen. After MANA PMD is merged, any changes in libmana while in staging will not break the PMD. (At minimum, it will guarantee not to break compilation)

> 
> Please remember that rdma-core is also used for mlx PMDs, and we don't
> want mana to break compilation when updating rdma-core.
> 
> 
> > From: Jason Gunthorpe <jgg@nvidia.com>
> > Sent: Sunday, October 9, 2022 7:08 AM
> > To: thomas <thomas@monjalon.net>; Long Li <longli@microsoft.com>
> > Cc: dev@dpdk.org; ferruh.yigit@amd.com;
> andrew.rybchenko@oktetlabs.ru;
> > stephen@networkplumber.org
> > Subject: Re: [PATCH] net/mana: fix dependencies
> >
> > I'm hopeful for 6.2, but it needs a respin I haven't seen yet.
> >
> > From: Thomas Monjalon
> > <thomas@monjalon.net<mailto:thomas@monjalon.net>>
> >
> > Long,
> >
> > For the reasons below, we should not have merged the MANA PMD in
> DPDK 22.11.
> > We must not assume dependencies until they are upstream.
> > This is a red flag on the PMD, a revert is possible.
> >
> > Jason,
> >
> > Please could you tell us what is the expected date of release of the
> > MANA support in Linux and rdma-core?
> >
> >
> > 09/10/2022 15:53, Thomas Monjalon:
> > [...]
> > > The libibverbs was not detected through pkg-config.
> > > The method dependency() needs to be used first.
> > >
> > > The support in rdma-core and Linux is not released yet, so the
> > > documentation is updated.
> >
> > [...]
> > > -  The minimum required version of rdma-core with libmana is v43.
> > > +
> > > +  The support of MANA is not merged in rdma-core 42.
> > >
> > >  - **Kernel modules**
> > >
> > > @@ -56,6 +56,8 @@ and must be installed separately:
> > >    - mana_ib: InifiniBand device driver.
> > >    - ib_uverbs: user space driver for verbs (entry point for libibverbs).
> > >
> > > +  The support of MANA is planned in Linux 6.2.
> 
> 


  reply	other threads:[~2022-10-10 20:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-09 13:53 Thomas Monjalon
2022-10-09 14:03 ` Thomas Monjalon
2022-10-09 14:08   ` Jason Gunthorpe
2022-10-10 18:53     ` Long Li
2022-10-10 19:55       ` Thomas Monjalon
2022-10-10 20:20         ` Long Li [this message]
2022-10-10  8:18   ` Ferruh Yigit
2022-10-09 14:18 ` Thomas Monjalon
2022-10-10 21:58   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH7PR21MB32633374BBA90C079047A50FCE209@PH7PR21MB3263.namprd21.prod.outlook.com \
    --to=longli@microsoft.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=asafp@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=jgg@nvidia.com \
    --cc=lmargalit@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).