From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 534ECA0543; Fri, 8 Jul 2022 00:12:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4186440E2D; Fri, 8 Jul 2022 00:12:46 +0200 (CEST) Received: from na01-obe.outbound.protection.outlook.com (mail-eastus2azon11021015.outbound.protection.outlook.com [52.101.57.15]) by mails.dpdk.org (Postfix) with ESMTP id 5C83A40041 for ; Fri, 8 Jul 2022 00:12:45 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V33Lwtf+8VLAJ0f2guLDMs1s7bPHjULAh0svtclaNGfcUgaG6CiZmeWv3mBSc+eUi2Brb/nXZq9+XpSyNgac19DjvW5zfHoUUKLHfZQe1I/NfoW+Dl8c262Dc1bO2ZHjQXQ36yLWauWy+GZ9XYlkqpVBeMJIsJpZlN2AbySNRKm6jETFYrz5Nv1OH7fj40Z07bMHAk7vnXh6KDU9JWsyHgRieyHcghS1ziIZPilEJfwXQnewIX8W5InLcs6kyvD7xxmafFGxkRhvR7RPsSwJXXGPgo4vT/QgKBBLYftG0+rL8ZFk7RbMV78gMdBJZxTUnUrrM4gthB2PSoMz8pCWpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SAzbmIEIQ8baCNpLNJM98C2hURwBlXQQM/FPYaIIizI=; b=nN/fmlldd35YL7aSY1PMFZA84Jkz6K7/3k4fZSmmcgGqAq1u+8yp7EuVL7yPcJb2lX3VcJlG8dlOpsLqKcbFOqom1EgBq+4N5ukWlMYrI2odi4TAgtD/gOhEVE+C/kiwCc8jC2jQHJRrcyYABZfjO3XESU7eTbxYGKq2Vk1keWMYA+9qTerJZAI3qcVwrNwYKz1W0WQJVvWcrgxp7pOy9E873f6j0mFQ6Q+YMPZtpdTrENF+0TgFOpnd8JQGzgYKPhmRaKVKbv9kWDVZrb6xKYwgCmJMjeFBWvwTu4wRdICDo2Hc3XXSAX3nsxjyAD4SVz2q1ZTqdUpD/mjrO2nInA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SAzbmIEIQ8baCNpLNJM98C2hURwBlXQQM/FPYaIIizI=; b=Dz2muricyjyc+gh1QNqIFWltaq5rkypBwbLati8u94+x7znsilHhu5n3F4Uznjawm9L/ssDFOrpNvo8Rn7fFeU3eTSY3cjwB3IUYk/XXhmiDGSlE/1B9ua67WWHLcD/7Mdg8ntTNPoGd/jB+OllHSVNiENLaOqaNtSIski1qJvA= Received: from PH7PR21MB3263.namprd21.prod.outlook.com (2603:10b6:510:1db::16) by PH7PR21MB3237.namprd21.prod.outlook.com (2603:10b6:510:1d9::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.4; Thu, 7 Jul 2022 22:12:43 +0000 Received: from PH7PR21MB3263.namprd21.prod.outlook.com ([fe80::88cc:9591:8584:8aa9]) by PH7PR21MB3263.namprd21.prod.outlook.com ([fe80::88cc:9591:8584:8aa9%7]) with mapi id 15.20.5438.005; Thu, 7 Jul 2022 22:12:43 +0000 From: Long Li To: Stephen Hemminger , "longli@linuxonhyperv.com" CC: Ferruh Yigit , "dev@dpdk.org" , Ajay Sharma , Stephen Hemminger Subject: RE: [Patch v3 01/17] net/mana: add basic driver, build environment and doc Thread-Topic: [Patch v3 01/17] net/mana: add basic driver, build environment and doc Thread-Index: AQHYkkBsP0pyVCxn4EayTKdFFvdQxK1zcQyAgAAHuxA= Date: Thu, 7 Jul 2022 22:12:43 +0000 Message-ID: References: <1657225822-3512-1-git-send-email-longli@linuxonhyperv.com> <1657225822-3512-2-git-send-email-longli@linuxonhyperv.com> <20220707144447.4bfd02e4@hermes.local> In-Reply-To: <20220707144447.4bfd02e4@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=be300eaa-0593-4e06-a5df-8cd3dfd912d8; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2022-07-07T22:12:26Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: af4498b3-8b88-4c76-fb83-08da6065d0bf x-ms-traffictypediagnostic: PH7PR21MB3237:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RTFcwU1sU7yYHpesT/AO/NEkSl7RmYU4/eb1DX6luM/ARUCdMP4r8YyNqW5LAQk9Y+tRAzofveNGO6FybN5sydPnrblfLl8efK2QJFltSL3n90Oj7oeSbfxXUlSWhUdeeeTxDBb3bAFFHiWu6MtTFxlokuWgGJJhxOZSo2rtGBj9oZrOLTCv/bdz/Rnb9lC1whGSDsNwQRGuGQX9t7uBtrEW0EY39lO+5J69wbFmL10ciEfWnKVGO7LSXJyExnT2KKvH1wr5kDFt2p+XhIM78TlRG5D2yS5gxYl0MfEZeTBNH42dOCBZ7oUJqTMtkbZFi1v2HnveJYB9OMAdMNmTtXSYbSrLckU0SAdMOJjuT82PCWwKYQp4NpTn3fya+VQtvop78kpZjizrHLFbMvhfktqIZxpvsmNgvL1yFBGTZIzmTtuKGHcW7Vk+249k9N5JgUjrYg+1z+678e7+uIqTZaGjlxYepB2igIfOCAZZ2SwC+JODvlLjPuOQ4PsbERcav0KnrIV0L2PzYmI+y0Tj9VRyY7q5jSQRLiEMnyvA9tk/RTkj6api8xUx3DA860JSTLfrFYhCGwjnS3RjoVsrydWIWmJtNJH/rUepNK9a1PEL3IhtiK6C0z6QxoWlrJMsgBG/Ap5R5oXthBBJDgrtVk/AnFYdyUUnLLbnqIPXgHYzTIUPWEOlSDWWARn5XLc5WsVFB+ABFrWxrdiYNQxbcC05jJzn+wYQIvVBF9iCeKVm7AwV6I/eFwpPa3Pw3eZUktChEZupHW7xcLedhrt9vQvPGUGuVj9i1YqJOqwyzt0EsrLPXMskXkjPsZ5RJzqfayNW+4JQBcGnfoXpi8HVC6Y5FLLf5oxdaclSSU402y1biieZGqkLNx/pz0q1TGXN x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR21MB3263.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(396003)(376002)(346002)(39860400002)(136003)(451199009)(54906003)(4744005)(26005)(8676002)(2906002)(186003)(66556008)(110136005)(82950400001)(107886003)(82960400001)(10290500003)(64756008)(76116006)(66476007)(38070700005)(122000001)(9686003)(66946007)(7696005)(6506007)(478600001)(41300700001)(55016003)(5660300002)(8936002)(66446008)(4326008)(38100700002)(316002)(8990500004)(52536014)(86362001)(71200400001)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dCIt2gnuFwPW06sSs9C7uVWul9qI1LuJi7xJLJZ1q1RL7uqzWaNC3FhCCyp3?= =?us-ascii?Q?BIcgtbknVaBlEC1iFiWWIViNWGZsGM3FqctCRZjaTcCUuPs7UJvWXRCdnbIs?= =?us-ascii?Q?5WxUgFPFu2oJMILsb+hBdCt0Xb4OUrYrosSrjfTWPF3IV7sZe7dheXGKaO+O?= =?us-ascii?Q?pINEz6tooXE7TBmTAJ6URByaolUcnP6LcdAzKkZM0fpFkOz5ahmH8SfsiGkH?= =?us-ascii?Q?GvhE8QyYDld7rM/B08ktOjkwatxFloh8xwmAL8TrdVtuUdDdkSp3DwIsAKyf?= =?us-ascii?Q?4dMbbkOo33fO4Xvihiu2kufguPTfSKSWFZHT4FMMwbHfXvM3OUB4nNTsgN5k?= =?us-ascii?Q?2vflaVkX7u+0TZ0vINppmkPVgx9zq5oanAFiHB+E5rMqITQPZCTLwGejzq+c?= =?us-ascii?Q?KdZphtTYL3jvIFaUlESUddQKyYYNg3yK1Hm2gUKsQgZj4EG7lzhwByJdO6ZL?= =?us-ascii?Q?UrCx6iNtBC/1OSr1p5iUUQTPcTQKwsPboYW0QY0MEZCAv8kQ35WPngWQJIAE?= =?us-ascii?Q?6WRa5G1wkQIZmeaeiFfMrLMoQAHLGIl5a6iBbNgjXdLZem7OojOiD4gwrfGh?= =?us-ascii?Q?kGJgjvAQo3NCO8nzx6q8DAtxZNq/2TLE+MLo8gUpibN9lh1T2lCs6eHWFWrf?= =?us-ascii?Q?EBTG1FrMHYT2yw9zO8RKNC/8iqvleQF7P2/pAKuDHJbnIibtjdGYJOn3HxR0?= =?us-ascii?Q?ZS/ppvVQgx7b0Djx41G6iS0T+/TWoZ11YjYfw9Ctj7r8I6+0knkA4ru5cha/?= =?us-ascii?Q?iG1uhSSQOw7oX0nsKOndcVx73FRHu8jGMwaEnBFAgcDR3VFS9rV5NioacNeF?= =?us-ascii?Q?/daa8RAfAH90a3Q4xw0z2hT/jtgDgSW65shBJh521c2un+IBbOaBsjjQDGpB?= =?us-ascii?Q?uyfQ7aheqYD4aCDoDmUXKV7JNJfS4O/jynvEiaHdFIwprq1DyFW2n7hQbaAg?= =?us-ascii?Q?qSnKJBrBnBMOqaPyIXTFptSgtViolTVOyNMHxtih1YTB/reROgRyNdUWqIv1?= =?us-ascii?Q?Yo47d9bUG2G3fpXrMFPvuEUd6TlJpziLkN6eBJryFz+M1Co9QrVZVYN/ZZKO?= =?us-ascii?Q?52ZAIs5+OsHKuSyH7QuMUsizzdNShWguFTB0j8oWVhQmM6yzrFSpBPXgVlly?= =?us-ascii?Q?lthh8IrtZ7eLwGOeBqJgZf0R67/zMCgpn5NPCMgXBYZTxwRgYHEKhE4dsQki?= =?us-ascii?Q?QR/60AZLelmczVdLXc4Kophl7k1nyh8WHk2C82KCjyVCYEzOmrs7neXEkLTX?= =?us-ascii?Q?2sgmxrmhoaopqB9j4a27qvXfIF1m51K/cVZ6FaOqMxbHGCZhcRcLmQv3dJAY?= =?us-ascii?Q?vZ1AVk2VUAC7oN3DwzM0/GDtSj2VAzGyfZ5l5G2fyEpzs8T7mbbZDqptYaw5?= =?us-ascii?Q?sUtSLq3yXpHDhfAnEcb7loPVXe8nTpRy3ZrIxdzujXw4/w/LMVfeZLk6urQd?= =?us-ascii?Q?fXsm5MgNeRspw/XhV+uQBcqo6v4XGT/8x4Scxu3kOszdMwi4zAS0oyflfjL9?= =?us-ascii?Q?hC2CNeUIk641YZXaqGQTvKyHRATRvC+YmF3TELgzQjgjNlQtOlWWsZseOGR4?= =?us-ascii?Q?T7CZVoALYgRHrYyKxU/i0oQIw2PeCEppnw4dDTFR?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR21MB3263.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: af4498b3-8b88-4c76-fb83-08da6065d0bf X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2022 22:12:43.6083 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9FtC1ismmf4i1uNrv9XfoiK5nJiHW5kzuEQdurTxbAzIM4MJE9qF8YP3qQYnylBVD670i4bgTLwmL7daQdF0wg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR21MB3237 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Subject: Re: [Patch v3 01/17] net/mana: add basic driver, build environme= nt and > doc >=20 > On Thu, 7 Jul 2022 13:30:06 -0700 > longli@linuxonhyperv.com wrote: >=20 > > + file =3D fopen(path, "rb"); >=20 > Minor nit, if you make any later changes. > "rb" is same as "r" on Linux. b means binary, and this is actually a tex= t file. Will fix this.