From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6877A43A48; Fri, 2 Feb 2024 02:22:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 50D6442DDE; Fri, 2 Feb 2024 02:22:47 +0100 (CET) Received: from BL0PR05CU006.outbound.protection.outlook.com (mail-eastusazon11023015.outbound.protection.outlook.com [52.101.51.15]) by mails.dpdk.org (Postfix) with ESMTP id 7659B4026E for ; Fri, 2 Feb 2024 02:22:45 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E9CFfT0P3K/SNs1JifovpcZHUVZrHZekxI3z5z+rF1mqgHsRsuiDIPFX+1cMk3DgqYvp9zxoe9Bgli6I2ZLAjfvqPSlSbL1PbpRhRGbqxgb+wEeK3JhZXBkvGjvltBfhdqDbGOfKau2oQXACxsA20oPT4ENxfWGOpCqZCby81OQMlkHEUFQVich9PgBgFJTSxDEjhOQ/GQ1XET37xXaJYPHf2A/QjEIntvlev5uNTKX/7QJZ5kAuxUnuiSgBoT2KrhBl0JmXqTVB7QhEp6EaK4tokTUAYOdQnzdUTvUh2iwR5V8SQkTeUZ73vN390Lryrg+xN/CJupVEnQ4KAKS5Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=grp1bDDaWukCry38AhObosnlx7DgwwEYuVs+gxbvXyE=; b=Y/CwFFf1oc1lP39llekLjXAJDlpbvQGOusXCreV5hT/ZC8nJfiIjcnxWKvoE8VyhcaNuxwDwRuBe3Cq5gablNvYjn6B+n94oRH09Lt/7UMNKpjKBgDbENqr0ZODTlKOLHPV+3wzYSnasHUQjQsSSP7lFdnLgFhrIyUzNYyv49Xi2j6TNRvNEH9FWUNtvhpHvKnvOH02Lujybq3YRlJOS03lZpiNci3UyYi/0pH1azszFY/YnzK1Tyo9pwf6Cir8d1Z2o95R46WqqCKBo9cGz9TvjqT4ls8X7UhQX3kzdBmAQpfQENiqwYlCBCl9WtIZUC8X+VQ/7pawPuCA4HVp27A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=grp1bDDaWukCry38AhObosnlx7DgwwEYuVs+gxbvXyE=; b=ewLs/+2zeTuAt8SNAB+zNdysz6CxyS5zeubeoCSZRLQ+S6FRPaFWkhao308JcfeLc5gmmbAmxHbSS2oiouevGNm6EYL/XZ2lXefVN8ofRHThhkNOGdtwVfPF8iZSvT1J1riqZmFU1vsxIWgBcrRiy7JQ4rh6igINY0u37uUw94M= Received: from PH7PR21MB3263.namprd21.prod.outlook.com (2603:10b6:510:1db::16) by SA0PR21MB1884.namprd21.prod.outlook.com (2603:10b6:806:ec::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.11; Fri, 2 Feb 2024 01:22:41 +0000 Received: from PH7PR21MB3263.namprd21.prod.outlook.com ([fe80::38ce:7072:976c:bb15]) by PH7PR21MB3263.namprd21.prod.outlook.com ([fe80::38ce:7072:976c:bb15%3]) with mapi id 15.20.7270.010; Fri, 2 Feb 2024 01:22:41 +0000 From: Long Li To: Tyler Retzlaff CC: Ferruh Yigit , stephen , Andrew Rybchenko , "dev@dpdk.org" Subject: RE: [Patch v2] net/mana: use rte_pktmbuf_alloc_bulk for allocating RX WQEs Thread-Topic: [Patch v2] net/mana: use rte_pktmbuf_alloc_bulk for allocating RX WQEs Thread-Index: AQHaUxl9ccGx8ROH1E+8R8KoEK3RW7DyJW4AgABrYgCAAGQ6AIAB505AgADWHoCAAJO/cA== Date: Fri, 2 Feb 2024 01:22:41 +0000 Message-ID: References: <1706150562-23248-1-git-send-email-longli@linuxonhyperv.com> <1706577181-27842-1-git-send-email-longli@linuxonhyperv.com> <20240130084352.56971000@hermes.local> <20240201163305.GB13514@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20240201163305.GB13514@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=05f5a407-13d4-4262-bda1-6d285f8164a0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2024-02-02T01:21:53Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR21MB3263:EE_|SA0PR21MB1884:EE_ x-ms-office365-filtering-correlation-id: a888c22f-031e-414f-be47-08dc238d7367 x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: q7TG9YTzR1ImOMn4ebdSzAWBt6kcfA0XY4oQQdPGDKFq0EkZfpcQ+ZQMLmQA56wo8NdqOh8y6S7bSuY4NCVKGZmeZ3/xJD+sgFTC7FpVVGSM5oNxRkLFISmT081lezXHBtQsKHJwr2FnN4JgEpJY27MLWE3AgZAfKj+g3UtRRtkYIt2rQW2ChzgOJ4xrfrlvqzYB7JLQGC6Q+DEVS+M7HLBm9tjhpA5OxEQ1UjqZgtgdqr7/KQvJ32aeGpfT+YlDflLccsLySPK20y4aTkGOo8+/gR4NZkv2R0XxHE7LKsWYaSql/BhEGOI3eYvtExr/JO3+wh9CuR66WcTF0aZjnVaJ3kSDSwDvqXKmI6pHtBGsIkGm0upYZqdthywKEPS5oHth/Q16vxX7oMcnz3E2JMtnEb9H4iJAUwSlpvdS8faymZzFPfUqHmH34+25mWKi+eP4pIqOk6EopSXkEVl7ZZh3zWZEApq3KjU1F996hebze5v/l0X9u1oFjNGAs+Vcfft8i9PiSVof9RiicRZ1iFS+Akc9ZBPUqAf9xRPqJ7AxFRXNH9xUYT1PUICbB/QmS9UFQuCTje44eucuQlv+De+hXLK8TAN7npEcqWX2sRySVOEY6Oycek2MIsyhIMio x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR21MB3263.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(376002)(39860400002)(136003)(366004)(396003)(230922051799003)(64100799003)(451199024)(186009)(1800799012)(9686003)(2906002)(5660300002)(33656002)(83380400001)(38070700009)(8990500004)(41300700001)(52536014)(10290500003)(26005)(82950400001)(82960400001)(76116006)(66946007)(64756008)(66476007)(66446008)(66556008)(54906003)(316002)(38100700002)(122000001)(8936002)(8676002)(6862004)(4326008)(71200400001)(86362001)(478600001)(55016003)(7696005)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?A5jinaTHki161TL+ticVMTWPjhmaqRjMPTyd+M/DtD72J1tiq8ydi25JfW9Y?= =?us-ascii?Q?66YLQb1DhzeaVDxUPcCwouU1RuZptjYUNKnQW0JS2vkpDRq02D5Yg+0+cjtA?= =?us-ascii?Q?t82hEqqEQAVNFMcMKv+a2dZIbXu0QyxqCt7Cw0Kr2H74s/gPuGjEX/t+C1u0?= =?us-ascii?Q?NuZ2rlWJyepAgn02lJKLpQg0LrPua0XLsPzZyYiUsmQg4nUdHRDoqkYjfazR?= =?us-ascii?Q?2uCpNDQtXXGQItTGzhq2WF6JCO4N3HQJpJPi0tRlvaRy/5uR6kwlcJA15NC+?= =?us-ascii?Q?wgl0pDVAqrEIpuC/KwlOo6Qy4noDtVO1vUigKqi/bTAd8R9Zt2xsepA4V2uu?= =?us-ascii?Q?D8zaAi9rePjcNn+JZo8VtUc3wMAorJYwaggwvCWmnDHGghUsD6k00uPei+P6?= =?us-ascii?Q?WO//LQyBoxidxosMuvTcwvZ5myA5DHyH1qXe5ZWEE0BFlzdYjmZ5dpWjBGUI?= =?us-ascii?Q?tWOL+pYQkI8lq4W34qSfvWpgBS6mh7S5v2J+HOLhwrmmaFREAnq6VmgJBXtC?= =?us-ascii?Q?MKN07hMq8hPtR6caBxxkUVxnUpMCYsOY5OjHstLl1R8X3svrdM/6MigNsC5j?= =?us-ascii?Q?POQwlXwzlRoy4hwTwlE+5EzYgjko/osGHHetfQG8m9CjiF0ta7SygF4PMz3T?= =?us-ascii?Q?OcRZOsGt6+dONAzSEVEoIz7bmn3xqTUBAE9yaVNz1ZkSeLi+cmps5N8HmJz2?= =?us-ascii?Q?nwGAOt7ssyF6uZHpZ9tDVpNxHhNEgczVpI2zZ6nJLPl5WjNtoGdj1SfjT493?= =?us-ascii?Q?o7mbR6SM5JOnSh+ZJUt1A80pasFQghI89GgBcgCWPIchyMsXwgcnqZujnOZs?= =?us-ascii?Q?WDNeOYO3oZxgfq+GDyTTToMW8hk0vdFJJq6z1iLAfMB5IF5CH0a8q0G19Ai1?= =?us-ascii?Q?Jq7A8NRe+9dLvwIUDGstG7fdNSaqq9Ayh7uDJ0MIj8Pk1SV5XlXUHaR81lLC?= =?us-ascii?Q?VNAxxQ7wSqYIyi1F7ujK5FxZLhTOQyB39El3IS7pBkgVWi/4h5b6SVAc3JSa?= =?us-ascii?Q?UemhFoNqASgOs/aC1IvwTU1PpTBC9HhdNLgRGZpaxgNGAKDPMQAuMvIxhT1p?= =?us-ascii?Q?9ryPfouxYws3Iz6QIzlHf12Wl5r3S7qq50XLeUU+SY5oV+s1jyUYSsIz0P0r?= =?us-ascii?Q?O/cyAl/36GxZeeK3f13o1dme4iDiDUVvs4drVSTG92kZliafXUgELvGNxUg2?= =?us-ascii?Q?iYibD8JoLufWb61kAN5F3A6+kLnPSD8Aza7zIa4HN/E7gfmPJpuA2KhH3wBd?= =?us-ascii?Q?dPN2LAlOebkcH4fx/y5K7+f9PgPG1GIP3PZLNlvc3pJXITe1foNFrccBtzpR?= =?us-ascii?Q?H9jxbrfdqdt+bzLhnfA+3W4PxjhPn0I/0zRqbLpy7abK2egJ0hhmkzZmvTSo?= =?us-ascii?Q?5U/ApbhiM7seNMniV1MkYdNpJ/JVAgvwtwnmKW1pL1kyrG+36+U6z/N4bTKU?= =?us-ascii?Q?Unxl5OjvPP8aLKUZ4EFaFD67Wqxzdfl4KgishxsE//s2sDXjbUHwEzbyZokW?= =?us-ascii?Q?K7p5LhxLogQy6a6lhboAufrB/nUVrE8iaaazEuP807vmGA3sPNgv+VpQqo4n?= =?us-ascii?Q?vhAyuk7d6N/JCz2kp3CG1tX7zvzM39QqyVk7Lv0H?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR21MB3263.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a888c22f-031e-414f-be47-08dc238d7367 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2024 01:22:41.3073 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QANl3nuH6w9ZkLsBVUgc7aacLupjlIkRorzy9CKrZRtPBMuGSxuIi79aZAkiwo9zc5Qib2PhzmoWXOyDAYoGTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR21MB1884 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > I think another approach is to use VLA by default, but for Windows use = alloc(). >=20 > a few thoughts on VLAs you may consider. not to be regarded as a strong > objection. >=20 > indications are that standard C will gradually phase out VLAs because the= y're > generally accepted as having been a bad idea. that said compilers that im= plement > them will probably keep them forever. >=20 > VLAs generate a lot of code relative to just using a more permanent alloc= ation. > may not show up in your performance tests but you also may not want it on= your > hotpath either. >=20 > mana doesn't currently support windows, are there plans to support window= s? if > never then i suppose VLAs can be used since all the toolchains you care a= bout > have them. though it does raise the bar, cause more work, later refactor,= carry > regression risk should you change your mind and choose to port to windows= . >=20 > accepting the use of VLAs anywhere in dpdk prohibits general checkpatches > and/or compiling with compiler options that detect and flag their inclusi= on as a > part of the CI without having to add exclusion logic for drivers that are= allowed to > use them. >=20 I agree we need to keep the code consistent. I submitted v4 using fixed arr= ay. Thanks, Long