> From: Mattias Rönnblom <mattias.ronnblom@ericsson.com>

> Sent: Monday, September 9, 2024 8:11 PM

> To: dev@dpdk.org <dev@dpdk.org>

> Cc: hofors@lysator.liu.se <hofors@lysator.liu.se>; Van Haaren, Harry <harry.van.haaren@intel.com>; Stefan Sundkvist <stefan.sundkvist@ericsson.com>; Mattias Rönnblom <mattias.ronnblom@ericsson.com>

> Subject: [PATCH v2] service: extend service function call statistics

> Add two new per-service counters.

> RTE_SERVICE_ATTR_IDLE_CALL_COUNT tracks the number of service function

> invocations where no work was performed.

> RTE_SERVICE_ATTR_ERROR_CALL_COUNT tracks the number invocations

> resulting in an error.

> The semantics of RTE_SERVICE_ATTR_CALL_COUNT remains the same (i.e.,

> counting all invocations, regardless of return value).

> The new statistics may be useful for both debugging and profiling

> (e.g., calculate the average per-call processing latency for non-idle

> service calls).

> Service core tests are extended to cover the new counters, and

> coverage for RTE_SERVICE_ATTR_CALL_COUNT is improved.

> The documentation for the CYCLES attributes are updated to reflect

> their actual semantics.

> Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>

Thanks for the patch; Nice that these extra counters help in understanding what

a specific service is doing (e.g. idle, errors) in the context of the (existing) call count.

Test coverage and updates all look good to me:

Acked-by: Harry van Haaren <harry.van.haaren@intel.com>