From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6FF64596C; Thu, 12 Sep 2024 11:18:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D1C5F40E5A; Thu, 12 Sep 2024 11:18:40 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by mails.dpdk.org (Postfix) with ESMTP id DDE9D406BA for ; Thu, 12 Sep 2024 11:18:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1726132720; x=1757668720; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=tokYtSUA9cAWWUyziCe4OImO8F0uxaK+OYssPawAUjU=; b=USITLIKR/V5qjPoRQ9N214yhdG2mb3IbTEdRX7/Pfp2uMIuSPOwo+/Xy eq+Mw14cR/BQAhnrFi1jJg4Bj0cKmR6FK4aOxmO/1ybVzaFA3Q5odX7x/ JcufzTLet4xk6Ed8aEk5i6mcSG5AOrVF4RnF3BAdHvpXhAQPqLPBDAxIl cnSLcQ0l36TYghYTuRYdgDAU0V1ZmBBlN0Fg7bY76KJ94xHa8DVYoJpBo gcNz45PsDahRUEUj0WbjYNq/n4LdhfgD2B/kquCqgHqfbGwVjUW1Ps/QT NmDnAr3dkJ3cmJceuwPCJJ0iToADAXbcAcucXelEfs6TcSihkvsB+TvvG A==; X-CSE-ConnectionGUID: n9UzMKkOQ0Kl7U83y+zt9Q== X-CSE-MsgGUID: 4kZsum4eS/qH2wwdhfkvlw== X-IronPort-AV: E=McAfee;i="6700,10204,11192"; a="25132935" X-IronPort-AV: E=Sophos;i="6.10,222,1719903600"; d="scan'208,217";a="25132935" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Sep 2024 02:18:39 -0700 X-CSE-ConnectionGUID: j9S8ZAsIQJq1nK+pzQGXPA== X-CSE-MsgGUID: j5xVhO0pRv+oOAyoSdGRaQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,222,1719903600"; d="scan'208,217";a="72018591" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 12 Sep 2024 02:18:39 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 12 Sep 2024 02:18:38 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 12 Sep 2024 02:18:38 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.40) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 12 Sep 2024 02:18:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qF6HX3BGyui/IRnhfTKMoL/q/3gcpk6/inhT+Cezb7F4Z4qShpzTNGkc4D0tqe0JEhltWgXsNSdSuD5wAdYy1tih3bgZ5gGCQwEr9RNYvy6egepFVbdRANKu6O9ZCmsD3w5AwXbvckqhRVO2Fay5EvCrkszuNgqPlxjEstQQ/GcqXOYU9SSaVU+SC31NKAtim+lytve9kzkOd33YY26bMVc98zC4ocZoa3dkfA2q16KElKTijq08eUoSbxUpml2jhA/EHj4PmqXOsf3n+8G0RhsV+OmdqA6Oufl4mElkHMQIUWReD6Vf2RvNGtymkyvzqLb5Yj6pzXXGDPqathytVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tokYtSUA9cAWWUyziCe4OImO8F0uxaK+OYssPawAUjU=; b=xYCAljfHStZoV3hXgbLPOZR75f+8U95mn2dIZD5hOGFu/34ahcy3FMHfY38CpghOksKyvw6los1xZwx8yLSJj+RRJ3BYAUiu1UkEI8xUhMkcS0+o1p3Tawv1kLRZ5P20TSio4kP4JcKFJ+89y+i2P6NdISQmN1HJPWR1Qo6+EArycHhx6Uh9mFHNkByfBjgHMYAI/T7yqePP9+tkD15MasoRQ++DewTVN9y0d74TAEionI1+aSC72/MqeZqfeN0WIjN8vwYp5N6A93nAZrp0yLi4BwMkwVFHQdFJ7pSkGjES+rrEKEI7Wq0GjdVYKiuXSd+MgkuS33PnfS6IxVTcqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH8PR11MB6803.namprd11.prod.outlook.com (2603:10b6:510:1cb::12) by CYXPR11MB8711.namprd11.prod.outlook.com (2603:10b6:930:d7::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7939.25; Thu, 12 Sep 2024 09:18:31 +0000 Received: from PH8PR11MB6803.namprd11.prod.outlook.com ([fe80::8680:ff9f:997:18b4]) by PH8PR11MB6803.namprd11.prod.outlook.com ([fe80::8680:ff9f:997:18b4%3]) with mapi id 15.20.7962.017; Thu, 12 Sep 2024 09:18:31 +0000 From: "Van Haaren, Harry" To: =?iso-8859-1?Q?Mattias_R=F6nnblom?= , "dev@dpdk.org" CC: "hofors@lysator.liu.se" , Stefan Sundkvist Subject: Re: [PATCH v2] service: extend service function call statistics Thread-Topic: [PATCH v2] service: extend service function call statistics Thread-Index: AQHbAu1jwfKzdCzWZky93lopdGSdDbJT4vsX Date: Thu, 12 Sep 2024 09:18:31 +0000 Message-ID: References: <20240809202539.590510-1-mattias.ronnblom@ericsson.com> <20240909191103.697554-1-mattias.ronnblom@ericsson.com> In-Reply-To: <20240909191103.697554-1-mattias.ronnblom@ericsson.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH8PR11MB6803:EE_|CYXPR11MB8711:EE_ x-ms-office365-filtering-correlation-id: c46d73cc-bd78-4645-2340-08dcd30bde7d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|1800799024|366016|38070700018; x-microsoft-antispam-message-info: =?iso-8859-1?Q?xYkao4KxxNhWFySEKZhrLdbtYlD7EqXlt4zZNthkFDJhlioEhLLO7rr0m3?= =?iso-8859-1?Q?5w1w429pE8hvGh3DJDQUfSPRhxSWmSVk9+qk35odYOtML2DJUAWVKuxTt9?= =?iso-8859-1?Q?G6AZ94QcBzdh7mLlrmOMcjF5e9EOrF6N02jzehJ1oP/3PrfJ4oKvDqa106?= =?iso-8859-1?Q?+QWsKCMiz9bVIfRiycBG+a07Ij4a/o1hY93y9faiCRTQ6Xl1Bmjobfywne?= =?iso-8859-1?Q?2TCrAuBfWM3gFB8IEGuK5jwi1+Okimo+a851MybmZWAQUSYt779Xj37gXt?= =?iso-8859-1?Q?XAsOsirP4zJu3MvEaHPxnoZWUYUvaM9e/5n2LECkG6TbcXqnpu/6jaeTvN?= =?iso-8859-1?Q?CW/j5093Q3482XsLb3LMg3JtfqZUhpqvq5sor0Go5yV92LwwTA+BAqD4qT?= =?iso-8859-1?Q?PNUPr/XJ7Fw9EgUmpNhkkPPgcDLopZNShvrz0OwmY479MgvEid1f5JmsjX?= =?iso-8859-1?Q?1262aIpLZK4bR/fELHZ/62exNPlHt9HQL7zJYDmLyN9ysA5ibbpHleBqy+?= =?iso-8859-1?Q?PJZldtnFG/MHLzZXpwendxwScCC72wt7IXKFrXAjiAyUMzD/FFxpsG+GVq?= =?iso-8859-1?Q?cAE7A6/JgdO8cinvBAaVzwwbw4n7mAlESuehKJScoVq+Qd8hEZuSY+CvaT?= =?iso-8859-1?Q?Ev1lwv9jN5RP+ba4O+VfQM9QQOgefmOoc14cmf9sblfSHyercSKVFDBvSg?= =?iso-8859-1?Q?VgUvoadZsZ3GaDkDPEz/hLVMJcuFtaI1B4uTNbiAFZA2YLNSi4UC8xua8H?= =?iso-8859-1?Q?NcVzIjZIYEMIpqmEicjzTEynfXwTfo3V4ov6LkkJ5rEQWGC6zLOeBK3rQn?= =?iso-8859-1?Q?WSvEn7e86WKZKgOCRAbeD6InO+jdtbjImtcW6Aw3EXWEFm/0TtdfqD7XXK?= =?iso-8859-1?Q?AaIGNZlOroogskUGHfWhWG6Zj4fqQGU156x3bmzL1rJBAk79F6l+kM/Zpa?= =?iso-8859-1?Q?MErZg4H28OyfF9I99lsJUQIxeBY+PXZziBj0i9gJXCO24UP1NwNRtgoXCo?= =?iso-8859-1?Q?IWH3IDdRKM8PKgCqzfA8IKRo45sYqXYRadwHdevrTEGV0hhlSrHJTdUxpW?= =?iso-8859-1?Q?aLSvESo/0WCBhlgjxtctj2W5AP5+POwnnDCi5mT8vgG7VbMkqk2d4Z3Aw8?= =?iso-8859-1?Q?PRT+2hP1aN5zU41BtBZgTG8SGFfOcbuTDjXnjwGrRKEMOg+20TEAuSIDoF?= =?iso-8859-1?Q?zPidliNMOEaRI1akPFVWE7Gvn5kjNIwK21dbMK2yccCWbik6xfjRbcGygf?= =?iso-8859-1?Q?l2Aqxtv27ec8rUZ/ob9yA5UJYzeS3rYFktcdZ+/Qg0ks3gjRhAqRc9Ye9i?= =?iso-8859-1?Q?gKWq7ZnSpX9+rDAYE/JPKVJ0WnmUrGdsXlcpTsC81Sbxghozpcpzi/kmAZ?= =?iso-8859-1?Q?Kcu0lxdKnMbXxVRBoZw5fuLfnzmhbhJmUgv99OtVCXjc3cQWY2W8jPvTHX?= =?iso-8859-1?Q?xJ069A7tp2fHBk9C2ub5VUEeuNoVVDk4m78cfQ=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH8PR11MB6803.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?2nDKQL4FnBgOS7vdLy8l1GcKORTBAWdVQ+6JzyDdah/WffytaUisiljxP1?= =?iso-8859-1?Q?iwApQspI/z1qpRYzkk1b1R9T1DlXb+dVCxBCRXp64pcP3e77Gc591JGyrs?= =?iso-8859-1?Q?7rQmma5zU/8AuU6TCnsACGi+3quhn4K+Xnkj3x4Ljhl34DZYHcjVDISehr?= =?iso-8859-1?Q?B/RVBN3lFLpjX+oT6bPj8ZUrrhMXYs2geYkSaLjMyoCcZlawx+4mQoC7qZ?= =?iso-8859-1?Q?8ljR+r55+rgwKO0kRUvS1Idzbs6CnTU8WhPQQdWzcJacgIbOrloyhERj9S?= =?iso-8859-1?Q?5rAn48ZHaHt35F4DkC+VJgbylx0QlHMVUAV/5ffGeBVv+m0SaN5sMrJrVx?= =?iso-8859-1?Q?GeaPfC0uFS7VN+FKcSh0vGYeugF8KCvgKsnl+XOhaHaD+GISvGZ0wnLu4U?= =?iso-8859-1?Q?YSZAOsgDADfQv+jNC9k6jk7eOk604tDdfrdemNO6hAZ9XADqa88Wh/hjqg?= =?iso-8859-1?Q?AhQR1DRAJ1sMaUno4wRIE3RDwm44EcYIZhpnk1Cq9q21pUq9BThyNG2cfo?= =?iso-8859-1?Q?I9nLWFgqJX/QTJIWQm2Q8DWvXQAPJoVVjU4rWkng7qCgzCg70WtGxgWNj5?= =?iso-8859-1?Q?TEMGx5SkmhKMPbkIqzzHw/M5hHrqD2Mob0qJf85XMY06jkvXdLi4SxF80E?= =?iso-8859-1?Q?dNojKo0O1dLYwX8F1+IvYS1iMRusIBQdtaeW13ubIelawGcWR9iroveLWQ?= =?iso-8859-1?Q?qgW+ioQ5iN+3t1FGo1UXuHn6vJ3zyh8JR1ibbPudEepg9t4jMU7tHyGiUI?= =?iso-8859-1?Q?GHHXpM4fdq4TSyARb+jFWAfMyGcPhikAzkxU5lx7m8Loh+ByXEzqPRo8AD?= =?iso-8859-1?Q?cM84qU6l9H9qREWDL3H7wpV29Nk0ufYHsmy9mpFTgZw1GLPHzlggeHMc4B?= =?iso-8859-1?Q?CIdbMVdSsIkbs/MWFMh0VX2RCqcazoEbMN+UKmTCFewXu8rSUUe+IGU/UC?= =?iso-8859-1?Q?70pJZspqc7/Ux6lw42fMN7liS3bhFds3yUDUPbJBVVFfy0HKf6gqBJvAxZ?= =?iso-8859-1?Q?7JA4x9PQpJAEvnzApDI/RsGjks6Ch9/xx3hXT8SL6SjBiFzw9jGye1wqHG?= =?iso-8859-1?Q?9AyZM6Dwl4UlnSSHCyyMaMKzgmWpP7yrsJfjZyRqbAwNkI2N9tl4qRI0MR?= =?iso-8859-1?Q?CUTtEjBCvz2AIe1RCO94rTf6C4VVmBIEB2eH8Jo2/avHlzVTMmlhMzgwc3?= =?iso-8859-1?Q?zuS0UFcnGooXDAfL1Eyf9KYMkgjp9mZmO+R5W9uGZGKAPqHupF8q8aCJOS?= =?iso-8859-1?Q?nTPFmkZTxB/B18AVwrPutVniEMO+qa9jEBh2Tl0zVzHwResVNvN5hVHKyz?= =?iso-8859-1?Q?BrYdPAq9GW9E7Thq96PKX3PZJwzKnPO6Dd7/ooriulzh8rMD2y4sNfc2x2?= =?iso-8859-1?Q?Uc50yID7z+68ItTyjqviTWzjWDA8VBvkZZcSN1crKpcQnH1WzlDUdemmg9?= =?iso-8859-1?Q?1x1twjGmWdiEE1umFu2sy/NXnyuZXj8lhL5M3pQGjBwaxRWiz8X8m2foW2?= =?iso-8859-1?Q?EzcAelBWKdRAjnKipADCrhFSn9dn3kJtpIpbWKYEcxg6XZm7wnGvMVUpiU?= =?iso-8859-1?Q?uvv1TOBZ7kMo+yN7BUZv9hFMO4p48jNYaLBnOsEEWAFLFIkFH8Qovf37nk?= =?iso-8859-1?Q?LIw0wsCmfS5J7BHR+3ZJyDPjoAZ3kdT8QCs81dd8UOeH7l6v3plQRfUw?= =?iso-8859-1?Q?=3D=3D?= Content-Type: multipart/alternative; boundary="_000_PH8PR11MB68039B034EDB581C9E124ED5D7642PH8PR11MB6803namp_" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6803.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c46d73cc-bd78-4645-2340-08dcd30bde7d X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Sep 2024 09:18:31.0150 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: T9sDvuLrDf4G9SnoQ/dMNpbOn6qYM9255JMulC5qpn2fQCSWlOZ2BuPTaQc6UQLldMUNHDVkludKg1l5tbwV+RqHqFX55TQIaWAksmu7NIQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR11MB8711 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_000_PH8PR11MB68039B034EDB581C9E124ED5D7642PH8PR11MB6803namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable > From: Mattias R=F6nnblom > Sent: Monday, September 9, 2024 8:11 PM > To: dev@dpdk.org > Cc: hofors@lysator.liu.se ; Van Haaren, Harry ; Stefan Sundkvist ;= Mattias R=F6nnblom > Subject: [PATCH v2] service: extend service function call statistics > > Add two new per-service counters. > > RTE_SERVICE_ATTR_IDLE_CALL_COUNT tracks the number of service function > invocations where no work was performed. > > RTE_SERVICE_ATTR_ERROR_CALL_COUNT tracks the number invocations > resulting in an error. > > The semantics of RTE_SERVICE_ATTR_CALL_COUNT remains the same (i.e., > counting all invocations, regardless of return value). > > The new statistics may be useful for both debugging and profiling > (e.g., calculate the average per-call processing latency for non-idle > service calls). > > Service core tests are extended to cover the new counters, and > coverage for RTE_SERVICE_ATTR_CALL_COUNT is improved. > > The documentation for the CYCLES attributes are updated to reflect > their actual semantics. > > Signed-off-by: Mattias R=F6nnblom Thanks for the patch; Nice that these extra counters help in understanding = what a specific service is doing (e.g. idle, errors) in the context of the (exis= ting) call count. Test coverage and updates all look good to me: Acked-by: Harry van Haaren --_000_PH8PR11MB68039B034EDB581C9E124ED5D7642PH8PR11MB6803namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable
> From: Mattias R=F6nnblom <mattias.ronnblom@ericsson.com>
> Sent: Monday, September 9, 2024 8:11 PM
> To: dev@dpdk.org <dev@dpdk.org>
> Cc: hofors@lysator.liu.se <hofors@lysator.liu.se>; Van Haaren, H= arry <harry.van.haaren@intel.com>; Stefan Sundkvist <stefan.sundkv= ist@ericsson.com>; Mattias R=F6nnblom <mattias.ronnblom@ericsson.com&= gt;
> Subject: [PATCH v2] service: extend service function call statistics
>  
> Add two new per-service counters.
>
> RTE_SERVICE_ATTR_IDLE_CALL_COUNT tracks the number of service function=
> invocations where no work was performed.
>
> RTE_SERVICE_ATTR_ERROR_CALL_COUNT tracks the number invocations
> resulting in an error.
>
> The semantics of RTE_SERVICE_ATTR_CALL_COUNT remains the same (i.e.,
> counting all invocations, regardless of return value).
>
> The new statistics may be useful for both debugging and profiling
> (e.g., calculate the average per-call processing latency for non-idle<= /div>
> service calls).
>
> Service core tests are extended to cover the new counters, and
> coverage for RTE_SERVICE_ATTR_CALL_COUNT is improved.
>
> The documentation for the CYCLES attributes are updated to reflect
> their actual semantics.
>
> Signed-off-by: Mattias R=F6nnblom <mattias.ronnblom@ericsson.com>= ;

Thanks for the patch; Nice that these extra counters help in understanding = what
a specific service is doing (e.g. idle, errors) in the context of the (exis= ting) call count.

Test coverage and updates all look good to me:

Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
--_000_PH8PR11MB68039B034EDB581C9E124ED5D7642PH8PR11MB6803namp_--