From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 418CDA04DD; Tue, 26 Nov 2019 17:20:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B5D5A2B96; Tue, 26 Nov 2019 17:20:08 +0100 (CET) Received: from APC01-PU1-obe.outbound.protection.outlook.com (mail-eopbgr1320090.outbound.protection.outlook.com [40.107.132.90]) by dpdk.org (Postfix) with ESMTP id 3F6273195; Tue, 26 Nov 2019 04:28:38 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OrbIK5Q07JcHpGfms2D2kPz9NbHzFC+YS/BvXzWLcvbt4AAvxDhraRaGHzeWiLVcqj18WCFcHiWA5zXRbg9KWLQuaJIARjYf79dOUd5Tw+RKQOK9wxIVfYtw0o7c1FFKoupJnjVEmOGSrsCcXJ2VXqBmb428LbPLHVbDV29JpFFuz+H9fqE7uq10B4gcSkNK1npjiC9/lGE8UK2r0l1FjwcR8K3guDnEdIS1lX8eZq+wYrmdca+/Bvwt/e5cEChqVxReWES8EW4TmyKTjgIPgCP3I9wd3NDZJkwmrO/zqrx9sDobL25j5j3fqrawuXjjqmzQ00AweIFnENQpAZHjvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bxlwHiWT1/gRpqxdvY59PXvhbLGJFWNS5v1nNMW7Q5o=; b=cz3j5L3uLcHGmP+WFewAQcSdJ/UQvJCCuzOwfERr8z1i5daYOv5Q7OVbfB+y/Wav6VzDadHmHTCqYbREY3/ZEFfbLZE62QbSOpvVnlRFNmTDS5Q5JsWmZshqGgiqu/fKc+mWsSc/VaW8/1bIiwwSGXNTPIz+GkmDKcZShmreeWW7DQbPTNojgSbJGFXHJ7rEqVEoHwur8U3V8MVuMrsqWPA58brOXYHrP/G2/nZ/aaKvDSkyzSCtPVf0JSxtnrUACXNVRX9OtubIo/7hldhjPlD9s0cKBtt9z/e1Dhyxvd86MM0q3gi7NspNCSAgtAtehPZkHXwVBhjcPyicwOjn3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bxlwHiWT1/gRpqxdvY59PXvhbLGJFWNS5v1nNMW7Q5o=; b=EzpgrzuyRzqHJ49CvQIyHiicBSYtNmlRBkNys51WiKLFJ+Zt6S2TwlMLynwuE4AmQTy4bv9mrRefHP9bnmWmEUNoJIjkPgCT8HbLBUvze+V0XG8si6PNlNeQUjrXB3FFpSLwWCqQde/dR2UdRMDANAdk/yyMkUGCAkt9P2oiIXg= Received: from PU1P153MB0169.APCP153.PROD.OUTLOOK.COM (10.170.189.13) by PU1P153MB0140.APCP153.PROD.OUTLOOK.COM (10.170.188.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2516.2; Tue, 26 Nov 2019 03:28:36 +0000 Received: from PU1P153MB0169.APCP153.PROD.OUTLOOK.COM ([fe80::704b:f2b6:33d:557a]) by PU1P153MB0169.APCP153.PROD.OUTLOOK.COM ([fe80::704b:f2b6:33d:557a%10]) with mapi id 15.20.2516.003; Tue, 26 Nov 2019 03:28:36 +0000 From: Dexuan Cui To: Stephen Hemminger , "dev@dpdk.org" , "Donald Lee (RD-TW)" CC: "stable@dpdk.org" Thread-Topic: [PATCH] net/netvsc: disable before changing RSS parameters Thread-Index: AdWkCZCSRBa3Z8IWRAK5fNreHRUkqQ== Date: Tue, 26 Nov 2019 03:28:35 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=decui@microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2019-11-26T03:28:33.6092091Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=031a46c2-06e0-43e1-b061-7477b96c975c; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic authentication-results: spf=none (sender IP is ) smtp.mailfrom=decui@microsoft.com; x-originating-ip: [2601:600:a280:7f70:d876:5e02:2ddf:79f2] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: e963ad26-3b69-4e07-75d3-08d77220b8e9 x-ms-traffictypediagnostic: PU1P153MB0140:|PU1P153MB0140: x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2089; x-forefront-prvs: 0233768B38 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(346002)(376002)(366004)(136003)(39860400002)(199004)(189003)(71190400001)(478600001)(256004)(14444005)(8990500004)(25786009)(71200400001)(229853002)(10290500003)(86362001)(66446008)(76116006)(33656002)(55016002)(6436002)(14454004)(4326008)(6246003)(9686003)(66946007)(8676002)(74316002)(81166006)(305945005)(7736002)(81156014)(22452003)(7696005)(316002)(5660300002)(8936002)(66476007)(66556008)(46003)(64756008)(6116002)(6506007)(2501003)(10090500001)(186003)(2906002)(53546011)(99286004)(102836004)(110136005)(52536014); DIR:OUT; SFP:1102; SCL:1; SRVR:PU1P153MB0140; H:PU1P153MB0169.APCP153.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TYFY3Swk6mFuNTJq98Dxe7oADqUopZGK2Nn0oaE7C1qhcRZIUZNV/+IIPPW1VFVuDJ2Nsl0MlUstoNAdy3pX1K2P2jVeBgwoIJPrm4wZDtY6fDaJSvqrO/iOYMjt19qsCDRL1AS/EgJ62gyvqc2tnLdF2LHFleq9msifxg3NSa6cGfyDmSxL5H0nD951Hgr8bzaQNtThbKyai//9g4ORVW7XCN3K5UmaPj0TiEHttDMwmWrpVO4yCjYE+4SUM5z1GiB5LAw0lktdRfIPgUjZg5r4LLMsQjaCPMwwEvIOL+NHO303YdVc8nilRH9dh1TPA0BPYglUaxuqb+7AmnpFfg/5pyawb3tb7ciVHljNGNJhHMVbJjQkdwYnF4rDzpYlijwxjLXt7xgx2yCRci1tPs6ucbCAEpL96JkdbHFI/VuPWBLIM2m1oemKw2DrslSR x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: e963ad26-3b69-4e07-75d3-08d77220b8e9 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Nov 2019 03:28:35.9744 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +Ne2MGpqVT9qJ6VlFcHn1scuw0iEJ86EQyRVeSTiVPZpOZ1qa1x+s17XTfJKAeye72aW3+nyEkz1SMa4ztwCAw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PU1P153MB0140 X-Mailman-Approved-At: Tue, 26 Nov 2019 17:20:07 +0100 Subject: Re: [dpdk-dev] [PATCH] net/netvsc: disable before changing RSS parameters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: Stephen Hemminger > Sent: Monday, November 25, 2019 9:13 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; stable@dpdk.org; > Dexuan Cui >=20 > In order to change RSS parameters, the host requires that RSS > is disable first. >=20 > Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters") > Cc: stable@dpdk.org > Signed-off-by: Dexuan Cui > Signed-off-by: Stephen Hemminger > --- > drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) >=20 > diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethde= v.c > index 164e9ad174a7..575780ee5f26 100644 > --- a/drivers/net/netvsc/hn_ethdev.c > +++ b/drivers/net/netvsc/hn_ethdev.c > @@ -291,6 +291,13 @@ static int hn_rss_reta_update(struct rte_eth_dev > *dev, > hv->rss_ind[i] =3D reta_conf[idx].reta[shift]; > } >=20 > + err =3D hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE); > + if (err) { > + PMD_DRV_LOG(NOTICE, > + "rss disable failed"); > + return err; > + } > + > err =3D hn_rndis_conf_rss(hv, 0); > if (err) { > PMD_DRV_LOG(NOTICE, > @@ -578,6 +585,13 @@ static int hn_dev_configure(struct rte_eth_dev > *dev) > return err; > } >=20 > + err =3D hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE); > + if (err) { > + PMD_DRV_LOG(NOTICE, > + "rss disable failed"); > + return err; > + } > + > err =3D hn_rndis_conf_rss(hv, 0); > if (err) { > PMD_DRV_LOG(NOTICE, > -- > 2.20.1 Hi, Stephen, I think the patch originally came from Donald Lee (I added him to "To"). IMO Donald's Signed-off-by should be added. And, can you please change my Signed-off-by to Tested-by? Thanks, -- Dexuan