From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EDDAAA0560; Tue, 18 Oct 2022 07:40:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 950684021D; Tue, 18 Oct 2022 07:40:17 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 990FE40143; Tue, 18 Oct 2022 07:40:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666071616; x=1697607616; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=BfMWjwZRwJUojaHxLVpIxMBi+qOcEpN4f9L9xOiHQEU=; b=W2Ja+2sypkmWS+tomu5lt+u1qWmTQAorAI16P/1270kqlm2/G4vbmB+V gmZiJZTZ/2u9PtGIkhe747P+2zWAirXaMYegTkG6i27VbRYRR4xWWREf1 x+KH9Xv3isOknaPdA4X3ihzi1AEK+l8S3Oev6lbkXoOYMpi+ZOKL2sBiM 2hkNAF+gbLM+OZQOADCFFgiZR8KGpU+dAeitgJFsTayAoauitP7Q0aqnx 0yrEfNJs0pyOTKcRe6j4vjuI9j3lgrjJvVAHRNHhNV9BvozLv1lYccCJK TaGrtBo/w91s6Lf15CibjZvax/SWuyTCZ0QtXIOSyVp3Z4vpdJRkku03z g==; X-IronPort-AV: E=McAfee;i="6500,9779,10503"; a="285723773" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="285723773" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2022 22:40:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10503"; a="630965841" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="630965841" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga007.fm.intel.com with ESMTP; 17 Oct 2022 22:40:15 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 17 Oct 2022 22:40:14 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 17 Oct 2022 22:40:14 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 17 Oct 2022 22:40:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T08uH1dooLFftbJLydqs7RpBUWLqLfzre6CjjQ1a+I2AsEKt7PDzeoNf7g+tZm76uScFeCLVil1jFdCk4VwClp99g7XsaVquXY6Q+g05FsW3aFTOMuI9XmsbugwPaimCAeoz/EzJRgYHHnlrcTbxbKBOC2Ea+ocAIlb09atGgObKujoMS1LE14J8e5VC6PNnfNR7PgQK/iUfJPhUfR158PJNZHZ8iAjsW8Dc6EkBFc2UdufVehWkothPQx1zZ9apK9xY7Ik1oR7CFY8uts/i3jCOTVNge6BW1ZvlEqVXU7r0DCzzg9TQ6ElU4SzBu2GstSTDz3S10MrDaKtONpdsJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=skQrzoVhIkQyhQt5g6M2eMSrIGduCnRjfQlRuLK+LYA=; b=dvEsrUjxgcncZQB7Rzd9c6Gv4jkBTEteqWeazQstb8FGRRVW3cP/ienEJ/JLt1iXQrU4JtT6CDusU5XLpCwSwAz4zqBN23CdwcSOb067uZPo6l7MxyncV5B4S/lucWSLCg2kQCm+kI/B8M93ky6zpRe4Un8hQMduK24Q33aP+1BeiwCOL5hYVtJF3+CmxhOq2CYiQkhtZJ3YHvS7XFQOcI9SqiEQIRuRbChkx1dBXaDn9kIMkcsEtMM3fN6Nvv7r+WTdyT5Jcv9IXwPhiyevARm962j4DrNHvWuPgB9phFcvjK93y2G2G63zY510vd8qR2n88U2E+ovjioIHv1av0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA0PR11MB4670.namprd11.prod.outlook.com (2603:10b6:806:9a::8) by PH0PR11MB4808.namprd11.prod.outlook.com (2603:10b6:510:39::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Tue, 18 Oct 2022 05:40:12 +0000 Received: from SA0PR11MB4670.namprd11.prod.outlook.com ([fe80::828e:f61a:6342:a12a]) by SA0PR11MB4670.namprd11.prod.outlook.com ([fe80::828e:f61a:6342:a12a%7]) with mapi id 15.20.5723.033; Tue, 18 Oct 2022 05:40:12 +0000 From: "Ajmera, Megha" To: "Dumitrescu, Cristian" , "dev@dpdk.org" , "Singh, Jasvinder" CC: "stable@dpdk.org" Subject: RE: [PATCH 3/3] sched: support for 100G+ rates in subport/pipe config Thread-Topic: [PATCH 3/3] sched: support for 100G+ rates in subport/pipe config Thread-Index: AQHY2bZrVM3UkbCE+kqAnRCai1DYza4JMRwwgAqBTZA= Date: Tue, 18 Oct 2022 05:40:12 +0000 Message-ID: References: <20221005172239.254327-1-megha.ajmera@intel.com> <20221006190038.431828-1-megha.ajmera@intel.com> <20221006190038.431828-3-megha.ajmera@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA0PR11MB4670:EE_|PH0PR11MB4808:EE_ x-ms-office365-filtering-correlation-id: 3568181f-4362-4962-08b3-08dab0cb3a37 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oRRvFvX6u6D76zWV7Zr9tyySYQOypxlgJVfN8tu6O6VWfIiI0BAObwv+/jrJBZDdBvEYBidpK9sMw/+IgrQcoCdDHr9lp5gw1v7uOVutPKvkL2UPDNHELontR8h4YmGAvFSLTBv8lhr4fiQNz70dmOLhLfj+FPGd3AsVp5rwy8BysbQlzMnKNTk8H/xYx1F/Ry2cmeKhFtLl7rv3idg1E4f9XAysQoD259TW7UmpPNGX3vnoLUd/4Y9LWE2Qed5tz6A5OlN9/MRC2tnMXL2kUH0VHaAUyxRSWRIsBL1BSjgx5qKRy518qoa/cOfhJCob8z5onWk+miePWFLXjhbzhX7UWAsxTPZhIrW0qddw11Fvp9ri5Jz06govtXdGUdD4HJf1S70dbcH/hvt3mQpO/8EVh5XAVxHp6k4Ok8B7uSVXk1iJyapDfOYqMRnSisY4v+HLMdaLXv8VAhMLx5BQ0zv3cEB8GFyzHy4kGmu35GhREBndDbmVpvZJOlqgWw3tq5WdWLbfT3qOKCpNsQHn7AB7TsiXyzZ/KFSnJASCwejkINrMZB80k/m9LXYSHvV7oH7ixg5VrC4t67gWkcvYayhoNbOWqjRrf+yMql460ETh4HXmqBH5dvosfdKMPJT/xGBbyEVVgyDXsmZETBylDFsRKRqWfmuoHF2T7gSUFtYW3hB+ENxtp3G95gjkGt8lYmDF/QsO1zw3jT4UAXQ6kApziBbmEmex3TvERsPz/1Q0u1uLRPL96yUZWPGixMfYurG0nJE2AtVlGL1omnnL3w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA0PR11MB4670.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39860400002)(366004)(396003)(136003)(346002)(376002)(451199015)(110136005)(64756008)(316002)(6636002)(33656002)(186003)(7696005)(6506007)(4326008)(26005)(2906002)(8936002)(4744005)(55236004)(41300700001)(83380400001)(86362001)(52536014)(9686003)(66446008)(66476007)(66946007)(76116006)(450100002)(66556008)(8676002)(55016003)(71200400001)(5660300002)(122000001)(38100700002)(38070700005)(82960400001)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?N+c/m/JhvpHwD1jbtxcl71bnJtSeBTOuzTerHShASa/jBvODc/TXAEl8Q7/5?= =?us-ascii?Q?3PqvVKp37R+LkXN2chE9dw4lT4/uMo6Kp3WmGabNMltja3fgCcGitD+sRGa/?= =?us-ascii?Q?ydUr6mgR4rOF8uhgGKvnnSyJ7ak5AMsbs3wJCPUuFhwUI9XYF1EJbogr0dk/?= =?us-ascii?Q?KjDjqEW6DEevUNEINyu5hSoVAtCTyEk2tQKg7rmMQ0+RvqEwSltnIx/CGyOY?= =?us-ascii?Q?TLAGazj+83YxwkH17Wb3FFZ0h3ML4Y1HDHfrzHJhd6RV8bltij+LFK6sQuae?= =?us-ascii?Q?NnJbE0b6cwnU1zqeDvNIayzDRHJ2J4ibsGAXi6TdxGYiWogdC1k3yuH/Y3/V?= =?us-ascii?Q?2rErf2YNfT8aWH+rPwxS08d07Yss7LH0UBfD3D6Ke0HlVn5gaHuGBTIpmnDY?= =?us-ascii?Q?uYu8VN2B7KegEB3FrquwLfXv02ce8Mzpgyl/Bm+FAob4UYbd+c9GZsktza7o?= =?us-ascii?Q?Vx6BqCIDfIiY3wpsP2z+fTtz3LH/PoOgNajU92q8RFCo+5UOs0kzEX6lTfvc?= =?us-ascii?Q?kG7gBB8TJ52PHLuaiizMLE+1pWDKjVNnMUxwbNk0W3v+HF4v3hJrzajyCJAz?= =?us-ascii?Q?RD3OkYAZ5uGkPGtBS8UFG59xfLXEx5vYuSKpYCz+hWDaVEvq2oW+AN/HrnAd?= =?us-ascii?Q?d1XarM5QMxoC0C2nL87QkIhpt8jrI53O8W1R+6K+AYEMaz/9sV6WFPyQAWIq?= =?us-ascii?Q?pkcY3OTJlZIKEx/Qplp9V9JC6LwkEY77qgMv4dwRVZdY7mAoa54ma6/IbbFz?= =?us-ascii?Q?cRMf6k1o5FUw/wG607P+mh2tuKtJBBhSopbVc59l5C4xOaZPm/rJvFKl1w+l?= =?us-ascii?Q?dU2ynsUISElTlShrRZNK+AgsZhcMO+tP2IBLvKx+SXHYPw0T4eaI9x2FQ+Ko?= =?us-ascii?Q?7r6vRaVIsunhrWQnKPv5+KX8EejrWN71szdtqhYHYRWgRFXnk9/CqNvPuGig?= =?us-ascii?Q?9hg+o+wDOuMb8U8Jod67c5IPKZ5XAdG7/QQNlfwgPt4MMmbsB/FJIr8XJkq2?= =?us-ascii?Q?5+6cg1ZWLtFa9BCV8UaNLTQr9rwlqDoFRsHkfvquSbhdPfrYDu8HI6GYUdCh?= =?us-ascii?Q?pkpSK88Zmtsc4JZprNXR52bXVcXyUhSqx76UsEbJQoxaAPRPuEVwCF0fIVOW?= =?us-ascii?Q?1G6s1U24iLDv536F6dClCnAzlQAG5VF4Y5vMXJlMHTCRnInfdkWlOZFV4t+m?= =?us-ascii?Q?xUc1DIpLQXCKfPXTPs6hwnYWQKNxQCfxtLVzDH4A2Pr0O/mxVf7sFVdUZ3b4?= =?us-ascii?Q?Jia9LQa+pXcsyLG6/hArHKhABPTY4r+ld3q59fhSpY/cERnKo5QltKaZdzB8?= =?us-ascii?Q?bfnz9VhlBCvGQsm0KBasD/NPFH2IBdQKf0cyoZ/mwe5/KtnOHiWbmYzhyKZ3?= =?us-ascii?Q?V9546a64vh3qEtCJimSKpNXAS7+BK0vxPD3bQE3DdINOl6Ip+1KmEEUe3Osb?= =?us-ascii?Q?eCN2Bu/PeMtAGRrZG4uupKzqdKjizqqXnCcyDbn1P2ysa+HEfHj91CwysC7p?= =?us-ascii?Q?db1jICclYG4ECuLO2oB1528siaCVhX5bjIonLmP+imQLlZAzHZVSCjQ5v2Q8?= =?us-ascii?Q?oV0dw7XEk9PW6zRX6+GsWyjFl87l1w9QNNzdP1dL?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA0PR11MB4670.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3568181f-4362-4962-08b3-08dab0cb3a37 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2022 05:40:12.7725 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pC+v/xNCmq9JHDUrblPF2yzXJFUxEdyh2ySW+EKpR0Jn0nxfQ8HL/YSjGc8WYlJgmijiDfnPEZAWB7tT9iTIuw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4808 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > entry =3D rte_cfgfile_get_entry(cfg, sec_name, "tc 12 rate"); > > if (entry) > > - subport_profile[i].tc_rate[12] =3D (uint64_t)atoi(entry); > > + subport_profile[i].tc_rate[12] =3D atol(entry); > > } > > > > return 0; > > -- > > 2.25.1 >=20 > Hi Megha, >=20 > Maybe you can explain how removing this typecast can provide support for > 100+G rates? >=20 > The atoi() function returns a 32-bit value, while the subport and pipe ra= tes are > 64-bit values; this typecast can at most remove a compiler warning ... Hi Cristian, We have now changed 'atoi' to 'atol' which will return 64-bit value so it w= ill take care of 100G+ port speeds. However, I noticed that 'atol' will ret= urn signed-64-bit so typecast may still be needed to assign it to unsigned-= 64-bit variable. Will send updated patch today. Regards, Megha