From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E59DA0544; Tue, 5 Jul 2022 20:04:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 62E7640223; Tue, 5 Jul 2022 20:04:15 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id C855F400D7 for ; Tue, 5 Jul 2022 20:04:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657044254; x=1688580254; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=+gRQIDJ8hl+jjNOwNxDSPOytE0elyL3774YO7xV/Vgw=; b=mL0M1QeacwpxCAkWHeYECa18B91Xy3CwfoCuc74mj2k86osaMKHlAAKv 0HPko4BbweSLsyRsK4smuG82rACt3ygr0Aju9VNo0GUTbuz9uWyZehRTO HoZGavF0okuwZQ+EMYfmHLqY7BZHiFTyt5383uRg+p2f2lgVibLV9wS3Z lWtGVEUJYGEPHj3tUrIj2tfsjfLD4rBSe8pRq9WA/U4d7T/4GUGQFbEvy l9HaqZ+kcLTUSYR/L7+ZPTl65PJOfPDEf6nvxBWarkQyyZ1JuQ1qK+w2z lge//t0O0MPYvtvJ4puuV9AO2ZuS1VrDapI/h5pIPAbF3oHc3wOrdJ1dw w==; X-IronPort-AV: E=McAfee;i="6400,9594,10399"; a="282185565" X-IronPort-AV: E=Sophos;i="5.92,247,1650956400"; d="scan'208";a="282185565" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2022 11:00:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,247,1650956400"; d="scan'208";a="719822793" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga004.jf.intel.com with ESMTP; 05 Jul 2022 11:00:32 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 5 Jul 2022 11:00:32 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 5 Jul 2022 11:00:31 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 5 Jul 2022 11:00:31 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 5 Jul 2022 11:00:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kGd0pkM8/VTtZPTV/zbrwqsiW5Ah2qWEDPOaCt4hblTuCbjvgyJEw8nDliYlVtkglt0HNurx3ecms/lVV4WOPEo1l6sw2mw7w1293ff54FFUGAFFUZxWwnVJ4f/QgUdDCQAYDo+zkcIdAIk67R0WtdJ6ATezkTt9L3DzuQHXsgIRhBYmA6Bvm5olzOE+anQSAH9SwqFrQzt/6t4UILI1u6/tSrRlcw/B/sst6kfTno9JrlbkoNN6phuaeJxQN2bj4YJTE1X6OueBPKDtcQs8fTcRaXhITCMZTYn9AGg6hNmiQk5YhcHmYnMQ+frAUG64jNX3z8KF/csqDBsk5wTutQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U2iPWjWKWP1v9EoQ3q0BV6LpL3qtWuGkwNwxizh+3j0=; b=hxc9apqyYXhCqFp5W0hY1CiJXGk10Wh3dm8RH1R8o/JLklc1ibnjc6Topi8dtA4vkmTmql4/n5Jjn2gRAa4hb6INA/VyCNKD1Ugcwmhjs+1v+oS20deLO5zLme6mIr7In457y/tGq2RXzVcISxZk+VkfSg0e4ZfSFF363KkQIR9pe/nTEJ3HMEq7+LxFQ1TYAkUwdJV1XOMb+btgJFdoiZ4qrPex+ivuy9DYTAeCa4MgpkIKKTYEk5ygwI+KNAw7Z9ZPcwoFOC0aNGmH8axjZ9rdFPQ4bgTg0z0lmx1MQhQs0cr5Vr3Xt1Q5pfkBIwK9WMhmyHB/qvNmffVDPgOTAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA0PR11MB4670.namprd11.prod.outlook.com (2603:10b6:806:9a::8) by DM4PR11MB6310.namprd11.prod.outlook.com (2603:10b6:8:a7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.19; Tue, 5 Jul 2022 18:00:29 +0000 Received: from SA0PR11MB4670.namprd11.prod.outlook.com ([fe80::e05a:ce53:8362:8468]) by SA0PR11MB4670.namprd11.prod.outlook.com ([fe80::e05a:ce53:8362:8468%9]) with mapi id 15.20.5395.022; Tue, 5 Jul 2022 18:00:29 +0000 From: "Ajmera, Megha" To: "Danilewicz, MarcinX" , "dev@dpdk.org" , "Singh, Jasvinder" , "Dumitrescu, Cristian" Subject: RE: [PATCH v8] sched: enable CMAN at runtime Thread-Topic: [PATCH v8] sched: enable CMAN at runtime Thread-Index: AQHYkJF4gKYI21ChWEacXk5RTweArq1wDjjQ Date: Tue, 5 Jul 2022 18:00:29 +0000 Message-ID: References: <20220704091926.549909-1-marcinx.danilewicz@intel.com> <20220705170533.709971-1-marcinx.danilewicz@intel.com> In-Reply-To: <20220705170533.709971-1-marcinx.danilewicz@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 27792556-22fd-4c50-ce02-08da5eb03f48 x-ms-traffictypediagnostic: DM4PR11MB6310:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YZ5htzoeC/UEWcMWy9OJYGs7ppuyIr9L+HFckK58g/0HTa72wolc0haDButsKoaCXQzYWxkivNNZvivJ9ViiAEZFa2mZgxa1hXayUnmmvFLb+M8NKCCh0AomkaYjN5sYOEhvOKb7uLg74QkCvBhr0CfRMRKAjO94D4Ho75zMsUxoeup3CBnjbMP4ODL219abta5E7WSPMRSd1wj6XocvSJK6icVI8pyHZosblnFg8gXIxITSx20qFe/m0+C3VxsuDmCX6AWtD1NYkNmj//do5G9g9TLOInCAyS8zMHRDszlHWkHNpQUHrCN5koNApQB6X32iI/CA8xP+HXc8iWKVsnehNYSq1mC6iBeyczeX761UPPyaJvINPFhJHGMLv1/bp2KxELJlF/WV7Ye7FI+Nb8+T493o1jsbcAW4IrSXhudw67Bw2DpHaRS0xUTUJzh1Qns4LVqX6YrRv+oWQ39kRhaqOV5HCV8c5pwA2fNV0Ls3pjlro//mha4Gg8wRvmxcRey2lKSxM5DCdMQr/En/hYeR5HTOvlcC4hSySt0cnVNu0NiJj46AT2RJMGBqmRrqn3eqssm8VBpM8tdYD5OPMC3mQybHm1DhwNrgourfoMLyoMXJRX+5XCgsiDckaq3Toxa8VQ2iZqLfeHB/rzua7WBxOTIuCvcIpWUq+/YYODroDBlryexqQvUP455wCred7j+YXkm0/NwtrmqhBMpeCH4MTPAZBx6PyURqsUcJ5439kKvvLqlCcvUK1oBLiCwyY1RK7QLBpWHTykHgRWwFsXLFhC9aCq5Sqj6bBwtqk82lMk6ws2ZMfkK4E5npDARf x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA0PR11MB4670.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(39860400002)(366004)(136003)(376002)(396003)(346002)(33656002)(83380400001)(8936002)(71200400001)(478600001)(5660300002)(316002)(9686003)(55016003)(52536014)(186003)(86362001)(122000001)(66476007)(6636002)(110136005)(82960400001)(38070700005)(2906002)(66556008)(26005)(41300700001)(8676002)(38100700002)(64756008)(66446008)(66946007)(76116006)(6506007)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hcR/4/54xGbPWzk/JkMs1F4vM8gNnJeVJ57FCX04NBvxT6jQYzEPf9cFZ8Zz?= =?us-ascii?Q?ggjD2jYPRAac4zxiSB1VgQgRaXSKHmetOCs8PphUID7fmOWUa4S7xIsN3QAT?= =?us-ascii?Q?K/v5KYgerZ1IBPmB4LWwjYbBTiOycIYGYaoIUZ5mchv/nJpDtT+n7nZAO8Kl?= =?us-ascii?Q?k0Mb82XdnErB8wcha99qxwMFF77kcqvQhuWhpRBm2IZWr7xjOBNyMS958ymD?= =?us-ascii?Q?aEU6A09z+KMb0RiJ6NYBGtFZUkN8T0xeuQwbFhuWHrlAGuz2g4JELyLSqQaF?= =?us-ascii?Q?NRQ6crByUcpZcgtHLy5kYggDwYlO1p6A9oZe1FC+Im9cLZx+9ezVWGmoTp5S?= =?us-ascii?Q?2oafL17VcYREaQI8StJI4pT5MYLhXYH+VYpBpdEoSZEbKJS7Xg0Z0fVbRPe9?= =?us-ascii?Q?K/gRc+XorrQENNMaXog9ZAmWaMGnMDcjynIgQBiHq6HNLCaVA8HrzsD0nb86?= =?us-ascii?Q?ulwjAf2KnFilXMPq0iQhVShvJJwg8BRpXJkRjkTudTY528/TK14pl7NgnL8l?= =?us-ascii?Q?tKm6z7dyqKu7xc4t+ZO3hzLc5csPCXubUgrUhtDcVKvU4UZ0wfzbXiDqGO1T?= =?us-ascii?Q?Ovew+IETv4YqRhuFk+88jqxqC7HQz1bRu8oAJ+mSZUIrVPhNnO/CUfdXJOos?= =?us-ascii?Q?5xHlbZ7V9ytxVndp7uDIifHX6QLkZLzsn88FsyanhKaptk2TjgKQfSToQeyk?= =?us-ascii?Q?TNQz1NnpBr+38uYnrzrc3OgC2rbPFRwbVsRQGT16EtqfoR0lf42Q0X0fsP80?= =?us-ascii?Q?loLLQJlDhB5nF0blEbYbuDNc0xYa6M3cC1O0W5C0Sym7OmLsv/Omwi0RJlxF?= =?us-ascii?Q?mQ5li4JGH3u1dlMNhGGFwbRleT///YKDC1+BXqO8iWMF1ZWBT3MeaKdKHc11?= =?us-ascii?Q?6a/4ShEaXzyd0X0KVEVO2AJL8MoAnkmEXDb4VoVlbVzWl+tU/EmrQamnDtFr?= =?us-ascii?Q?2fW5vDxPcKgXjbVP99hnHg5Uors2Izf1qemhvN9FCYNlC9g/NWSteJT33HL4?= =?us-ascii?Q?c/swZsAWs3zqgwpWPakNXU6b894KoTTzQEXOjuHsntfazIX/JF6+a2IIw56r?= =?us-ascii?Q?dG9RB5yFxelE4Z/u+d0UE3H6xVOLUSvU/ZdzGP7sJMB8us6ozCTgDcye8Fcl?= =?us-ascii?Q?C8tWH4zo5Sl5VybUn2x0vuknnqCPhWfNzg7shunVuHN64wuVsu2MBFLXM0bF?= =?us-ascii?Q?JLC2K7eItsZlvfvtn1v1NA4PhRqrape86JbH6krGOxLybbvuu05qS4pka9lQ?= =?us-ascii?Q?9rW/OO8yrE5lHPvZkik7xfTcy4a2yZbL6V5XGo7Jio/Gb/x3qAnZJOKuPaRk?= =?us-ascii?Q?31R5/lLmuEWst3kzcf4gA9LsdsWiUUwOaCtgcekqVcHUVhPSs5c1v7yEb/0s?= =?us-ascii?Q?HDX7Eh/q8v5VFgfkF+J4Coq32sZplApe65ujiTvNGH7sNA6OOWCfuqXspP1w?= =?us-ascii?Q?QccRXxqfpziKosBo9kKu+bAW9di46ploKi37U4WvGPH0Bw6hJLLFpVZrErIC?= =?us-ascii?Q?H/SxatazwS17Tv62BT5ijS79bpZGjq2ygTdS8xB6+80a/Kwq6MVu7D0ykbn7?= =?us-ascii?Q?reiTx45TvT8RHS0tOnzE9Ucr6v10elj4sclcjgWs?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA0PR11MB4670.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 27792556-22fd-4c50-ce02-08da5eb03f48 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jul 2022 18:00:29.5181 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3m8IM5lu6SA/bjUUJxwEAa1Dg8ng11wKU5/w/cPg+qZun/zzjkm6aaut0mJ9mHRaWiySGPamfTVz3ZGzLUWbiQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6310 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org >=20 > Added changes to enable CMAN (RED or PIE) at init from profile configurat= ion > file. >=20 > By default CMAN code is enable but not in use, when there is no RED or PI= E > profile configured. >=20 > Signed-off-by: Marcin Danilewicz > --- > Log: v2 change in rte_sched.h to avoid ABI breakage. > v3 changes from comments > v4 rebase to 22.07-rc1 > v5 rebase to main latest > v6 commit message fixed > v7 changes from comments > v8 with changes from comments > --- > config/rte_config.h | 3 - > drivers/net/softnic/rte_eth_softnic_tm.c | 12 -- > examples/ip_pipeline/tmgr.c | 4 - > examples/qos_sched/cfg_file.c | 47 +------- > examples/qos_sched/cfg_file.h | 5 - > examples/qos_sched/init.c | 76 +----------- > examples/qos_sched/main.h | 2 - > examples/qos_sched/profile.cfg | 135 +-------------------- > examples/qos_sched/profile_pie.cfg | 142 ++++++++++++++++++++++ > examples/qos_sched/profile_red.cfg | 143 +++++++++++++++++++++++ > lib/sched/rte_sched.c | 47 +------- > 11 files changed, 296 insertions(+), 320 deletions(-) create mode 10064= 4 > examples/qos_sched/profile_pie.cfg > create mode 100644 examples/qos_sched/profile_red.cfg >=20 > diff --git a/config/rte_config.h b/config/rte_config.h index > 46549cb062..ae56a86394 100644 > --- a/config/rte_config.h > +++ b/config/rte_config.h > @@ -88,9 +88,6 @@ > /* rte_power defines */ > #define RTE_MAX_LCORE_FREQS 64 >=20 > -/* rte_sched defines */ > -// RTE_SCHED_CMAN is not set > - > /* rte_graph defines */ > #define RTE_GRAPH_BURST_SIZE 256 > #define RTE_LIBRTE_GRAPH_STATS 1 > diff --git a/drivers/net/softnic/rte_eth_softnic_tm.c > b/drivers/net/softnic/rte_eth_softnic_tm.c > index 6a7766ba1c..3e4bed81e9 100644 > --- a/drivers/net/softnic/rte_eth_softnic_tm.c > +++ b/drivers/net/softnic/rte_eth_softnic_tm.c > @@ -420,11 +420,7 @@ pmd_tm_node_type_get(struct rte_eth_dev *dev, > return 0; > } >=20 > -#ifdef RTE_SCHED_CMAN > -#define WRED_SUPPORTED 1 > -#else > #define WRED_SUPPORTED 0 > -#endif >=20 > #define STATS_MASK_DEFAULT \ > (RTE_TM_STATS_N_PKTS | \ > @@ -2300,8 +2296,6 @@ tm_tc_wred_profile_get(struct rte_eth_dev *dev, > uint32_t tc_id) > return NULL; > } >=20 > -#ifdef RTE_SCHED_CMAN > - > static void > wred_profiles_set(struct rte_eth_dev *dev, uint32_t subport_id) { @@ - > 2325,12 +2319,6 @@ wred_profiles_set(struct rte_eth_dev *dev, uint32_t > subport_id) > } > } >=20 > -#else > - > -#define wred_profiles_set(dev, subport_id) > - > -#endif > - > static struct tm_shared_shaper * > tm_tc_shared_shaper_get(struct rte_eth_dev *dev, struct tm_node *tc_node= ) { > diff --git a/examples/ip_pipeline/tmgr.c b/examples/ip_pipeline/tmgr.c in= dex > b138e885cf..e68e9961be 100644 > --- a/examples/ip_pipeline/tmgr.c > +++ b/examples/ip_pipeline/tmgr.c > @@ -17,7 +17,6 @@ static uint32_t n_subport_profiles; static struct > rte_sched_pipe_params > pipe_profile[TMGR_PIPE_PROFILE_MAX]; >=20 > -#ifdef RTE_SCHED_CMAN > static struct rte_sched_cman_params cman_params =3D { > .red_params =3D { > /* Traffic Class 0 Colors Green / Yellow / Red */ @@ -86,7 > +85,6 @@ static struct rte_sched_cman_params cman_params =3D { > [12][2] =3D {.min_th =3D 32, .max_th =3D 64, .maxp_inv =3D 10, .wq_log= 2 > =3D 9}, > }, > }; > -#endif /* RTE_SCHED_CMAN */ >=20 > static uint32_t n_pipe_profiles; >=20 > @@ -96,9 +94,7 @@ static const struct rte_sched_subport_params > subport_params_default =3D { > .pipe_profiles =3D pipe_profile, > .n_pipe_profiles =3D 0, /* filled at run time */ > .n_max_pipe_profiles =3D RTE_DIM(pipe_profile), -#ifdef > RTE_SCHED_CMAN > .cman_params =3D &cman_params, > -#endif /* RTE_SCHED_CMAN */ > }; >=20 > static struct tmgr_port_list tmgr_port_list; diff --git > a/examples/qos_sched/cfg_file.c b/examples/qos_sched/cfg_file.c index > 450482f07d..7f4114bd56 100644 > --- a/examples/qos_sched/cfg_file.c > +++ b/examples/qos_sched/cfg_file.c > @@ -23,6 +23,8 @@ > uint32_t active_queues[RTE_SCHED_QUEUES_PER_PIPE]; > uint32_t n_active_queues; >=20 > +struct rte_sched_cman_params cman_params; > + > int > cfg_load_port(struct rte_cfgfile *cfg, struct rte_sched_port_params > *port_params) { @@ -229,40 +231,6 @@ cfg_load_subport_profile(struct > rte_cfgfile *cfg, > return 0; > } >=20 > -#ifdef RTE_SCHED_CMAN > -void set_subport_cman_params(struct rte_sched_subport_params *subport_p, > - struct rte_sched_cman_params > cman_p) > -{ > - int j, k; > - subport_p->cman_params->cman_mode =3D cman_p.cman_mode; > - > - for (j =3D 0; j < RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE; j++) { > - if (subport_p->cman_params->cman_mode =3D=3D > - RTE_SCHED_CMAN_RED) { > - for (k =3D 0; k < RTE_COLORS; k++) { > - subport_p->cman_params- > >red_params[j][k].min_th =3D > - cman_p.red_params[j][k].min_th; > - subport_p->cman_params- > >red_params[j][k].max_th =3D > - cman_p.red_params[j][k].max_th; > - subport_p->cman_params- > >red_params[j][k].maxp_inv =3D > - cman_p.red_params[j][k].maxp_inv; > - subport_p->cman_params- > >red_params[j][k].wq_log2 =3D > - cman_p.red_params[j][k].wq_log2; > - } > - } else { > - subport_p->cman_params->pie_params[j].qdelay_ref =3D > - cman_p.pie_params[j].qdelay_ref; > - subport_p->cman_params- > >pie_params[j].dp_update_interval =3D > - cman_p.pie_params[j].dp_update_interval; > - subport_p->cman_params->pie_params[j].max_burst =3D > - cman_p.pie_params[j].max_burst; > - subport_p->cman_params->pie_params[j].tailq_th =3D > - cman_p.pie_params[j].tailq_th; > - } > - } > -} > -#endif > - > int > cfg_load_subport(struct rte_cfgfile *cfg, struct rte_sched_subport_param= s > *subport_params) { @@ -276,11 +244,7 @@ cfg_load_subport(struct > rte_cfgfile *cfg, struct rte_sched_subport_params *subpo > memset(active_queues, 0, sizeof(active_queues)); > n_active_queues =3D 0; >=20 > -#ifdef RTE_SCHED_CMAN > - struct rte_sched_cman_params cman_params =3D { > - .cman_mode =3D RTE_SCHED_CMAN_RED, > - .red_params =3D { }, > - }; > + subport_params->cman_params =3D NULL; >=20 > if (rte_cfgfile_has_section(cfg, "red")) { > cman_params.cman_mode =3D RTE_SCHED_CMAN_RED; @@ - > 387,7 +351,6 @@ cfg_load_subport(struct rte_cfgfile *cfg, struct > rte_sched_subport_params *subpo >=20 > } > } Here only mode is set to RTE_SCHED_CMAN_RED. But I could not find the place= where cman_params are set from cfg_file (for e.g. red_params). Can you cla= rify?